The Clang bug that caused this silencing has been fixed for a while.
Test: mmma frameworks/base/libs/hwui
Change-Id: Ia03f7c223f95a51fbda70dbbbabf4821eaef74ca
Clang is producing non-deterministic result when the new pass manager is
enabled. Turn it off as a temporary workaround.
Test: presubmit
Bug: 142372146
Change-Id: Ie21d97c0fe6770b0ae9ec103133b940b1eb8a220
DIRTY_MAX cannot be represented precisely in an IEEE 754 single
precision float. Calls to DamageAccumulator::dirty() that pass
DIRTY_MAX thus result in an implicit cast that results in imprecision.
Add one to the DIRTY_MAX constant so that its value can be precisely
representing in a single precision float.
Alternatively, we can accept the imprecision via explicit casts in
multiple call sites.
Bug: 139945549
Test: mm
Change-Id: I38b2942f976ad05af2d0e45d1a9fe4214e759a02
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Fraction comparison does not work for 143.999985 and 2.000001.
This CL resolves this corner case.
Bug: 140778647
Test: pass CTS
Change-Id: I7e39ba822167a3c36c628255a4c79b1ade976929
(cherry picked from commit 019adb0293)
65.9998 should be detected as integer aligned. Before this CL
only 65.0001 was detected as an integer.
Test: Pass TextureViewTest#testSamplingWithTransform
Bug: 137682518
Change-Id: I65e650f50040ab56d2237c14d5d8ee191349b93e
(cherry picked from commit 694f3e4a55)
Detect scaling in screen coordinates, which allows to turn off
filtering for some rect-to-rect matrices (90/270 rotation, scaling).
Test: CTS test coverage expanded in testSamplingWithTransform
Bug: 135895166
Change-Id: Icf5c45fa62bb7a96c5f5464d312bf98a653bc78d
(cherry picked from commit 134372dba9)
Timeout recovery isn't working properly, so increase it
to avoid any false-positives from something like a
slow screen-on
Bug: 137509524
Test: none
Change-Id: Ic4fae04b41f71600479f9557e334f67c27851db4
Merged-In: Ic4fae04b41f71600479f9557e334f67c27851db4
When there is overlay package in system_ext, turn on POLICY_SYSTEM_PARTITION.
In other words, overlay pacakge in /system_ext is considered as system's one
Test: mv vendor/overlay/framework-res__auto_generated_rro.apk system_ext/overlay
and then check if it works properly.
Bug: 136715327
Change-Id: Ib225368eae41203a8630f4310d26e9cf1afa706a
Merged-In: Ib225368eae41203a8630f4310d26e9cf1afa706a
(cherry picked from commit cba9579158)
Protobuf 3.9.1 redefines google::protobuf::uint64 from unsigned long
long to uint64_t, which is sometimes unsigned long and sometimes
unsigned long long. Use PRIu64 to print it, and add an implementation
of ProtoOutputStream::write for long.
Bug: 117607748
Test: m checkbuild
Change-Id: Ib2d3f4e17857f8ccbbe342ce6678e76b591df510
Merged-In: Ib2d3f4e17857f8ccbbe342ce6678e76b591df510
To check if a value falls in a range, it should be
a >= MIN && a <= MAX
instead of
a >= MIN || a <= MAX
Found by an experimental Clang warning change,
https://reviews.llvm.org/D66044.
Test: presubmit
Change-Id: I91e2a04687285d9311fd831197c73af38ec8379c
The file permissions of the idmap2 binary are currently not set
correctly when the system forks and execs the idmap binary during
zygote. This chnages sets the uid and gid after forking to the same uid
and gid of the parent process.
Bug: 134897503
Test: device boots and generates idmap
Change-Id: Ic7fac49e5982f3c47713603b905c3a6be117a05b
whenever clear is used as a blend mode to draw bitmaps
Modified SkiaRecordingCanvas to call filterBitmap instead of
filterPaint in order to conduct the necessary compatibility checks
to use dest_out instead of clear whenever a bitmap is drawn
Test: In progress..
Bug: 131689368
Change-Id: I56d015e773b312cac948d850ca2997d8df0cc66d
Merged-In: I56d015e773b312cac948d850ca2997d8df0cc66d
Usually isTrippleBuffered should be true when mSwapDeadline bigger
than IntendedVsync. However, vsync could be drifting on some platforms,
which make isTrippleBuffered to be true and report a fake high input
latency.
So add a small threshold to avoid this case.
Test: Manually
Change-Id: Ib6ff1046cfb94f89f4985361b84ad2d34850f783
Signed-off-by: Gao Shuo <shuo.gao@intel.com>
Signed-off-by: Wu Zhongmin <zhongmin.wu@intel.com>
Signed-off-by: Zhu Tingting <tingting.zhu@intel.com>
These aren't really actionable logs by whatever
is producing them, so move to verbose
Bug: 131773342
Test: build
Change-Id: Icd020d889d83deae5dfd4aac3352bc9b1e1159bc
SkiaLayer::inverseTransformInWindow should be the inverse
matrix of Layer transform. This CL fixes a bug, that matrix
value was not inverted.
This matrix is used in one place: to transform light
center coordinates from device to RenderNode/layer
coordinate space.
Bug: 132758858
Test: Ran test app attached to bug. Manually compared coordinates.
Change-Id: Id8e887276a5296091a8264d7a0b1bcc955620a6a
* changes:
Fix lookup of incident section by name to not crash.
Add command line utilites to set the reason field in incident report header
Add ProtoOutputStream.serializeToVector
These traces are small and noisy, so they hurt performance more than they help.
This reverts commit c37457799b.
Test: m
Bug: 132721345
Change-Id: I9ef719f54f2bc8a54f23e88f46d74e35417a6519
(cherry picked from commit 3509b624fe)
Bug: 132354626
Bug: 129117085
Test: skia unit tests and test cases described in the bug
Change-Id: Ieaa7c831dd6298ac0565e6f1837b1c1dbd4545da
(cherry picked from commit ac33a48751)
This reverts commit f802abe47f.
Reason for revert: We're seeing jank increase after this patch.
Change-Id: Ic8d77df3fbbeeedeed4b8f31737454d9c056f8b0
Bug: 132733305
