Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[frameworks][base][hwui] fix -Wimplicit-int-float-conversion

Browse Source 
DIRTY_MAX cannot be represented precisely in an IEEE 754 single
precision float.  Calls to DamageAccumulator::dirty() that pass
DIRTY_MAX thus result in an implicit cast that results in imprecision.
Add one to the DIRTY_MAX constant so that its value can be precisely
representing in a single precision float.

Alternatively, we can accept the imprecision via explicit casts in
multiple call sites.

Bug: 139945549
Test: mm
Change-Id: I38b2942f976ad05af2d0e45d1a9fe4214e759a02
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
This commit is contained in:
Nick Desaulniers
2019-10-10 13:11:23 -07:00
parent 58664e8a7c
commit 19ae5f9ac9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/hwui/DamageAccumulator.h
View File

@@ -27,7 +27,7 @@
// Smaller than INT_MIN/INT_MAX because we offset these values
// and thus don't want to be adding offsets to INT_MAX, that's bad
#define DIRTY_MIN (-0x7ffffff - 1)
#define DIRTY_MAX (0x7ffffff)
#define DIRTY_MAX (0x8000000)
namespace android {
namespace uirenderer {