- When we return early when detecting when to skip applying the bounds
the stored bounds and rotation weren't being updated
- In landscape, the addition of the nav bar inset in the bottom pushed
the movement bounds to be out of range, which cause an incorrect
offset to be calculated
- Simplified the logic to calculate the offset for the adjustment for
IME and shelf -- keep track of the previous offset, check the previous
movement+offset bounds with the next movement+offset bounds and only
update if the PIP is currently between those two bounds
- Tweak to landscape policy, if there isn't enough space for the ime
offset, then don't apply it as a part of the shift
Bug: 126199952
Test: Go to landscape + pip, open IME and dismiss IME and ensure the
PIP is pushed off and restored correctly
Test: In portrait, test going from app/home/ime and verify that the right
offsets are applied, and then if the stack is not in the bounds of
the offset change, that it is not applied
Change-Id: I67eee7d321995f403137db940b06f685d0c919af
This reverts commit b023773a18.
Reason for revert: Not yet decided to release this at this stage
Change-Id: Ic0018cadcc228667a64f6f8c694bb6a04f00adc9
Bug: 130857483
Bug: 133201131
Bug: 132291669
Logging was broken by a refactor, this fixes it so that it works
correctly again. Also adds handle, phone state, and dismiss reason
logging to the metrics as they were never being logged.
Test: Tested locally
BUG:128982146
BUG:133407447
BUG:133247164
Change-Id: I3d925243f9826439c6acb718e8436ccdd1d27564
After the user adjusts the priority of a notification, we need to
temporarily lift the VisualStabilityManager's ban on reordering
to allow the priority adjustment to take effect.
There's no clear signal as to when this reprieve should end --
eventually, we'll get a ranking update, but there's no way to tell
that it was the update that our change triggered. So instead we just
wait for 1000ms and then drop the adjustment ban again. If a few
extra reorders slip in during that time, so be it.
Test: atest, manual
Bug: 129772718
Change-Id: Iefb6917bb41935ed6bfc720b51738c66ffa83457
Both the radius and margin will vary from device to device. Created a
derivation of margin from the radius values based upon numbers on real
devices.
Bug: 133861138
Test: Verified padding and radius on multiple devices.
Change-Id: I3a284d75da8beb7ab77e5cb8e1fa8af57c5e3978
If the user is ephemeral, it shouldn't be possible to resume a previous
session. Only register the guestResumeSessionReceiver if the guest is
not ephemeral.
Bug: 122893274
Test: manual - local build
Change-Id: I16aa0e396ea8bd8d249ffcfb639438858bea4b35
(cherry picked from commit 32d5d50bfd)
ChannelEditorDialogController now tells interested parties about the
fact that it wants to dismiss. NotificationInfo also can close itself
without saving changes
Test: disable top channel in dialog, watch the guts close and
notification disappear
Bug: 133182818
Change-Id: I70adc7dc0d6b9a8a207cdff0b28b281fbd24e18a
In the case where at least one SIM supports EC (either it has service or
it supports them), we replace "No service" carrier name into "Emergency calls
only". This does not replace the string if the sub is already mark as
ECO.
Test: manual
Test: atest KeyguardUpdateMonitorTest
Test: atest CarrierTextControllerTest
Fixes: 130857483
Fixes: 133201131
Fixes: 132291669
Change-Id: Ia0ba2076c9750a8bb081994291753dbea68a2270
Main changes are:
- Update metadata when it changes instead of checking in the timer
- Reuse PlaybackState object when checking if media is seekable
Fixes: 132941962
Test: manual, atest com.android.systemui.statusbar.notification.row.wrapper.NotificationMediaTemplateViewWrapperTest
Change-Id: If870159662bdd6d2288c61d80a14060a4e751da7
Refactors yesterday caused tests to fail because of dependencies getting
initialized earlier. Refactored so that they are initialized late enough
for the tests to be able to mock them correctly.
Also fixes bug where handles would still show when there was no
Assistant.
Test: atest AssistHandleBehaviorControllerTest
BUG:132424950
Fixes: 134086503
Change-Id: I645a2529bf56b5e996e8250267ead87bed9f4f2b
FIX:132424950
