The issue is likely caused by QS tiles not getting redistributed in PagedTileLayout#onConfigurationChanged which does it only when orientation changes. One fix would be to remove that condition at all but then we would be redistributing for every configuration change or we'd need to make PagedTileLayout aware of split shade - none of these options seem good.
So the solution here is to force redistribution from QSPanelControllerBase which is already aware of split shade and can listen to changes there.
I'll also add more logs (in case bug is not fixed) in follow-up CL.
Bug: 255208946
Test: there is no reliable way to reproduce the issue, we'll see if it stops happening
Test: QSPanelControllerTest
Change-Id: I81630b6eec16237a1a665982553dfc5b9dbac54b
This creates a TintedIcon & TintedIconViewBinder and forces all chipbar
clients to provide the tint.
Fixes: 260954564
Test: active unlock chipbar watch icon has correct tint in light and
dark mode
Test: media ttt chipbar with default icon and app icon has correct tint
in light and dark mode
Test: media ttt receiver default icon has correct tint in light and dark
mode
Test: atest MediaTttUtilsTest MediaTttChipControllerReceiverTest
ChipbarCoordinatorTest
Change-Id: Ic5d0a97a41b78c851da78d0b159011b27086f8c6
The autosizing logic seems to have inadvertent side effects. Will remove
this for now.
The autosizing logic was added in ag/20612038. I'm opting to fix forward
because other changes were added into that CL.
Fixes: 261552438
Test: open up bouncer.
Change-Id: I44c41c93ad235b09fc6e4e9966b24c6b4fdcd915
Adding a flag DISPLAY_CATEGORY_ALL_INCLUDING_DISABLED
when getting display list to calculate the size
of the unfold overlay.
Bug: 261591746
Bug: 221071695
Test: manual unfolds => check size is correct
Change-Id: I87990ec13eb726f9c70a05953462d011da4fb952
for the modern bouncer. We will maintain the old version suffixed with
_Old and delete it when we do cleanup. I have copied the tests and
replaced all bouncer references to use the bouncer interactor.
Fixes: 261172736
Test: atest StatusBarKeyguardViewManagerTest
Test: atest StatusBarKeyguardViewManagerTest_Old
Change-Id: I605481ed6d2d323ab3a3911e58dc725cda23b1fc
Currently isSimPortAvailable API returns true if the port is active without any profile enabled on it or the calling app has carrier privileges over the selected port. It is hampering switching to MEP mode when the psim is active and empty.
Test: Manually verified isSimPortAvailable API behavior on C10 with EuiccPartnerApp.
Bug: 240273417
Change-Id: I4c9ad2bc6f1093163290be0e47f8a065245e5783
This makes it easier to test classes that create and show an
`AlertDialog`. If using `AlertDialog.Builder`, extra work is needed to
use this.
Test: atest TestableAlertDialogTest
Bug: 260731518
Change-Id: I027cc96cbbaff569b2df33fcdcef0ad50800f56d
Add an EXTRA for passing the value of this setting to the activities
when the TaskView is started. That way they can respect it when showing
content.
Also, make sure that we create the pending intent for the correct user
Test: atest ControlsUiControllerImplTest
Test: manual with test app
Fixes: 259953724
Change-Id: I44bb8191f8412eb098c3cc654dea2e8badd6fabd
This CL is the sketch of how we can achieve demo mode using the modern
architecture that makes up the new data pipelines. The basic idea is to
put a `RepositorySwitcher` in between the real repository impl and the
demo mode repository.
RealRepository
│
├──►RepositorySwitcher──►RealInteractor──►RealViewModel
│
DemoRepository
In this case, we have a `IRepository` interface which both the demo and
fake repositories implement, and the switcher decides which
implementation to connect to the (real) downstream classes based on
whether or not demo mode is active.
Note that this CL does not hook up the demo mode repository properly,
since the old data pipeline uses a demo icon group layered on top of the
real one to achieve fake icons. That makes things kind of a mess and so
will be implemented in its own CL
Test: DemoMobileConnectionParameterizedTest
Test: DemoMobileConnectionsRepositoryTest
Test: MobileRepositorySwitcherTest
Bug: 249790009
Change-Id: I9ad6bab6dd0ab6eadf43232e3bea0f4fa3116a17
This reverts commit d4c3da1be3.
Reason for revert: Need to restore this functionality. Problem fixed.
Bug: 257302229
Test: manual via the flag app
Change-Id: Ieefc76bda09431ed2f7a0fe28d91a59ef02184b8
If there is no DisplayState, and it gets initialised because of any
other field, for instance refresh-rate, the brightness gets initialised
by 0. Since 0 is a permissible value for brightness, is causes issues by
changing the brightness to 0.
Bug: 259517441
Test: atest PersistentDataStoreTest
Change-Id: I532afc9e9d437199922f83f3c4440127a86a88f5
Make sure to only evicts non-opening task when there's a new task
opening into split.
Fix: 261540443
Test: dragging the same app to the same side won't dismiss split
Change-Id: I5d7ae6cdfdc2971817a80befc834d7c45524ebc2
Refactor BrightnessTracker so that it receives an array of lux readings rather than listening to the light sensor
Bug: 215100807
Test: atest BrightnessTrackerTest
Test: atest AutomaticBrightnessControllerTest
Change-Id: I9807ecb39ac8962d2dae9e53c68e6eadbba5c50f
Merged-In: I9807ecb39ac8962d2dae9e53c68e6eadbba5c50f
This CL allows disassociating the leaf task if relaunched and
reparented it to TDA as root task for split-screen.
Bug: 236317871
Test: atest WindowOrganizerTests
Change-Id: I6704fab733ed7d239d7004c93d3d2f471ac94822
Merged-In: I6704fab733ed7d239d7004c93d3d2f471ac94822
Update device selection layout to match with UX markup.
1. divide device item part with group part, to allow both transfer and
grouping.
2. update checkbox image to match with markup.
guard this change by flag.
Bug: 249371764
Bug: 255126338
Test: atest MediaOutputAdapterTest MediaOutputControllerTest MediaOutputBaseDialogTest MediaOutputDialogTest
Change-Id: I6e92a40f25ea940286cb5ca49aa0193fd9f406a5
Apps commonly do not handle landscape orientation cameras correctly. In
order to prevent stretching and rotation issues in these apps, this
patch adds a flag to override the behavior of these landscape cameras
to produce a portrait image instead by changing the SENSOR_ORIENTATION
reported by CameraCharacteristics and applying a 90 degree rotate and
crop. It also adds a CompatChanges entry which will track which apps
require this treatment.
Test: Ran on foldable device with several camera apps to verify behavior.
Bug: 250678880
Change-Id: I92b6f227916b97828ab6a7f856eea5a1e427644d
