Commit Graph

1447 Commits

Author SHA1 Message Date
TreeHugger Robot
db5c8259e4 Merge "Removing RemoteAnimationTargetCompat and using RemoteAnimationTarget directly" into tm-qpr-dev 2022-10-24 21:32:33 +00:00
Beverly Tai
b64614fc29 Merge "Add historical logs to AnimatableClockView" into tm-qpr-dev 2022-10-24 20:05:44 +00:00
Sunny Goyal
f8a3e7e5f8 Removing RemoteAnimationTargetCompat and using RemoteAnimationTarget directly
Merged-In: I4497b44677a5c32bbf5dc0745559b3bc2f2efcc8
Bug: 221961069
Test: Presubmit
Change-Id: I4497b44677a5c32bbf5dc0745559b3bc2f2efcc8
2022-10-24 17:17:10 +00:00
Mady Mellor
731095e5cf Merge "Track visible tasks in DesktopModeController and add a listener" into tm-qpr-dev 2022-10-24 16:04:59 +00:00
Beverly
9b7626dec6 Add historical logs to AnimatableClockView
adb shell dumpsys activity service com.android.systemui/.SystemUIService
dependency DumpController KeyguardClockLog

Test: see logs in sysui dumpsys
Bug: 222260948
Change-Id: Ie668c7d85ad4278500253d20567eccaf64b78d92
2022-10-24 13:46:44 +00:00
Jamie Garside
63322e05fb Merge "Add large screen clock motion - method 2." into tm-qpr-dev 2022-10-21 14:57:42 +00:00
Hawkwood Glazier
0b6c884d34 Merge "Deflake Lockscreen Clock Screenshot Tests" into tm-qpr-dev 2022-10-21 14:38:35 +00:00
Hawkwood Glazier
f06ed7fd0f Merge "Add Dagger Singleton Provides method for ClockRegistry" into tm-qpr-dev 2022-10-21 14:37:15 +00:00
Jamie Garside
9ac8c9a74d Add large screen clock motion - method 2.
When the clock moves on a large screen (e.g. when locking/unlocking the
device), this adds a subtle offset for each digit of the clock.

This hooks a new transition in to the existing clock move transition,
which just forwards progress through to the actual clock. This also adds
a feature flag (210) to enable/disable this, since it needs a little
more polish yet.

As above, this needs more polish (tweaking the time and/or easing), but
this at least gets something moving to start with :).

Bug: 199051139
Test: Manually verified.
Change-Id: Icec0bcfdb431d24b9405c5dfe8993016f687cac5
Merged-In: Icec0bcfdb431d24b9405c5dfe8993016f687cac5
2022-10-21 09:41:35 +00:00
Mady Mellor
457d8317f1 Track visible tasks in DesktopModeController and add a listener
- Adds DesktopModeTaskRepository to FreeformTaskListener to track
  visible freeform tasks
- Adds a listener on DesktopModeController to allow sysui to find
  out about freeform tasks becoming visible
- Adds a sysui state flag for freeform tasks being visible

Bug: 245569277
Test: manual - add freeform task => launcher contents are gone
             - remove freeform task => launcher contents are visible
Test: WMShellTest DesktopModeTaskRepositoryTest
Change-Id: I2d717052678bc35a4c59b0bc03e0c4d22e6b103d
2022-10-20 17:25:11 -07:00
Vinit Nayak
e3d56e6994 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev 2022-10-20 22:49:54 +00:00
Hawkwood Glazier
ba2863bc34 Add Dagger Singleton Provides method for ClockRegistry
Bug: 229771520
Test: Manually verifid ClockRegistry loaded
Change-Id: I06f140b6f29f87ca42c2cb4039fe4f9bffa8d0f5
2022-10-20 21:21:08 +00:00
Hawkwood Glazier
8417d27f9d Deflake Lockscreen Clock Screenshot Tests
Disabling the TextAnimator when animation is disabled should produce
consistent text between runs of the screenshot test.

Fixes: 243942947
Test: atest KeyguardClockSwitchScreenshotTest
Change-Id: Ifaa060a1212331756ad412f1e6027c140fa35921
Merged-In: Ifaa060a1212331756ad412f1e6027c140fa35921
2022-10-20 16:39:36 +00:00
TreeHugger Robot
259321ee9a Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev 2022-10-20 16:35:49 +00:00
Vinit Nayak
fa05cb2209 Scale screenWidth for split proportionally for thumbnail matrix
* Created TODO(b/254378592) to consolidate different
SplitBounds classes

Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape

Change-Id: If5c55d10a0d21b7984442d01f306c2016eba3701
2022-10-19 17:57:06 -07:00
Sunny Goyal
f7c759be0c Merge "Revert^2 "Removing unused surface transaction wrappers"" into tm-qpr-dev 2022-10-20 00:26:12 +00:00
Hawkwood Glazier
71833c1d3d Merge "Fix gson usage with R8 full mode" into tm-qpr-dev 2022-10-19 21:35:08 +00:00
Florence Yang
e13d22fbcc Merge "Abstract out the logic to determine text color" into tm-qpr-dev 2022-10-19 20:24:37 +00:00
TreeHugger Robot
5da62d4715 Merge "Prevent proguard from pruning ClockSetting" into tm-qpr-dev 2022-10-19 17:27:09 +00:00
Nicolo' Mazzucato
c75bae06cc Add CUJ_RECENTS_SCROLLING
This adds Jank instrumentation every time recent tasks are scrolled.

Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while scrolling
Change-Id: I48201e73d7025ec2ff38c7f9158eec27ed9cbafa
2022-10-19 14:25:11 +00:00
Jared Duke
3b6191e651 Fix gson usage with R8 full mode
Ensure the appropriate signatures are retained for ClockRegistry's gson
usage when R8 full mode is enabled.

Bug: 215530220
Bug: 229771520
Test: m + boot tests
Change-Id: I824b870a355a4cfea04e55d5648a6c441ab446d3
(cherry picked from commit 994594ba6f)
Merged-In: I824b870a355a4cfea04e55d5648a6c441ab446d3
2022-10-19 11:47:51 +00:00
Grace Han
8b86315b2a Abstract out the logic to determine text color
This change moves the implementation of determining and setting
text color into the region sampling instance.

Fixes: 202758428
Test: manual
Change-Id: Idf539226ebf0251d5ea8846f5dbec1858975dd7a
2022-10-19 01:08:39 +00:00
Hawkwood Glazier
1731bf0806 Prevent proguard from pruning ClockSetting
ClockSetting is populated via gson (using reflection), so proguard
will clean it. This causes gson to silently fail and return and
empty object in some configurations. Annotating the class with
@Keep prevents this from occuring.

Bug: 229771520
Test: Manually tested on userdebug variant
Change-Id: I9a7c3e4c4d66d1c13d58cba5994d5578034a9bf8
2022-10-19 00:40:27 +00:00
Sunny Goyal
ff6a8b23df Merge "Adding missing rotationChange in RemoteAnimationTarget" into tm-qpr-dev 2022-10-18 16:32:28 +00:00
Sunny Goyal
2dc02fc420 Revert^2 "Removing unused surface transaction wrappers"
2460910c8c

Change-Id: I076a7178c73e3bd86e3e62f562bc89398e6df4e9
2022-10-17 22:48:03 +00:00
Nicolò Mazzucato
aea723c854 Merge changes from topic "cancel_unfold_anim_on_rotation" into tm-qpr-dev
* changes:
  Cancel unfold animation when rotation changes
  Create RotationChangeProvider in sysui
2022-10-13 23:06:44 +00:00
Nicolo' Mazzucato
0def5f9805 Cancel unfold animation when rotation changes
In DeviceFoldStateProvider.kt, FOLD_UPDATE_FINISH_HALF_OPEN is emitted if the rotation changes while the animation is in progress.

 This targets the case when the device goes to tabletop mode during the transition.

+ Using RotationChangeProvider to fix problems when the new orientation change was received in a background thread unexpectedly. This fixes: (1) wrong launcher icons movement after the rotation, and (2) wrong dark overlay scrim after rotation.

+ Minor formattig fixes by ktfmt

Bug: 241743859
Test: DeviceFoldStateProviderTest && NaturalRotationUnfoldProgressProviderTest && manual stress testing
Change-Id: I0ff6a823709e0891a7bcd13528a0e160d6f39c98
2022-10-13 12:30:59 +00:00
Will Osborn
6d1c1b57b4 Merge "Allow rotation when display is half-folded" into tm-qpr-dev 2022-10-13 08:47:42 +00:00
TreeHugger Robot
2689585c62 Merge "Add information to Task model for desktop entry" into tm-qpr-dev 2022-10-12 21:10:12 +00:00
TreeHugger Robot
5cc7eec00a Merge "Check activity start result code to properly return whther startActivityFromRecents was successful." into tm-qpr-dev 2022-10-11 22:22:10 +00:00
Hawkwood Glazier
941c170c1c Improve dumps and logging around AnimatableClockView and KeyguardClockSwitch
Bug: 251403277
Test: Manually took a bug report
Change-Id: Ie4d11e51e7768d8ad968986c259a70d6b94e2043
2022-10-11 15:10:24 +00:00
William Osborn
9723cfbc38 Allow rotation when display is half-folded
When in 'tabletop' or 'book' mode, allow the display to rotate
even if it is frozen. Then return to the previously locked rotation when
the device is unfolded.

Bug: 240146362
Test: locally tested + ran atest on DisplayRotationTests
Change-Id: I9869f5b070fecd7df70e08323dfacef8b883f470
2022-10-10 20:47:26 +01:00
Schneider Victor-tulias
e48a269ca2 Check activity start result code to properly return whther startActivityFromRecents was successful.
Launcher was not properly giving the user an error message when an activity failed to launch from recents. Added a result code check.

Bug: 240373119
Test: Manually repro'd bug and checked logs
Change-Id: I12e299077b51b27c4e3f477a0a7440f0502fee39
2022-10-07 15:23:16 -07:00
Hawkwood Glazier
edd7822744 Seperate clockface specific callbacks
This change cleans up the Clock interfaces a bit by seperating some of
the interface methods and passing darkness data in to each clock face
seperately.

Test: Manually checked existing clock on device. Some unit tests.
Bug: 229771520
Change-Id: I8fee1c6c9bfff3a970f8333c5d5c3940f797dc28
2022-10-07 18:00:03 +00:00
Matt Pietal
90c03205a6 Merge "Fix unfold transition with RTL" into tm-qpr-dev 2022-10-07 17:19:31 +00:00
Winson Chung
dc06f11eb0 Merge "Simplify exposing external interfaces to Launcher" into tm-qpr-dev 2022-10-07 16:55:55 +00:00
Winson Chung
c03010f150 Simplify exposing external interfaces to Launcher
- Currently, the collection of binders to send to Launcher is inverted
  and managed by OverviewProxyService which has to know about each
  component directly (and a SysUI interface has to be created to support
  this even if there are no other calls in SysUI to that component).

  Instead, we should have each component register itself with the
  ShellController for controllers which can be exposed to an external
  process, and each product can customize which set of controllers it
  needs to support.
- Add missing dump registration for ShellController
- Updating docs for creating remote callable controllers

Bug: 238217847
Test: atest WMShellUnitTests
Change-Id: Icd0ed33bdbd68b1dd9d782b9ba1f5b4a604479ba
Merged-In: Icd0ed33bdbd68b1dd9d782b9ba1f5b4a604479ba
2022-10-06 22:49:13 +00:00
Matt Pietal
b1ddb662f6 Fix unfold transition with RTL
The code was hardcoded to assume left/right translations, which went
in the wrong direction on unfold. Add an additional multiplier for
RTL.

Fixes: 241793140
Test: atest UnfoldConstantTranslateAnimatorTest
Change-Id: I535ab6e53bf15747e22dcab30d03e01156261158
2022-10-06 14:19:32 +00:00
Nick Chameyev
b55f5dae30 Merge "Extract PreviewPositionHelper to shared library" into tm-qpr-dev 2022-10-05 12:52:01 +00:00
Winson Chung
ddc26a33f8 Merge "Clean up some methods on the Pip interface" into tm-qpr-dev 2022-10-04 16:54:48 +00:00
Winson Chung
5414dab01e Clean up some methods on the Pip interface
- Remove some pip methods that aren't used from SysUI
- Migrate an old ISystemUIProxy pip call to IPip

Bug: 238217847
Test: atest WMShellUnitTests
Change-Id: Iab57329a9d79704b0e35fdb22a36594aa4368141
2022-10-04 04:39:33 +00:00
Selim Cinek
6a2f4e2ab5 Merge "Fix RegionSamplingHelper race condition" into tm-qpr-dev 2022-10-03 12:42:42 +00:00
Ats Jenk
0ba5abfb20 Add information to Task model for desktop entry
Desktop recents entry needs some extra information about a Task.
Add support to populate this

Bug: 244348395
Test: manual
Change-Id: If358ea63dff0725f312672f5c247147c1e3cb9f9
2022-09-30 15:27:50 -07:00
Florence Yang
524ae21e70 Fix RegionSamplingHelper race condition
mSamplingRequestBounds was causing a race condition in RegionSamplingHelper because it becomes an empty Rectangle in the main thread when the background thread needs it to be non-empty for CompositionSamplingListener.register().To fix this, a final copy of mSamplingRequestBounds is passed to the background thread, so that it will always be working with a non-empty Rectangle.

Test: atest testCompositionSamplingListener_has_nonEmptyRect
Fixes: 247690841
Change-Id: Ib0139c8be80f828172e1909503dcf57a59673717
2022-09-29 21:28:56 +00:00
Nick Chameyev
b2551fc716 Extract PreviewPositionHelper to shared library
Moves Launcher's PreviewPositionHelper to shared
library between SystemUI and Launcher to reuse
it in the future in the partial screensharing
recents selector.

There should be no functional changes in the
code itself.

Bug: 240924926
Test: presubmit
Change-Id: I66c2b2ff68deb56394b52c07b98e36d23822025f
2022-09-27 19:08:32 +01:00
Lucas Dupin
5c4704b781 Merge "Allow multiple clock plugins simultaneously" into tm-qpr-dev 2022-09-27 17:09:08 +00:00
Ats Jenk
df2bdd5135 Merge "Add support to show apps on desktop in sysui proxy" into tm-qpr-dev 2022-09-26 23:43:18 +00:00
Lucas Dupin
e601a67d00 Allow multiple clock plugins simultaneously
Test: atest ClockRegistryTest
Bug: 248101364
Change-Id: I92380d19fcbbbcdb3d3c5d292d44fd57f8595996
2022-09-26 13:57:19 -07:00
Ats Jenk
d849498a69 Add support to show apps on desktop in sysui proxy
This enabled launcher to show all desktop apps when user clicks on the
desktop tile in recents.
This is only enabled when Desktop Mode feature flag is enabled.

Bug: 244348395
Test: atest DesktopModeControllerTest
Change-Id: I3c89ef01fd7d1f457a7afabda94b481711c0a350
2022-09-26 10:53:10 -07:00
Josh Tsuji
64a3f7394a Add jank instrumentation for occlude/unocclude/launcher unlock.
Fixes: 241195239
Test: grab a trace
Change-Id: If9af9aa95ddff26c9baf5101fb5aa45389e532eb
2022-09-23 15:33:52 -04:00