Deflake Lockscreen Clock Screenshot Tests
Disabling the TextAnimator when animation is disabled should produce consistent text between runs of the screenshot test. Fixes: 243942947 Test: atest KeyguardClockSwitchScreenshotTest Change-Id: Ifaa060a1212331756ad412f1e6027c140fa35921 Merged-In: Ifaa060a1212331756ad412f1e6027c140fa35921
This commit is contained in:
@@ -185,8 +185,13 @@ class AnimatableClockView @JvmOverloads constructor(
|
||||
|
||||
override fun onDraw(canvas: Canvas) {
|
||||
lastDraw = getTimestamp()
|
||||
// intentionally doesn't call super.onDraw here or else the text will be rendered twice
|
||||
textAnimator?.draw(canvas)
|
||||
// Use textAnimator to render text if animation is enabled.
|
||||
// Otherwise default to using standard draw functions.
|
||||
if (isAnimationEnabled) {
|
||||
textAnimator?.draw(canvas)
|
||||
} else {
|
||||
super.onDraw(canvas)
|
||||
}
|
||||
}
|
||||
|
||||
override fun invalidate() {
|
||||
@@ -340,6 +345,9 @@ class AnimatableClockView @JvmOverloads constructor(
|
||||
onAnimationEnd = onAnimationEnd
|
||||
)
|
||||
textAnimator?.glyphFilter = glyphFilter
|
||||
if (color != null && !isAnimationEnabled) {
|
||||
setTextColor(color)
|
||||
}
|
||||
} else {
|
||||
// when the text animator is set, update its start values
|
||||
onTextAnimatorInitialized = Runnable {
|
||||
@@ -354,6 +362,9 @@ class AnimatableClockView @JvmOverloads constructor(
|
||||
onAnimationEnd = onAnimationEnd
|
||||
)
|
||||
textAnimator?.glyphFilter = glyphFilter
|
||||
if (color != null && !isAnimationEnabled) {
|
||||
setTextColor(color)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user