Commit Graph

424299 Commits

Author SHA1 Message Date
Joshua Baxter
311218304a Merge "docs: remove incorrect (default) identifiers" into qt-dev am: 2c7d94c7ed
am: b2a8b29d10

Change-Id: Ie1d730b2777f85cd2a2d601576aeedd5e3728620
2019-11-08 15:26:57 -08:00
Joshua Baxter
b2a8b29d10 Merge "docs: remove incorrect (default) identifiers" into qt-dev
am: 2c7d94c7ed

Change-Id: I3b86d60b47443b7b3d50deccc81048b78c0e1dc7
2019-11-08 15:18:53 -08:00
Joshua Baxter
9c69b40e2e docs: fix typo
bug: 119479852

Change-Id: I5c2c31432446ef6fccf3ac80e44a1660654375c0
Test: make ds-docs
2019-11-08 22:57:39 +00:00
Joshua Baxter
2c7d94c7ed Merge "docs: remove incorrect (default) identifiers" into qt-dev 2019-11-08 22:55:18 +00:00
TreeHugger Robot
88c651eab1 Merge "Force FGS notifications to show for a minimum time" into oc-dev 2019-11-08 22:30:24 +00:00
Heemin Seog
7d88476cb5 Add prefix to logs based on call source
Bug: 144166111
Test: manual, ./external/chromium-trace/systrace.py camera -o
/tmp/mytrace.html (after changing tracing tag to "camera" since it isn't
used for anything else in automotive)

Change-Id: I082888daee17c671ba9ab5c8cf1ae486e683ab16
2019-11-08 14:13:12 -08:00
Heemin Seog
e0e71bcabb DO NOT MERGE Create a single provider of car service
This should be shared across all things requiring it in system UI.

Test: manual
Bug: 142808072
Change-Id: I334d74c3bbe8270822feae268513bf93a4160a5b
2019-11-08 14:10:00 -08:00
Malcolm Chen
4bff428285 Don't allow reading IMSI of one active sub if only has carrier privilege
on the other.

Bug: 136123413
Test: unittest
Change-Id: I67a0121d3e965f193be9e827533646423502fe70
2019-11-08 13:41:24 -08:00
Evan Laird
f7f67adcba [automerger skipped] Force FGS notifications to show for a minimum time am: 3692a6d231 -s ours am: 663d3d7991 -s ours am: 13be3108cb -s ours
am: fead6f705d -s ours
am skip reason: change_id I0680034ed9315aa2c05282524d48faaed066ebd0 with SHA1 09843a687b is in history

Change-Id: I70bd239e00bc10f394c88c49fb266c9ce23d03a6
2019-11-08 13:36:59 -08:00
Evan Laird
fead6f705d [automerger skipped] Force FGS notifications to show for a minimum time am: 3692a6d231 -s ours am: 663d3d7991 -s ours
am: 13be3108cb -s ours
am skip reason: change_id I0680034ed9315aa2c05282524d48faaed066ebd0 with SHA1 3b8c4743f6 is in history

Change-Id: I6d39b885aff0624f983e7290b83a88eeb6c92518
2019-11-08 13:31:06 -08:00
Evan Laird
13be3108cb [automerger skipped] Force FGS notifications to show for a minimum time am: 3692a6d231 -s ours
am: 663d3d7991 -s ours
am skip reason: change_id I0680034ed9315aa2c05282524d48faaed066ebd0 with SHA1 3b8c4743f6 is in history

Change-Id: I74620297e68c2bfd6664ed903f912e5e25d575be
2019-11-08 13:25:14 -08:00
Evan Laird
663d3d7991 [automerger skipped] Force FGS notifications to show for a minimum time
am: 3692a6d231 -s ours
am skip reason: change_id I0680034ed9315aa2c05282524d48faaed066ebd0 with SHA1 3b8c4743f6 is in history

Change-Id: I575817ba777d7212391d75a6163c28e75c7ccbc4
2019-11-08 13:19:35 -08:00
Evan Laird
3692a6d231 Force FGS notifications to show for a minimum time
It's possible for a service to do a start/stop foreground and cause a
couple of things to happen:

NotificationManagerService will enqueue a EnqueueNotificationRunnable,
post a PostNotificationRunnable (for the startForeground), and then also
enqueue a CancelNotificationRunnable. There is some racy behavior here
in that the cancel runnable can get triggered in between enqueue and
post runnables. If the cancel happens first, then
NotificationListenerServices will never get the message.

This behavior is technically allowed, however for foreground services we
want to ensure that there is a minmum amount of time that notification
listeners are aware of the foreground service so that (for instance) the
FGS notification can be shown.

This CL does two things to mitigate this problem:

1. Introduce checking in the CancelNotificationRunnable such that it
will not cancel until after PostNotificationRunnable has finished
executing.

2. Introduce a NotificationLifetimeExtender method that will allow a
lifetime extender to manage the lifetime of a notification that has been
enqueued but not inflated yet.

Bug: 119041698
Test: atest NotificationManagerServiceTest
Test: atest ForegroundServiceLifetimeExtenderTest
Change-Id: I0680034ed9315aa2c05282524d48faaed066ebd0
Merged-In: I0680034ed9315aa2c05282524d48faaed066ebd0
2019-11-08 11:17:53 -05:00
Daniel Sandler
8ea650e18c Merge "Don't retain the filtered list of notifications." into qt-qpr1-dev 2019-11-08 15:36:01 +00:00
TreeHugger Robot
818b083244 Merge "Fix notification shell commands" into qt-qpr1-dev 2019-11-08 15:30:30 +00:00
Julia Reynolds
adc39de3a1 Fix notification shell commands
- Notification posting is done as calling app
- make some only callable by shell

Test: atest
Test: sample app; make sure posted notification is from app itself
Test: sample app; make sure some commands fail
Test: make sure all modified commands still work from shell
Fixes: 143339775
Change-Id: I50ee768e792266ad2091f1913168e89d5d1463ed
(cherry picked from commit 1c943a2670)
2019-11-08 14:14:49 +00:00
Felipe Leme
1025c000ff Merge "Added UserInfo.preCreated on fixture used by unit tests." into qt-qpr1-dev 2019-11-08 10:36:13 +00:00
Felipe Leme
b286462f68 DO NOT MERGE - Removed FLAG_EPHEMERAL from pre-created users.
When a User is pre-created with that flag, its CE & DE keys are not persisted on storage. Hence,
when that pre-creatd user is converted to full-user, the expected keys don't exist and the user
doesn't boot properly.

This change fix the issue by making the pre-created user non-ephemeral, and changing it to
ephemeral when it's converted to a "real" user.

Test: manual verification on Automotive by creating a new user than deleting it using the UI -
that creates and switches to a new guest user (which was pre-created); without this change,
that user  would be hanging with a "Android is starting..." message

Bug: 143092698
Fixes: 143553590

Change-Id: If595b29356b5b50c812f2888cda6e636f18a0d4b
2019-11-08 10:30:35 +00:00
Raff Tsai
00d746fea3 Fix Jank when factory resetting
A progress dialog is shown and quickly disappear caused the UI jank.
The progress dialog should be shown only when erase external SD card
is needed because WipeDataTask only wipe SD card in it background
task. Other factory reset function is done in Thread thr.

Fixes: 140594314
Test: manual
Change-Id: I71ab1577165ceab79704b359c47c3f752d9dfc79
(cherry picked from commit d5b1510994)
2019-11-08 08:47:15 +00:00
TreeHugger Robot
c73945bd84 Merge "Fix LocalOnlyHotspotReservation double stop of local hotspot." into qt-qpr1-dev 2019-11-08 06:11:19 +00:00
TreeHugger Robot
22f1bf64db Merge "DO NOT MERGE: Fixes NPE when preparing app data during init" into qt-qpr1-dev 2019-11-08 04:58:27 +00:00
Andrew Solovay
8e351a1c14 Merge "docs: Clarified behavior of TypedArray.getBoolean()" into qt-dev am: de21a30cda
am: c5f06a08c8

Change-Id: Ic61f305c81ebeaa0e4002c4f23007f2edacc6e4a
2019-11-07 17:35:10 -08:00
Andrew Solovay
c5f06a08c8 Merge "docs: Clarified behavior of TypedArray.getBoolean()" into qt-dev
am: de21a30cda

Change-Id: Ib53cd5a940756e4d3448fa4dc280a87bc0c06f58
2019-11-07 17:29:10 -08:00
TreeHugger Robot
de21a30cda Merge "docs: Clarified behavior of TypedArray.getBoolean()" into qt-dev 2019-11-08 01:17:29 +00:00
Patrick Baumann
46e6a0b1ff DO NOT MERGE: Fixes NPE when preparing app data during init
When deleting an unused static shared library on Q, the user manager was
fetched via mContext.getSystemService. At this time during boot, the
service wasn't registered and so null was returned. This has already
been addressed in R with a move to injecting dependencies in the
PackageManagerService constructor.

Bug: 142083996
Bug: 141413692
Test: manual; remove static dependency on eng Q build and reboot
Change-Id: I8ae4e331d09b4734c54cdc6887b273705dce88b1
2019-11-08 01:08:03 +00:00
jovanak
debb009a2c DO NOT MERGE: Fix several issues with precreated users.
1. Prevent UserManager from destroying storage for precreated users.
2. Modify UMS.getUserIds to exclude precreated users.
3. Remove pre-created users if the system has upgraded.
4. Read permissions during conversion to a "real" user. Permissions should have been granted during the pre-creation. If we cannot read permissions, re-grant them for the user.

Fixes: 143464654
Fixes: 143463955
Test: Repeated subsequent boots; observing logs; boot systrace; applied OTA, verified user cleanup
Change-Id: I75b031105b2622a8a28e84cf2394e43ec93e4174
2019-11-07 16:39:50 -08:00
Eric Berglund
e224fb3fc5 Merge "DO NOT MERGE Revert "Adding scrim bubble to car's super_status_bar.xml"" into qt-qpr1-dev 2019-11-07 22:31:36 +00:00
TreeHugger Robot
fa35152703 Merge "Fixed incorrect WAC decoding" into qt-qpr1-dev 2019-11-07 21:45:06 +00:00
TreeHugger Robot
725dff26a5 Merge "Add comment in getSubscriptionsInGroup about throwing IllegalStateException" into qt-qpr1-dev 2019-11-07 20:50:32 +00:00
Jack Yu
6586ad9e80 Fixed incorrect WAC decoding
Fixed the incorrect warning area coordinate decoding
when data length is greater than 127 bytes.

Bug: 143762197
Test: unit test
Change-Id: I498ccd0933f31898d531dcea307e160ae94653e8
2019-11-07 11:13:31 -08:00
TreeHugger Robot
51a159329f Merge "Dedup smart reply updates for bubble flyout [DO NOT MERGE]" into qt-qpr1-dev 2019-11-07 18:29:49 +00:00
Dan Sandler
899cad8551 Don't retain the filtered list of notifications.
Previously the entire set of notifications was "leaked" until
the next call to getNotificationsForCurrentUser(), which
currently only happens for certain configuration changes
(UiMode, density, fontscale).

Bug: 143461605
Test: atest SystemUITests
Test: sanity check: boot and switch night mode
Change-Id: I39f2c96f848ab92a050aa4bda3ae203fbf99d915
(cherry picked from commit c0c6edee7f)
2019-11-07 14:54:55 +00:00
Felipe Leme
29ad306bcf Added UserInfo.preCreated on fixture used by unit tests.
Bug: 140750212
Bug: 142093568

Test: atest UserManagerServiceUserInfoTest

Merged-In: I5ccaca67e2a0a9b93be9a9ac270970d7cc9926a8
Change-Id: I5ccaca67e2a0a9b93be9a9ac270970d7cc9926a8
(cherry picked from commit 9cbee8aa9b)
2019-11-07 06:47:17 -08:00
Martijn Coenen
730e04453a Don't hold sProxyLock while retrieving interface descriptors.
Since we can't guarantee apps won't call back into us while calling
getInterfaceDescriptor() (even though that's a *really* bad idea),
don't hold any locks while doing so, to protect us from deadlocks.

Bug: 140603195
Test: adb shell am dump binder-proxies
Change-Id: I6289c799aa7027f80792cb751fe1dc437552ea58
2019-11-07 10:19:21 +01:00
Tsung-Mao Fang
4f05f9790b Merge "Refine battery saver footer string" into qt-qpr1-dev 2019-11-07 09:17:15 +00:00
TreeHugger Robot
24e8073af9 Merge "Hide "swipe up to unlock" when entering Doze" into qt-qpr1-dev 2019-11-07 08:02:48 +00:00
TreeHugger Robot
a115070c19 Merge "Carrier config to switch data if primary is OOS" into qt-qpr1-dev 2019-11-07 05:54:19 +00:00
Yury Kotlyarov
166f256958 Fix LocalOnlyHotspotReservation double stop of local hotspot.
If user executed startLocalOnlyHotspot(), then reservation.close()
garbage collector still keeps reservation object until drain.
If user executed startLocalOnlyHotspot second time during
application life cycle, garbage collector can delete previously
allocated reservation object. In this case finalize() of old
reservation object will be executed, then close(), then
stopLocalOnlyHotspot(). As result, new started LocalOnlyHostpot
can be immediatly stopped by old reservation object delete.
Steps to reproduce: execute startLocalOnlyHostpot() and
reservation.close() multiple times during application life cycle,
check if hotspot up couple of seconds after start.
This fix prevents stopping of local hotspot if reservation
was previously closed.
Test: manual

Bug: 139074896
Bug: 143653311

Change-Id: I86c10b577dbab8cad2d5f7e19805511a93bcb668
Merged-In: I86c10b577dbab8cad2d5f7e19805511a93bcb668
(cherry-picked from ee7b0a6ab2)
2019-11-07 05:44:36 +00:00
Lucas Dupin
b54d7e2a03 Hide "swipe up to unlock" when entering Doze
"Swipe up to unlock" should only be visible when the screen is
interactive, even though it would last for 5sec otherwise.

Test: manual
Test: atest KeyguardIndicationControllerTest
Fixes: 139400542
Change-Id: If7290459a3ae28f689cf4c9e2311398e5f6bcf13
Merged-In: If7290459a3ae28f689cf4c9e2311398e5f6bcf13
2019-11-06 15:51:08 -08:00
Kevin Hufnagle
6288754ef9 Merge "docs: Added perm req for getUserCount()" into qt-dev am: c949db391d
am: f58949bd0e

Change-Id: Ifbced59e15c2ad19ad94b93af05d28ccfbccd255
2019-11-06 15:04:13 -08:00
Kevin Hufnagle
f58949bd0e Merge "docs: Added perm req for getUserCount()" into qt-dev
am: c949db391d

Change-Id: Ib9f6f7561cc6dd365537cf169d45c2eb191f514a
2019-11-06 14:57:13 -08:00
Kevin Hufnagle
c949db391d Merge "docs: Added perm req for getUserCount()" into qt-dev 2019-11-06 22:44:46 +00:00
Patrick Baumann
a5c4b9e350 Merge "Use KNOWN_PACKAGES when shared lib consumers" into qt-qpr1-dev 2019-11-06 22:40:09 +00:00
Joshua Baxter
5411869170 docs: remove incorrect (default) identifiers
Change-Id: I4ce6bc8a7b0e2f18055416a21f465cd2cfe4ec66
test: make ds-docs
bug: 112679894
2019-11-06 22:14:11 +00:00
Joshua Baxter
2947a87032 Merge "docs: remove old broken link" into qt-dev am: 2dc61fc4f4
am: 101f294b58

Change-Id: Id655af3e092e125cc80cdb0d792e56a4adb93100
2019-11-06 14:09:20 -08:00
Joshua Baxter
bcc7d237a6 Merge "docs: fix typo" into qt-dev am: 49357cbf9e
am: 01b5ee8eca

Change-Id: I449250128879b14a4cf9da7c43f8d40af765c4d6
2019-11-06 14:05:27 -08:00
Malcolm Chen
ebc4cff912 Add comment in getSubscriptionsInGroup about throwing IllegalStateException
Bug: 142250528
Test: build
Change-Id: I57b87755f6ddf962721e620f869ff48370e3f2d6
2019-11-06 14:02:46 -08:00
Joshua Baxter
bd87d666eb Merge "docs: fix typos" into qt-dev am: f6c85f3c0d
am: 256363052e

Change-Id: I3596d0642bb2bb36eb673f1c387d324cbc02295d
2019-11-06 14:01:38 -08:00
Joshua Baxter
ebfb71dcde Merge "docs: fix typo" into qt-dev am: 74ff8a0bbd
am: 6b70c7893d

Change-Id: I930b4b473f697499857eac19cfa6eb4d6d290cef
2019-11-06 13:57:01 -08:00
Joshua Baxter
ffcb948028 docs: fix a couple of minor typos am: 9bc8e0cb53
am: 7cebef8505

Change-Id: I0e278a53b781580041315e74a669ae6cca3340bf
2019-11-06 13:50:13 -08:00