* changes:
[automerge] [DO NOT MERGE] Do not clear calling identify when using BiometricPrompt from FingerprintService. 2p: ac89f8682f
[DO NOT MERGE] Do not clear calling identify when using BiometricPrompt from FingerprintService.
This reverts commit 47032a2095.
Reason for revert: DroidMonitor: Potential culprit for Bug 230140012 -
verifying through ABTD before revert submission. This is part of the
standard investigation process, and does not mean your CL will be
reverted.
Change-Id: I22f5aa5bd57e37d638292773986b479428e5cdbc
Revert "Use new onStartSplitLegacy when starting split from overview"
Revert submission 17779173-startSplitLegacy
Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...
Change-Id: I754bc308f37eea2fc50eda2b9df068adf711a268
* changes:
[Media] Allow output switcher chip to handle larger font sizes without cutting off the test.
[Media Recs] Hide the title / subtitle views if none of the albums have titles / subtitles so that the album art is centered better.
Behaviorally, this is *almost* a pure refactoring. It does make
one very minor logic change(*) that could hypothetically fix a
race condition, although no particular bugs have ever been
observed as a result (nor do they seem especially probable), and
it's unknown what the severity would be if they ever were to occur.
Additionally, this change clarifies existing comments and adds
more inline documentation to help understand the rebuildList()
flow. Code cleanup identifies a few areas where the current design
seems a little clumsy, noted with new "TODO" comments in the code.
There's room for more improvement, but this function plays an
important role in preparing Sharesheet targets, so it's good to
bring attention to these thorny requirements.
For justifications of behavioral equivalence and other metacognitive
notes, see comments in the code review.
(*) The one behavior change is called out in code review comments;
briefly, the line of code that sends a synchronous "results
pending" event used to follow the line that started the async
flow that would result in a "results complete" event. This
could hypothetically race if the async work finished and sent
"results complete" before we got to the "results pending" line.
Bug: 227486788
Test: `atest ChooserActivityTest` (no behavior changes expected)
Change-Id: I2e74d68579be8b34716ba2202ac2a08361008400
Merged-In: I2e74d68579be8b34716ba2202ac2a08361008400
(cherry picked from commit 1e42cad19b)
As described in b/222124533, the reliability of these tests
can be improved with a timeout, but that's still not a very
solid fix. We should just ignore them for now so they stop
breaking on the monitor, and meanwhile I'll continue
investigating the root cause.
Bug: 222124533, 220337209, 220959679, 218218953
Test: disabling tests only
Change-Id: I113a1ba4de2176e209339a1cbbe2583cb5fe518c
Merged-In: I113a1ba4de2176e209339a1cbbe2583cb5fe518c
(cherry picked from commit 2864475fd7)
Define the API for interacting with comparator model data;
provide implementations for our two current model types; and
(as a first step) re-write our legacy ResolverComparators
to be implemented internally in terms of their new model types.
This is the first CL in a multi-part cleanup of the
AbstractResolverComparator design. This demonstrates that the
role of an AbstractResolverComparator sub-class amounts to
(i.e., Ctrl+F "@Override") some amount of work to prepare model
data; some cleanup; and a set query methods against data that
*really should be* immutable (separated in this CL as the new
ResolverComparatorModel interace). Any remaining responsibilities
of the abstract base class would be better handled (in a subsequent
CL) by an external controller operating on a ResolverComparatorModel
(i.e., preferring composition to inheritance). The async
model-preparation steps should also be separated and cleaned
up (in a later CL).
I believe this to be a pure refactoring with no observable side
effects. While the new design aids in implementing the correct
"immutable snapshot" style, for now I've written the new
ResolverComparatorModel implementations to preserve any possible
quirks in the legacy implementations. Nevertheless, if some
inadvertant behavior change is introduced as a result of this CL,
it's most likely to be a bug-fix where we previously would've mixed
in stale data. A later CL will intentionally pursue those fixes.
Test: atest ResolverActivityTest ChooserActivityTest
Bug: 227486788
Change-Id: If88bf7a5a6394d81c021782d5d9bce7955f1c0e6
Merged-In: If88bf7a5a6394d81c021782d5d9bce7955f1c0e6
(cherry picked from commit 8b5d279d90)
These tests (testShortcutTarget{With,Without}ApplyAppLimits) are
currently disabled by @Ignore annotations, and I'm not re-enabling
them in this CL because I'm not sure that they won't flake -- I
just know that this was an easy (and understandable) fix when I
tried to run these tests locally, and I'd like to preserve that
fix for posterity.
Test: Re-enabled the tests and confirmed they passed only w/ fix
Bug: 208803748
Change-Id: I5268e3324d3cec9f6a72aee5de9ec1f06e45e987
Merged-In: I5268e3324d3cec9f6a72aee5de9ec1f06e45e987
(cherry picked from commit 72b8b079b5)
Context: go/pm-settings-persistence
0. The main issue is a background thread holding to 2 major and 1
less-major locks for a long time.
1. Refactor Settings.writeStateForUser* not to take PMS lock in advance.
2. Add an option to move PMS-locked processing into PMS handler thread,
executing on a big core with DEFAULT priority.
3. Make XML serialization use its own lock.
4. Move XML serialization + IO to background thread.
5. (separate CL) slightly optimize XML serialization. It's still an AI
to move it to Fast/Binary serializers.
Bug: 220083428
Test: presubmit
Change-Id: I428d46d90c3ceef55a83358f5f3b2cddbce60efd
Remove all runWithStates that use the live data and use snapshots
instead. This ensures that if AppsFilter is called by a snapshot, it
uses the data from the same snapshot. Also prevent corner-case lock
contentions where a snapshot calls to acquire mPm.mLock.
BUG: 226668722
Test: unit test
Test: manual check of boot time
Change-Id: I2b8472659392b9e7c499bb816dd23e9470655af4
Merged-In: I2b8472659392b9e7c499bb816dd23e9470655af4
