Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fixed obsolete TODOs."

Browse Source
This commit is contained in:
Felipe Leme
2017-03-14 21:09:04 +00:00
committed by Android (Google) Code Review
parent d3e684575d 104b932b7b
commit fe6c9dfd98
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/java/android/os/storage/StorageVolume.java
View File

@@ -373,8 +373,7 @@ public final class StorageVolume implements Parcelable {
}
/** {@hide} */
// TODO(b/26742218): find out where toString() is called internally and replace these calls by
// dump().
// TODO: find out where toString() is called internally and replace these calls by dump().
public String dump() {
final CharArrayWriter writer = new CharArrayWriter();
dump(new IndentingPrintWriter(writer, " ", 80));

2
core/java/android/service/autofill/AutofillServiceInfo.java
View File

@@ -78,14 +78,12 @@ public final class AutofillServiceInfo {
// TODO(b/35956626): inline newSettingsActivity once clients migrate
final String newSettingsActivity =
metaDataArray.getString(R.styleable.AutofillService_settingsActivity);
System.out.println(">>> NEW CRAP MAN: " + newSettingsActivity); // TODO(felipeal): tmp
if (newSettingsActivity != null) {
mSettingsActivity = newSettingsActivity;
} else {
mSettingsActivity =
metaDataArray.getString(R.styleable.AutoFillService_settingsActivity);
}
System.out.println(">>> FINAL CRAP MAN: " + mSettingsActivity); // TODO(felipeal): tmp
metaDataArray.recycle();
} else {
mSettingsActivity = null;

4
services/autofill/java/com/android/server/autofill/RemoteFillService.java
View File

@@ -240,7 +240,7 @@ final class RemoteFillService implements DeathRecipient {
}
mBinding = false;
if (isBound()) {
// TODO(b/33197203, b/35395043): synchronize access instead
// TODO(b/33197203): synchronize access instead?
// Need to double check if it's null, since it could be set on onServiceDisconnected()
if (mAutoFillService != null) {
try {
@@ -322,7 +322,7 @@ final class RemoteFillService implements DeathRecipient {
}
try {
// TODO(b/33197203, b/35395043): synchronize access instead
// TODO(b/33197203): synchronize access instead?
// Need to double check if it's null, since it could be set on
// onServiceDisconnected()
if (mAutoFillService != null) {