From 104b932b7b84e4d4dda51b187615d79e2559ebca Mon Sep 17 00:00:00 2001 From: Felipe Leme Date: Tue, 14 Mar 2017 08:40:06 -0700 Subject: [PATCH] Fixed obsolete TODOs. Test: not needed Bug: 35395043 Bug: 26742218 Change-Id: I0e5adb574610374055a6546b66529a7aed7cc413 --- core/java/android/os/storage/StorageVolume.java | 3 +-- core/java/android/service/autofill/AutofillServiceInfo.java | 2 -- .../java/com/android/server/autofill/RemoteFillService.java | 4 ++-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/core/java/android/os/storage/StorageVolume.java b/core/java/android/os/storage/StorageVolume.java index 46f2d387ac526..1fc0b820cf06e 100644 --- a/core/java/android/os/storage/StorageVolume.java +++ b/core/java/android/os/storage/StorageVolume.java @@ -373,8 +373,7 @@ public final class StorageVolume implements Parcelable { } /** {@hide} */ - // TODO(b/26742218): find out where toString() is called internally and replace these calls by - // dump(). + // TODO: find out where toString() is called internally and replace these calls by dump(). public String dump() { final CharArrayWriter writer = new CharArrayWriter(); dump(new IndentingPrintWriter(writer, " ", 80)); diff --git a/core/java/android/service/autofill/AutofillServiceInfo.java b/core/java/android/service/autofill/AutofillServiceInfo.java index d2200528aedb3..f6d40dbf3414d 100644 --- a/core/java/android/service/autofill/AutofillServiceInfo.java +++ b/core/java/android/service/autofill/AutofillServiceInfo.java @@ -78,14 +78,12 @@ public final class AutofillServiceInfo { // TODO(b/35956626): inline newSettingsActivity once clients migrate final String newSettingsActivity = metaDataArray.getString(R.styleable.AutofillService_settingsActivity); - System.out.println(">>> NEW CRAP MAN: " + newSettingsActivity); // TODO(felipeal): tmp if (newSettingsActivity != null) { mSettingsActivity = newSettingsActivity; } else { mSettingsActivity = metaDataArray.getString(R.styleable.AutoFillService_settingsActivity); } - System.out.println(">>> FINAL CRAP MAN: " + mSettingsActivity); // TODO(felipeal): tmp metaDataArray.recycle(); } else { mSettingsActivity = null; diff --git a/services/autofill/java/com/android/server/autofill/RemoteFillService.java b/services/autofill/java/com/android/server/autofill/RemoteFillService.java index eeff37cef7e7a..47251db783fdb 100644 --- a/services/autofill/java/com/android/server/autofill/RemoteFillService.java +++ b/services/autofill/java/com/android/server/autofill/RemoteFillService.java @@ -240,7 +240,7 @@ final class RemoteFillService implements DeathRecipient { } mBinding = false; if (isBound()) { - // TODO(b/33197203, b/35395043): synchronize access instead + // TODO(b/33197203): synchronize access instead? // Need to double check if it's null, since it could be set on onServiceDisconnected() if (mAutoFillService != null) { try { @@ -322,7 +322,7 @@ final class RemoteFillService implements DeathRecipient { } try { - // TODO(b/33197203, b/35395043): synchronize access instead + // TODO(b/33197203): synchronize access instead? // Need to double check if it's null, since it could be set on // onServiceDisconnected() if (mAutoFillService != null) {