Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improving comment inside expandWithQs for special split shade case

Browse Source 
Bug: 228796547
Test: just changing comment
Change-Id: I2fe903a81645f46a20f10b7d4fe3a3e4ca0768aa
This commit is contained in:
Michal Brzezinski
2022-05-10 18:51:04 +01:00
parent 9b8362201e
commit cd21376df0
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java
View File

@@ -1669,9 +1669,11 @@ public class NotificationPanelViewController extends PanelViewController {
if (mShouldUseSplitNotificationShade && isOnKeyguard()) {
// It's a special case as this method is likely to not be initiated by finger movement
// but rather called from adb shell or accessibility service.
// In the future method below could be used for non-split shade as well but currently
// motion in that case looks worse than using flingSettings.
// TODO: make below function transitioning smoothly also in portrait with empty target
// We're using LockscreenShadeTransitionController because on lockscreen that's the
// source of truth for all shade motion. Not using it would make part of state to be
// outdated and will cause bugs. Ideally we'd use this controller also for non-split
// case but currently motion in portrait looks worse than when using flingSettings.
// TODO: make below function transitioning smoothly also in portrait with null target
mLockscreenShadeTransitionController.goToLockedShade(
/* expandedView= */null, /* needsQSAnimation= */false);
} else if (isFullyCollapsed()) {