From cd21376df02b8211d8e53a3d576453a776db5a3b Mon Sep 17 00:00:00 2001 From: Michal Brzezinski Date: Tue, 10 May 2022 18:51:04 +0100 Subject: [PATCH] Improving comment inside expandWithQs for special split shade case Bug: 228796547 Test: just changing comment Change-Id: I2fe903a81645f46a20f10b7d4fe3a3e4ca0768aa --- .../statusbar/phone/NotificationPanelViewController.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java index 5014c83bf353f..e4af189a5469b 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java @@ -1669,9 +1669,11 @@ public class NotificationPanelViewController extends PanelViewController { if (mShouldUseSplitNotificationShade && isOnKeyguard()) { // It's a special case as this method is likely to not be initiated by finger movement // but rather called from adb shell or accessibility service. - // In the future method below could be used for non-split shade as well but currently - // motion in that case looks worse than using flingSettings. - // TODO: make below function transitioning smoothly also in portrait with empty target + // We're using LockscreenShadeTransitionController because on lockscreen that's the + // source of truth for all shade motion. Not using it would make part of state to be + // outdated and will cause bugs. Ideally we'd use this controller also for non-split + // case but currently motion in portrait looks worse than when using flingSettings. + // TODO: make below function transitioning smoothly also in portrait with null target mLockscreenShadeTransitionController.goToLockedShade( /* expandedView= */null, /* needsQSAnimation= */false); } else if (isFullyCollapsed()) {