Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove some stale TODOs from the Java Bridge tests

Browse Source 
These TODOs were related to testing behavior with JavaScript and Java arrays.
This is now tested thoroughly in JavaBridgeArrayTest.java and
JavaBridgeArrayCoercionTest.java.

No functional change.

Change-Id: I5972b929c3e2743c06aff626c983b4b749ea452f
This commit is contained in:
Steve Block
2012-01-11 11:03:04 +00:00
parent 38e90751a2
commit c93643be42
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/WebViewTests/src/com/android/webviewtests/JavaBridgeCoercionTest.java
View File

@@ -47,7 +47,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase {
private long mLongValue;
private float mFloatValue;
private double mDoubleValue;
// TODO: Test passing to methods with array parameters.
private String mStringValue;
private Object mObjectValue;
private CustomType mCustomTypeValue;
@@ -100,7 +99,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase {
mDoubleValue = x;
notifyResultIsReady();
}
// TODO: Test passing to methods with array parameters.
public synchronized void setStringValue(String x) {
mStringValue = x;
notifyResultIsReady();
@@ -146,7 +144,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase {
waitForResult();
return mDoubleValue;
}
// TODO: Test passing to methods with array parameters.
public synchronized String waitForStringValue() {
waitForResult();
return mStringValue;
@@ -472,8 +469,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase {
assertNull(mTestObject.waitForCustomTypeValue());
}
// TODO: Test passing arrays.
// Test passing a JavaScript object to a method of an injected object.
public void testPassJavaScriptObject() throws Throwable {
// LIVECONNECT_COMPLIANCE: Should raise a JavaScript exception.