From c93643be42a552c2a08fd2c147e28da61edbaed3 Mon Sep 17 00:00:00 2001 From: Steve Block Date: Wed, 11 Jan 2012 11:03:04 +0000 Subject: [PATCH] Remove some stale TODOs from the Java Bridge tests These TODOs were related to testing behavior with JavaScript and Java arrays. This is now tested thoroughly in JavaBridgeArrayTest.java and JavaBridgeArrayCoercionTest.java. No functional change. Change-Id: I5972b929c3e2743c06aff626c983b4b749ea452f --- .../src/com/android/webviewtests/JavaBridgeCoercionTest.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/WebViewTests/src/com/android/webviewtests/JavaBridgeCoercionTest.java b/tests/WebViewTests/src/com/android/webviewtests/JavaBridgeCoercionTest.java index 9aed8882a302b..a0f78a4b52382 100644 --- a/tests/WebViewTests/src/com/android/webviewtests/JavaBridgeCoercionTest.java +++ b/tests/WebViewTests/src/com/android/webviewtests/JavaBridgeCoercionTest.java @@ -47,7 +47,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { private long mLongValue; private float mFloatValue; private double mDoubleValue; - // TODO: Test passing to methods with array parameters. private String mStringValue; private Object mObjectValue; private CustomType mCustomTypeValue; @@ -100,7 +99,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { mDoubleValue = x; notifyResultIsReady(); } - // TODO: Test passing to methods with array parameters. public synchronized void setStringValue(String x) { mStringValue = x; notifyResultIsReady(); @@ -146,7 +144,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { waitForResult(); return mDoubleValue; } - // TODO: Test passing to methods with array parameters. public synchronized String waitForStringValue() { waitForResult(); return mStringValue; @@ -472,8 +469,6 @@ public class JavaBridgeCoercionTest extends JavaBridgeTestBase { assertNull(mTestObject.waitForCustomTypeValue()); } - // TODO: Test passing arrays. - // Test passing a JavaScript object to a method of an injected object. public void testPassJavaScriptObject() throws Throwable { // LIVECONNECT_COMPLIANCE: Should raise a JavaScript exception.