Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix naming of the parameter in method deleteWindowMagnification

Browse Source 
Fixing naming and logic for the parameter for better readability since
the original ones are confusing.

Bug: 257272333
Test: manually test the behavior of magnification setting panel
Change-Id: Ifaf1cdee2d6a943476866414a106a7d2e14fbe1b
This commit is contained in:
chihtinglo
2023-03-07 11:53:17 +08:00
parent 2f390b89da
commit 9edcba0d03
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java
View File

@@ -404,18 +404,18 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold
}
void deleteWindowMagnification() {
deleteWindowMagnification(/* hideSettingPanel= */ false);
deleteWindowMagnification(/* closeSettingPanel= */ true);
}
/**
* Deletes the magnification window.
*/
void deleteWindowMagnification(boolean hideSettingPanel) {
void deleteWindowMagnification(boolean closeSettingPanel) {
if (!isWindowVisible()) {
return;
}
if (!hideSettingPanel) {
if (closeSettingPanel) {
closeMagnificationSettings();
}
@@ -495,7 +495,7 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold
// Recreate the window again to correct the window appearance due to density or
// window size changed not caused by rotation.
if (isWindowVisible() && reCreateWindow) {
deleteWindowMagnification(/* hideSettingPanel= */ true);
deleteWindowMagnification(/* closeSettingPanel= */ false);
enableWindowMagnificationInternal(Float.NaN, Float.NaN, Float.NaN);
}
}