From 9edcba0d03e3b0a6f15a2e57bb7fc50aaaecfdbc Mon Sep 17 00:00:00 2001 From: chihtinglo Date: Tue, 7 Mar 2023 11:53:17 +0800 Subject: [PATCH] Fix naming of the parameter in method deleteWindowMagnification Fixing naming and logic for the parameter for better readability since the original ones are confusing. Bug: 257272333 Test: manually test the behavior of magnification setting panel Change-Id: Ifaf1cdee2d6a943476866414a106a7d2e14fbe1b --- .../accessibility/WindowMagnificationController.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java b/packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java index 462b3a6c234db..57c99187c302c 100644 --- a/packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java +++ b/packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java @@ -404,18 +404,18 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold } void deleteWindowMagnification() { - deleteWindowMagnification(/* hideSettingPanel= */ false); + deleteWindowMagnification(/* closeSettingPanel= */ true); } /** * Deletes the magnification window. */ - void deleteWindowMagnification(boolean hideSettingPanel) { + void deleteWindowMagnification(boolean closeSettingPanel) { if (!isWindowVisible()) { return; } - if (!hideSettingPanel) { + if (closeSettingPanel) { closeMagnificationSettings(); } @@ -495,7 +495,7 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold // Recreate the window again to correct the window appearance due to density or // window size changed not caused by rotation. if (isWindowVisible() && reCreateWindow) { - deleteWindowMagnification(/* hideSettingPanel= */ true); + deleteWindowMagnification(/* closeSettingPanel= */ false); enableWindowMagnificationInternal(Float.NaN, Float.NaN, Float.NaN); } }