Merge "Make sure to reset isFoldHandled" into tm-qpr-dev

This commit is contained in:
Treehugger Robot
2023-05-05 01:05:05 +00:00
committed by Android (Google) Code Review
2 changed files with 32 additions and 4 deletions

View File

@@ -150,10 +150,6 @@ constructor(
pendingScrimReadyCallback = onReady
}
} else if (isFolded && !isFoldHandled && alwaysOnEnabled && isDozing) {
// Screen turning on for the first time after folding and we are already dozing
// We should play the folding to AOD animation
isFoldHandled = true
setAnimationState(playing = true)
centralSurfaces.notificationPanelViewController.prepareFoldToAodAnimation()
@@ -169,6 +165,13 @@ constructor(
// No animation, call ready callback immediately
onReady.run()
}
if (isFolded) {
// Any time the screen turns on, this state needs to be reset if the device has been
// folded. Reaching this line implies AOD has been shown in one way or another,
// if enabled
isFoldHandled = true
}
}
/** Called when keyguard scrim opaque changed */

View File

@@ -197,6 +197,31 @@ class FoldAodAnimationControllerTest : SysuiTestCase() {
job.cancel()
}
@Test
fun onFolded_onScreenTurningOnWithoutDozingThenWithDozing_doesNotLogLatency() =
runBlocking(IMMEDIATE) {
val job = underTest.listenForDozing(this)
keyguardRepository.setDozing(false)
setAodEnabled(enabled = true)
yield()
fold()
simulateScreenTurningOn()
reset(latencyTracker)
// Now enable dozing and trigger a second run through the aod animation code. It should
// not rerun the animation
keyguardRepository.setDozing(true)
yield()
simulateScreenTurningOn()
verify(latencyTracker, never()).onActionStart(any())
verify(latencyTracker, never()).onActionEnd(any())
job.cancel()
}
@Test
fun onFolded_animationCancelled_doesNotLogLatency() =
runBlocking(IMMEDIATE) {