Merge "Temporarily disable some Bubbles checks"

This commit is contained in:
TreeHugger Robot
2020-10-23 21:18:47 +00:00
committed by Android (Google) Code Review
2 changed files with 6 additions and 4 deletions

View File

@@ -6097,14 +6097,15 @@ public class NotificationManagerService extends SystemService {
}
// bubble or inline reply that's immutable?
if (n.getBubbleMetadata() != null
// TODO (b/171418004): renable after app outreach
/*if (n.getBubbleMetadata() != null
&& n.getBubbleMetadata().getIntent() != null
&& hasFlag(mAmi.getPendingIntentFlags(
n.getBubbleMetadata().getIntent().getTarget()),
PendingIntent.FLAG_IMMUTABLE)) {
throw new IllegalArgumentException(r.getKey() + " Not posted."
+ " PendingIntents attached to bubbles must be mutable");
}
}*/
if (n.actions != null) {
for (Notification.Action action : n.actions) {

View File

@@ -7145,7 +7145,8 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {
inOrder.verify(child).recordDismissalSentiment(anyInt());
}
@Test
// TODO (b/171418004): renable after app outreach
/*@Test
public void testImmutableBubbleIntent() throws Exception {
when(mAmi.getPendingIntentFlags(pi1))
.thenReturn(FLAG_IMMUTABLE | FLAG_ONE_SHOT);
@@ -7160,7 +7161,7 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {
} catch (IllegalArgumentException e) {
// good
}
}
}*/
@Test
public void testMutableBubbleIntent() throws Exception {