From 54f0682ff06235a02d01c7af521419f3aa78b93b Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Fri, 23 Oct 2020 14:04:04 -0400 Subject: [PATCH] Temporarily disable some Bubbles checks Test: atest Bug: 171418004 Change-Id: I11517d35594901108789621218457b3221ecaf1d --- .../server/notification/NotificationManagerService.java | 5 +++-- .../server/notification/NotificationManagerServiceTest.java | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java index 4d6b760fc56f5..0a11fbc2d12c9 100755 --- a/services/core/java/com/android/server/notification/NotificationManagerService.java +++ b/services/core/java/com/android/server/notification/NotificationManagerService.java @@ -6091,14 +6091,15 @@ public class NotificationManagerService extends SystemService { } // bubble or inline reply that's immutable? - if (n.getBubbleMetadata() != null + // TODO (b/171418004): renable after app outreach + /*if (n.getBubbleMetadata() != null && n.getBubbleMetadata().getIntent() != null && hasFlag(mAmi.getPendingIntentFlags( n.getBubbleMetadata().getIntent().getTarget()), PendingIntent.FLAG_IMMUTABLE)) { throw new IllegalArgumentException(r.getKey() + " Not posted." + " PendingIntents attached to bubbles must be mutable"); - } + }*/ if (n.actions != null) { for (Notification.Action action : n.actions) { diff --git a/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java b/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java index 1100496dffbeb..5016710f22b93 100755 --- a/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java +++ b/services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java @@ -7145,7 +7145,8 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { inOrder.verify(child).recordDismissalSentiment(anyInt()); } - @Test + // TODO (b/171418004): renable after app outreach + /*@Test public void testImmutableBubbleIntent() throws Exception { when(mAmi.getPendingIntentFlags(pi1)) .thenReturn(FLAG_IMMUTABLE | FLAG_ONE_SHOT); @@ -7160,7 +7161,7 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { } catch (IllegalArgumentException e) { // good } - } + }*/ @Test public void testMutableBubbleIntent() throws Exception {