Commit Graph

2009 Commits

Author SHA1 Message Date
Edgar Wang
4d93ad694b Merge "Fix NPE if default supervisor is not defined" am: 9bc3b6a207
Change-Id: I74e93eca610194d7251c596bb854446bbc3dc129
2020-05-28 06:45:04 +00:00
Edgar Wang
9bc3b6a207 Merge "Fix NPE if default supervisor is not defined" 2020-05-28 06:30:46 +00:00
TreeHugger Robot
d078f8e326 Merge "Enable the filterTouchesWhenObscured in Special app access" into rvc-dev am: 01338915d8
Change-Id: Ia4845ed6f59769cbd763e2137a807afa54696e62
2020-05-28 03:07:04 +00:00
TreeHugger Robot
01338915d8 Merge "Enable the filterTouchesWhenObscured in Special app access" into rvc-dev 2020-05-28 02:58:23 +00:00
Sunny Shao
ee4ec4b33f Enable the filterTouchesWhenObscured in Special app access
- Enable the filterTouchesWhenObscured attribute on all toggle
  switches in all pages of the special app access

Fixes: 155288585
Test: make RunSettingsRoboTests
Change-Id: I011cfe4b7e4e624a8338332ac47a353f7f3ab661
2020-05-27 17:21:24 +08:00
Yanting Yang
bf4f72b1fa Merge "Improve scrolling performance for App Info page" into rvc-dev am: 4e14ffd77e
Change-Id: I6eb31ab162338e52a754dc098752feefa6d8dcd0
2020-05-27 05:48:03 +00:00
Yanting Yang
6b457d882c Improve scrolling performance for App Info page
Root cause:
App info page will load application icon and content description in
onBindViewHolder(), it will query PackageManager and UserManager many
times in scrolling. Actually these actions will become time consuming if
there is a large app list.

Solution:
To relieve the janky scrolling, cache the icon and content description
if it has been loaded once.

Bug: 156527207
Test: manual test and robotests

Change-Id: I997179834511f86b3155c7d54989a873ac8e2559
2020-05-21 19:09:39 +08:00
Treehugger Robot
045783bd37 Merge "Preserve icon for "manage space"" am: c39b3dfd76 am: d71f2b3f1a
Change-Id: I6b0b1a56980191bc551ba409bfce8e104ca2706a
2020-05-19 12:12:16 +00:00
Treehugger Robot
d71f2b3f1a Merge "Preserve icon for "manage space"" am: c39b3dfd76
Change-Id: Ic24c59d88117a9e0a6f61e2c1b0e2726a1546487
2020-05-19 11:58:13 +00:00
TreeHugger Robot
18b095ee68 Merge "Close Settings page when cross-profile appop is granted" into rvc-dev am: 1b240b646d
Change-Id: Ia6e4fc35be4c951897e67d162e5767c197c2b66b
2020-05-18 03:38:21 +00:00
TreeHugger Robot
1b240b646d Merge "Close Settings page when cross-profile appop is granted" into rvc-dev 2020-05-18 03:25:24 +00:00
Alex Kershaw
d3fa045e35 Close Settings page when cross-profile appop is granted
Fixes: 156365481
Test: manual
Change-Id: I9250ef5db0c40a42a25a2dedf84a47d1b1da11f1
2020-05-16 20:33:34 +01:00
Wang Han
719b573173 Fix NPE if default supervisor is not defined
* Checking for null does not work sadly. This fixes NPE at
   calling who.compareTo(supervisorComponent).

Change-Id: Ie49df625b1514b1d1e5f8063db66dce4a5050039
2020-05-15 14:06:11 +00:00
TreeHugger Robot
27a4a17aac Merge "Add null check for intent in AppPermissionPreferenceController" into rvc-dev am: bb7a65a19b
Change-Id: Id3005fde29c015152fbc345bd1b8d7fe3d2efd20
2020-05-14 03:32:22 +00:00
Nate Myren
8c7c22d4b9 Add null check for intent in AppPermissionPreferenceController
Sometimes, the App Info page can be reached without an intent in tests.
Add a null check to catch this

Bug: 154650244
Test: atest AppPermissionPreferenceControllerTest#handlePreferenceTreeClick_shouldStartManagePermissionsActivity

Change-Id: I514acda6b78d9e76b230aa945067bd7d6d9feff9
2020-05-13 13:00:53 -07:00
Kholoud Mohamed
d3bd08653d Merge "String changes in the cross profile settings page" into rvc-dev am: 311ff0c1ea
Change-Id: Ic44752f686a0878ab05e8ccf7a2e4190fa153b26
2020-05-12 15:29:49 +00:00
Kholoud Mohamed
311ff0c1ea Merge "String changes in the cross profile settings page" into rvc-dev 2020-05-12 15:13:32 +00:00
Nate Myren
fbe64a68da Merge "Add Auto Revoke log to the App Info page" into rvc-dev am: 0c6037af5f
Change-Id: I547a008b73764af371f27710c1f94348fb3d0644
2020-05-11 22:55:34 +00:00
Nate Myren
0c6037af5f Merge "Add Auto Revoke log to the App Info page" into rvc-dev 2020-05-11 22:37:04 +00:00
Kholoud Mohamed
bcbd9158d6 String changes in the cross profile settings page
Fixes: 155771527
Test: visually tested the string changes.
Change-Id: Idcde93e2035bb8d3d82213befb652aa29aa12efe
2020-05-11 18:38:05 +01:00
Tsung-Mao Fang
c497fc6670 Merge "Talkback speaks "work" for work profile app" into rvc-dev am: 32e693d657
Change-Id: I3d5ba48c4e02d2efe558aad8c907cbaebb76b8a8
2020-05-08 05:38:24 +00:00
Nate Myren
d55449aec0 Add Auto Revoke log to the App Info page
Test: manual
Bug: 154650244
Change-Id: Ibc944ce72d176204cc20c6d0460bf5efe6f7a878
2020-05-07 10:02:35 -07:00
Tsung-Mao Fang
e8ffbb21a1 Talkback speaks "work" for work profile app
Set a content description for each app entity.
If app is a work profile, then talkback says "work" app name.

Test: Rebuilt rom and talkback speaks correct description.
Bug: 127602715
Change-Id: I1952b77a18a884a887d912fb7edc44a12be70ad4
2020-05-07 19:39:41 +08:00
Yanting Yang
4b6408bf04 Merge "Hide the app details preference for mainline module apps" into rvc-dev am: cf33b4bc5e
Change-Id: I421103706198203fb7e25aff4a380c0b0ede8df7
2020-05-07 08:44:51 +00:00
Yanting Yang
cf33b4bc5e Merge "Hide the app details preference for mainline module apps" into rvc-dev 2020-05-07 08:41:39 +00:00
Yanting Yang
172f4064a9 Hide the app details preference for mainline module apps
For mainline module apps, user can not install them from the play store.
We should not provide the play store link for them in app info page.
Therefore, we decide to hide their app details preference which is to
provide the play store link from the app info page.

Bug: 152718521
Test: visual and robotests
Change-Id: I46b64be0d725740c2b80a5251a42e9fc834e4596
2020-05-06 20:56:51 +08:00
TreeHugger Robot
2fb7f3e5bb Merge "Enable some settings pages to use paralleled-loading method" into rvc-dev am: 18490b2dc8
Change-Id: I7bd50f81b088c8dc1ffcf92e23dc8be06e1d0f8e
2020-05-05 09:34:13 +00:00
Sunny Shao
6d60248053 Enable some settings pages to use paralleled-loading method
- Here these pages include AppInfoDashboardFragment, ConnectedDeviceDashboardFragment,
  DevelopmentSettingsDashboardFragment, NetworkDashboardFragment, ConfigureNotificationSettings.
- The TimeSpentInAppPreferenceController use the LiveDataController.

Fixes: 135299529
Bug: 137558156
Test: compilation
Change-Id: I455a16536c9966184f1b2bd81d1f1217f3e09f9d
2020-05-04 10:34:23 +08:00
Yanting Yang
fb2ef59a3c Merge "Fix NPE crash when opening the app info from shortcut suggestion" into rvc-dev am: 459e5e1636
Change-Id: Iffcf5b68b1efb84ee0467480f68ef1cdb5d196e7
2020-04-30 13:37:42 +00:00
Yanting Yang
9dc0a45fd8 Fix NPE crash when opening the app info from shortcut suggestion
It occurs NPE in invoking refreshUi() of AppButtonsPreferenceController
when user fully install the instant app from google play and then
directly open app info from the shortcut suggestion in launcher.

Root cause:
AppButtonsPreferenceController.refreshUi() will be invoked when user
directly open app info from the shortcut suggestion in launcher. In
refreshUi(), we will update the information of button preference, but
the preferences will not be initialized if device existed an instant
version for the app.

Solution:
Check button preference and initial them if need in refreshUi().

Fixes: 137854835
Test: visual, robotests
Change-Id: Id5c3e53b9db2683cab970c10eace7925d889eea3
2020-04-30 08:53:16 +08:00
Wang Han
d3d2760841 Preserve icon for "manage space"
* I1f7cccf0558960f867a8bf2d0ee14dc5ec9fd7a9 fixes the text but
   there is no more icon for "manage space". Preserve the old
   icon.

Change-Id: I3256f176b861cfa88780dfcbc54c6e38aac87c8b
2020-04-19 04:52:27 +00:00
TreeHugger Robot
4deaf56720 Merge "Fix incorrect app count displayed under special app access" into rvc-dev am: 87883c7634
Change-Id: I8e9c0ce77944b57245ca25e3fe00bf427e061cd4
2020-04-17 10:19:04 +00:00
TreeHugger Robot
87883c7634 Merge "Fix incorrect app count displayed under special app access" into rvc-dev 2020-04-17 10:07:21 +00:00
Sunny Shao
d63c5ebff5 Fix incorrect app count displayed under special app access
- This special app Google Play services will change its hasLauncherEntry
  value after receiving the MSG_LOAD_LAUNCHER.
- Update the summary while SpecialAppAccessPreferenceController is
  receiving the onLauncherInfoChanged callback.

Fixes: 150480524
Test: manual test
Change-Id: I26b99fce54606644ee5603b4ca4730267c0f7ce5
2020-04-16 21:38:03 +08:00
TreeHugger Robot
63536f8392 Merge "Refactor the OpenSupportedLinks" into rvc-dev am: ccb37bb8d1
Change-Id: I60fc8f0427b85a27599e29c3b5c62f66efe330c2
2020-04-15 17:01:22 +00:00
Sunny Shao
44b74c9cfe Refactor the OpenSupportedLinks
- Use the AppInfoWithHeader to replace the DashboardFragment.
- It provide the AppHeader controller and handle the app update/remove event.

Fixes: 147996227
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.applications.OpenSupportedLinksTest
Change-Id: I1633c39fc926805a379c5c31845897914e5181a6
2020-04-15 09:53:43 +08:00
George Chang
f4d5666aea Merge "[NFC] Disable contactless payments when no payment application installed" into rvc-dev am: 0181643bb7
Change-Id: I8208b97e26b28fffd435703e0aacea051d95aed2
2020-04-13 03:00:40 +00:00
George Chang
28895f2822 [NFC] Disable contactless payments when no payment application installed
Bug: 153821082
Bug: 149270345
Test: Check settings
Change-Id: I5162ecb07c26a33427305b6cf65829b2c61ad317
2020-04-13 01:53:23 +00:00
TreeHugger Robot
b0ea1a81a3 Merge "Add metrics for the cross profile settings page" into rvc-dev am: a59df23975
Change-Id: I13147ab8d9b982728bb2d0f65cf300cf66340e19
2020-04-09 11:08:55 +00:00
TreeHugger Robot
a59df23975 Merge "Add metrics for the cross profile settings page" into rvc-dev 2020-04-09 10:52:11 +00:00
Treehugger Robot
a801eee2e9 Merge "Button text for app space management is overwritten" am: 1d47b76cb5 am: 41087780ee
Change-Id: I526f17f1ba6f6c2502ce8691f38319828c3dc378
2020-04-07 08:10:22 +00:00
Treehugger Robot
41087780ee Merge "Button text for app space management is overwritten" am: 1d47b76cb5
Change-Id: Ibd3486cb9338e910049e1e2bc9febb751575320b
2020-04-07 07:58:27 +00:00
Jason Chiu
4edb83b260 Merge "Refine metrics log in infrastructure" into rvc-dev 2020-04-07 06:33:30 +00:00
Jason Chiu
819abf7f87 Refine metrics log in infrastructure
- Add interfaces to set/get metrics category in BasePreferenceController
  for descendants having a chance to get it.
- Set metrics category in DashboardFragment
- Automatically log metrics in onPreferenceChange of
  TogglePreferenceController
- Add support for TwoStateButtonPreference in TogglePreferenceController
  to make the preference generic

Bug: 137559984
Test: robotest
Change-Id: Ia7e0d24a3db1991b18e0286d9894570fa71247a3
2020-04-07 14:08:39 +08:00
Pingzhi Wang
63c3b9a6cd Button text for app space management is overwritten
Apps that have implemented a managed space activity
gets the wrong label in Settings../App info/"Storage & cache"

Test: manual
Bug: 111674319
Change-Id: I1f7cccf0558960f867a8bf2d0ee14dc5ec9fd7a9
2020-04-06 21:00:54 +02:00
TreeHugger Robot
d81224b7d4 Merge "Update permission summary when permission changing." into rvc-dev 2020-04-06 05:22:01 +00:00
kholoud mohamed
a8bd1bea4e Add metrics for the cross profile settings page
Also changed the install banner to not say "Tap to
install" if the intent to redirect to Play is missing.

Bug: 149774826
Test: tested manually that the metrics are being reported by running
./out/host/linux-x86/bin/statsd_testdrive 103

Change-Id: Ieebda237748b5dbff8e974465c5d67b147d92077
2020-04-03 11:21:10 +00:00
kholoud mohamed
f9a03cd415 Fix crash when trying to open app info page
Fixed a crash in App info page that happens when
no work profile exists, also fixed some unit tests.

Fixes: 152933121
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesDetailsTest
Change-Id: I7a1e5857cb1e10b96b33abd64359ba30459b1b13
2020-04-01 17:27:17 +00:00
Yi-Ling Chuang
f31d38620c Update permission summary when permission changing.
Some apps have pre-grant permissions, so when they get disabled and then
enabled again, those pre-granted ones will come back automatically. This
CL handles this kind of cases by listening to permission changes and
update the summary accordingly.

Fixes: 142053555
Test: robotests
Change-Id: I75b010139657ec3b4ff875de77573a46387e42c8
2020-04-01 15:27:15 +08:00
Kholoud Mohamed
7fb6f35c3a Merge "Show all apps that requested cross profile permission" into rvc-dev 2020-03-31 13:09:31 +00:00