Commit Graph

44926 Commits

Author SHA1 Message Date
Nitin Shivpure
75787c8a77 Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" into pi-dev
am: d924894652

Change-Id: Ia7a01f35e8a231cf53b481e71266982359a810cf
2018-05-16 16:41:43 -07:00
TreeHugger Robot
d924894652 Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" into pi-dev 2018-05-16 23:28:28 +00:00
Matthew Fritze
caf745ea13 Merge "Set slice summary text to screentitle first" into pi-dev
am: e7f321c3c0

Change-Id: Ib351491d18ef9fb057fffebf7c1bc2b90c3a917b
2018-05-16 16:08:00 -07:00
TreeHugger Robot
e7f321c3c0 Merge "Set slice summary text to screentitle first" into pi-dev 2018-05-16 22:51:55 +00:00
Nitin Shivpure
1b0afb9d1c Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak
Usecase:
1.) Make sure BT is turned off.
2.) Go to Settings -> Network & Internet
3.) Press back  from Network & Internet.
4.) Repeat above step 2000 times

Expected Result:
No ANR/Crashed should be seen.

Observed Result:
ServiceConnection leak is happening & android setting app get crashed.

Root cause: TetherPreferenceController tries to get
pan Proxy object, when BT is oFF, which is leaking one
service connection each time

Fix: getProfileProxy for Pan must only be called, when BT is
      turned on.

Test: lifeCycle_onCreate_shouldNotInitBluetoothPanWhenBluetoothOff

Bug: 79561076
Change-Id: I85208f48ce4dded94020cb156fcdb98b2cc873f9
(cherry picked from commit 31bcf6225cdabee4f810d4fe55ea32d0d43a9c5c)
(cherry picked from commit 31c799305b480e56bd083a48c6acca11572ebe16)
2018-05-16 15:22:56 -07:00
Fan Zhang
afb17b6ed1 Merge "Move app setting link from Entity header to pref controller" into pi-dev
am: e3319d0449

Change-Id: I5cbc1dc4dfab9df74bca3bda824d38d3b4b778f6
2018-05-16 14:08:25 -07:00
TreeHugger Robot
e3319d0449 Merge "Move app setting link from Entity header to pref controller" into pi-dev 2018-05-16 20:51:17 +00:00
Fan Zhang
cac18e12ac Move app setting link from Entity header to pref controller
Change-Id: I13a27486a9c9b4c4fb358715d678473e63c1b624
Merged-In: I13a27486a9c9b4c4fb358715d678473e63c1b624
Fixes: 79688822
Test: robotest
2018-05-16 19:56:33 +00:00
joeshih
421b0cf526 Merge "Support Vibrate for calls in Settings Slices" into pi-dev
am: a0f9241400

Change-Id: Ib77fc8257bfb4a00368735504558c6b27a95ec17
2018-05-16 11:58:11 -07:00
TreeHugger Robot
a0f9241400 Merge "Support Vibrate for calls in Settings Slices" into pi-dev 2018-05-16 18:48:14 +00:00
hughchen
14ce329377 Merge "Change string from "Add device" to "Pair new device"" into pi-dev
am: 46338558e1

Change-Id: I5fa291ba3677398efcfe0f5b89f10df24463a3fa
2018-05-16 10:47:40 -07:00
TreeHugger Robot
46338558e1 Merge "Change string from "Add device" to "Pair new device"" into pi-dev 2018-05-16 17:32:38 +00:00
Joshua Mccloskey
c7123d4b0e Merge "Fixed accessibility bug in choose_lock_pattern_common.xml where title was not always read" into pi-dev
am: d819dbacb6

Change-Id: I4041083c976c506ed1848c91c6a19e470b4d2766
2018-05-16 10:03:45 -07:00
Joshua Mccloskey
d819dbacb6 Merge "Fixed accessibility bug in choose_lock_pattern_common.xml where title was not always read" into pi-dev 2018-05-16 16:49:14 +00:00
Matthew Fritze
f9c13fc305 Set slice summary text to screentitle first
To improve context on search surfaces where the
setting may be ambiguous, we set the screentitle
as the summary text as the top priority. If there is
no screentitle or the it matches the title, then we
try to use the controller summary. If the controller
summary is not valid, then we show nothing.

Bug: 79780762
Test: robotests
Change-Id: If4f7f8d4a072125604ede14e3df2afd667fa24b7
2018-05-16 08:13:22 -07:00
Beverly
df1614f7f1 Merge "DO NOT MERGE Update zen onboarding" into pi-dev
am: b7b355a1c5

Change-Id: Ia5360d8576f97db9b2eb8db6b3b9dff029811e2b
2018-05-16 06:33:05 -07:00
TreeHugger Robot
b7b355a1c5 Merge "DO NOT MERGE Update zen onboarding" into pi-dev 2018-05-16 13:24:39 +00:00
hughchen
4e0e3c83e8 Change string from "Add device" to "Pair new device"
Change string from "Add device" to "Pair new device"

Bug: 79298886
Test: Build pass
Change-Id: Iac4e251d5fab794f90e98911208f026d62b91659
2018-05-16 19:17:06 +08:00
joeshih
a025eb2b35 Support Vibrate for calls in Settings Slices
Use TogglePreferenceController instead of AbstractPreferenceController
for VibrateWhenRingPreferenceControllr

Bug:74915140
Test: make RunSettingsRoboTests
Change-Id: Ib06126324516826411a7d50a2bd8a790bfd477c7
Merged-In: I501a1470da7dc1ff582c2a90b5235b25036caefc
2018-05-16 11:36:45 +08:00
Fan Zhang
c3669d8971 Update sound setting icons
am: 37a6a91444

Change-Id: I81addc754a5fbb17a31d15cc1d001de72a50f15e
2018-05-15 18:35:04 -07:00
Fan Zhang
37a6a91444 Update sound setting icons
- icon for sound setting in Settings homepage
- icon on phone muted condition card
- icon on DND condition card and DND suggestion

Bug: 77982107
Test: visual
Change-Id: I22b5223029d67de0bcb2466a45075835453a2b5f
2018-05-15 15:35:37 -07:00
Beverly
7f53974cbd Merge "DO NOT MERGE Show mute icon in sound settings page" into pi-dev
am: 69ec1673df

Change-Id: I825f94150e349465d4dd9168ab18d8f03fc9ed73
2018-05-15 14:58:21 -07:00
TreeHugger Robot
69ec1673df Merge "DO NOT MERGE Show mute icon in sound settings page" into pi-dev 2018-05-15 21:39:55 +00:00
Beverly
90ebab0650 DO NOT MERGE Show mute icon in sound settings page
- Show mute icon when ringer is muted
- Show vibrate icon when ringer is on vibrate
- Show ringer icon when ringer is on ring

Test: visual inspection
Change-Id: I662e0d4fd33ac2284378c2f558509c93c907fbe3
Bug: 78330194
2018-05-15 20:35:50 +00:00
richard chou
baadcabd04 Merge "Suppress NewDeviceIntroSuggestionActivity if Tips application exists" into pi-dev
am: 034e39679d

Change-Id: I79ba64918f591c28067b10a09c3844824f7a9278
2018-05-15 11:57:59 -07:00
Rajeev Kumar
1378ebfcca Merge "Make sure we do not make UI calls from background thread in DashboardSummary class." into pi-dev
am: e3813863b7

Change-Id: Iba013ff7a6983b7544b5194ff3480f1b1aa28025
2018-05-15 11:42:07 -07:00
hughchen
5487984da5 Merge "Add and update string" into pi-dev
am: ef9b8cda82

Change-Id: Ibb97f897a9564a03598c56e5e1514c9b645106ed
2018-05-15 11:28:37 -07:00
TreeHugger Robot
034e39679d Merge "Suppress NewDeviceIntroSuggestionActivity if Tips application exists" into pi-dev 2018-05-15 18:16:25 +00:00
Jeff Gaston
77122cf150 Merge "Update for support library prebuilt drop" into pi-dev
am: 72f57a7c99

Change-Id: I4256831e69c3a61ce18a22afcec0cec845da2e93
2018-05-15 11:16:02 -07:00
TreeHugger Robot
e3813863b7 Merge "Make sure we do not make UI calls from background thread in DashboardSummary class." into pi-dev 2018-05-15 18:07:56 +00:00
richard chou
4eb9e542c1 Suppress NewDeviceIntroSuggestionActivity if Tips application exists
NewDeviceIntroSuggestionActivity should not show if Tips application exists.

Bug: 77652536
Test: atest SettingsRoboTests
Change-Id: I0aa19a5bc79c8b1497f42372d293299509d897b2
Merged-In: I85575e8eb92a8a620f0af9e5ad3ebd5b8dd05323
2018-05-15 17:17:21 +00:00
TreeHugger Robot
ef9b8cda82 Merge "Add and update string" into pi-dev 2018-05-15 17:04:10 +00:00
Beverly
e3a66fc16d DO NOT MERGE Update zen onboarding
- Update text
- Update buttons
- Update style

Bug: 79702414
Bug: 78447976
Bug: 79525632
Test: ZenOnboardingActivityTest
Change-Id: Ied476fc920828409993953fba32bf3dae324ea3c
2018-05-15 12:43:55 -04:00
Jeff Gaston
72f57a7c99 Merge "Update for support library prebuilt drop" into pi-dev 2018-05-15 16:37:55 +00:00
Jeff Gaston
3e76e17c15 Update for support library prebuilt drop
Bug: 79267345
Test: m -j checkbuild

Change-Id: I086a2253a1c94af6f7c4dca04d2644a4f9e54ef5
2018-05-15 11:21:26 -04:00
Matthew Fritze
94f84da552 Merge "Remove old meta data declarations in manifest" into pi-dev
am: 9b7f0e4c5d

Change-Id: I5c28d032d6ca39be4ec9a239ff0637d3806ae74f
2018-05-15 06:52:41 -07:00
TreeHugger Robot
9b7f0e4c5d Merge "Remove old meta data declarations in manifest" into pi-dev 2018-05-15 13:45:32 +00:00
Jason Monk
2d462ea467 Merge "Delay index job a little bit" into pi-dev
am: 5530329da2

Change-Id: Ifd278179f6c5527bdd19dcc656459525ac403cd1
2018-05-15 06:21:25 -07:00
Beverly
e385ab21a3 Merge "Gets rid of dividers in sound settings" into pi-dev
am: e6f66a3c9a

Change-Id: Iaaa2ea0ba1f37b1c477a18000e49724b5162288a
2018-05-15 06:20:34 -07:00
TreeHugger Robot
5530329da2 Merge "Delay index job a little bit" into pi-dev 2018-05-15 13:18:42 +00:00
TreeHugger Robot
e6f66a3c9a Merge "Gets rid of dividers in sound settings" into pi-dev 2018-05-15 13:16:22 +00:00
hughchen
1b2b83968e Add and update string
* Change the string from "cast" to "driving mode"
* Add string "Bluetooth, NFC" and "Bluetooth"

Bug: 79299421
Test: build pass
Change-Id: I6da7e54545f209110fca8e7a107f3b20066c7623
2018-05-15 15:24:17 +08:00
timhypeng
5248e0cfd9 Click left side of list in "previously connected devices" should connect to the device
am: bafae44cb2

Change-Id: I8663afa58fe1cb5210575c8966e7430885d19f49
2018-05-14 23:15:50 -07:00
timhypeng
bafae44cb2 Click left side of list in "previously connected devices" should connect to the device
* In "previously connected devices", to connect device
* In "Available media devices", to activate device

Bug: 77607104
Test: make -j50 RunSettingsRoboTests
Change-Id: If5005031bd3f5dc4950abf2c77575785cd6f67b1
Merged-In: If5005031bd3f5dc4950abf2c77575785cd6f67b1
2018-05-15 06:07:28 +00:00
Lei Yu
ca5296446d Merge "Add string for disabled FAS toggle." into pi-dev
am: cbf68188ff

Change-Id: If82cb65870b876462d9aff7cd5630db8186129cb
2018-05-14 20:15:11 -07:00
TreeHugger Robot
cbf68188ff Merge "Add string for disabled FAS toggle." into pi-dev 2018-05-15 03:09:19 +00:00
Lei Yu
bb975a5751 Merge "Remove the dynamic summary for bt preference." into pi-dev
am: 912af577ab

Change-Id: I7f14345e55d15e50c3bd16ad234d1f31edd5ffc2
2018-05-14 18:37:21 -07:00
TreeHugger Robot
912af577ab Merge "Remove the dynamic summary for bt preference." into pi-dev 2018-05-15 01:15:18 +00:00
Rajeev Kumar
549a188efe Make sure we do not make UI calls from background thread in DashboardSummary class.
Bug: 79705354
Test: make RunSettingsRoboTests -j40 and manual testing.
Change-Id: I08a08e05f3424f4a6d2100aed32d32bb15997c86
2018-05-14 17:59:59 -07:00
Lei Yu
dae3c912d7 Add string for disabled FAS toggle.
If FAS toggle is disabled because app is in doze whitelist(not optimized), show
a dialog that has this string.

Bug: 77924141
Test: Manual
Change-Id: I30518cd887125bff00b7c567e26204d5b1814858
2018-05-14 17:55:21 -07:00