Commit Graph

1548 Commits

Author SHA1 Message Date
Beverly
4922aa006a Notification history a11y fixes
- When clicking the expand/collapse button to see the posted
notifications from an app in the last 24 hours, refocus accessibility on
the button so the entire button (contentDescription + clickability) are
announced. Previously only the contentDescription update was being
announced.

- Fix local context menu of NotificationHistory elements by calling the
super method in performAccessibilityAction

Test: manual
Fixes: 153396313
Fixes: 153518629
Change-Id: I3d847ec1f2b72dcf411c6c7c7fe2dc061ccfde26
2020-04-21 14:54:45 -04:00
Julia Reynolds
4fa251613e Merge "Set explicit back target for history" into rvc-dev am: bb979153ed
Change-Id: I2c81ca3114f44cab401b7f698cde7ae5481b8ebb
2020-04-20 17:53:22 +00:00
Julia Reynolds
6c8451a89f Set explicit back target for history
Test: manual
Fixes: 153554906
Change-Id: Ic3198afae878e3cfbfbfa7e72b1c71a6f4e74a2e
2020-04-20 11:31:43 -04:00
Julia Reynolds
a8bb57287c Merge "Update conversation bubble settings" into rvc-dev am: 608bd69328
Change-Id: Id6c256f18943631a727b212d39b102c93f1a0f63
2020-04-20 13:37:30 +00:00
Julia Reynolds
b84e194474 Update configure notifications screen am: f43cf08634
Change-Id: Idc63949ef2f2ecaaae7891a01d6eb48cbf830eaa
2020-04-17 20:58:04 +00:00
Julia Reynolds
cecc69512d Update conversation bubble settings
Test: atest
Fixes: 153471239
Change-Id: If53571b17236e5f49a1750acc9816287f5de2b1a
2020-04-17 16:32:44 -04:00
Julia Reynolds
f43cf08634 Update configure notifications screen
Test: atest
Bug: 153150072
Change-Id: I99ebe2cad5036a154c40bce54dbd6ddbd23c2323
2020-04-17 12:47:06 -04:00
Julia Reynolds
f1801907d8 Merge "Launch subscreens with the correct user" into rvc-dev am: 0c99ecaec1
Change-Id: I40f34bf9f15c76ad1474a8d6096d47027d37b13a
2020-04-16 14:12:27 +00:00
Julia Reynolds
e3cb4f094e Launch subscreens with the correct user
Test: atest
Fixes: 153556621
Change-Id: I5f3f0f408dc8e50db1762b1ce93f7748ea6332b0
2020-04-15 17:36:11 -04:00
TreeHugger Robot
10052a54ab Merge "Update flows for notification history" into rvc-dev am: 79a38a733f
Change-Id: Iad8a918c924115a7cbd04fa160dcf7be9a68fee8
2020-04-15 17:41:53 +00:00
Vince Leung
fa63980566 Merge "Use super method for Vibration preferences" into rvc-d1-dev 2020-04-15 03:53:01 +00:00
Julia Reynolds
1845421ef8 Update flows for notification history
- Remove settings observer, since the switch is right here
- Add 'notifications will soon appear' whenever history is empty

Test: manual
Fixes: 153677280
Fixes: 152578971
Change-Id: Ia372fafb3688fe7d45a7634e379f022bcffea169
2020-04-14 13:16:04 -04:00
Julia Reynolds
6585f79439 Merge "Bubble settings: feature, notification, app" into rvc-dev 2020-04-14 11:22:14 +00:00
Mady Mellor
409c3dfe68 Bubble settings: feature, notification, app
* Removed setting from developer options
* Removed bubble settings from normal notifications /
  channels

* Feature available via notification setting
* Feature screen with educational gif

* App level is now a tri-state choice of all / selected /
  none
* App level bubble controls are accessible top-level in
  app notifications

Test: make -j40 RunSettingsRoboTests ROBOTEST_FILTER="Bubble"
Bug: 138116133
Change-Id: Id103e9d3717fdc9b86a916be40c43cda9c35ac34
2020-04-13 10:15:38 -07:00
Julia Reynolds
5c4c2ed6b3 Merge "Fixes for notification history" into rvc-dev 2020-04-13 13:11:06 +00:00
Julia Reynolds
ecb66ce790 Fixes for notification history
- Fix some crashes
- Fix layout in landscape
- Fix a11y readout

Test: manual
Fixes: 153510934
Fixes: 153554113
Fixes: 153407364
Fixes: 152728558
Change-Id: I6c6bb10d4a67ece61fbf109b4289c4f368206788
2020-04-10 15:34:19 -04:00
Vince Leung
7d6c329746 Use super method for Vibration preferences
onDisplayPreferenceDialog is overriden to handle BT related preferences
but VibrationPreferences require the super method of
onDisplayPreferenceDialog. Therefore if VibrationPreferences wants to
display a dialog, use the super method instead of the overriden method.

Bug: 150661723
Change-Id: I3f8e86e1d1f32fa6eae2798d3bad3cb48402db7b
Merged-In: I3f8e86e1d1f32fa6eae2798d3bad3cb48402db7b
(cherry picked from commit eb27aefa32)
2020-04-09 23:01:40 +00:00
Beverly
ecc377bab8 Update DND strings and image spacing
Test: manual
Bug: 153428950
Change-Id: I25ff7432d6e22224fd1922f097fdd5bdf9ef9a5a
2020-04-09 14:32:26 +00:00
Julia Reynolds
94ad6a1959 Adjust tap targets in history
- Fix a crash if an app couldn't be launched
- Fix the height of tap targets and overlap of text

Fixes: 152977855
Fixes: 153199215
Change-Id: Id623f942c7663c977c61df3d1188fe498cab8acc
2020-04-06 19:44:40 +00:00
Alex Mang
ea5526ca7d Add flag to allow NAS to indicate adjustments on notifications and
solicit feedback.

Bug: 145559028
Test: make -j RunSettingsRoboTests
Change-Id: I45e880168352e4dc5409e5d91ff22d7e4ce69ca7
2020-04-03 14:18:00 -07:00
Julia Reynolds
c7a77f6065 Update history flow
So the screens are more clear when you don't have history
items yet

Test: manual
Fixes: 150211282
Change-Id: Icf1dded3e92ed2121e18bf9a35d570f9efcfda62
2020-04-03 21:00:58 +00:00
Beverly
7aac5c5214 Add conversations image to People DND setting page am: e646b28e26 am: 3afe367fa1 am: dd7d201712 am: 00258ba7ab
Change-Id: I592f23b609964a7abff58ec39c12586a180f948d
2020-04-02 18:49:41 +00:00
Beverly
e646b28e26 Add conversations image to People DND setting page
Previously the image was only on the Conversations settings page, but it
should also be included on the People settings page too.

Test: manual
Bug: 151845457
Change-Id: I99af85b3dcc266a1a5743755fe3cb31fc16ccfba
2020-04-02 16:08:31 +00:00
TreeHugger Robot
eacc08eaa7 Merge "Add conversations image resource" into rvc-dev am: a3160941e2 am: 956d0265fe am: 5288d8236c am: d9738e1ae3
Change-Id: Ia640e2ca2610aba0a6d6c0e6de564cfadc65728c
2020-04-02 00:35:08 +00:00
TreeHugger Robot
a3160941e2 Merge "Add conversations image resource" into rvc-dev 2020-04-01 23:06:58 +00:00
TreeHugger Robot
1a70d052c9 Merge "Some more a11y fixes" into rvc-dev am: c78ad2087d am: 7883d6af66 am: 00573cf65e am: aa204a81fb
Change-Id: If82fbefab5e891ef0fe84a5b938d0235015f2f6d
2020-04-01 22:04:28 +00:00
TreeHugger Robot
c78ad2087d Merge "Some more a11y fixes" into rvc-dev 2020-04-01 20:38:29 +00:00
Beverly
216bf3c320 Add conversations image resource
- Conversations image resource is a compilation of the conversation
icons that are allowed to bypass DND
- Update category header text on DND > Display options for hidden notifications
page
- Update a11y bug in messages and calls pref pages that said images were
tappable

Test: manual
Bug: 151845457
Change-Id: I5387722abf0543b6e07378d498cc0085122c91b9
2020-04-01 13:51:52 -04:00
Julia Reynolds
6fb9669e44 Some more a11y fixes
Min height, and announcing button changes

Test: manual
Fixes: 152729661
Fixes: 152728211
Change-Id: I886ce046da3dd5b2b93673aee0cd5bdc37d5fc48
2020-04-01 12:05:25 -04:00
TreeHugger Robot
5f7375b546 Merge "Add dnd messages + calls senders image resource" into rvc-dev am: 947cb48303 am: e9c4d17eb2 am: 81df373d42 am: 43d299ac8a
Change-Id: I0ef739ea2386854001b719b1e2cf5e8cc43f4241
2020-03-31 21:49:12 +00:00
TreeHugger Robot
53c6bfffae Merge "Disable conversation strip setting." into rvc-dev am: 04d64f470e am: 6e9938cf48 am: 0035707d32 am: 85f940b564
Change-Id: Ia73d18279f72e0eaefe73f0053549a4287a68ffa
2020-03-31 21:48:17 +00:00
TreeHugger Robot
947cb48303 Merge "Add dnd messages + calls senders image resource" into rvc-dev 2020-03-31 19:40:48 +00:00
TreeHugger Robot
04d64f470e Merge "Disable conversation strip setting." into rvc-dev 2020-03-31 19:21:51 +00:00
TreeHugger Robot
5aa24d76ab Merge "Use DEFAULT_LIST contact intent" into rvc-dev am: 07a3b1c6ed am: e15d04acf1 am: 767d51e123 am: 20074d4c41
Change-Id: I8ee88fb72f11ed870bd585ed258efe5ecf6372e6
2020-03-31 18:44:12 +00:00
Beverly
5a4fb7986f Add dnd messages + calls senders image resource
Add a visual representation of the call or message senders that can
bypass DND.

Test: manual
Bug: 151845457
Change-Id: Ie7d3598d5993e4c1cd62294ab9e17da47f2b6f76
2020-03-31 13:29:35 -04:00
Steve Elliott
8a575029fc Disable conversation strip setting.
Test: manual, robotests
Fixes: 149070144
Fixes: 149001624
Change-Id: I422872e38f7adead81938c39b6084bbc7ed911ae
2020-03-31 13:24:46 -04:00
Beverly
82e7bc46cf Use DEFAULT_LIST contact intent
Test: manual
Fixes: 152733367
Change-Id: Ib2addc353298e593160500347d0a9bbfa85d1e0b
2020-03-31 11:09:50 -04:00
TreeHugger Robot
bc1687c94f Merge "Don't filter demoted conversation from app subtext" into rvc-dev am: 6f837d10bf am: f61da397fd am: 8b94c0e4a3 am: 1b29a5a2ba
Change-Id: Ia90ec22e76476867615f4482e27c55434e50bb10
2020-03-31 05:01:12 +00:00
Julia Reynolds
43848a4093 Merge "Remove bubble settings from channel pages" into rvc-dev am: 56d45997b3 am: 52b375b242 am: fdf32b618c am: 2db927cb79
Change-Id: I70729282db462779734fc7e29ae6a43d2e8eef70
2020-03-31 05:00:45 +00:00
Julia Reynolds
139f0ccf07 Merge "Conversations can't individually bypass dnd" into rvc-dev am: b3f2c0d528 am: 6d30804cec am: 639b6f89ea am: 41874f9f73
Change-Id: Ic0b0645779a3ca80c841b83c21f2f93cc2bdf5c5
2020-03-31 05:00:16 +00:00
TreeHugger Robot
6f837d10bf Merge "Don't filter demoted conversation from app subtext" into rvc-dev 2020-03-30 20:03:45 +00:00
Julia Reynolds
56d45997b3 Merge "Remove bubble settings from channel pages" into rvc-dev 2020-03-30 20:01:17 +00:00
Julia Reynolds
b3f2c0d528 Merge "Conversations can't individually bypass dnd" into rvc-dev 2020-03-30 19:57:48 +00:00
TreeHugger Robot
3b0e0f6b60 Merge "Fix the ringtone subtext is empty" into rvc-dev am: 83dfe52029 am: 68a77ceb47 am: 54058eedca am: e705d2ce91 am: 1fd4ebb841
Change-Id: I42cd43c19e765a85b72da1ec4c8470cc6dc70689
2020-03-30 19:05:25 +00:00
TreeHugger Robot
bb2a4aa264 Merge "Only request focus if change was self-triggered" into rvc-dev am: c22d90cb1b am: 5093ea158d am: 052610467e am: a2b560931a am: b569a4db40
Change-Id: I400f28d517347cd318b00bc5d7e3cc75c31d2515
2020-03-30 19:04:24 +00:00
Julia Reynolds
cb355e0fb8 Merge "Remove items from the 'last 24 hours' history on swipe" into rvc-dev am: dad135f4ed am: fe8ad05005 am: 5ba1c6e55d am: 380bb6d519 am: 1a4c34029b
Change-Id: I997bc55f7ba1a9d87071826cd887350f98352ef7
2020-03-30 19:04:06 +00:00
TreeHugger Robot
63420a1f66 Merge "Add tap targets to top 2 sections" into rvc-dev am: 9db658bfe0 am: 9d9504f951 am: 99ab33a0fa am: 4448e97222 am: 430a95ab19
Change-Id: Ide6f46939421ac2c620047055651919c71b2ecf0
2020-03-30 19:02:01 +00:00
Beverly
ef2c91c9a3 Don't filter demoted conversation from app subtext
If the notification channel is a demoted converation, we still want to
include it as a notification channel that can bypass DND under the
"apps" preference for DND.

Test: manual, make RunSettingsRoboTests7
Fixes: 152765113
Change-Id: Ief072b19280b0dc6e6c37d2d46d51f045d42bb4e
2020-03-30 14:01:38 -04:00
Julia Reynolds
138518141b Remove bubble settings from channel pages
It's only relevant for conversations

Test: manual
Fixes: 152764095
Change-Id: I31b342396ac3e66652ffc1457321594c55bbe0f3
2020-03-30 13:20:10 -04:00
Julia Reynolds
56d0f6b03a Conversations can't individually bypass dnd
Test: atest
Fixes: 152482973
Change-Id: I19432b79724beca46974c1c88d42a231f0703dc7
2020-03-30 13:18:38 -04:00