Commit Graph

1548 Commits

Author SHA1 Message Date
Julia Reynolds
40f5402a32 Fix a11y issues in notification history
- crash at large display sizes/landscape
- no content description for expand buttons
- no call to action on tappable notification rows

Test: manual
Fixes: 149307144
Change-Id: I63f59de66d96a55c48852e4fbf79c87c7826076f
2020-02-12 00:24:09 +00:00
Julia Reynolds
a4798d0d36 Merge "Improve notification history" 2020-02-11 21:54:54 +00:00
TreeHugger Robot
7b036f36e1 Merge "Add a settings for notification history" 2020-02-11 20:50:18 +00:00
Julia Reynolds
24aac215f1 Improve notification history
- An on/off switch
- An on/off UI
- improve headers/dividers/layout
- add counts
- shrink recyclerviews to content

Fixes: 148698132
Bug: 137396965
Test: manual
Change-Id: I0b103769cffa446e32f05a6c5a39a614e024a083
2020-02-11 12:08:20 -05:00
Julia Reynolds
28bc10faba Add a settings for notification history
Test: atest
Bug: 137396965
Change-Id: Id575bd8ef34f977200384f95c0244cbbb073e027
2020-02-10 12:04:10 -05:00
TreeHugger Robot
1ffd0fb163 Merge "Fix the overlap problem in the Schedule Rule page" 2020-02-10 11:34:26 +00:00
Sunny Shao
10400a5654 Fix the overlap problem in the Schedule Rule page
Fixes: 149071676
Test: manual test
Change-Id: I5a090ddf12ad5c4c2f248b487bd55af64dbc2ae4
2020-02-10 18:24:34 +08:00
TreeHugger Robot
978b19ec63 Merge "Implement remote media preference in Sound Setting" 2020-02-10 01:48:37 +00:00
Julia Reynolds
976a07baa6 Separate conversations from channels
Test: atest
Bug: 137397357
Change-Id: I15c360e8ef89f9fcb8db92678dd02a2c6fe083c5
2020-02-07 09:45:30 -05:00
timhypeng
b545599933 Implement remote media preference in Sound Setting
-Add test cases

Bug: 147395289
Test: make -j42 RunSettingsRoboTests
Change-Id: I7a3a2312e5f777cc22afb7a33df52afcc7707dc7
2020-02-07 14:21:16 +08:00
Julia Reynolds
1cba784014 Merge "Support new conversation DND options" 2020-02-05 12:21:25 +00:00
Yiwen Chen
3099df31d4 Merge "Implement new vibrate for calls in Settings." 2020-02-04 22:55:57 +00:00
Yiwen Chen
4b4c6c2c7b Implement new vibrate for calls in Settings.
Test: built and tested on device
Change-Id: Ia6ca7eb54472d44a9934d7f125a9f71e42c616a3
2020-02-03 13:32:58 -08:00
Julia Reynolds
7c5ac8fdac Support new conversation DND options
Test: atest
Bug: 137397357
Change-Id: I52420ffdc4b6618e66354a9c1bb99b0296bc4ea4
2020-02-03 11:09:20 -05:00
Sunny Shao
9013d8033f Add ContentObserver to RedactNotificationPreferenceController
- Monitor the LOCK_SCREEN_SHOW_NOTIFICATIONS to decide the enabled/disabled status.

Fixes: 134055112
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.notification
Change-Id: I7c7edbe13f47638df69f31d15d863c2088a5774f
2020-02-03 13:10:52 +08:00
TreeHugger Robot
1767201534 Merge "Use MasterSwitchPref vs subclass" 2020-01-29 19:20:48 +00:00
Julia Reynolds
82433b0239 Use MasterSwitchPref vs subclass
MasterSwitchPrefence changed in an incompatible way, but also
added functionality so we no longer need to subclass it.

Test: atest
Fixes: 146503141
Change-Id: I2441c8c265370c138ced13741aa5afd5c2088917
2020-01-29 17:11:45 +00:00
Julia Reynolds
86c0007e1d Add setting to hide silent notifs in status bar
Test: atest
Bug: 148444551
Change-Id: If7171ed36984b76552f3f795f0b4652dce5daad3
2020-01-29 11:25:18 -05:00
Julia Reynolds
b37d565ce8 Add screen for notification history
Bug: 137396965
Test: manual

(cherry picked from commit 84b593d592a74aeddfce453bc8700180192199ed)

Change-Id: Icac4000bd7323583f8a5f462ccb40826a4151765
2020-01-21 10:06:47 -05:00
Julia Reynolds
b5ea53a981 Visual updates for DND screens
(part 1), emphasizing People

Test: atest, manual
Bug: 137397357
Change-Id: I5672462feb480ea2fced70470ed7c2c8116fadfd
2020-01-11 17:03:22 +00:00
Jason Chiu
2d609759cd Add preference click metric logs for some special cases
Bug: 137559984
Test: visual, robotest
Change-Id: If8624b49abcd0000487065160ce4a7ba861f234c
2020-01-02 17:45:23 +08:00
Alex Mang
8f966787d9 Add flag to allow NAS to peform ranking
This will be used by implementations of NotificationAssistantService to
rerank notifications within the same importance bucket.

Bug: 146443378
Test: atest
Change-Id: I95e45081ae90f1e60de86b1b850ad18f33eb803b
2019-12-17 20:33:40 +00:00
Steve Elliott
bcfdbf4951 New toggle for peoplehub in Notification settings
Fixes: 146150828
Test: manual, atest
Change-Id: I7c21b81b1337ca0daf5b846f6ba9c7e6a239f09f
2019-12-13 20:47:18 +00:00
Yi-Ling Chuang
3f9f068ca9 Make some notification related slices public.
Only PreferenceControllers with isPublicSlice() set to true are exposed
to other apps. Others will be Settings only.

Bug: 141088937
Test: robotests
Change-Id: I6e7b9d45084ea9944143e606bfac56b2cae3e8a3
2019-12-13 11:43:03 +08:00
Julia Reynolds
aceccce75c Reorganize notification Settings classes
The notification package was getting too big.

Test: make -j64 RunSettingsRoboTests
Fixes: 145224451
Change-Id: I25ba82f42f7a137d8adcce72dcf8089d0e018bdc
2019-11-27 10:02:13 -05:00
Beverly
a30cb1158f Focus remains on the button after turning on/off
Test: manually test talkback
Fixes: 145181672
Change-Id: I16ceb81dd686e4a18354dfd464c7683ba94df79d
2019-11-26 15:37:42 +00:00
Tsung-Mao Fang
14c80f8151 Move UpdatableListPreferenceDialogFragment to SettingsLib
Change-Id: Ide669e1f35715fc45b5e7fe4b0852860812d392c
Fix: 79459635
Test: robo test
2019-11-19 18:16:47 +08:00
Julia Reynolds
9540929cfe Merge "Add NLS specific screens for notification listener approval" 2019-11-13 14:02:39 +00:00
TreeHugger Robot
eb3eb1fdb3 Merge "Update text on notification on/off toggles for clarity" 2019-11-11 19:24:42 +00:00
Julia Reynolds
f356ced8d7 Remove filtering from "recent sent" notifs preference
The 'has a launch intent' filter was inherited from 'recent apps'
preference but an app doesn't need a launch intent in order to
send notifications. Also, the next screen didn't apply the filter
so the data wouldn't always match up.

Also make the preferencecontroller more robust to failure.

Test: manual, trigger a notification from a non-launchable app
and makes sure it appears in the list
Fixes: 141380329
Fixes: 142956641

Change-Id: Icf3abead82c572bbffe6e06ecf51a8e02c11c982
2019-11-11 17:38:23 +00:00
Julia Reynolds
78b4505d6e Update text on notification on/off toggles for clarity
Test: manual
Fixes: 141011559
Change-Id: I06b8519bb5a80496d84889f8c5264bff098ebefd
2019-11-11 17:37:45 +00:00
Jay Aliomer
b499cc5643 Merge "Don't disable DND permission settings for apps that have disabled NLS" 2019-11-08 16:38:12 +00:00
Jay Aliomer
8754d40124 Don't disable DND permission settings for apps that have disabled NLS
ZenAccessController.getPackagesRequestingNotificationPolicyAccess
was including disabled packages.
We change this behavior to exclude any disabled package

Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.applications.specialaccess.zenaccess.ZenAccessControllerTest"
Change-Id: I354b8f0bdbf602d1f35233d5003ce09f01df3cb2
Fix: 141318822
2019-11-08 16:21:15 +00:00
Julia Reynolds
31dc1fd806 Add NLS specific screens for notification listener approval
Fixes: 141689199
Fixes: 143639217
Test: atest

Change-Id: I4ead087e0015ad33d6be4f9357de50a4298b3347
2019-11-08 14:13:24 +00:00
timhypeng
b2297dcdf9 Unable to adjust cast device's volume
- Update slider UI when receiving volume changed
- Do not create an infinite message loop

Bug: 143262277
Test: make -j42 RunSettingsRoboTests
Change-Id: If83a97cfce8b90c2eda7d55389775222bfc6bba0
2019-10-25 10:05:09 +08:00
TreeHugger Robot
764115ca4e Merge "Fix crash on clicking dismissed notifications" 2019-10-11 19:12:41 +00:00
Julia Reynolds
d80ddbd82b Fix crash on clicking dismissed notifications
Read the channelid from the notification vs RankingMap
for historical notifications

Test: manual
Fixes: 142531668
Change-Id: Ia7b48e6bcee3995286eea2e2f5f3b6bc4cff98e2
2019-10-11 17:27:36 +00:00
Julia Reynolds
3b10e450cb Rename class
Test: atest
Bug: 137397399
Change-Id: Idae73251bb67fbef2cf29f730f1420e98e38a8f3
2019-10-11 11:45:51 -04:00
Julia Reynolds
4c1bfdfe73 Merge "Handle multi-user in notif log" 2019-10-07 13:15:16 +00:00
Julia Reynolds
7e7271fff8 Handle multi-user in notif log
Test: manual
Fixes: 141575553
Change-Id: I03ff85358e8ae6ed5e6699358c4f9c785c416ecf
2019-10-03 11:50:12 -04:00
Raff Tsai
6db277ebb7 Remove summary provider
- use SummaryProvider to provide the summary of UserSettings
- use WifiDisplayPreferenceController to replace the summary loader
in WifiDisplaySettings
- use ConfigureNotificationPreferernceController to replace the
sumary load in ConfigureNotificationSettings

Fixes: 141653158
Test: robolectric
Change-Id: Id5f5ed645707caa0b25ecae5252174cbf017651c
2019-10-03 15:04:36 +08:00
Beverly
0ea2d6fb87 Update enabled state of ZenRulePreference
Test: manual
  1. Settings > Sound > Do Not Disturb > Schedules > Sleeping
  2. Toggle enable state of DND rule to ON
  3. Navigate back
  4. Observe: Sleeping rule is enabled visually (check box is checked)
Fixes: 140090071
Change-Id: I44078cdba9642eea93f9b6d2eb3eef486d3c38bc
2019-09-27 15:58:26 -04:00
Raff Tsai
966fa01423 Use SettingsLib Indexable
- Use SettingsLib Indexable
- Directly use resource id in getPreferenceScreenResId

Bug: 135053028
Test: roboletric
Change-Id: I05f493b55e8b6e2091301e9231ba5615215618e6
2019-09-25 18:24:56 +08:00
Raff Tsai
ac3e0d0988 Directly use BaseIndexableProvider
- Add function getXmlResourceId, Fragments don't need to write
xml resource id twice.
- Remove getPreferenceControllers from Indexable.java. Because it will
move to SettingsLib later for other apps which don't need this function

Bug: 135053028
Test: robolectric
Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003
2019-09-24 00:35:52 +08:00
Julia Reynolds
b294b82c84 Update notification log
- Change notification presentation to better match notification shade
- Stop constantly removing and readding all of the preferences
- Update individual preferences in a kind of hacky way (to be improved
later)
- Link notification entries to notification preferences screen
- Hide notification summaries

Bug: 137396965
Test: manual
Change-Id: Icdd54488b8bf659f6fe42af93e42cd21912fa4fe
2019-09-18 17:30:04 -04:00
Raff Tsai
1f30b1cd67 Merge similar BaseSearchIndexProvider code together
Bug: 135053028
Test: robolectric, check search_index.db contains the same items
Change-Id: If3c18a170b0e671690df1fdf26e59a421d2c48cd
2019-09-12 11:09:09 +08:00
Mady Mellor
0c47113a5b qt-r1-bubbles-dev @ build 5835883
Test: presubmit setup on source branch

Bug: 129158983
Bug: 136034310
Bug: 137876221
Change-Id: If2b813f24cf5998829fe417e32179c5e8283d308
2019-08-29 17:54:26 -07:00
Sunny Shao
b46650a10f Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ZenCustomRuleBlockedEffectsSettings page.

Fixes: 139264543
Test: manual test
Change-Id: Ib174eaa1c18b33e03fe5729d4a966b260e2bc15d
2019-08-12 17:10:17 +08:00
Sunny Shao
b4214464e5 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ZenModeBlockedEffectsSettings page.

Fixes: 139258311
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.notification
Change-Id: I0367390ffb27743e394db3108b3992fee1b943a7
2019-08-12 12:09:39 +08:00
Christine Franks
2b07a7e818 [DO NOT MERGE] Update title for null uri when setting changes
am: ea14373666

Change-Id: Icfb8e179f59529b30d3262c00d644257aa2f67f1
2019-08-04 00:55:36 -07:00