Settings: Allow dismissing suggestions

Fixes: https://github.com/crdroidandroid/issue_tracker/issues/782
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
This commit is contained in:
Pranav Vashi
2025-11-20 07:12:26 +05:30
committed by Joey
parent a69577e4a5
commit 2920b2e817
2 changed files with 1 additions and 3 deletions

View File

@@ -84,7 +84,6 @@
android:layout_width="48dp"
android:layout_height="48dp"
android:padding="8dp"
android:visibility="gone"
android:layout_gravity="center"
android:contentDescription="@string/suggestion_button_close"
android:src="@drawable/ic_suggestion_close_button"

View File

@@ -43,7 +43,6 @@ import kotlinx.coroutines.withContext
private const val SUGGESTIONS = "suggestions"
private const val TAG = "ContextualSuggestFrag"
private const val FLAG_IS_DISMISSIBLE = 1 shl 2
/**
* Fragment to control display and interaction logic for [Suggestion]s
@@ -184,7 +183,7 @@ class SuggestionFragment : InstrumentedFragment(),
summary?.visibility = View.VISIBLE
summary?.text = suggestionSummary
}
if (suggestion.flags and FLAG_IS_DISMISSIBLE != 0) {
if (suggestions.size > 0) {
dismiss?.let { dismissView ->
dismissView.visibility = View.VISIBLE
dismissView.setOnClickListener {