Android/lineage-sdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sdk: Don't clear calling identify when calling IOverlayManager.setEnabled()

Browse Source 
* Since changing overlays is now guarded with enforceCallingPermission()
  instead of enforceCallingOrSelfPermission() we can no longer call
  setEnabled() after resetting our identify.

Change-Id: I25df30d0ba83f15ca1124d6fc6f79d3465d052f2
This commit is contained in:
LuK1337
2018-10-05 02:54:14 +02:00
committed by Sam Mortimer
parent 9f0adb656e
commit 7702fb29a8
1 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lineage/lib/main/java/org/lineageos/platform/internal/StyleInterfaceService.java
View File

@@ -318,15 +318,7 @@ public class StyleInterfaceService extends LineageSystemService {
@Override
public boolean setAccent(String pkgName) {
enforceChangeStylePermission();
/*
* We need to clear the caller's identity in order to
* allow this method call to modify settings
* not allowed by the caller's permissions.
*/
long token = clearCallingIdentity();
boolean success = setAccentInternal(pkgName);
restoreCallingIdentity(token);
return success;
return setAccentInternal(pkgName);
}
@Override
@@ -384,15 +376,7 @@ public class StyleInterfaceService extends LineageSystemService {
@Override
public boolean setDarkOverlay(String overlayName) {
enforceChangeStylePermission();
/*
* We need to clear the caller's identity in order to
* allow this method call to modify settings
* not allowed by the caller's permissions.
*/
long token = clearCallingIdentity();
boolean success = setDarkOverlayInternal(overlayName);
restoreCallingIdentity(token);
return success;
return setDarkOverlayInternal(overlayName);
}
@Override