In the old navigation model, we set focus to a node, and checked to see
if that node was still valid (could have changed since we built the
navigation cache). Then we sent a message back to the UI thread to
tell it to draw the ring differently. In the new model, we are essentially
moving a mouse, so we do not concern ourselves with whether the node is
valid. Removed all the code for passing the message to the UI thread
and calling into native. Needs a change to external/webkit to work
properly.
Also, set focusControllerActive state based on presence of
focus and cursor that wants key events.
Disable focusControllerActive when moved cursor wants key
events.
Remove unused recompute-focus code.
Previously, many methods, variables, etc referred to the focus.
Now, they have been changed to refer to the cursor when
appropriate. Some references were changed to the focusCandidate,
since they may apply to either the focus or the cursor, which
is a candidate for focus. Also removed unneeded method
unblockFocus. WebView will not work without a corresponding
change in external/webkit.
This will enable the IME to enable/disable prediction features
for browser fields where the exact type is not very well defined.
Part of the fix for #1743620
WebView was (incorrectly) handling the ENTER key as if it could start
a long press like CENTER key does. Separate the two behaviors. Now,
the ENTER key does not do anything unless it is part of a textfield or
the DOM otherwise handles it.
As a result, I was able to remove some orphaned code. Before this
change, pressing ENTER would play a click noise, and animate the
focus ring as if its link were being followed, but do nothing. In
WebViewCore, do not pass the ENTER key back to the Activity.
Remove NO_FOCUS_CHANGE_BLOCK and BLOCK_FOCUS_CHANGE_UNTIL_KEY_UP, which were
part of SET_FINAL_FOCUS (which is no longer used) from WebViewCore. In WebView,
do not pass BLOCK_FOCUS_CHANGE_UNTIL_KEY_UP with SET_MOVE_MOUSE, since the
receiver does not care about it.
Rename the TextDialog to be a more accurate description of what it is.
Also rename some methods and variables which pertain to it, and preload
the newly created class.
Older code treated the trackball as a four way dpad with
equivalents to moving up, down, left and right by generating
arrow key events. This change makes the trackball solely
generate mousemove events.
The old arrow keys in turn were mapped to be as close as
possible to tab-key events that moved the focus. The new
model leaves focus-changes to the DOM.
Clicking the dpad is distinguished from pressing the enter
key to be more compatible with desktop-authored web pages.
Merge commit 'ff686ce11e952a9001b1384d8e7d82127b0529a2'
* commit 'ff686ce11e952a9001b1384d8e7d82127b0529a2':
Change when gestures listeners are fired.
Manual merge from cupcake_dcm. internal CL#148693. Two donottranslate.xml-s are already submitted.
Use Integer.valueOf() instead of new Integer()
Eliminate unused fields in InvokeListBox
Make FocusNode, HitTestRequest, and ExtendedZoomControls
static inner classes.
Fix a bug where the filter text could not be deleted,
and another where filtering changes the checked item,
so that filtering <select> lists can be reenabled.
Merge commit 'e292086e6b5124a8e6b9435609d41c9ab2ef5e22'
* commit 'e292086e6b5124a8e6b9435609d41c9ab2ef5e22':
Fix 1799207. With the new local dns, we should allow the host without any PERIOD. Otherwise http://go won't work properly.
This will ensure that we do not parse the data in chunks when passing it to the
LoadListener. Decoding in chunks can lead to incomplete sequences which will
lead to a failed decode.
Check for a cancelled LoadListener in StreamLoader and stop the load. This is
just a shortcut for downloaded or failed resources.
Cleanup some of the LoadListener code around resetting a few member variables.
Reset them in the status callback since that indicates a new response from the
server (or StreamLoader).
Previously we had converted application/xhtml+xml to text/html because of bad
server data. Now we need to treat xhtml as xhtml to get svg to be interpreted
correctly.
If a webpage suppresses keys from getting echoed back to the
browser app, then also disable select/copy when a key follows
a shift key press.
Also add in missing debug string to permit debug builds.
This change is dependent on another change to external/webkit. Tell the WebViewCore to change its FocusController's "active" status depending upon whether the WebView has focus. This fixes a bug where we were showing the blinking cursor when the WebView was not in focus.
Frame.cpp:
Removed a line that should not be there anyway. Somehow when merging in Apple's ENABLE(TEXT_CARET) changes we left in a line that disables the blinking Cursor.
Platform.h:
Let WebKit draw the cursor.
RenderThemeAndroid.cpp:
Make the active selection color (the color of a selection in an active <textfield> or <textarea>) visible, and match the selection color shown in other places in Android.
WebViewCore.cpp:
Make the focused node's document's focus controller active. This allows webkit to draw the cursor.
TextDialog.java:
Set WillNotDraw to true, and remove our background, so that the TextDialog is completely invisible. Note that I have not changed its visibility to View.VISIBLE, which would have other undesired effects (would not accept touch events, for example). Since we are not drawing, remove onPreDraw, which is no longer necessary. In onSelectionChanged, pass a message to webkit telling it that the selection has changed. It is important that the two threads always agree (albeit webkit may be behind) because the user will now only see the selection drawn by webkit. Remove some old flawed code whose purpose was to keep the selection up to date and do not send key events for arrow keys (which would mess up the selection that was correct thanks to onSelectionChanged).
BUG=1781070,1712752,916193,1411370,1160999,1775425,1354814
Automated import of CL 146153
