Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge change 2267

Browse Source 
* changes:
  Fix some Java mistakes found by FindBugs.
This commit is contained in:
Android (Google) Code Review
2009-05-26 06:20:15 -07:00
parent ee8332286c 213a31c7d5
commit b7eef04564
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/java/android/webkit/WebView.java
View File

@@ -210,7 +210,7 @@ public class WebView extends AbsoluteLayout
static final boolean DEBUG = false;
static final boolean LOGV_ENABLED = DEBUG;
private class ExtendedZoomControls extends FrameLayout {
private static class ExtendedZoomControls extends FrameLayout {
public ExtendedZoomControls(Context context, AttributeSet attrs) {
super(context, attrs);
LayoutInflater inflater = (LayoutInflater)
@@ -564,7 +564,7 @@ public class WebView extends AbsoluteLayout
public void onNewPicture(WebView view, Picture picture);
}
public class HitTestResult {
public static class HitTestResult {
/**
* Default HitTestResult, where the target is unknown
*/
@@ -2859,7 +2859,7 @@ public class WebView extends AbsoluteLayout
/**
* Class representing the node which is focused.
*/
private class FocusNode {
private static class FocusNode {
public FocusNode() {
mBounds = new Rect();
}
@@ -4568,8 +4568,8 @@ public class WebView extends AbsoluteLayout
HashMap arg = new HashMap();
arg.put("focusData", new WebViewCore.FocusData(mFocusData));
arg.put("replace", replace);
arg.put("start", new Integer(newStart));
arg.put("end", new Integer(newEnd));
arg.put("start", Integer.valueOf(newStart));
arg.put("end", Integer.valueOf(newEnd));
mTextGeneration++;
mWebViewCore.sendMessage(EventHub.REPLACE_TEXT, oldStart, oldEnd, arg);
}
@@ -4888,10 +4888,6 @@ public class WebView extends AbsoluteLayout
// Class used to use a dropdown for a <select> element
private class InvokeListBox implements Runnable {
// Strings for the labels in the listbox.
private String[] mArray;
// Array representing whether each item is enabled.
private boolean[] mEnableArray;
// Whether the listbox allows multiple selection.
private boolean mMultiple;
// Passed in to a list with multiple selection to tell