* changes:
Remove Dependency.get usages from LightBarController
Remove Dependency.get usages from NotificationLogger
Remove Dependency.get usages from OverviewProxyService
Remove Dependency.get usages from BubbleController
Remove Dependency.get usages from BatteryControllerImpl
Remove Dependency.get usages from BluetoothControllerImpl
Remove Dependency.get usages from DeviceProvisionedController
Remove Dependency.get usages from HotspotControllerImpl
Remove Dependency.get usages from RemoteInputQuickSettingsDisabler
Remove Dependency.get usages from SecurityControllerImpl
Remove Dependency.get usages from UserSwitcherController
Remove Dependency.get usages from SmartReplyController
Reduce usages of Dependency.get in TunablePadding
Remove Dependency.get usages from TunerServiceImpl
Remove Dependency.get usages from GarbageMonitor
MediaRecorder.AudioEncoder has unsupported VORBIS audio encoder constant declared. Edited javadoc
comment for the same as optional support.
Bug: 120211083
Test: make offline-sdk-docs
- edited comment visible in MediaRecorder.AudioEncoder.html#VORBIS
Change-Id: I3294d9a768a8f439579f238ee2f1db93f20bc178
When updating a system app, a recent code change resulted in trying to
read the parsed package from a @Nullable field without first checking
for the null case. We have access to the package from the original scan
request and so this change just fetches it from there.
Change-Id: Ieeb4d7f94db23adea64bca7fb982f473cc0a40fe
Fixes: 121411453
Fixes: 121455797
Test: Wait for and observe successful GMS Core update
This is part of our on-going effort to review caller verifications in
InputMethodManagerService (IMMS).
In Android P, IMMS started relying on IBinder#shellCommand() to
implement 'adb shell ime' command [1]. When handling incoming
request, following caller verifications are used depending on the
command type.
* IMMS#calledFromValidUserLocked()
* This can be bypassed with INTERACT_ACROSS_USERS_FULL permission
* WRITE_SECURE_SETTINGS permission
From the viewpoint of caller verification, this is basically the same
as how commands like 'adb shell ime' were handled before
IBinder#shellCommand().
What this CL aims to do is adding one more foolproof to this protocol.
Given that all commands exposed via IInputMethodManager#shellCommand()
are intended to be used only from "shell" environment, it is most
likely safe to reject any request from non-shell users. With this
additional restriction, even if some caller verification was
accidentally missed in those shell commands such a security hole would
not be exposed to random applications.
[1]: I9a2dbbf1d4494addbe22c82e2c416eedc4d585f2
926488d70d
Bug: 34886274
Fix: 121989657
Test: Following commands still work, before/after "adb shell root"
* adb shell ime
* adb shell ime list
* adb shell ime set com.android.inputmethod.latin/.LatinIME
* adb shell cmd input_method
* adb shell cmd input_method refresh_debug_properties
* adb shell dumpsys input_method
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: If87189563ccaacd4f9c666bab4f9ad08a9343084
