1. Move responsibility for the bouncer container to the
NotificationShadeWindowViewController
2. Start very basic keyguard documentation (much more to come)
Bug: 195430376
Test: atest KeyguardBouncerTest StatusBarTest StatusBarKeyguardViewManagerTest
NotificationPanelViewControllerTest
Change-Id: Iba45a9252fd37c00b2023407eb44bd91c44a87ad
This change resets the brightness short term model when RBC is turned
off or the strength is changed. We add a singular interaction when RBC is turned on, and add
interactions in RBC as normal.
Since users turning RBC in a bright environment could want any
brightness between the given one and MAX, but turning RBC off will often result in
a MAX interaction being logged, if the slider is already at MAX (given
RBC) which is not necessarily what we want.
In order to prevent unwanted changes to the brightness curve, we ignore
interactions that turn RBC off. Turning RBC on seems like a valid
indicator that the user wants the brightness darker, and at a specific
brightness, however turning RBC off is less of an indicator. Changing
the strength of RBC is also a good time to reset the short term model,
however after resetting, we still add an interaction after this.
Bug: 199187829
Test: manual
Change-Id: I6512d9642f2da634aa60af6b5573c792c0a116d5
Each callback will map to a unique id. The id is stored in an enum, and we use the ordering of the enum to determine the order the callbacks should run in.
Test: locally on device
Test: atest WmTests:ActivityStartInterceptorTest
Test: atest WmTests:ActivityTaskManagerServiceTests
Bug: 191994709
Bug: 191996331
Bug: 200324021
Change-Id: I34a1e88852b51444fff751b25e138a44f45e1773
Required support if the platform supports 14 or 16
channels internally, otherwise CTS test fails.
Test: atest AudioTrackTest#testImmersiveAudio
Bug: 202162797
Change-Id: I052f2e38a27a63e5304b7fb6bffaaabe37efa8eb
The guest user cannot have extra apps, hence the DPC app is not
installed. We could try to bypass that restriction, but it could
cause other issues down the road; besides, on phones the guest
user is not managed neither and DPM doesn't provide an API to
created managed guests.
Test: manual verification using TestDpc
Fixes: 202327386
Change-Id: I02f963bc84325dd73a18abb7103fc34d4960005d
- Sort paused controls by last active time, regardless of whether they
are local or remote sessions
- Ensure resume controls have isPlaying=false
- Add test for ordering
Fixes: 198099352
Fixes: 192259825
Test: manual
Test: atest com.android.systemui.media
Change-Id: Ie5717cbf2dae3701e0ebff6b693a3bb5640accf5
* changes:
[Status Bar Refactor] Remove some indirection about minFraction between NotificationPanelViewController and PanelBar.
[Status Bar Refactor] Remove PanelBar#onPanelFullyOpened and instead handle that logic in the listener callback.
[Status Bar Refactor] Add a PanelStateChangeListener interface and use it in PanelBar#go.
Previous CL[1] uses isImeAttachedToApp to check if the IME should set
relative layer with the app window, but it's wrong because the method
also check if the IME parent has reparented to the app.
(This brakes RoleManagerTest failure as Bug 202246318, since the test
activity has created a child window but we accidentally set the wrong
relative layer of IME even the activity didn't request showing IME,
so the child window will end up not be on the top of screen)
As originally CL[1] is only need to check if the window is eligible to
attach IME then we don't need to set relative layer for IME,
use shouldImeAttachedToApp to fix the original issue and unblock
RoleManagerTest failure.
Also move allowAttachToApp related with magnicationSpec check from
computeImeParent into shouldImeAttachedToApp to make the attach logic
more consistent.
[1]: I2f466a2305e56e4fd2a0c509d7c8027104cb51b6
Fix: 202227155
Fix: 202246318
Bug: 201504527
Test: atest RoleManagerTest ZOrderingTests
Change-Id: Ib6233b8f9270829a7d7c6fbb3bd98fdefaf4c206
Else, the clock may animate in at the wrong font weight.
Test: atest AnimatableClockControllerTest
Test: manually swipe away all notifications on LS,
see the large clock animate in at full font weight
Fixes: 201615075
Change-Id: I139e5a5c88551f23f99decff3e7ffc8bdaa5bba4
The main issue was that QS and notifications container had padding of the size of taskbar. It was because taskbar is included in window insets and container doesn't check where insets come from. If insets are coming from taskbar only they should be ignored because taskbar should disappear when shade is expanded. But if they're coming from taskabar and navigation buttons are visible, they shouldn't be ignored as then taskbar always stays on the screen - that's assessed with checking if gesture navigation is available (if not, it means button navigation). Also because buttons are on the right side only and taskbar might or might not be visible, QS is just taking full height and notifications (that are on the right) have bigger spacing from the bottom.
Because this change involved using a few extra objects not available in NotificationsQuickSettingsContainer and I wanted to avoid doing everything in NotificationPanelViewController (it's big enough) and just passing results to NotificationsQuickSettingsContainer, I introduced controller for it: NotificationsQSContainerController. Now this controller has all the logic for determining bottom spacing. There can be a few more things that can be moved from NPVC to NotificationsQSContainerController but it's a start. Also now QS views and its children views instead of talking directly to container, they talk to controller via QSContainerController interface, which is a nice side-effect improvement.
Fixes: 194989891
Fixes: 200291264
Test: Home screen (so taskbar is hidden) -> go to split shade -> use anything that is close to the bottom of QS side (music widget, rearranging QS tiles, etc)
I'll add unit tests if the change overall looks good
Change-Id: I91ab8ec26dd2ef60562ffb9fdbc0e5739745ca0b
NotificationPanelViewController and PanelBar.
The current code flow is NPVC#setPanelScrimMinFraction =>
PanelBar#onPanelMinFractionChanged =>
NPVC#setMinFraction.
The minFraction doesn't need to flow through PanelBar if it's going to
go right back to NPVC.
Test: Test steps from ag/15759151
Bug: 200063118
Change-Id: If31a0d78cf4ac4a4d4bc6fcc7423a8006ab309fa
