Commit Graph

9069 Commits

Author SHA1 Message Date
Nikita Dubrovsky
2f9684b65b Merge "Make drop consistent with paste for multiple text items in a ClipData" into sc-dev am: 4b2ab9bba3
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14455023

Change-Id: I729c08eb540e4618388e48897507226e84a96c6b
2021-05-07 16:58:09 +00:00
Nikita Dubrovsky
4b2ab9bba3 Merge "Make drop consistent with paste for multiple text items in a ClipData" into sc-dev 2021-05-07 16:57:02 +00:00
Pierre Barbier de Reuille
66b91b4a27 Merge "Save/restore view states when reapplying RemoteViews for color changes" into sc-dev am: 6d82bd39e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14294133

Change-Id: Ia13bc70ef250cf3356cae421eb97b3b100909efa
2021-05-06 19:00:18 +00:00
Pierre Barbier de Reuille
6d82bd39e7 Merge "Save/restore view states when reapplying RemoteViews for color changes" into sc-dev 2021-05-06 18:54:54 +00:00
Nikita Dubrovsky
e480958234 Make drop consistent with paste for multiple text items in a ClipData
A ClipData can contain multiple items, for example:
```
ClipData clip = ClipData.newPlainText("label", "ONE");
clip.addItem(new ClipData.Item("TWO"));
clip.addItem(new ClipData.Item("THREE"));
```

When a clip like this is pasted, the TextView impl inserts a newline
between each item. When the same clip is inserted via drag-and-drop,
no newlines are inserted.

This change makes the behavior of drop and paste consistent by updating
drop to match the paste behavior (since pasting has been around longer
and is more common).

Bug: 187428338
Test: atest CtsWidgetTestCases:TextViewReceiveContentTest
Change-Id: I08f30e619b858a4586ab9b4ed287be28b218231e
2021-05-06 11:50:52 -07:00
Yinglei Wang
bb5482d835 Merge "Use state description of "in progress" for indeterminte ProgressBar" 2021-05-06 17:43:17 +00:00
yingleiw
bc45cab1f2 Use state description of "in progress" for indeterminte ProgressBar
When a ProgressBar is set to indeterminate, we assign a default
state description of "in progress" to AccessibilityNodeInfo. We
only assign default state description to AccessibilityNodeInfo,
but not to View. If the developer
sets a custom state description through either View API or
AccessibilityNodeInfo API, the custom state description will
be used for both indeterminate and determinate progressbar instead
of default ones.

We put the "in progress" in state description instead of content
description to prevent accessibility services like talkback from
automatically assigning a state description when the state description
is null or empty.

Fix: b/182582617

Test: tested manually with a material linear indeterminate progressbar
with talkback. It says "In progress, progress bar".
Unit tests added.

Change-Id: I24477622bf8992f80a19b8df3a6032bac7f9d5bd
2021-05-05 21:07:48 -07:00
George Mount
fd308c1823 Merge "Allow fling during stretch in ListView" into sc-dev am: 9d7658ac57
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14392463

Change-Id: I6b4ec30213c0f36ed2a7dce944b9e5fde96de4e8
2021-05-05 15:56:24 +00:00
George Mount
9d7658ac57 Merge "Allow fling during stretch in ListView" into sc-dev 2021-05-05 15:50:08 +00:00
Nader Jawad
af62127679 Merge "Update hole punch logic in HWUI" into sc-dev am: 603d612707
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14244206

Change-Id: I25572446223bf7266c05d6442e0415065f774a83
2021-05-05 03:05:11 +00:00
Nader Jawad
603d612707 Merge "Update hole punch logic in HWUI" into sc-dev 2021-05-05 02:59:18 +00:00
Stevie Kideckel
691ff96db6 Save/restore view states when reapplying RemoteViews for color changes
This ensures that adapters have their caches filles and other benefits
such as lists maintaining their scroll positions

Bug: 183503469
Test: validated with local app that service is not called on drag for
colors changing and that flicker is removed

Change-Id: I043d1d7a547b012f7a12eb555b35854a9bb7109b
2021-05-04 23:18:45 +01:00
George Mount
d317ef65a8 Allow fling during stretch in ListView
Bug: 186430321

ListView should accept a fling while stretching.

Test: New test
Test: manual testing
Change-Id: I67221e06818d9953882e16d1c72f2d9e6b191ebb
2021-05-04 15:15:10 +00:00
Nader Jawad
b00eba7319 Merge changes from topic "fling_after_pull" into sc-dev am: d8f57c7cf3
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14414739

Change-Id: I2805d99d8c6cd011e906ad676fa70795f4366c1f
2021-05-04 04:47:05 +00:00
George Mount
930d7b4eb7 Remove edge effect type from the API. am: b1aee44bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14390423

Change-Id: If4f4c564adbcd2cc6d455f8224ad930cb6f07d4d
2021-05-04 04:46:58 +00:00
Nader Jawad
197743ff9c Update hole punch logic in HWUI
--Updated HWUI holepunch logic for SurfaceView to
also apply the stretch to the hole punch
--Updated RenderNode callbacks to also include
an offset from the ancestor RenderNode that also
has a stretch configured on it
--Added new test activity to verify hole punch
logic

Bug: 179047472
Test: manual
Change-Id: Ibbaf8248a31839ba9dc352ecb9fef54e1276918e
2021-05-03 18:08:47 -07:00
George Mount
b1aee44bea Remove edge effect type from the API.
Fixes: 186758538

Relnote: "Removes edge effect type from the API -- EdgeEffect now
supports only stretch edge effect for all applications."

Test: existing tests, modified to work with stretch
Change-Id: Iec7a9d4a0316ff3ba7297c4565bb881a1adcf949
2021-05-03 22:45:10 +00:00
George Mount
07406f3642 Allow EdgeEffect to fling during pull
Bug: 186430321

EdgeEffect was restarting the fling from the start if onAbsorb()
was called after onPullDistance(). This CL does not reset
the distance in onAbsorb().

Test: new test
Change-Id: I0657059c275f42cfe229a3aaa8bf37c87e0394f1
2021-05-03 22:45:10 +00:00
TreeHugger Robot
c406acdd79 Merge "Dismiss magnifier correctly in concurrent editing scenario" into sc-dev am: 7b0989f35d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14344156

Change-Id: I2391b5f3cec2b19ecfe5745107732a57133f3979
2021-05-03 16:01:42 +00:00
TreeHugger Robot
7b0989f35d Merge "Dismiss magnifier correctly in concurrent editing scenario" into sc-dev 2021-05-03 15:44:37 +00:00
George Mount
9cfa6895e7 Merge "Fling while overscrolled: ScrollView/HorizontalScrollView" into sc-dev am: ee5ed9dfaa
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14356490

Change-Id: Iab93e6773a9d9685a0568e2f6841ed4f2aac71ce
2021-04-29 23:17:14 +00:00
George Mount
02843213c0 Fling while overscrolled: ScrollView/HorizontalScrollView
Bug: 186430321

ScrollView and HorizontalScrollView was not allowing a fling
effect while overscrolling. This adds the ability to fling
while overscrolling.

Test: new test
Test: manual ApiDemos
Change-Id: Iebd402ff0f5b6f16518ecc5403e085cb58de5976
2021-04-29 20:37:56 +00:00
George Mount
509448d1d6 Merge "Allow intercept touch event while animating edge glow." into sc-dev am: a4b222f48d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14342255

Change-Id: Ibb7ee93abdf93f161dc72a47b4a6163799990912
2021-04-29 15:28:15 +00:00
George Mount
a4b222f48d Merge "Allow intercept touch event while animating edge glow." into sc-dev 2021-04-29 15:21:51 +00:00
Mihai Popa
d32571e9b5 Dismiss magnifier correctly in concurrent editing scenario
Fixes: 186505600
Test: manual testing
Change-Id: I864f03e976be92c232f51a576043cb49731cda26
2021-04-29 11:04:59 +00:00
TreeHugger Robot
49aa2dfb05 Merge "Fix stale EditorInfo upon EditText#setText()" into sc-dev am: 7c9d3192de
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14334694

Change-Id: I3d18a1b6e6417dd0ac71dc7595f98181fadf6307
2021-04-29 02:45:15 +00:00
George Mount
109e474959 Allow intercept touch event while animating edge glow.
Bug: 185906621

During overscroll animation, there is no need to call
disallowInterceptTouchEvents(). This removed the
call so that parents can intercept touch events.

Test: Ia9ac6d81a5b60222f489ea87f31ecba0c1d48cea
Test: manual testing

Change-Id: Ie5d9428d95b86d7a976c2f3c519547151a45cec5
2021-04-28 21:47:12 +00:00
Yohei Yukawa
a35ebcf88e Fix stale EditorInfo upon EditText#setText()
This is a follow up to our previous CL [1], which added initial
surrounding text support into EditorInfo and let TextView support it.

What we overlooked was that calling TextView#setText() would trigger

  TextView#onCreateInputConnection()

before TextView#mText is updated to the new value.  As a result,
EditorInfo is initialized with a stale surrounding text information.

With this CL, EditorInfo will correctly be initialized with the new
text specified to TextView#setText().

One complicated thing in this CL is InputMethodManager also has some
issues about how to drop spurious

  InputMethodService#onUpdateSelection()

while InputConnection is being replaced with a new instance.  I ended
up having to introduce a hacky boolean

  Editor#mHasPendingRestartInputForSetText

to work around this in the TextView/EditText. This workaround is
expected to be removed/revisited as part of Bug 186582769.

 [1]: Ie04f2349b1157408aa8ed9044aea12ce99132cb4
      c486acc4d2

Fix: 161330778
Test: atest CtsInputMethodTestCases:EditTextImeSupportTest
Change-Id: Iee3b754eea319861b2eb955d6cc95ba13006b55e
2021-04-27 19:20:16 -07:00
TreeHugger Robot
87d9162e30 Merge "Reduce animation completion epsilon to avoid early end." into sc-dev am: 1700fa9e5c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14282082

Change-Id: Ia2e70288a9a3194679d8a2b75216a9ce300e8e0f
2021-04-28 00:20:32 +00:00
TreeHugger Robot
1700fa9e5c Merge "Reduce animation completion epsilon to avoid early end." into sc-dev 2021-04-28 00:08:30 +00:00
Stevie Kideckel
d663b5b081 Merge "Fix some potential nullability issues in RemoteViews" into sc-dev am: cda49ca089
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14186226

Change-Id: If0951e234485bb5ef8918a78278bec3db2703a01
2021-04-27 20:20:40 +00:00
Stevie Kideckel
cda49ca089 Merge "Fix some potential nullability issues in RemoteViews" into sc-dev 2021-04-27 20:10:27 +00:00
Stevie Kideckel
957a33fe0a Fix some potential nullability issues in RemoteViews
Test: Ran locally on device, all sample widgets still worked
Test: atest RemoteViewsTest
Bug: 185316709

Change-Id: I60c235ea196dd106325e79962e545c582a975168
2021-04-27 13:44:26 +00:00
Qi Wang
630fce52f4 Merge "Validate spell checker suggestions before applying." into sc-dev am: 0ebb4d88a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14305127

Change-Id: If179741ff15268b771de5404b3cff5702151b0ac
2021-04-27 06:49:29 +00:00
Qi Wang
0ebb4d88a1 Merge "Validate spell checker suggestions before applying." into sc-dev 2021-04-27 06:26:43 +00:00
TreeHugger Robot
5fc5597b29 Merge "Fix Magnifier position updates" into sc-dev am: 400dc92ebe
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14312828

Change-Id: I2a190086d75790d8f00a332c9b709c4014d4445d
2021-04-26 22:46:25 +00:00
TreeHugger Robot
400dc92ebe Merge "Fix Magnifier position updates" into sc-dev 2021-04-26 22:27:40 +00:00
Vishnu Nair
f752c800d3 Fix Magnifier position updates
When the magnifier content moves relative to the parent surface,
it will call setPosition on the content surface control. This conflicts
with position updates called by the BlastBufferQueue adapter
causing a flicker on screen. Fix this by providing a wrapper surface
to BlastBufferQueue adapater to send buffer updates.

Fixes: 186072574
Test: Select text and see magnifier surface does not flicker or move
around

Change-Id: Idfcc06a5d90f400f69e5cbe91008a0cb59fd4646
2021-04-26 10:27:50 -07:00
Qi Wang
cfa318ee4d Validate spell checker suggestions before applying.
Fix: 185786752
Test: atest CtsInputMethodTestCases:SpellCheckerTest
Change-Id: Icf447fc3ab174bc17af0e823b830f5abef6071df
2021-04-26 10:06:37 +08:00
George Mount
e4f9d4f632 Reduce animation completion epsilon to avoid early end.
Fixes: 184892316

Changed the animation termination epsilons to make sure
that the animation doesn't end early and cause a jerky
end.

Test: visual inspection
Change-Id: I56e4ccb50cee95e713e92ffb659eff4dd026dd12
2021-04-22 16:20:25 +00:00
Chun-Yi Lee
f704e7cc7b Merge "Move CtsAutoFillServiceTestCases to group presubmit-large" into sc-dev am: 6a213319a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14264393

Change-Id: Ib29130fd8ca1f1cfbc97f272f29d04cac0e16c2a
2021-04-22 11:36:20 +00:00
Chun-Yi Lee
6a213319a8 Merge "Move CtsAutoFillServiceTestCases to group presubmit-large" into sc-dev 2021-04-22 11:11:55 +00:00
Stevie Kideckel
964eed7e6b Merge "Expose GridView/Layout APIs via @RemotableViewMethod" into sc-dev am: 32b16fa4fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14251395

Change-Id: I4a8c57ba68a5dbf99fd4970d7052a25feb9449a0
2021-04-22 09:51:26 +00:00
Stevie Kideckel
32b16fa4fc Merge "Expose GridView/Layout APIs via @RemotableViewMethod" into sc-dev 2021-04-22 09:33:43 +00:00
easoncylee
e9f67379be Move CtsAutoFillServiceTestCases to group presubmit-large
The test config takes longer than 15mins to run. Move it to a dedicated
group for running slow presubmit Test Mapping test.

Some more context is in the referenced bug, e.g, b/174495337
The group will work exactly the same as presubmit for now.

Bug: 174654670
Bug: 174495337
Test: none
Change-Id: I946061e2c5a75b12ca370d172db32a8f7e8e8f68
2021-04-21 13:24:07 +00:00
Stevie Kideckel
9f8a7db5f9 Expose GridView/Layout APIs via @RemotableViewMethod
Bug: 185972660
Test: Built and ran locally, annotation change only

Change-Id: I85fc00ae62b124653e20fd53f9179493463933e0
2021-04-21 09:20:25 +00:00
Joanne Chung
e64b5a54dd Merge "API feedback: Translation View API refinement." into sc-dev am: be20ca46f6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14127344

Change-Id: I42e0fc736b980ca8297a848c3ce90dfcea96351d
2021-04-21 00:30:54 +00:00
Joanne Chung
be20ca46f6 Merge "API feedback: Translation View API refinement." into sc-dev 2021-04-21 00:29:24 +00:00
TreeHugger Robot
03a40cfe4e Merge "Revert^2 "Introduce SpellCheckerSessionParams."" into sc-dev am: 32e08f8b0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14250992

Change-Id: I0e6f373e197324bbe9535ef5a99d5ae58b405a1e
2021-04-20 17:01:19 +00:00
TreeHugger Robot
32e08f8b0d Merge "Revert^2 "Introduce SpellCheckerSessionParams."" into sc-dev 2021-04-20 16:45:50 +00:00