Commit Graph

797 Commits

Author SHA1 Message Date
Gilles Debunne
2050de5b9a Text selection is broken.
Bug 3439569

Lazy initialization code was not back-ported.

Change-Id: I9815f649891e2ddc602383488749144686ab1dd3
2011-02-09 14:17:22 -08:00
Gilles Debunne
cdfe899991 Fix for multiple merge problem.
Change-Id: I5d9c497f44aa9cdc34c195c41e02c3d7353c3fb4
2011-02-04 16:50:01 -08:00
Gilles Debunne
c0728cc042 Double tap triggers text selection in a TextView. DO NOT MERGE
This is a convenient way to switch to selection mode without the
context menu. Context menu is still available and offerts Select Input method option.

Browser overloads touch events and this feature is not available in Browser which
limits the conflict with double tap zoom in browser.

Change-Id: I286504cf03733d5c2fb9bc01765f713d14bbd2f4
2011-02-04 15:50:10 -08:00
Gilles Debunne
893ac28f75 Merge "Blinking runnable is created only if text is editable. DO NOT MERGE." into gingerbread 2011-02-04 15:46:15 -08:00
Gilles Debunne
8a6ba494a2 Merge "All runnable are stopped on detach. DO NOT MERGE." into gingerbread 2011-02-04 15:46:11 -08:00
Gilles Debunne
53841df2a4 Merge "SelectAllOnFocus shows a higlighted text. DO NOT MERGE." into gingerbread 2011-02-04 15:46:06 -08:00
Jeff Brown
39bc6197ba Never drag scroll views with no children. (DO NOT MERGE)
Fixes a regression from Froyo.  Previously, when a scroll view
had no children, its onTouchEvent would return because the scroll
view would only start dragging if the user touched one of its children.
In Gingerbread, the user can drag from anywhere within the scroll
view, not just by touching a child.  However, it makes no sense
to drag a scroll view that has no children so an empty scroll view
should just ignore touches like any other empty view group would.

This change fixes applications that for some reason or other happen
to have empty scroll views in strange places.

Bug: 3246230
Change-Id: I76c6136d3cd74968983033014d60deec1718ce30
2011-01-19 11:20:46 -08:00
Gilles Debunne
16141478df SelectAllOnFocus shows a higlighted text. DO NOT MERGE.
Bug 3201383

Highlighted is different from selected, only the background is modified
and selection mode is not started.

Tapping inside a highlighted text places the cursor. This is especially
useful for WebView and search bar has been modified to select all on focus.

Selection handles time out is no longer needed.

This CL is pretty involved and especially messes up with the terrible
ExtractedTextView, which causes a lot of problem with text selection
across device rotations.

The current implementation works pretty well. It has one problem: the handles
are not displayed when switching to landscape mode with a selected text.

This is still an improvement over the current GB version, where the handles
are not preserved at all across device rotation and where I can find more bugs.

Handles are now hidden when a context menu is displayed.

I can polish this more if we decide to include this in the MR1.

Change-Id: Id10bf2808ff25752efd59a1987e91d609ba478cd
2011-01-12 09:46:53 -08:00
Gilles Debunne
dc32a99889 Blinking runnable is created only if text is editable. DO NOT MERGE.
Change-Id: If85acc73cfa12b6da23d60459a746e1aef51d3aa
2011-01-11 10:24:11 -08:00
Gilles Debunne
d5253fae69 All runnable are stopped on detach. DO NOT MERGE.
This prevents these runnable from holding a reference to the context
that will prevent it from being garbage collected.

The blinking cursor is especially bad and appears in memore traces.

Change-Id: I8acbfbbfc59975dfd7bcf06e941074ea7dc0b0bc
2011-01-11 10:21:41 -08:00
Dianne Hackborn
7becaeea7b Another stab at fixing issue #3149290 java.lang.RuntimeException:...
...Unable to pause activity
{com.android.settings/com.android.settings.applications.StorageUse}

Change-Id: Ibfa28a1c5af50dd150dfcafe71e905426d312643
2010-12-22 18:29:32 -08:00
Dianne Hackborn
99441c45e4 Fix issue #3149290: java.lang.RuntimeException: Unable to pause activity
{com.android.settings/com.android.settings.applications.StorageUse}

AbsListView could call mAdapter.getItemId() if a save state happened
after the data changed but before a layout occurred.

Change-Id: Ica020971dc458dff79b56dd810733e217f4f7da6
2010-12-15 11:02:55 -08:00
Owen Lin
45ca778d8e Merge "Make sure the controller will get repositioned after size changing." into gingerbread 2010-11-09 19:02:23 -08:00
Jesse Wilson
28c742573c Add @Deprecated to match @deprecated where it's missing.
Change-Id: Ice95022671968386a601f32df7850f9baa1d2dd0
2010-11-09 10:10:11 -08:00
Owen Lin
a8381dfc5e Make sure the controller will get repositioned after size changing.
Bug: 3177061
Change-Id: I8f9606d4e05146ba568e8fe370cfe115dadedab9
2010-11-09 19:32:30 +08:00
Adam Powell
36ffc5c960 DO NOT MERGE Fix bug 3121030 - Text handles erroneously appear over
extract mode IME window

Make the SelectionModifierCursorController track its show/hide state
more accurately in the presence of an extract mode IME.

Lazily initialize CursorControllers so that we don't end up creating
them for various TextViews where they are not needed.

Change-Id: Ib76a95d9e7669016cf11b8b0add8843b438068ea
2010-11-08 15:00:49 -08:00
Leon Scroggins
5642625cfb Update insertion handler for WebTextView.
Bug:3152629
Change-Id: If2a33eb5456493fb9b3b2c54fcc4f5348fe129e1
2010-11-01 15:45:37 -04:00
Adam Powell
b9b8f7b99b DO NOT MERGE Fix bug 3124899 - timeout in CTS test
ExpandableListViewBasicTest

A certain sequence of events could cause AbsListView to enter an
infinite event loop. Only report reaching a scroll boundary to the
overscroll code path if the Scroller wants to move further, not if
we're done moving.

Change-Id: Ifdaf72d60ca25584e4a37d3d8f17365e0fcbfa40
2010-10-25 11:12:41 -07:00
Mindy Pereira
6fbc5d9c19 DO NOT MERGE. Make sure to invalidate after pulling on an edgeglow.
Fixes b/3111778 overscroll glitch in news & weather

Change-Id: Ic255da1f7c4301ea3980acc4fa033c9f17a60dac
2010-10-19 17:38:24 -07:00
Gilles Debunne
0dcad2bd01 Removed "Select word" option on password fields.
It would return an arbitrary selection around current position.
Rely on select all instead.

Bug: 3100750
Change-Id: I73d995e6481d7c230cc9f334c72fbfb7e9828007
2010-10-15 16:29:25 -07:00
Daniel Lehmann
d16f7588a8 Merge "DO NOT MERGE: Private API to pass the selected tab through QuickContacts" into gingerbread 2010-10-14 18:31:16 -07:00
Daniel Lehmann
2f14c62125 DO NOT MERGE: Private API to pass the selected tab through QuickContacts
Bug:3082932

Change-Id: I28dbb21a30fbe22e6e58a8dda534fc9110621c85
2010-10-14 11:26:18 -07:00
Gilles Debunne
d97b7f20b8 Really leave text selection mode when using the trackball.
Bug 3086617

Change-Id: I04c7f5b59d41ed294ac10c20588d2ea476f9d7f6
2010-10-13 19:20:53 -07:00
Mindy Pereira
bcfcd8ecd4 Reduce the time it takes to decay the glow after a pull.
The decay is now in line for the decay for absorb glows.
Fixes b/3094064  Overscroll fade timeout is too long

Change-Id: Ida987c8f6193fcb15f743d72c590a5c1daef056d
2010-10-13 16:02:01 -07:00
Adam Powell
8c8293bc4d Fix bug 3064135 - do not allow text handles on TextViews in sub windows.
Change-Id: I35db64d0a5c92c8ad184b36d243e45c91d4ac46e
2010-10-12 14:45:55 -07:00
Gilles Debunne
6b8bdaa9c8 New AppsPermission and market style
Bug 3067333

Change-Id: Ibbf444cfd9b1e2d7b51f4194d57c6dee30ac18ee
2010-10-10 17:57:55 -07:00
Gilles Debunne
b72a335a7f Merge "Voice input replaces selected text." into gingerbread 2010-10-10 14:01:10 -07:00
Gilles Debunne
e507a9e4af Voice input replaces selected text.
Bug 3068128

Hiding controllers no longer stops text selection.

Change-Id: Ie00c99948b3a14ce8a4a2a93c064c0635cadc993
2010-10-10 12:44:18 -07:00
Mindy Pereira
7a64e3a6f3 DO NOT MERGE Set the cap at alpha to 80% of the total available.
No matter how much the user drags, the alpha like the height
should not get greater than a max and that max is 80% of what
is available in the image.

Change-Id: I57d181d6ea685461a44ed3ee29f83a675bc07fbc
2010-10-10 12:18:01 -07:00
Gilles Debunne
a827d7bc34 Merge "Other improvements to text cursor movement." into gingerbread 2010-10-08 17:14:45 -07:00
Mindy Pereira
f6859c3da7 DO NOT MERGE Limit the height of the pull glow.
Event when the user keeps pulling, should NEVER get bigger than
the max height (~2list items tall).
Fixes b/3074337  Overscroll glow can be stretched indefinitely

Change-Id: Ifc30d4c907d432faf9ee10ddc20bcc8f50b21f81
2010-10-08 17:04:04 -07:00
Gilles Debunne
380b604a03 Other improvements to text cursor movement.
Paste happened on pressed position instead of current cursor location
when triggered by a long touch.

Change-Id: I86900f2bbb93390d3efa756aeebb424c4ae7e19b
2010-10-08 16:12:11 -07:00
Gilles Debunne
528c64887e TextView cursor and selection improvements.
Insertion cursor handle no longer appears on empty text views (Bug 3075988).

Tapping on an unfocused TextView moves the insertion point at tapped position.

Bug fixes for trackball initiated text selection.

Change-Id: Ief246fd9a9f1eb745dcf9f0605e2ce53b5563f01
2010-10-08 14:02:37 -07:00
Mindy Pereira
612d570a6f DO NOT MERGE Adjust amount pull effects the glow and edge decay.
Edge decay is now based on the remaining height of the glow so that
as the glow reduces, the edge will reduce and not disappear entirely
before the glow is gone.

Change-Id: I03376ee3807e21ce6ac74c0cfad713b7fd5e4520
2010-10-08 11:45:57 -07:00
Gilles Debunne
c873112810 Long press with trackball selects word under cursor.
Bug 3068305

Change-Id: Ib37fc98a61efdf3fbfccbb2174e2dbdbcb1a240e
2010-10-07 20:59:09 -07:00
Gilles Debunne
cbfbb524af TextView refactoring to ease future merges in HC.
Change-Id: I979324b28fa4ca787e5836271c9014bca590c595
2010-10-07 16:58:06 -07:00
Mindy Pereira
4de94de9c5 DO NOT MERGE Only show edge glow effect on 1 side at a time.
Pulling on a side should force the opposite side into "decay".
Fixes b/3061753  new list "bounce" shouldn't show on both ends
This fixes scroller and horizontalscroller.

Change-Id: I4d9820c7178378b793ed9a29b119943eb1f46587
2010-10-07 15:12:56 -07:00
Mindy Pereira
ca6eb210e6 DO NOT MERGE Only show edge glow effect on 1 side at a time.
Pulling on a side should force the opposite side into "decay".
Fixes b/3061753  new list "bounce" shouldn't show on both ends

Change-Id: I4742e8c212f8e13da29ed887ebdd712903b533f7
2010-10-07 14:14:10 -07:00
Adam Powell
574b37ecc2 Fix bug 3071869 - text anchors are now treated as application sub-panels.
This places text anchors on a layer above normal application panels,
ensuring that they stay above things like the browser autocompletion
list.

Change-Id: I4ee0aea7416a2dafd7e48a7a39acf949af5db3e9
2010-10-07 11:17:12 -07:00
Adam Powell
fbb3b4768e Fix bug 3066313 - integrate new text anchor assets.
This adds the differentiated left/right anchors for hdpi and further
tweaks the behavior of text anchors.

Highlights:
* New assets are translucent - increased visibility for whatever is
  beneath.
* Start and end anchors may not cross one another.
* Minimum selection size is now 1.
* Touch targeting tweaked.

Change-Id: I601361323916ee19149562a23dc3242d908da45c
2010-10-06 21:46:28 -07:00
Gilles Debunne
671b2a57bb Merge "Fix for IndexOutOfBounds in text pasting." into gingerbread 2010-10-05 18:11:09 -07:00
Gilles Debunne
330e263c4a Fix for IndexOutOfBounds in text pasting.
Made paste safe even in case of replace problems due to filters.

Bug 3042016

Change-Id: I9be34fa41fa6117502bbd959f91c562f28fb4237
2010-10-05 17:33:08 -07:00
Adam Powell
737e8fe2c7 DO NOT MERGE Fix bug 3001751 and bug 3001584 - Gingerbread API review for over-scroll
Change-Id: If34c8ea4e15697420adad0bc404f3c278efd7c1b
2010-10-05 15:22:07 -07:00
Adam Powell
abcbb1a198 Fix bug 3061544 and some clipping errors.
Change-Id: I124d0bcae080c27e2978be7eecfbb131f101a35f
2010-10-04 23:10:11 -07:00
Gilles Debunne
8c03723da7 DO NOT MERGE. Select word no longer selects spaces between words.
Bug 3000870

This feature was useful to paste between two words. To do this, all you
have to do now in to first position the cursor between the words, and then
long pressing anywhere to get the pop-up menu with paste.

Not merged into HC since the paste story in HC still has to be determined.

Change-Id: Iea8d87e09b7ad43658ec5526110e609b9735c27a
2010-10-04 16:15:56 -07:00
Adam Powell
62a744e17d Fix bug 3052686 - ScrollView padding treated incorrectly
Also allow grabbing scrollviews for dragging outside of content
bounds, which makes a difference for overscroll effects.

Change-Id: I344db4490ad59f393bb6de338009e251a76e6282
2010-10-04 15:06:30 -07:00
Adam Powell
d29e686171 Merge "Fix bug 3058324" into gingerbread 2010-10-04 12:15:34 -07:00
Gilles Debunne
4d3baaf530 Merge "Bug fixes in Text selection." into gingerbread 2010-10-04 12:06:10 -07:00
Adam Powell
c3808b5dc7 Fix bug 3058324
PopupWindow now responds to the style attribute popupAnimationStyle
instead of windowAnimationStyle. The latter was being overridden with
undesired values. Animation.PopupWindow style added as a special
default sentinel value, which switches animation styles based on
whether the window is showing above or below an anchor.

Change-Id: Id7cc81f089b6053f2d3a495b1046002548ecf125
2010-10-04 11:55:38 -07:00
Gilles Debunne
baaace59f6 Bug fixes in Text selection.
"Select word" is displayed only when the text field is not empty.

Paste is always displayed in first menu.
Bug #3001438

Cut/copy works
Bug #3052005 fixed in 3047653

Change-Id: I573f04818683f9b1c78ecb4613570b738d30ba09
2010-10-04 11:21:54 -07:00