Commit Graph

18799 Commits

Author SHA1 Message Date
Yohei Yukawa
e893ec4f8d Rename IInputContext to IRemoteInputConnection
IInputContext is the IPC interface name used behind InputConnection,
which was named in the initial development of IME API for Android 1.5.

To make it more descriptive and consistent with other classes such as
RemoteInputConnection, let's rename it to IRemoteInputConnection.

This CL also renames

  IInputContextInvoker

to

  IRemoteInputConnectionInvoker

for consistency.

This is a rename of internal IPC interface.  There should be no
user/developer observable impact.

Bug: 234882948
Test: presubmit
Change-Id: Iae82d5a26f0746161c2bf91a421b97f0f238aafd
2022-06-06 12:48:14 -07:00
TreeHugger Robot
bf58690832 Merge "Move IInputMethodClient to com.android.internal.inputmethod" 2022-06-06 06:12:57 +00:00
Yohei Yukawa
3221237629 Move IInputMethodClient to com.android.internal.inputmethod
Bug: 234882948
Test: presubmit
Change-Id: I7c11c9613732c3faa722938c2c4761868444cd42
2022-06-03 17:27:34 -07:00
TreeHugger Robot
31604826e2 Merge "Fix modulo div by 0 in Choreographer." into tm-dev am: 6dadf45f60 am: 6ac56d2506
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18718035

Change-Id: I3eff3b1602c5d0f71bb6d4d33158743ed292d148
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 00:13:35 +00:00
TreeHugger Robot
52dc6f568d Merge "Add transition timestamp to AccessibilityWindowInfo" 2022-06-03 20:50:17 +00:00
TreeHugger Robot
6dadf45f60 Merge "Fix modulo div by 0 in Choreographer." into tm-dev 2022-06-03 19:03:33 +00:00
chaviw
e777b75d4c Convert to using inputConfig for clone info in WindowInfo
Remove explicit isClone flag and add CLONE to InputConfig

Test: Builds
Bug: 230300971
Change-Id: Iced894472c75bf2ef22618b9e7485d1978d88be2
2022-06-02 17:16:43 +00:00
TreeHugger Robot
788f36bb4f Merge "Make GPU duration metrics more accurate for Vulkan" into tm-dev am: 9bcdb76b98 am: 445ab1404f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18639113

Change-Id: I25c01e18201f8e147e23049242c9bf281a1bfaf4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-02 06:36:09 +00:00
TreeHugger Robot
9bcdb76b98 Merge "Make GPU duration metrics more accurate for Vulkan" into tm-dev 2022-06-02 06:12:33 +00:00
Rachel Lee
2c303b3f51 Fix modulo div by 0 in Choreographer.
Bug: 234483897
Test: atest ChoreographerTest
Change-Id: I7d7766f6ea120109490d307e971a3da80a3d92ad
2022-06-01 15:24:05 -07:00
Alec Mouri
3afb3972f4 Make GPU duration metrics more accurate for Vulkan
In the Vulkan pipeline, the GPU start time was measured to be when
swapBuffers starts. But the command queue has already been submitted at
this point, which means that the GPU work would already have begun. This
means that it's possible to measure a negative time since for very light
GPU workloads, the GPU fence can fire prior to CPU making it to
swapBuffers().

To compensate, instead measure from after skia completed submitting GPU
commands, until the GPU fence fires. Since it is theoretically possible
for GPU work to complete if the render thread gets descheduled
immediately after submitting the GPU, we also add some clamping to
ensure that the duration from command submission -> completion of GPU
work is nonnegative.

Bug: 230713131
Test: atest android.view.cts.FrameMetricsListenerTest
Change-Id: Ia30b7732eaab71e4e29766f788d5cd94ec63c38a
2022-06-01 21:18:30 +00:00
Chavi Weingarten
66c6130598 Merge "Remove lock when calling Surface.destroy" into tm-dev am: 3868362584 am: 42dee93b53
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18674393

Change-Id: I617601e94a863ad105a94abd1802b630ff3d3c5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 17:26:43 +00:00
Chavi Weingarten
3868362584 Merge "Remove lock when calling Surface.destroy" into tm-dev 2022-06-01 16:36:34 +00:00
Pablo Gamito
eef429affc Merge "Revert "Revert "Add ability to trace shell transitions""" into tm-qpr-dev am: 9fd0212e95 am: ddffd55d64
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18619887

Change-Id: I45601515d0184483aeefa57a8a344831c96bb97e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 12:41:50 +00:00
Pablo Gamito
9fd0212e95 Merge "Revert "Revert "Add ability to trace shell transitions""" into tm-qpr-dev 2022-06-01 12:19:49 +00:00
TreeHugger Robot
0232f47db6 Merge "Log why presentation was not shown" into tm-dev am: bd26701a6b am: e25d1148e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18519537

Change-Id: I6a7a3a46319f614e4a13cf73ffdd328714970c08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 09:17:05 +00:00
TreeHugger Robot
bd26701a6b Merge "Log why presentation was not shown" into tm-dev 2022-06-01 08:04:53 +00:00
Kate Xu
713a6d84ab Merge "Log why presentation was not shown" 2022-06-01 04:36:43 +00:00
Ryan Lin
a4c2f638fe Merge "Drop the cloned windows from visible window list" into tm-dev am: 8ef351123b am: 9896fe1981
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18659076

Change-Id: Ic304c22ababb1c256d877623cbbc142cc342811f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 02:22:16 +00:00
Ryan Lin
e49dcfca1b Merge "Drop the cloned windows from visible window list" into tm-dev am: 8ef351123b am: 2684945fb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18659076

Change-Id: Ib2521d2807afeeb61614532957caa48c82785d7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 01:52:06 +00:00
Ryan Lin
8ef351123b Merge "Drop the cloned windows from visible window list" into tm-dev 2022-06-01 01:29:36 +00:00
skxu
296065496f Log why presentation was not shown
Fixes: 219613425
Test: b/233833739
Change-Id: Ic95cc69b912e8144726124ebc8355c2d1e24079e
2022-06-01 00:43:54 +00:00
TreeHugger Robot
05ed701655 Merge "Get velocitytracker strategy from InputManager" 2022-06-01 00:24:55 +00:00
skxu
48a5cbb2d6 Log why presentation was not shown
Fixes: 219613425
Test: b/233833739
Change-Id: Ic95cc69b912e8144726124ebc8355c2d1e24079e
Merged-In: Ic95cc69b912e8144726124ebc8355c2d1e24079e
2022-06-01 00:10:02 +00:00
chaviw
9e3cd0533f Remove lock when calling Surface.destroy
Surface already has a lock on the native object so it's safe to call
destroy without holding additional locks. This also fixes ANR issues
where an app is still attempting to render when the window is destroyed.

Test: App from bug doesn't ANR
Bug: 234006724
Change-Id: I0d323c03f299e5857d1950870498f3182d019924
2022-05-31 13:48:56 -05:00
ryanlwlin
70764c141a Drop the cloned windows from visible window list
Currently the cloned windows is avaialbe from window list,
however the node info from the cloned window is incorrect.
To avoid confusion, we would drop them for a short term solution.

Bug: 230300971
Test: manually test with switchaccess
      adb shell dumpsys accessibility to observe the window list
Change-Id: I7a03376567698a493c9eb5e26d1f3390aacdb408
2022-05-31 13:48:08 +08:00
Riley Jones
050b5a833c Merge "Updated liveRegion documentation to avoid promoting using liveRegion for errors." 2022-05-30 19:35:21 +00:00
Pablo Gamito
fcdcd75faf Revert "Revert "Add ability to trace shell transitions""
This reverts commit 0dced9da30.

Reason for revert: Re-land change

Change-Id: I6f0159d239582c655d3a10f57f10a54f42967ebd
2022-05-30 14:42:34 +00:00
Tiger Huang
d95834c214 Merge "Only update the compat system UI visibility if the source is valid" into tm-dev am: 1fab45404b am: 8893bc9d06
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18583184

Change-Id: I887327b4d504f7c9576f11bf263c8e4d942c757e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-30 09:20:07 +00:00
Tiger Huang
ee3aa546f9 Merge "Only update the compat system UI visibility if the source is valid" into tm-dev am: 1fab45404b am: 1a2b3de8e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18583184

Change-Id: Iacbf6be2ba274e4542a09ba6f882dde9f1bdb15c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-30 09:19:39 +00:00
Tiger Huang
1fab45404b Merge "Only update the compat system UI visibility if the source is valid" into tm-dev 2022-05-30 08:40:03 +00:00
Mark Punzalan
8428fed8e0 Merge "Don't clear translation state on temporary detachment." into tm-dev am: 76ba87f909 am: ac3a48b69a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18624095

Change-Id: Ie7e4f57311feb3843dd6f3d7ee87dc8facb3a60a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 23:06:24 +00:00
Riley Jones
0ee08ce7dd Updated liveRegion documentation to avoid promoting using liveRegion for errors.
Test: No tests, just updating documentation.
Change-Id: I88cef50ca1713743a0befab9e23d746626346265
2022-05-27 21:40:58 +00:00
Mark Punzalan
89f3d4968d Merge "Translate selectable TextViews by temporarily disabling selectable." into tm-dev am: 8bbc7f6554 am: 8f85334591 am: 905979b385 am: af0c004e46
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18490753

Change-Id: I4d327ef4f8ff677a338df1a4be488d3e452da4d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 20:39:01 +00:00
Mark Punzalan
b8432ae0ad Merge "Don't clear translation state on temporary detachment." into tm-dev am: 76ba87f909 am: 29e91d3a0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18624095

Change-Id: Ie2f7e9d9f56c31ba342b790e565b547728524bae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 17:57:31 +00:00
Mark Punzalan
76ba87f909 Merge "Don't clear translation state on temporary detachment." into tm-dev 2022-05-27 17:15:29 +00:00
Siarhei Vishniakou
6d0488d866 Get velocitytracker strategy from InputManager
We are already caching this value inside InputManager, so let's just use
it directly from there.

We can't get this value reliably from ViewConfiguration because we dont
have a UI context. We can't use the application context because it would
create strict mode violations.

Bug: 233112584
Test: atest BinderTests#testSwitchToOverview
Test: atest android.view.cts.VelocityTrackerTest
Change-Id: I86595fb133c298b5dd1098b58b8743bb16a2e24b
2022-05-27 09:54:02 -07:00
Mark Punzalan
a695631475 Don't clear translation state on temporary detachment.
Change I97cc418a8 broke translation on apps which use ListView; messages
were re-translated with the animation even while on-screen. A new
message arrival triggers a re-layout which causes the temporary
detachment, which caused translation to be cleared, and the views get
translated again later.

The solution is to NOT clear translation in the case of temporary
detachment. When Views are actually recycled (e.g., by ListView and
RecyclerView), the detachment is permanent/non-temporary.

Bug: 232178488
Test: atest UiTranslationManagerTest
Test: Manual - Verified scrolling and new messages arriving when
translation is enabled. Tested on apps that use ListView and
RecyclerView.

Change-Id: Ibf1be58219c43252e00b06d4c9e27def5bd36fc2
2022-05-26 23:57:13 +00:00
Mark Punzalan
905979b385 Merge "Translate selectable TextViews by temporarily disabling selectable." into tm-dev am: 8bbc7f6554 am: 8f85334591
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18490753

Change-Id: I61c1109f8b7b4cf42bd38ab5fc234959056ca710
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 21:52:49 +00:00
Mark Punzalan
8bbc7f6554 Merge "Translate selectable TextViews by temporarily disabling selectable." into tm-dev 2022-05-26 21:06:34 +00:00
Kohsuke Yatoh
d71b5fbe49 Do not print extras in IMM/IMS dump.
EditorInfo.extras may contain arbitrary user-generated contents,
such as
androidx.core.view.inputmethod.EditorInfoCompat.CONTENT_SURROUNDING_TEXT.
We should not include such data in bug reports.

This CL does not change the behavior of the public API
(EditorInfo#dump()), in case any app depends on it.

Bug: 233405987
Test: atest FrameworksCoreTests:android.view.inputmethod.EditorInfoTest
Test: atest CtsInputMethodTestCases:android.view.inputmethod.cts.DumpTest
Change-Id: If3785e91c1aa5ce624a331a25035b7541d012d48
2022-05-26 05:45:03 +00:00
Pihuei Wang
36d1daefdd Merge "Revert "Add ability to trace shell transitions"" into tm-qpr-dev am: 180b752558 am: 2f68cafb63
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18606247

Change-Id: Ibde68994b09457b264194291ae4d34b5241a0b56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 03:45:57 +00:00
Pihuei Wang
180b752558 Merge "Revert "Add ability to trace shell transitions"" into tm-qpr-dev 2022-05-26 03:14:59 +00:00
Pihuei Wang
0dced9da30 Revert "Add ability to trace shell transitions"
This reverts commit 6ae3b6c67e.

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?branch=git_master&target=test_suites_arm64&lkgb=8640544&lkbb=8644278&fkbb=8640550, bug b/233875239

Change-Id: I44da4fc6d4f7ae585c122624e5cbe7838cd2a71f
2022-05-26 03:08:10 +00:00
Mark Punzalan
6758b3f7e7 Translate selectable TextViews by temporarily disabling selectable.
The text is not selectable while translated. Making translated text
selectable requires many more changes.

This was tested in Nextdoor in the feed/posts activity. When there is a
"Read more" link in the post, the link doesn't work while translated,
and doesn't behave the same way after translation is paused.

Bug: 202966891
Test: atest CtsTranslationTestCases
Test: Manually - with Nextdoor on feed and chat activities
Change-Id: I6e8f532d427d85ff22df0deb248d8416a15f4821
2022-05-25 20:03:10 +00:00
Pablo Gamito
13c8657958 Merge "Add ability to trace shell transitions" into tm-qpr-dev am: 1abf474563 am: e2b64e5ff9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17944325

Change-Id: I2257289a187e48bc03a5b5d8ebd1a73c5af43658
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 11:08:58 +00:00
Pablo Gamito
1abf474563 Merge "Add ability to trace shell transitions" into tm-qpr-dev 2022-05-25 10:31:00 +00:00
Tony Huang
5aca2dbbfd Merge "Remove the special logic of the divider bar z-ordering" into tm-qpr-dev am: 4f8c3f0841 am: 525db9b3b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18320962

Change-Id: I4cfd1dd9599570aa7c6259352b7a041d9f0cfd18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 02:47:35 +00:00
TYM Tsai
56cfaeb9f0 Merge "Fix inline tooltip position is wrong" into tm-dev am: edca30dce8 am: 34fe95788a am: 8a29813f8a am: eedfddb086
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18350147

Change-Id: I57c3922a095ab0f6df0fd48685c885e46b58a1ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 02:44:09 +00:00
Tony Huang
4f8c3f0841 Merge "Remove the special logic of the divider bar z-ordering" into tm-qpr-dev 2022-05-25 02:01:26 +00:00