Commit Graph

772314 Commits

Author SHA1 Message Date
Jeff DeCew
ca0f06f183 Dump NotificationWakeUpCoordinator state to bugreports.
Bug: 234979264
Test: dumpsysui NotificationWakeUpCoordinator
Change-Id: Ie59fc8ffdd2893010246a1518f0347c633c25f22
2022-08-03 19:54:23 +00:00
TreeHugger Robot
52fc08f789 [automerger skipped] Merge "Always set the top roundness of child rows to 0." into tm-d1-dev am: b86b71823f -s ours
am skip reason: Merged-In I3cd1aa23ad8333f35ec837edd39bc12aeb1573b6 with SHA-1 ef4782f55d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19501101

Change-Id: Ie482635ee78e9d8eb7c2235723a4ee9c56ae48ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 19:22:26 +00:00
Jeff DeCew
7acfdd4620 [automerger skipped] Always set the top roundness of child rows to 0. am: 16186884ec -s ours
am skip reason: Merged-In I3cd1aa23ad8333f35ec837edd39bc12aeb1573b6 with SHA-1 ef4782f55d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19501101

Change-Id: I78ce42352124a06e6621a8083d2c6e3533836d75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 19:22:11 +00:00
Yanli Wan
3544e25a4e Merge "Stop app pinning if lock task is requested from allowedlisted app" into tm-qpr-dev 2022-08-03 19:18:52 +00:00
TreeHugger Robot
b86b71823f Merge "Always set the top roundness of child rows to 0." into tm-d1-dev 2022-08-03 19:00:41 +00:00
Rahul Banerjee
d030be309a Turn off the new back arrow in Teamfood.
We're still in the middle of making fairly non-trivial changes to the
new Back Arrow, and it's expected that there might be regressions, or
misc changes that affect its current look+feel.

To avoid confusing folks with such random changes, we're disabling it in
Teamfood for now. The medium-to-long-term goal is to migrate the
UX prototype from its plugin incarnation into production-level code that
lives in this repo (which is when we'll re-enable it).

Bug: 241248730
Test: Manual
Change-Id: I1918008f15f47cfb0f3378462bc168d0bcd8e485
2022-08-03 11:51:48 -07:00
TreeHugger Robot
110cd7aa33 [automerger skipped] Merge "Allow system info to be set visible even if we don't animate" into tm-d1-dev am: 6b3f5537dc -s ours
am skip reason: Merged-In I7ad8c4a4df8ff335ea9b3de428521b24e59002ee with SHA-1 03c1d21c3e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498372

Change-Id: Ib23c304891e2146c3b9b64da826ffba5a7d031fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 17:51:11 +00:00
Evan Laird
9e85a17522 [automerger skipped] Allow system info to be set visible even if we don't animate am: 3b218416e0 -s ours
am skip reason: Merged-In I7ad8c4a4df8ff335ea9b3de428521b24e59002ee with SHA-1 03c1d21c3e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498372

Change-Id: Ida8e8302cb66657fb320d8840e9fbcefb3001c7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 17:51:09 +00:00
Issei Suzuki
54b7e34ba9 Merge changes from topic "cherrypick-setDismissKeyguard-sh5oh7kmyi" into tm-d1-dev am: aca8d31cc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19500329

Change-Id: I091897b2229874c81aca02e3c84871f643f47f8f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 17:49:58 +00:00
TreeHugger Robot
6b3f5537dc Merge "Allow system info to be set visible even if we don't animate" into tm-d1-dev 2022-08-03 17:29:24 +00:00
Issei Suzuki
aca8d31cc2 Merge changes from topic "cherrypick-setDismissKeyguard-sh5oh7kmyi" into tm-d1-dev
* changes:
  Clear ActivityRecord#mDismissKeyguard flag after app launches.
  Clear ActivityRecord#mDismissKeyguard flag after app launches.
2022-08-03 17:23:08 +00:00
Yein Jo
436b662850 Add ellipse shape to the ripple.
Bug: b/203800342
Test: Manual, RippleViewTest
Change-Id: I29fe4d05a868305814a980ef2bde53a608df0ce2
2022-08-03 16:28:18 +00:00
Lyn Han
a745ebf39c Merge "Fix dot/icon overlap in notification shelf" into tm-qpr-dev 2022-08-03 16:28:01 +00:00
Yein Jo
a37c26f550 Make RippleShader support circle and rounded box shapes.
There will be a follow up CL for adding a oval shape.
This CL breaks the RippleShader into smaller pieces
and glue only the neccessary parts together when
initializing.

Note that this CL, the rounded box shape is not being
used.

Bug: b/237282686
Test: Manual, WiredChargingRippleControllerTest

Change-Id: I09091a612e3307a76a0bc938ce0810153541243a
2022-08-03 16:26:11 +00:00
Jeff DeCew
16186884ec Always set the top roundness of child rows to 0.
The bug demonstrated that only the top radius was getting into a dirty state.  When I saw this function was resetting the bottom roundness and never touching the top roundness, it was clear that we just needed to set the top roundness.  Even though it's hard to reproduce the issue where top roundness is incorrectly huge, it's trivial to reproduce the issue where the top roundness is incorrectly small, and this fix definitively addresses that state.

Test: post auto-groupable Heads Up notifications.  Notice after grouping that child rows now never have any internal corner radii.
Fixes: 227433308
Merged-In: I3cd1aa23ad8333f35ec837edd39bc12aeb1573b6
Change-Id: I3cd1aa23ad8333f35ec837edd39bc12aeb1573b6
(cherry picked from commit ef4782f55d)
2022-08-03 16:20:40 +00:00
Felipe Leme
88f2307219 Fixed VIMS to postpone ASSISTANT rule change on pre-created users.
RoleService should not be calling onRoleHoldersChanged() on
pre-created users, but that behavior cannot be changed because its
implemented by a system app, and pre-created users APIs are hidden.

To test it:

$ adb shell pm create-user --pre-create-only  --guest
Success: created user id 12

$ adb shell pm create-user --guest ElGuesto
Success: created user id 12

$ adb shell cmd user list --all -v
4 users:

0: id=0, name=Driver, type=system.HEADLESS, flags=ADMIN|INITIALIZED|PRIMARY|SYSTEM (running)
1: id=10, name=Driver, type=full.SECONDARY, flags=ADMIN|FULL|INITIALIZED (running) (current)
2: id=11, name=null, type=full.SECONDARY, flags=FULL|INITIALIZED (pre-created)
3: id=12, name=ElGuesto, type=full.GUEST, flags=EPHEMERAL|FULL|GUEST|INITIALIZED (converted)

$ adb shell am switch-user 12

$ adb shell dumpsys voiceinteraction |egrep '(mBound|implementation)'
  mBound=true mService=android.service.voice.IVoiceInteractionService$Stub$Proxy@77da1bc

$ adb shell cmd voiceinteraction show

Test: see bove
Bug: 216141085
Bug: 226201975

Merged-In: I12d9bb32e144ecf91ee4b452affea0dcea546127
Change-Id: I12d9bb32e144ecf91ee4b452affea0dcea546127
(cherry picked from commit 39acca1d72)
2022-08-03 16:03:02 +00:00
Wu Ahan
699f5e9471 Merge "Mark CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE_LOCK as deprecated CUJ" into tm-qpr-dev 2022-08-03 15:49:08 +00:00
Beverly
24f8bdf627 Improve UDFPS unlock animation experience
- Don't expand shade if touch started from KG and then
ended when KG was not longer showing. This can happen
if the security setting is set to swpe to open,
and the user transitions to the SHADE. Then, the touch can
be canceled if a window is transitioning to landscape.
- Don't propagate notification panel expansion to the bouncer
when the device is unlocking with biometric (MODE_DISMISS_BOUNCER).
Since KeyguardBouncer.EXPANSION_VISIBLE = 0 panel expansion, calls
during the unlock transition to collapse the notification panel
unintentionally end up showing the bouncer.
- If the KG isn't showing and the bouncer is in transit, reset the
bouncer expansion to HIDDEN.

Test: open fruit ninja (which is locked to landscape)
and swipe to unlock, notice that panel does not expand on unlock
Test: unlock using udfps by sliding finger from slightly below/diagonal
of the UDFPS sensor (so that the bouncer transition begins), and then
successfully authenticate with UDFPS => observe the bouncer UI doesn't
flash on the screen after successful authentication.
Test: atest StatusBarKeyguardViewManagerTest
Bug: 240487038
Bug: 240763673
Change-Id: I9e1fb108147ffb4c812ea2b94a50d6201eaf008a
2022-08-03 15:00:38 +00:00
Evan Laird
e04531c84a Merge "Allow system info to be set visible even if we don't animate" into tm-qpr-dev 2022-08-03 13:26:33 +00:00
Hawkwood Glazier
23535e29d1 [DO NOT MERGE]Revert "Migrate KeyguardClockSwitch to new shared Clock library"
Revert "Expose the clock version of google-sans"

Revert "Changes to SystemUIGoogle to support clock migration"

Revert submission 19451291-cherrypick-clock_migration-tvip0m638i

Reason for revert: b/241084042
Reverted Changes:
Ia053aaec6:Migrate KeyguardClockSwitch to new shared Clock li...
Ia3e067b93:Changes to SystemUIGoogle to support clock migrati...
I5dbf01a83:Add clock version of google-sans
Ia654d4f41:Expose the clock version of google-sans

Change-Id: I432d3d814c85b9ba20bbb7a88d2e52bd2337c10c
2022-08-03 15:22:58 +02:00
Riddle Hsu
b27282acb5 Merge "Support shell rotation transition on general window container" into tm-qpr-dev 2022-08-03 13:09:54 +00:00
Fiona Campbell
b456bec06a Merge "Add idleEnabled to brightness event logging" into tm-qpr-dev 2022-08-03 13:09:48 +00:00
Riddle Hsu
3ad540478f Merge "Get the latest display info for overlay change" into tm-qpr-dev 2022-08-03 12:31:28 +00:00
Christian Göllner
a23f2dd5e9 [Large screens] Do not animate clock when turning on display not on AOD
The problem was that the large clock was always being centered on large
screens when the screen was off.

The fix is to make sure that the large clock is only centered when AOD
is enabled.

Fixes: 233888543
Test: Manually
Test: NotificationPanelViewControllerTest.java
Change-Id: I29f5c6ddd0dde549f37a8eee9d5446b219b4fb9a
2022-08-03 14:23:30 +02:00
Nicolò Mazzucato
560e645f3a Merge "Monitor fold to AOD latency" into tm-qpr-dev 2022-08-03 11:52:06 +00:00
Fiona Campbell
78cc78ca6f Add idleEnabled to brightness event logging
Bug: 241217290
Test: adb shell dumpsys display

Change-Id: I433b320171e79fa09aa18862e5b88a1289e9227c
Merged-In: I255396f132497ba42b60261de1477231520dad3d
2022-08-03 11:33:25 +00:00
TreeHugger Robot
7f96bd5a88 Merge "Fix leakage of pointer location" into tm-qpr-dev 2022-08-03 11:12:10 +00:00
Nicolo' Mazzucato
1a1976c329 Monitor fold to AOD latency
This logs the latency from when we receive the device state change (device folded), to when the AOD animation starts.

Bug: 237270816
Test: atest FoldAodAnimationControllerTest
Change-Id: I67e0e04bbc24064640f46cdc8feb667814170529
Merged-In: I67e0e04bbc24064640f46cdc8feb667814170529
2022-08-03 09:23:04 +00:00
Tony Huang
1c6b58efb2 Fix split overlay by drag drop launch
When drag drop launch, wms will use animation leash to do launch
transition, and reparent surface back and reset its position by
windows its configuration.
However, on split side we also set windows bounds in same time,
so in some race condition, wms side reset its position later and
use old configuration because we update it in same time then cause
task surface position wrong.
To fix this issue, we should apply windows bounds before we launch
the intent.

This CL also fix divider invisible issue when drag drop some specfic
app to active split screen caused by surface tanscation race too.

Fix: 227142506
Fix: 240638389
Test: manual
Test: pass existing tests.
Change-Id: Ia195f39fbf8879cbee9608f0c27f98df7e9e289f
2022-08-03 08:17:39 +00:00
Arthur Hung
034c4ee421 Mark IWindowFocusObserver as oneway interface
It used to notify if the window focus is gained or lost, mark it as
oneway to prevent it block the system server when outgoing.

Bug: 238050065
Test: Trigger back gesture and see the logs
Change-Id: I17b79a361edadf03d2b2887cce7ec29c3968e3e5
2022-08-03 08:08:26 +00:00
Riddle Hsu
0165c9e7f3 Support shell rotation transition on general window container
This eliminate the limitation of rotation animation that it could
only have one instance for display. Now the rotation animations
can be tracked by them self so there could have multiple instances
run at the same time, such as for multiple display or individual
child window container.

The first usage is: (also see commit d16620e)
The fixed rotation transform of activity is canceled so display
doesn't have rotation change but the activity has. Then only the
activity needs to animate.

Bug: 223397858
Test: adb shell setprop persist.wm.debug.shell_transit 1; reboot
      Enable auto rotation. Launch an app without fixed orientation
      from portrait launcher while device is in landscape. Before
      the launch animation is done, rotate the device to portrait
      (there is no display orientation change). The launched app
      should rotate from landscape to portrait without flickering.

Change-Id: Ic47960e812f07365965df4ab2913e2003289a315
2022-08-03 07:25:19 +00:00
TreeHugger Robot
4d334f4534 Merge "Fix the bug where the added field into the toString implementation does not have a corresponding %s formatting." into tm-qpr-dev 2022-08-03 02:16:08 +00:00
Josh Tsuji
fac6505c97 Don't reset the keyguard on occlusion if it's going away.
The reset() call only executes if the keyguard is visible,
and causes it to reset the visible views (it can not show/hide
the keyguard). However, if the keyguard is going away because
of a launching occluding activity, and was previously insecure,
this will cause us to decide that the views should be in SHADE
state rather than KEYGUARD state, and re-render them accordingly.
This causes the shade to flicker under the launching activity.

This reset is not needed, as the status bar state change will
change to SHADE after the launch animation occurs (or will be
forced back to KEYGUARD if the unlock animation is cancelled).

Fixes: 238294986
Test: launch controls from LS affordance with/without face unlock, with/without AOD
Change-Id: Ib0622655ef6f51e1bcc9a98a5ce8f4e7feacb2fe
2022-08-02 21:15:07 -04:00
Evan Rosky
fc301ed47c Merge "Strip transition information from activityoptions once it is read." into sc-v2-dev am: dc8ae7665a am: a824844cdf am: 7cb144249f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19505172

Change-Id: Ibded759578f05fe3dab6af5f0dc0e8579756e46d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 01:09:46 +00:00
Evan Rosky
7cb144249f Merge "Strip transition information from activityoptions once it is read." into sc-v2-dev am: dc8ae7665a am: a824844cdf
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19505172

Change-Id: Id7de444318f392c3d8e9735df2dd78834fc79eee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 00:18:31 +00:00
TreeHugger Robot
34c2839d3c Merge "Developer-facing document for quick affordances" into tm-qpr-dev 2022-08-03 00:12:57 +00:00
Evan Rosky
a824844cdf Merge "Strip transition information from activityoptions once it is read." into sc-v2-dev am: dc8ae7665a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19505172

Change-Id: I489c233fea52fff948c5b4d92cd61163904e974d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 23:52:01 +00:00
Evan Rosky
dc8ae7665a Merge "Strip transition information from activityoptions once it is read." into sc-v2-dev 2022-08-02 23:30:03 +00:00
Jeff DeCew
b64d342949 [automerger skipped] RESTRICT AUTOMERGE: Fix build breakage from merge conflict. am: 518980587b -s ours am: 2bd5ab6f26 -s ours am: 04928c8771 -s ours am: 7c5b922af8 -s ours am: d657a62950 -s ours am: 8582ebea5b -s ours am: b310ba4af2 -s ours am: 30df0c03c0 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498370

Change-Id: I40776d36fbbdc899a34066f3a3a7f6eba01aa98e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 23:21:35 +00:00
Jeff DeCew
d56cc1627f [automerger skipped] RESTRICT AUTOMERGE: Fix build breakage from merge conflict. am: 518980587b -s ours am: 2bd5ab6f26 -s ours am: 04928c8771 -s ours am: 7c5b922af8 -s ours am: 17c5ac1df5 -s ours am: 97b6dba3be -s ours am: f160b0e03d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498370

Change-Id: I20b6275bfebf10ab7acf016ddf1508d4b1f29e42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 23:21:08 +00:00
Cliff Wu
0bc5eed6fa Merge "Fix generic wrong strings to comply with the UX guideline" into tm-qpr-dev 2022-08-02 23:13:14 +00:00
Winson Chung
19aa091129 Merge "3/ Fix inverted ShellInit dependency order (no functional changes)" into tm-qpr-dev 2022-08-02 22:56:44 +00:00
Jeff DeCew
30df0c03c0 [automerger skipped] RESTRICT AUTOMERGE: Fix build breakage from merge conflict. am: 518980587b -s ours am: 2bd5ab6f26 -s ours am: 04928c8771 -s ours am: 7c5b922af8 -s ours am: d657a62950 -s ours am: 8582ebea5b -s ours am: b310ba4af2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498370

Change-Id: Idfb2c0baa905ee854270f051b39e816567cb05d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 22:47:37 +00:00
Jeff DeCew
f160b0e03d [automerger skipped] RESTRICT AUTOMERGE: Fix build breakage from merge conflict. am: 518980587b -s ours am: 2bd5ab6f26 -s ours am: 04928c8771 -s ours am: 7c5b922af8 -s ours am: 17c5ac1df5 -s ours am: 97b6dba3be -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498370

Change-Id: Ibea2cf4a9b519fbcdc7ef0da83cea19e077e791d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 22:47:32 +00:00
Jeff DeCew
b310ba4af2 [automerger skipped] RESTRICT AUTOMERGE: Fix build breakage from merge conflict. am: 518980587b -s ours am: 2bd5ab6f26 -s ours am: 04928c8771 -s ours am: 7c5b922af8 -s ours am: d657a62950 -s ours am: 8582ebea5b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498370

Change-Id: If4fd1689abacf49dee8bff5fc0e4adca1384f930
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 22:46:10 +00:00
TreeHugger Robot
0010c812a3 Merge "KeyguardBottomAreaView: turns on flag for teamfood." into tm-qpr-dev 2022-08-02 22:38:41 +00:00
Jeff DeCew
8582ebea5b [automerger skipped] RESTRICT AUTOMERGE: Fix build breakage from merge conflict. am: 518980587b -s ours am: 2bd5ab6f26 -s ours am: 04928c8771 -s ours am: 7c5b922af8 -s ours am: d657a62950 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498370

Change-Id: Ie48f454c27cbba90211710f86bbcfa5db388f15d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 22:23:52 +00:00
Jeff DeCew
97b6dba3be [automerger skipped] RESTRICT AUTOMERGE: Fix build breakage from merge conflict. am: 518980587b -s ours am: 2bd5ab6f26 -s ours am: 04928c8771 -s ours am: 7c5b922af8 -s ours am: 17c5ac1df5 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19498370

Change-Id: If942c502620edc4b569c1a7aa38d765407562478
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 22:23:50 +00:00
Hawkwood Glazier
4760b7cda3 Merge "Prevent NPE when displaying a missing clock" into tm-qpr-dev 2022-08-02 21:59:50 +00:00
Hawkwood Glazier
79dac2d234 Merge "Add Flag for Custom Clocks" into tm-qpr-dev 2022-08-02 21:59:14 +00:00