Commit Graph

397471 Commits

Author SHA1 Message Date
Gus Prevas
dca2be5f93 Combines NotificationEntryManager listener interfaces (part 5).
This change combines the onEntryRemoved() and
onPerformRemoveNotification() methods on NotificationEntryListener to a
single method.  The latter method was called after the former method in
all cases where the removal of the notification was precipitated by user
action (swipe, bubble swipe, launching content intent), so it's replaced
by a boolean parameter to the former method indicating whether a user
action caused the removal.

Test: atest SystemUITests, manual
Change-Id: I448fdd68984e3c2489259940c4d3432ac5bfe320
2018-12-27 09:49:02 -05:00
Gus Prevas
f37435a69b Combines NotificationEntryManager listener interfaces (part 4).
This change combines the onEntryRemoved() and onNotificationRemoved()
methods on NotificationEntryListener to a single method.  The logic in
NotificationEntryManager which calls these methods is rearranged and a
flag is added to the callback method in order to fully preserve the
previous behavior of all implementors.

Test: atest SystemUITests, manual
Change-Id: I6077e78005ed6c20b02f5fa21f213199384cc3b8
2018-12-27 09:45:30 -05:00
Gus Prevas
8621bd27a5 Combines NotificationEntryManager listener interfaces (part 3).
This change eliminates the mCallback field on NotificationEntryManager,
instead adding the listener which used to be in that field to the list
of listeners.

Test: atest SystemUITests, manual
Change-Id: I3b489ad87cf9d757c9ad9e49cf3c12c35972dee5
2018-12-27 09:25:03 -05:00
Gus Prevas
b43dc65641 Combines NotificationEntryManager listener interfaces (part 2).
This change introduces the NotificationAlertingManager component, a
NotificationEntryListener which handles showing/hiding/updating alerts
(heads-up or ambient pulsing) in response to events from the
NotificationEntryManager.  All code in the new component was moved out
of NotificationEntryManager proper.

Test: atest SystemUITests, manual
Change-Id: I46a046da6caf39b1d314b357e21ac6b4755c5796
2018-12-27 09:24:50 -05:00
Sungsoo Lim
ab1ad60ec8 Merge "Add Session2Command and Session2CommandGroup" 2018-12-27 11:18:03 +00:00
Jelle Fresen
ba281ccf76 Merge "Add add/remove for AnimationListener's" 2018-12-27 07:52:37 +00:00
Sungsoo Lim
bf37bd47fd Add Session2Command and Session2CommandGroup
Bug: 121230641
Test: build
Change-Id: Id9d79c90e99db7b78467cf3811d6dff667335a2e
2018-12-27 15:08:44 +09:00
TreeHugger Robot
f846f21543 Merge "Add getMediaDeviceById() method" 2018-12-27 05:37:31 +00:00
hughchen
0487263c50 Add getMediaDeviceById() method
Add getMediaDeviceById() for get MediaDevice through unique id.

Bug: 121083246
Test: build pass
Change-Id: I8e44c3167cfe7d0fc84e8132219dd17c76b4360c
2018-12-27 11:46:19 +08:00
Max Bires
21ffe60b70 Merge "Adding check for HMAC/EC key size for StrongBox" am: ffee7d8ce0 am: f5992f894a
am: 717fca1d59

Change-Id: I15c12c940722bb6a810f86b039d9a3d2f0eadac4
2018-12-26 18:44:14 -08:00
Max Bires
717fca1d59 Merge "Adding check for HMAC/EC key size for StrongBox" am: ffee7d8ce0
am: f5992f894a

Change-Id: Ib360b46f5094d9c19769aacb8e193a2bfcf750ce
2018-12-26 18:30:40 -08:00
Max Bires
f5992f894a Merge "Adding check for HMAC/EC key size for StrongBox"
am: ffee7d8ce0

Change-Id: I21057e17c5de0d25b278c041fcd0b599bf143977
2018-12-26 18:13:08 -08:00
Nathan Harold
d51c624874 Merge "Fix BSIC Check in CellIdentityGsm" am: 7d615aae59 am: d34107b272
am: af24817935

Change-Id: Id5dd355ca403db506cf2c9fa93b1282b3c28db92
2018-12-26 18:13:05 -08:00
Nathan Harold
af24817935 Merge "Fix BSIC Check in CellIdentityGsm" am: 7d615aae59
am: d34107b272

Change-Id: I565c33a88a34950bb788a1c0af6f270342d8c79b
2018-12-26 18:03:35 -08:00
Treehugger Robot
ffee7d8ce0 Merge "Adding check for HMAC/EC key size for StrongBox" 2018-12-27 01:58:05 +00:00
Nathan Harold
d34107b272 Merge "Fix BSIC Check in CellIdentityGsm"
am: 7d615aae59

Change-Id: Id32a0b32a8ccbd4b580bde1a1722f2214830b205
2018-12-26 17:54:11 -08:00
Nathan Harold
7d615aae59 Merge "Fix BSIC Check in CellIdentityGsm" 2018-12-27 01:44:14 +00:00
Nathan Harold
b635fb8eb3 Fix BSIC Check in CellIdentityGsm
Because Java uses signed bytes, a comparison between
a byte and 0xFF will always fail after integer
promotion. Fix this by forcing 0xFF to be treated as
a byte for comparison.

Bug: 119224773
Test: fixes build breakage

Change-Id: I9615667a6b442060f1d43084d56bc9c3fdb3ba35
2018-12-27 01:40:40 +00:00
Lucas Dupin
c220f6d75f Merge "Do not show lock icon on AOD" 2018-12-27 01:02:25 +00:00
TreeHugger Robot
565cc45586 Merge "Fixing the flickering issue when clock is clicked in status bar to open Quick Settings." 2018-12-27 00:33:27 +00:00
Nathan Harold
1a3aa1b586 Merge "Refactor CellInfo Constructors" am: bd9da6de04 am: 1d2825ce8e
am: 47872bf7e5

Change-Id: Ief5578fa6a5020d553c4d2c64cce2066667bb65f
2018-12-26 15:51:03 -08:00
Lucas Dupin
78ba0168ec Merge "make wake event trigger a pulse" 2018-12-26 23:43:54 +00:00
Nathan Harold
47872bf7e5 Merge "Refactor CellInfo Constructors" am: bd9da6de04
am: 1d2825ce8e

Change-Id: I98f792d178813cc93c0123ba73486d3d18a4874f
2018-12-26 15:40:04 -08:00
Nathan Harold
1d2825ce8e Merge "Refactor CellInfo Constructors"
am: bd9da6de04

Change-Id: Id4958424a4a3d8b9e85b102b8ad8ad964d3ee7a2
2018-12-26 15:25:27 -08:00
Priyank Singh
523837cba9 Fixing the flickering issue when clock is clicked in status bar to open Quick Settings.
Adding the flag "Intent.FLAG_ACTIVITY_SINGLE_TOP" which will stop the activity to relaunch if its already there.

Bug: 121345477
Test: Manual
Change-Id: I83f985c83d4954a722591b59fc7f6db24a923923
(cherry picked from commit a9971e07144bfa7fde5f4ae2cd602efb8ff02fec)
2018-12-26 23:24:45 +00:00
Nathan Harold
bd9da6de04 Merge "Refactor CellInfo Constructors" 2018-12-26 23:07:53 +00:00
Lucas Dupin
978ce92aa6 Merge "Delete hollow pill flag" 2018-12-26 21:52:15 +00:00
TreeHugger Robot
51cf66745a Merge "MediaRecorder:edit javadoc for vorbis encoder" 2018-12-26 21:48:46 +00:00
TreeHugger Robot
89810b25c7 Merge "Fixes NPE on system app update" 2018-12-26 21:36:13 +00:00
Lucas Dupin
de64ee0126 make wake event trigger a pulse
Test: manual
Test: atest ScrimControllerTest
Bug: 111405682
Bug: 111395593
Change-Id: I5a7b9024ecd5aea691ac5e3f23e70818186fc37c
2018-12-26 13:28:41 -08:00
Lucas Dupin
f22194f5e8 Do not show lock icon on AOD
Bug: 111405682
Test: visual
Change-Id: I93f4ddaae37d5fa83d4358a1090bc30351ff2668
2018-12-26 13:00:25 -08:00
Jason Monk
ce441748ac Merge changes Ie7f66818,I7e91d12b,I0f44b3dd,I8625f3d3,I115c55af, ...
* changes:
  Remove Dependency.get usages from LightBarController
  Remove Dependency.get usages from NotificationLogger
  Remove Dependency.get usages from OverviewProxyService
  Remove Dependency.get usages from BubbleController
  Remove Dependency.get usages from BatteryControllerImpl
  Remove Dependency.get usages from BluetoothControllerImpl
  Remove Dependency.get usages from DeviceProvisionedController
  Remove Dependency.get usages from HotspotControllerImpl
  Remove Dependency.get usages from RemoteInputQuickSettingsDisabler
  Remove Dependency.get usages from SecurityControllerImpl
  Remove Dependency.get usages from UserSwitcherController
  Remove Dependency.get usages from SmartReplyController
  Reduce usages of Dependency.get in TunablePadding
  Remove Dependency.get usages from TunerServiceImpl
  Remove Dependency.get usages from GarbageMonitor
2018-12-26 20:42:38 +00:00
Lucas Dupin
55b655c881 Delete hollow pill flag
Bug: 111405682
Test: compile, enter AOD, unlock
Change-Id: Iff2054420844099fdbb879ecef9af6ee218383b9
2018-12-26 19:49:43 +00:00
Gopalakrishnan Nallasamy
2675ac3c16 MediaRecorder:edit javadoc for vorbis encoder
MediaRecorder.AudioEncoder has unsupported VORBIS audio encoder constant declared. Edited javadoc
comment for the same as optional support.

Bug: 120211083

Test: make offline-sdk-docs
      - edited comment visible in MediaRecorder.AudioEncoder.html#VORBIS

Change-Id: I3294d9a768a8f439579f238ee2f1db93f20bc178
2018-12-26 11:48:41 -08:00
Patrick Baumann
75a5c60644 Fixes NPE on system app update
When updating a system app, a recent code change resulted in trying to
read the parsed package from a @Nullable field without first checking
for the null case. We have access to the package from the original scan
request and so this change just fetches it from there.

Change-Id: Ieeb4d7f94db23adea64bca7fb982f473cc0a40fe
Fixes: 121411453
Fixes: 121455797
Test: Wait for and observe successful GMS Core update
2018-12-26 11:44:50 -08:00
Lucas Dupin
bb9b195729 Merge "Fix issue where media icon cannot be loaded" 2018-12-26 19:43:37 +00:00
Jason Monk
e8e471db14 Remove Dependency.get usages from LightBarController
Test: atest SystemUITests
Change-Id: Ie7f6681809794bdedd76be57c50dfde6e0dffc3c
2018-12-26 13:18:19 -05:00
Jason Monk
d97204c986 Remove Dependency.get usages from NotificationLogger
Test: atest SystemUITests
Change-Id: I7e91d12be282bf6de615830aa813208018c74f33
2018-12-26 13:18:19 -05:00
Jason Monk
96a37f4f36 Remove Dependency.get usages from OverviewProxyService
Test: atest SystemUITests
Change-Id: I0f44b3ddf145eb4f5f7c5032a91c73e2bcb96d57
2018-12-26 13:18:18 -05:00
Jason Monk
92d5c24e70 Remove Dependency.get usages from BubbleController
Test: atest SystemUITests
Change-Id: I8625f3d3b3078e60e90145be77f286bfaacb8ed6
2018-12-26 13:18:18 -05:00
Jason Monk
de48d5df49 Remove Dependency.get usages from BatteryControllerImpl
Test: atest SystemUITests
Change-Id: I115c55af157410fccbf13db326ca246993cbb6e0
2018-12-26 13:18:18 -05:00
Jason Monk
8111bccc42 Remove Dependency.get usages from BluetoothControllerImpl
Test: atest SystemUITests
Change-Id: I5dd95d8ae7e319c74b6d96109d87f45d38c7e084
2018-12-26 13:18:18 -05:00
Jason Monk
cfa61ff2c9 Remove Dependency.get usages from DeviceProvisionedController
Test: atest SystemUITests
Change-Id: I3a8cd6e9802987f019dea5f402dac494f11f16c8
2018-12-26 13:18:18 -05:00
Jason Monk
b7d50a7999 Remove Dependency.get usages from HotspotControllerImpl
Test: SystemUITests
Change-Id: I3e4cbf81e95dd1b141bb32cee2941556e1c8b47e
2018-12-26 13:18:18 -05:00
Jason Monk
eeff95b1d7 Remove Dependency.get usages from RemoteInputQuickSettingsDisabler
Test: atest SystemUITests
Change-Id: I48268665e28cd0b2739a2f1eb8012e705c4868ea
2018-12-26 13:18:18 -05:00
Jason Monk
61936ee3d6 Remove Dependency.get usages from SecurityControllerImpl
Test: atest SystemUITests
Change-Id: Ieb42cd2bc45076ffee12c54154857642e95b4d58
2018-12-26 13:18:18 -05:00
Jason Monk
03561a8f25 Remove Dependency.get usages from UserSwitcherController
Test: atest SystemUITests
Change-Id: I2ebfee7986725ef1535798551591dced08f39118
2018-12-26 13:18:18 -05:00
Jason Monk
752c68fac1 Remove Dependency.get usages from SmartReplyController
Test: atest SystemUITests
Change-Id: I552075b4bb6165adcb8363b2c21dff4770f1ba2d
2018-12-26 13:18:18 -05:00
Jason Monk
b1a5f23eec Reduce usages of Dependency.get in TunablePadding
Test: atest SystemUITests
Change-Id: I8c99e71852d1dc572e262cf7bf722df316251f80
2018-12-26 13:18:11 -05:00
Lucas Dupin
2955bf1ec0 Fix issue where media icon cannot be loaded
Change-Id: Ie429cbb3e03674522bdc465cc630f44f12073983
Fixes: 121457418
Test: manual
2018-12-26 10:15:51 -08:00