Commit Graph

9038 Commits

Author SHA1 Message Date
Stevie Kideckel
d663b5b081 Merge "Fix some potential nullability issues in RemoteViews" into sc-dev am: cda49ca089
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14186226

Change-Id: If0951e234485bb5ef8918a78278bec3db2703a01
2021-04-27 20:20:40 +00:00
Stevie Kideckel
cda49ca089 Merge "Fix some potential nullability issues in RemoteViews" into sc-dev 2021-04-27 20:10:27 +00:00
Stevie Kideckel
957a33fe0a Fix some potential nullability issues in RemoteViews
Test: Ran locally on device, all sample widgets still worked
Test: atest RemoteViewsTest
Bug: 185316709

Change-Id: I60c235ea196dd106325e79962e545c582a975168
2021-04-27 13:44:26 +00:00
Qi Wang
630fce52f4 Merge "Validate spell checker suggestions before applying." into sc-dev am: 0ebb4d88a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14305127

Change-Id: If179741ff15268b771de5404b3cff5702151b0ac
2021-04-27 06:49:29 +00:00
Qi Wang
0ebb4d88a1 Merge "Validate spell checker suggestions before applying." into sc-dev 2021-04-27 06:26:43 +00:00
TreeHugger Robot
5fc5597b29 Merge "Fix Magnifier position updates" into sc-dev am: 400dc92ebe
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14312828

Change-Id: I2a190086d75790d8f00a332c9b709c4014d4445d
2021-04-26 22:46:25 +00:00
TreeHugger Robot
400dc92ebe Merge "Fix Magnifier position updates" into sc-dev 2021-04-26 22:27:40 +00:00
Vishnu Nair
f752c800d3 Fix Magnifier position updates
When the magnifier content moves relative to the parent surface,
it will call setPosition on the content surface control. This conflicts
with position updates called by the BlastBufferQueue adapter
causing a flicker on screen. Fix this by providing a wrapper surface
to BlastBufferQueue adapater to send buffer updates.

Fixes: 186072574
Test: Select text and see magnifier surface does not flicker or move
around

Change-Id: Idfcc06a5d90f400f69e5cbe91008a0cb59fd4646
2021-04-26 10:27:50 -07:00
Qi Wang
cfa318ee4d Validate spell checker suggestions before applying.
Fix: 185786752
Test: atest CtsInputMethodTestCases:SpellCheckerTest
Change-Id: Icf447fc3ab174bc17af0e823b830f5abef6071df
2021-04-26 10:06:37 +08:00
Chun-Yi Lee
f704e7cc7b Merge "Move CtsAutoFillServiceTestCases to group presubmit-large" into sc-dev am: 6a213319a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14264393

Change-Id: Ib29130fd8ca1f1cfbc97f272f29d04cac0e16c2a
2021-04-22 11:36:20 +00:00
Chun-Yi Lee
6a213319a8 Merge "Move CtsAutoFillServiceTestCases to group presubmit-large" into sc-dev 2021-04-22 11:11:55 +00:00
Stevie Kideckel
964eed7e6b Merge "Expose GridView/Layout APIs via @RemotableViewMethod" into sc-dev am: 32b16fa4fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14251395

Change-Id: I4a8c57ba68a5dbf99fd4970d7052a25feb9449a0
2021-04-22 09:51:26 +00:00
Stevie Kideckel
32b16fa4fc Merge "Expose GridView/Layout APIs via @RemotableViewMethod" into sc-dev 2021-04-22 09:33:43 +00:00
easoncylee
e9f67379be Move CtsAutoFillServiceTestCases to group presubmit-large
The test config takes longer than 15mins to run. Move it to a dedicated
group for running slow presubmit Test Mapping test.

Some more context is in the referenced bug, e.g, b/174495337
The group will work exactly the same as presubmit for now.

Bug: 174654670
Bug: 174495337
Test: none
Change-Id: I946061e2c5a75b12ca370d172db32a8f7e8e8f68
2021-04-21 13:24:07 +00:00
Stevie Kideckel
9f8a7db5f9 Expose GridView/Layout APIs via @RemotableViewMethod
Bug: 185972660
Test: Built and ran locally, annotation change only

Change-Id: I85fc00ae62b124653e20fd53f9179493463933e0
2021-04-21 09:20:25 +00:00
Joanne Chung
e64b5a54dd Merge "API feedback: Translation View API refinement." into sc-dev am: be20ca46f6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14127344

Change-Id: I42e0fc736b980ca8297a848c3ce90dfcea96351d
2021-04-21 00:30:54 +00:00
Joanne Chung
be20ca46f6 Merge "API feedback: Translation View API refinement." into sc-dev 2021-04-21 00:29:24 +00:00
TreeHugger Robot
03a40cfe4e Merge "Revert^2 "Introduce SpellCheckerSessionParams."" into sc-dev am: 32e08f8b0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14250992

Change-Id: I0e6f373e197324bbe9535ef5a99d5ae58b405a1e
2021-04-20 17:01:19 +00:00
TreeHugger Robot
32e08f8b0d Merge "Revert^2 "Introduce SpellCheckerSessionParams."" into sc-dev 2021-04-20 16:45:50 +00:00
Kohsuke Yatoh
d4e3278b3e Revert^2 "Introduce SpellCheckerSessionParams."
Updated test added in commit 7000b5f89d8c43af5ccd116c1840ea89dd9f17dc

Bug: 179804789
Change-Id: I48c744815662cabcbef8e823916b1e6bba9c9b17
2021-04-20 14:28:56 +00:00
Jeff DeCew
09dfdfe946 Merge "Allow passing 0 to RemoteViews.setDimen() or setAttr()" into sc-dev am: 5e7b103e14
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14191410

Change-Id: I03667edb0e857f53501a5f9e2a87631cf253892b
2021-04-20 13:47:35 +00:00
Jeff DeCew
5e7b103e14 Merge "Allow passing 0 to RemoteViews.setDimen() or setAttr()" into sc-dev 2021-04-20 13:44:38 +00:00
TreeHugger Robot
47ea726e85 Merge "Ensure that the root view is an AppWidgetHostView in setRemoteAdapter" into sc-dev am: 6ba89099f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14206221

Change-Id: I0928eeb2579a1a20a1da483186932f705e90775a
2021-04-20 11:47:21 +00:00
TreeHugger Robot
6ba89099f8 Merge "Ensure that the root view is an AppWidgetHostView in setRemoteAdapter" into sc-dev 2021-04-20 11:33:59 +00:00
Yi-yo Chiang
c04eba506a Merge "Revert "Introduce SpellCheckerSessionParams."" into sc-dev am: ea80476aa4
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14234776

Change-Id: I2770fd55d10e8762e3377f7102874aed20ba82c5
2021-04-20 04:46:22 +00:00
Yi-yo Chiang
ea80476aa4 Merge "Revert "Introduce SpellCheckerSessionParams."" into sc-dev 2021-04-20 04:41:45 +00:00
Yi-yo Chiang
cef2817d90 Revert "Introduce SpellCheckerSessionParams."
Revert "Use SpellCheckerSessionParams in CTS."

Revert submission 14191185-ky-tsm

Reason for revert: breaks build test_suites_x86_64 b/185855437
Reverted Changes:
I724aaad15:Introduce SpellCheckerSessionParams.
I510a4cfec:Use SpellCheckerSessionParams in CTS.

Change-Id: I4173bd5bee62f02a248de69df77420c39326b9f0
2021-04-20 03:57:05 +00:00
Kohsuke Yatoh
d5ea4714fe Merge "Introduce SpellCheckerSessionParams." into sc-dev am: 93528b8f5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14191185

Change-Id: Icf37d922d1995d8a0442d6ced81d77890691d805
2021-04-20 03:31:42 +00:00
Joanne Chung
f6a52811a1 API feedback: Translation View API refinement.
Bug: 178046780
Test: manual
Test: atest android.translation.cts.UiTranslationManagerTest
CTS-Coverage-Bug: 177960696

Change-Id: I557ca4b3b4e7324af12e81dd8b5ac8a04a17b6b8
2021-04-20 11:14:22 +08:00
Kohsuke Yatoh
93528b8f5b Merge "Introduce SpellCheckerSessionParams." into sc-dev 2021-04-20 03:06:40 +00:00
Ahaan Ugale
dbecc1a2bf Merge "AutoTranslate: Pad view text for compatibility reasons." into sc-dev am: 1281143a36
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14206887

Change-Id: I7958851096e91784f49463c04f238b5a3af54c56
2021-04-19 05:41:34 +00:00
Kohsuke Yatoh
94635fcb89 Introduce SpellCheckerSessionParams.
SpellCheckerSessionParams encapsulates parameters for
TextServicesManager#newSpellCheckerSession().

Bug: 179804789
Test: atest CtsInputMethodTestCases:SpellCheckerTest
Change-Id: I724aaad15b0a4bd38f6a24585c4c45cfeee5b499
2021-04-17 22:49:25 +00:00
Ahaan Ugale
7110641881 AutoTranslate: Pad view text for compatibility reasons.
Some apps operate on the view text based on layout calculations made on
the transformed text. This can cause issues (even crashes) if the
transformed text is longer than the original, as is often the case with
Translate. A previous temporary fix,
I685ae4a9752c817db81f0d736f1d746b2e4a9839, ellipsized the translated
text. This change fixes it properly by instead padding the original
text.

A followup change will make this controllable by API instead of padding
every TextView.

The en space character, U+2002, is used for the padding here. It seems
to work well in practice for multiple languages. We don't make this
configurable through API as it could make debugging harder (issues
triggered by server-side changes).

Bug: 179693024
Test: atest CtsTranslationTestCases
Test: manual - toggling between original and translated, scrolling, new
 views appearing, multiple apps
Change-Id: I9d7db5d2bc200e4042baf3267796f00cfc298f19
2021-04-16 19:38:28 -07:00
Jeff DeCew
208b1b1b69 Allow passing 0 to RemoteViews.setDimen() or setAttr()
Bug: 185488522
Test: atest RemoteViewsTest
Change-Id: I535e44a431701e68edcfaf527e326fd0e769b16a
2021-04-16 13:08:40 -04:00
Stevie Kideckel
fb2df70041 Ensure that the root view is an AppWidgetHostView in setRemoteAdapter
Bug: 185367016
Test: atest RemoteViewsFixedCollectionAdapterTest

Change-Id: I77d866157e97c4507243dbc2cd5411384f885458
2021-04-16 10:03:06 +00:00
Michel Comin Escude
50d2b9318b Merge "Fixed and decreased isAtEquilibrium thresholds" into sc-dev am: 219106593d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14181134

Change-Id: Id0a2d08b06ced7a27036e390b8356ccffa77ac66
2021-04-14 18:06:46 +00:00
Michel Comin Escude
219106593d Merge "Fixed and decreased isAtEquilibrium thresholds" into sc-dev 2021-04-14 18:03:18 +00:00
Joanne Chung
a7f77e045c Merge "Add debug log to help to debug translation problem." into sc-dev am: bef7481684
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14159586

Change-Id: Ia1147a8c7ea5109a51936066d258665cf3c4b014
2021-04-14 16:55:03 +00:00
Joanne Chung
bef7481684 Merge "Add debug log to help to debug translation problem." into sc-dev 2021-04-14 16:27:31 +00:00
Michel Comin Escude
6e0fa3641e Merge "Added velocity scalar and updated spring values" into sc-dev am: ce30625d47
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14179248

Change-Id: I846fec20b9ba87b48f7e7cd96aaf8dcac2c3ccb6
2021-04-14 15:29:22 +00:00
Michel Comin Escude
0ca911f5f8 Added velocity scalar and updated spring values
Updated spring values to the latest ones agreed in design. In addition,
added a velocity multiplier that only affects after it absorbs an impact
at the scroll boundary. This will help to increase the spring behavior
when we fling the content, but keeping it controlled when we pull and
release.

Bug: 183768138
Test: ran EdgeEffectTest and visual
Change-Id: I4ed7b01dd42a9a5adda637917369c349a6ae2f76
2021-04-14 03:07:53 +00:00
Michel Comin Escude
0c81801f9e Fixed and decreased isAtEquilibrium thresholds
Distance and speed were multiplied by LINEAR_STRETCH_INTENSITY which is
not directly related to speed and and distance. Moreover the velocity
threshold was a little bit high (1/0.016, wich means 62 pixels/second)
and the distance as well (1 is ok if there's no scale but since there's
some stretching the difference was being magnified).

Bug: 184892316
Test: EdgeEffectTests and visual
Change-Id: Ibd7adb16d1d00df0ab6e96132bfe96a4fa4d45dc
2021-04-13 18:50:22 -07:00
Nader Jawad
7031958062 Merge "Adjusted interpolation and stretch intensity" into sc-dev am: e178f50356
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14172974

Change-Id: I7011f885abf6cac692f9826d68f2aa50c0c65188
2021-04-13 22:41:00 +00:00
Nader Jawad
e178f50356 Merge "Adjusted interpolation and stretch intensity" into sc-dev 2021-04-13 22:11:11 +00:00
Michel Comin Escude
9ed86141f2 Adjusted interpolation and stretch intensity
Updated stretch intensity to 0.016 and added a new uniform to control
the intensity of the interpoloation

Bug: 183768138
Test: ran EdgeEffectTest and visual
Change-Id: Iac10bee5980802fffe838ed83e02b7c41dee6f71
2021-04-13 12:30:51 -07:00
Pierre Barbier de Reuille
943d63d41d Merge "Add attribute setters for RemoteViews" into sc-dev am: bc9e66e108
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14160186

Change-Id: I8c0ed136bd22898c32fdaf86f7627ad36574ec9c
2021-04-13 17:16:19 +00:00
Pierre Barbier de Reuille
bc9e66e108 Merge "Add attribute setters for RemoteViews" into sc-dev 2021-04-13 17:10:24 +00:00
Pierre Barbier de Reuille
11d243e01c Add attribute setters for RemoteViews
This implements go/remoteviews-attribute-setters

Bug: 184931139
Test: atest CtsWidgetTestCases:RemoteViewsTest
Change-Id: I135ab857d3a3a52bbb02ee3226e2bf723d8c916a
2021-04-13 09:49:34 +01:00
Joanne Chung
8960d6667b Add debug log to help to debug translation problem.
There are some issues the resume/finish seems not work well. The
debug flag should be enabled manually, but in the most time the
user may forget to enable it before testing. Try to enable it in the
debug rom to help debugging, we use b/182433547 to trace the disable
this check before rom release.

Bug: 182433547
Test: manual
Change-Id: I2f85a0e17f8a2b8a4b93252044cf48d739b4eca2
2021-04-13 13:58:03 +08:00
Ahaan Ugale
d88fae8ed9 Merge "Fix UiTranslation for ListView." into sc-dev am: 44dccdbe1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14064892

Change-Id: I8634683d1373e25cd8dd5dce52430a9649d3a1b1
2021-04-13 02:18:07 +00:00