Commit Graph

378526 Commits

Author SHA1 Message Date
Treehugger Robot
ceea877ddd Merge "[view-compiler] Add layout validation" 2018-12-17 21:28:37 +00:00
Chen Xu
18b925a7af Merge "expose Carrier Id related APIs" 2018-12-17 20:56:54 +00:00
Pengquan Meng
d0c404cb21 Merge "Add FrequencyRange comparator to ServiceState" 2018-12-17 19:07:27 +00:00
Chen Xu
610673690c Merge "public API for VideoProfile.CameraCapability with zoom" 2018-12-17 18:24:15 +00:00
Treehugger Robot
88f0e734b7 Merge "[view-compiler] DexBuilder: Add more instructions" 2018-12-17 18:15:11 +00:00
Treehugger Robot
1c3592a865 Merge "Remove uses of libcore.io DropBox and EventLogger" 2018-12-17 15:17:37 +00:00
Paul Duffin
bf76cf7c82 Remove uses of libcore.io DropBox and EventLogger
DropBox and EventLogger provide hooks for use by framework to intercept
messages sent by libcore. However, neither of these mechanisms are
actually used by libcore so there is no point in framework code using
it.

(cherry picked from commit ecb6124d54)

Bug: 119748341
Test: make checkbuild, flash
Merged-In: I9dbd1b6dea92f7441efb6d0a579efd13bc0e5139
Change-Id: I65425e49ab9ad9752b65772d27f788d1a674eeff
2018-12-17 12:10:11 +00:00
Treehugger Robot
a4d036e98b Merge "fd_utils: carry over O_CLOEXEC on duplicated FDs" 2018-12-17 07:43:34 +00:00
Treehugger Robot
783ec04909 Merge changes from topic "statsd-allow-bytes-type"
* changes:
  Add byte size of the bytes fields to statslog c++ APIs.
  Skip writing message field in an atom if it's empty
  Adding tests and move launcher.proto
  Add launcher.proto to atoms.proto
  Allow atoms to log fields in bytes format.
2018-12-17 02:33:20 +00:00
Yao Chen
d66ecfccf6 Add byte size of the bytes fields to statslog c++ APIs.
The proto binary data can contain '\0's and in the native layer,
the current liblog api would convert that into string and thus
the data is truncated.

This CL adds a "size_t bytes_field_len" after the bytes fields so that
we can correctly pass the data from JAVA to native.

Java StatsLog.write() APIs remain the same

Bug: 120635548
Test: test_drive with atom 103
Change-Id: I34f1c4ddd6a4ec5f3604b0c67a47a5399e3c6ddd
Merged-In: I34f1c4ddd6a4ec5f3604b0c67a47a5399e3c6ddd
(cherry picked from commit 1fe9f59498)
2018-12-15 13:52:47 -08:00
Yao Chen
2822b4f42f Skip writing message field in an atom if it's empty
Test: unit test added
Bug: 120635548
Change-Id: I825b1ce526944a20fe65705508ad180ece37492c
Merged-In: I825b1ce526944a20fe65705508ad180ece37492c
(cherry picked from commit 8e6f998300)
2018-12-15 13:52:27 -08:00
Yao Chen
046b51295e Adding tests and move launcher.proto
Test: statsd_test
Bug: 120635548
Change-Id: I0655f70098d78f8f6dc9381921c4a687d2195bd4
Merged-In: I0655f70098d78f8f6dc9381921c4a687d2195bd4
(cherry picked from commit 8c43386145)
2018-12-15 13:52:06 -08:00
Hyunyoung Song
cc651c118e Add launcher.proto to atoms.proto
Test: blank
Bug: 113043444
Bug: 120635548
Change-Id: I7e0e72cdf68dcf195188dbab8fe2567fcbd5964e
Merged-In: I7e0e72cdf68dcf195188dbab8fe2567fcbd5964e
(cherry picked from commit c6d6b77ddc)
2018-12-15 13:51:39 -08:00
Yao Chen
8b71c74894 Allow atoms to log fields in bytes format.
There are an increasing number of requests to log data in complex format to statsd, while the data
is not expected to be parsed or aggregated by statsd and only to be uploaded as events.

Instead of making an exception for each of these cases in a hard coded way, this CL add a feature to
annotate these field in atoms.proto and the stats-log-api-gen tool will produce byte array
interfaces for them.

Note that log_msg does not have byte array type, and only has string type, when statsd receives the
log, these fields are in string type. Only when the atom is written to proto, we will check if this
field should be bytes field and write it to protobuf in message format.

Change-Id: If53dd95c5826710c76d7fe982bf951a435dfc738
Merged-In: If53dd95c5826710c76d7fe982bf951a435dfc738
Fix: 118386797
Bug: 120635548
Test: unit test & manual test
(cherry picked from commit bbdd67d19f)
2018-12-15 13:51:08 -08:00
Nick Kralevich
d9765a4cc0 fd_utils: carry over O_CLOEXEC on duplicated FDs
Due to b/30963384, every time zygote creates a new child, zygote reopens
all existing file descriptors, taking careful measures to preserve the
file status flags, file descriptor flags, and seek offset. However, dup2
resets the sole file descriptor flag (FD_CLOEXEC) on duplication,
defeating the hard work done to preserve the flag.

From "man dup"

  NAME
    dup, dup2, dup3 - duplicate a file descriptor

  DESCRIPTION
    The dup() system call creates a copy ...
    ...
    The two file descriptors do not share file descriptor flags
    (the  close-on-exec flag).  The close-on-exec flag
    (FD_CLOEXEC; see fcntl(2)) for the duplicate descriptor is off.
    ...
    The  dup2() system call performs the same task as dup() ...

Use dup3 instead to allow us to preserve the FD_CLOEXEC status.

Bug: 120983106
Test: Android compiles and boots
Change-Id: Idbb27c83092f30d8394c254cfbdf33406f74eb94
2018-12-14 21:34:44 -08:00
Treehugger Robot
1d709c965b Merge "api/current.txt: Add SOCK_CLOEXEC and SOCK_NONBLOCK" 2018-12-15 00:26:55 +00:00
chen xu
055b1de272 public API for VideoProfile.CameraCapability with zoom
Bug: 120796998
Test: Build & CTS videoprofiletest
Change-Id: I12b3d1c510065666e2fdf5186d924e657f66d039
2018-12-14 15:27:31 -08:00
Jack Yu
47d385a5b3 Merge "Renamed data/net service provider onDestroy to close" 2018-12-14 23:24:06 +00:00
Pengquan Meng
424acc7f57 Add FrequencyRange comparator to ServiceState
The FrequencyRange is not comparable beucase it's an enum. This change
add a comparator to ServiceState to make the enum comparable.

Bug: 111453000
Test: atest FrameworksTelephonyTests
Merged-In: I59a595bdaf5451d2c4d95b1b5bdfefcba123fea7
Change-Id: I59a595bdaf5451d2c4d95b1b5bdfefcba123fea7
2018-12-14 14:49:18 -08:00
Adrian Roos
94becc7b4f Merge "API: Enable UnhiddenSystemApi check for frameworks/base" 2018-12-14 18:36:55 +00:00
Eric Holk
3cbf176e7c [view-compiler] Add layout validation
Layout validation walks over a layout resource and verifies that the layout only
uses features the layout compiler supports.

Currently this means we reject layouts that use any of the following tags:
  * include
  * fragment
  * merge
  * view

In the future, we will extend the layout compiler to handle these, but for now
we want to be liberal in what we reject.

Bug: 111895153
Test: atest view-compiler-tests
Change-Id: I8dca30c035a83b6763497a36fc60c68438fa1b0c
2018-12-14 09:36:14 -08:00
Eric Holk
c69449d95c [view-compiler] DexBuilder: Add more instructions
This CL adds the ability to generate code that calls static and virtual methods
which return objects, as well as the not-equal-to-zero comparison operator.

Bug: 111895153
Change-Id: I4ae9b3cb2edc6540671112b73c02bf6380d23051
2018-12-14 09:14:12 -08:00
Tyler Gunn
c3275b673c Merge "Update CallScreeningService API docs." 2018-12-14 15:06:53 +00:00
Adrian Roos
c6e2fc87ac API: Enable UnhiddenSystemApi check for frameworks/base
Test: m checkapi
Bug: 115333477
Change-Id: I84d454f3495d7ab8e5f0bc2e4c24725f1cd2324f
2018-12-14 13:45:05 +00:00
Jack Yu
cd67c02f1c Renamed data/net service provider onDestroy to close
Renamed them to avoid confusion with Android services'
onDestroy().

Test: Telephony sanity tests
Bug: 73659459
Change-Id: I05f68ced65498d6bfeb9e3c9ed3fb6164643bbaa
2018-12-14 00:22:02 -08:00
Luke Huang
d274332a9d Merge "Covert list<String> into String[] in INetd" 2018-12-14 05:57:34 +00:00
Aaron Huang
b11a084ebc Merge "apf: Drop ARP reply if SPA is 0.0.0.0" 2018-12-14 03:00:21 +00:00
Chen Xu
d2a163ad38 Merge "move and rename DcFailCause to DataFailCause" 2018-12-14 02:44:20 +00:00
Treehugger Robot
b5278998c7 Merge changes from topic "schematize_car_props"
* changes:
  Fix missing schematized Car system properties
  Schematize Car system properties
2018-12-14 01:31:29 +00:00
Nick Kralevich
ed4522b9a0 api/current.txt: Add SOCK_CLOEXEC and SOCK_NONBLOCK
Android makes the function socketpair() publicly visible, but never made
SOCK_CLOEXEC nor SOCK_NONBLOCK visible. Java socketpair() users have no
approved flag to ensure sockets are immediately created with O_CLOEXEC,
nor set the non-blocking status on sockets.

socketpair() documentation:
https://developer.android.com/reference/android/system/Os.html#socketpair(int,%20int,%20int,%20java.io.FileDescriptor,%20java.io.FileDescriptor)

Test: compiles
Bug: 120983106
Change-Id: Id7d1c853f3b00d6766ecf6dd88141da136011d6b
2018-12-13 16:07:20 -08:00
Youming Ye
97ee6295e9 Merge "Propagation of additional Ims Call Fail Causes" 2018-12-13 23:47:49 +00:00
chen xu
1afc47b154 move and rename DcFailCause to DataFailCause
Bug: 119891533
Test: Build
Change-Id: I6f0e474a9ee3f8befc8b0a221713a2080b59844c
Merged-in: I6f0e474a9ee3f8befc8b0a221713a2080b59844c
2018-12-13 12:54:38 -08:00
Sahin Caliskan
4929a0d782 Merge "Move RCS APIs to android.telephony.ims" 2018-12-13 20:48:34 +00:00
Treehugger Robot
cb61d10c90 Merge "Add back doc-comment-check-docs back to checkbuild." 2018-12-13 19:10:07 +00:00
Elliott Hughes
36c37f3ceb Merge "No-one should need libunwind in 2018..." 2018-12-13 17:48:41 +00:00
Philip P. Moltmann
657d612206 Merge "Add me to privapp-permissions owner file" 2018-12-13 16:53:39 +00:00
Sahin Caliskan
7719db2b16 Move RCS APIs to android.telephony.ims
This is due to being compatible with other RCS related changes by by other engineers.
Test: Existing tests pass

Bug: 109759350
Change-Id: Id56df22e9c313c5e0700eda3b2c489d2f84ea0cd
Merged-In: Id56df22e9c313c5e0700eda3b2c489d2f84ea0cd
2018-12-13 16:50:28 +00:00
Mark Chien
d9eeba6fd1 Merge "Track default upstream when system is ready" 2018-12-13 13:28:08 +00:00
Adrian Roos
a48e431113 Merge "API: Clean up redundant and ineffective usages of SystemApi and TestApi (2/2)" 2018-12-13 13:19:25 +00:00
Treehugger Robot
bee9a87193 Merge "Pass package name as part of startDiscovery" 2018-12-13 12:42:58 +00:00
markchien
a6c7287f41 Track default upstream when system is ready
Start tracking default upstream from boot.This is useful for
entitlement refine in following change. EntitlementManager can
decide if it needs to process entitlement provisioning before
tethering started.

Test: -atest FrameworksNetTests
      -build, flash, booted
      -manually turnoff/on tethering with different upstream
bug: 111490073

Change-Id: I8fdbd64c52f26b5363693bb5bd8050930e8ea961
2018-12-13 19:01:51 +08:00
Youming Ye
da9de2d7fa Merge "Fix property setting with failure" 2018-12-13 06:55:25 +00:00
Treehugger Robot
a32f898720 Merge "DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master" 2018-12-13 05:45:20 +00:00
Inseob Kim
ae3056f444 Fix missing schematized Car system properties
Properties accessed across partitions are now schematized and will
become APIs to make explicit interfaces among partitions.

Bug: 117924132
Test: mma -j
Change-Id: Ib698d64d93a7bf4c1d9b7d8b883009b8de65ed09
2018-12-13 14:07:31 +09:00
Inseob Kim
f9194ebacd Schematize Car system properties
Properties accessed across partitions are now schematized and will
become APIs to make explicit interfaces among partitions.

Bug: 117924132
Test: mma -j
Change-Id: I203861a78f48529434595c2e923c03d58b7e8299
Merged-In: I203861a78f48529434595c2e923c03d58b7e8299
2018-12-13 14:06:03 +09:00
Zach Johnson
57e6e90204 Pass package name as part of startDiscovery
Test: manual
Bug: 118347252
Change-Id: Icbc2e7e756b16ffd181924b586a0292c2bf32ec5
2018-12-12 20:33:09 -08:00
Treehugger Robot
e726c2654d Merge "Delete unused import" 2018-12-13 03:39:11 +00:00
Aaron Huang
0d9b942292 Merge "Add an APF unit test to drop all packets in the pcap file" 2018-12-13 03:05:56 +00:00
Jesse Fuentes
b9c35c1c0c Propagation of additional Ims Call Fail Causes
-Added new ImsReasonInfo error codes
-Add the new error codes in system-current.txt

Test:Manual
Bug:115925183

Change-Id: Id10651d08de2b77f0562e3c8733be76032a9611e
2018-12-12 17:49:50 -08:00
Treehugger Robot
f53c398133 Merge "Switch to metalava" 2018-12-13 01:46:54 +00:00