Commit Graph

8434 Commits

Author SHA1 Message Date
Nathan Harold
bf3fff073f Deprecate CellLocation#requestLocationUpdate
Remove this method, which is undesirable, has unfortunate
side effects, and which is a worse way of getting the current
location than other methods such as TelephonyManager#getAllCellInfo()
(since KK) and TelephonyManager#requestCellInfoUpdate() (since QT/11).

Bug: 152648516
Test: make update-api && make (docstring-only change)
Change-Id: I3c7d345abcdd8c35cf539d33166ddf76ba987b1c
2020-07-06 13:54:42 -07:00
Nathan Harold
0459eb7cdc Remove Support for Deprecated Location Updating
Remove support for location update control that impacts
the services state tracker. This functionality hasn't been
needed in many years, and it has the ability to:
-consume additional battery
-cause ServiceState to be reported incorrectly
-cause the phone to not know about changes to
 the service state (current cell, technology, etc).

Bug: 152648516
Test: compilation - code removal only
Change-Id: I1bf880c037b5c005bdd61a0ff6f5c4000ec2f9be
2020-07-06 13:54:20 -07:00
Nathan Harold
32deda2df3 Add Location Checks on CellLocation#requestLocationUpdate
Update CellLocation#requestLocationUpdate to pass the necessary
information to do soft location permission checks and bill
modem battery usage against the caller of the API.

Bug: 152648516
Test: atest CellLocationTest
Change-Id: Id9e354538953ef93193a937a834e5890e62ecebd
2020-07-06 13:54:15 -07:00
Daniel Bright
62e4a9516d Merge "Call on urls changed callback when callback added" 2020-06-30 22:11:43 +00:00
Amit Mahajan
d9b216af12 Remove spammy log line.
Test: TH
Bug: 157172358
Merged-in: Ib76bd317bdd21ef6c1272d38f102f8e40b66d9b8
Change-Id: Ib76bd317bdd21ef6c1272d38f102f8e40b66d9b8
(cherry picked from commit 5c5635ac7d)
2020-06-29 15:51:53 -07:00
Daniel Bright
7310da73a0 Call on urls changed callback when callback added
Now calling onSubscriberAssociatedUriChanged on IImsRegistrationCallback
when the callback is first added to ImsRegistrationImplBase.

Bug: 159301697
Test: Made phone call
Test: Added unit test
Change-Id: Ibfcb8aaae9d410a09ec98e57d77eccd34fcc222f
Merged-In: Ibfcb8aaae9d410a09ec98e57d77eccd34fcc222f
2020-06-29 14:41:30 -07:00
Nathan Harold
ed7cf992a0 Merge "Abort NetworkScans when Phone Process Crashes" 2020-06-26 22:12:28 +00:00
Makoto Onuki
a11035a7eb Remove unnecessarily @System/TestApi annotations
We can't expose APIs if the enclosing class is hidden, so these
annotations are redundant. We need to remove them so that we can enable the
check.

Exempt-From-Owner-Approval: Cherry-pick from goog/master
Bug: 159121253
Test: treehugger (i.e. this shouldn't trigger "API has changed" error.)
Merged-in: Ie1841a670bdf6c6f4b25a1fc5deed8ec2d18cda2
Change-Id: I36e3562b72e64b51e4febd1d42a3bc8e4dc60988
2020-06-24 20:49:20 +00:00
Nathan Harold
e9d38721db Abort NetworkScans when Phone Process Crashes
If the phone process crashes during a network scan, today
the scan hangs indefinitely. This CL adds a binder death
recipient to the wakefulness binder so that if the phone
process crashes, we detect it and cancel the scan.

Because there's no error code for "Telephony crashed" today,
the closest error code is to say that the modem is unavailable.

In addition, fix an issue where onError() did not actually remove
scans from the list of cached scans. This left dangling scan
objects in the cache after an error.

Bug: 155853346
Test: manual -
      1) start scan
      2) crash phone process
      3) verify error is returned to scan request
Change-Id: I8bd3823805fcc68623a685848517f2d11555e9c7
2020-06-24 18:35:41 +00:00
Treehugger Robot
8d0dfda3ce Merge "[5G settings UI] Add config for the 5G limited VoLTE alert dialog" 2020-06-23 17:45:01 +00:00
SongFerngWang
8c8c3dc81c [5G settings UI] Add config for the 5G limited VoLTE alert dialog
Flag specifying whether to show an alert dialog for 5G disable
when the user disables VoLTE.

Bug: 151313654
Test: build pass. manual test: UI show alert dialog.
Change-Id: I5a5ab9e47722ad2ba28038233c5d2fc5fbe7e667
Merged-In: I5a5ab9e47722ad2ba28038233c5d2fc5fbe7e667
2020-06-23 22:26:24 +08:00
SongFerngWang
bdedfc06ad Add a carrier config for WFC's carrier name override by ef_pnn
To override wifi calling's carrier name string using ef_pnn
from sim card.

Bug: 157108864
Test: UE with TMO sim card to test in Roaming and WFC on, and then
check operator name. (PASS)

Change-Id: Id72ce2a9a0fb8f45efa8a975e8052808f726a971
Merged-In: Id72ce2a9a0fb8f45efa8a975e8052808f726a971
2020-06-23 20:55:39 +08:00
Sarah Chin
de4959769d Merge "Update UL values for NR" 2020-06-22 23:21:08 +00:00
Sarah Chin
95553d14cd Update UL values for NR
Test: build
Bug: 158218596
Change-Id: I2d548711c5de9683b57dc7bbeea9379d23b18343
Merged-In: I2d548711c5de9683b57dc7bbeea9379d23b18343
2020-06-22 15:36:24 -07:00
Sarah Chin
4b42d70d84 Create carrier config for NR enabled setting
Test: build
Bug: 155915216
Change-Id: Ib81bb6b1712fcf53723df04f162c50a89c96e04d
Merged-In: Ib81bb6b1712fcf53723df04f162c50a89c96e04d
2020-06-22 15:24:44 -07:00
Brad Ebinger
6b8e4bdf66 Merge "Fix MmTelFeatureConnection Memory Leak" 2020-06-19 20:12:44 +00:00
Brad Ebinger
e51d2698ac Merge "Remove IllegalArgumentException for registration of capabilities" 2020-06-19 18:44:09 +00:00
Brad Ebinger
5c91f871d7 Merge "Fix UCE docs" 2020-06-19 18:27:56 +00:00
Brad Ebinger
3afcd20f6a Fix MmTelFeatureConnection Memory Leak
In FeatureConnection, we never cleaned up the ImsFeatureStatusCallback
after it was destroyed, leaving zombie FeatureConnections around.

Bug: 156893040
Fixes: 157948894
Test: atest FrameworksTelephonyTests
Merged-In: Idcf8b558c3807a3f9f5094afee532e76ea6f02cb
Change-Id: Idcf8b558c3807a3f9f5094afee532e76ea6f02cb
2020-06-19 10:57:04 -07:00
Brad Ebinger
aa4d1c60a5 Fix UCE docs
Clarify some of the docs for UCE Intent.

Fixes: 156114453
Fixes: 158014476
Test: docs only
Merged-In: I01617d0741055e347e05bdbd5eb5a6825f896e73
Change-Id: I01617d0741055e347e05bdbd5eb5a6825f896e73
2020-06-19 10:32:59 -07:00
Brad Ebinger
e170706352 Remove IllegalArgumentException for registration of capabilities
We threw an IllegalArgumentException for an invalid subscription,
however this is counter to what this exception should be used for.
Instead, use ImsException#CODE_ERROR_INVALID_SUBSCRIPTION.

Also fixed incorrect ImsException sent when telephony crashed.

Bug: 156402275
Fixes: 159135792
Test: atest FrameworksTelephonyTests; CtsTelephonyTestCases; manual
Change-Id: I3250419a2438afb58922ae653e3f2e4f9628e593
Merged-In: I3250419a2438afb58922ae653e3f2e4f9628e593
2020-06-19 17:20:22 +00:00
Shuo Qian
4455014028 Merge "Change the threshold for RSSNR from 10*db to db" 2020-06-16 21:26:10 +00:00
Shuo Qian
3950d0a631 Change the threshold for RSSNR from 10*db to db
Test: SignalStrengthTest
Bug: 158539126
Change-Id: I9bc4b2f601d7d3f2a32ca34768ecb2a78d59d5bb
Merged-In: I9bc4b2f601d7d3f2a32ca34768ecb2a78d59d5bb
(cherry picked from commit 6775b77bd5)
2020-06-16 20:41:05 +00:00
Hall Liu
915a081cd6 Throw exception from addServiceAnnouncement impl
Throw an UnsupportedOperationException from the base implementation of
addServiceAnnouncement and add supporting documentation.

Bug: 155926142
Test: existing CTS
Change-Id: Ib120b650d2a29acdacb9877cdeeba4b782f3f189
2020-06-08 17:14:54 -07:00
Hall Liu
70afad6952 Rename addServiceAnnouncement-related methods
Address feedback on the API

Fixes: 155926142
Test: CTS
Change-Id: I69e17faf4d09ab686fdd97975bc7f069597b87b3
2020-06-08 16:32:47 -07:00
Xin Li
d7785982ac Merge "Merge QQ3A.200605.002 into master" 2020-06-06 01:41:11 +00:00
Shi Lu
a2d5e8c2bf Merge "Correct comments/documentation" 2020-06-05 19:35:27 +00:00
allenwtsu
2a4441dc1c [KDDI] Define carrier config for call forwarding items
Test: build pass
Bug: 158013358
Bug: 149274975
Change-Id: Ie49ca51497e8f0d9f16d14cc183311dcd02d8bbb
Merged-In: Ie49ca51497e8f0d9f16d14cc183311dcd02d8bbb
2020-06-03 10:18:03 +00:00
Brad Ebinger
ed917bbe47 Merge "Fix possible deadlock in incoming call" am: c203e56238
Change-Id: Ifcfb48a88afbf4c46dcb87b8d07bac9763eb5b4f
2020-05-27 00:41:15 +00:00
Brad Ebinger
3c1c15c9a2 Fix possible deadlock in incoming call
When notifying the framework of an incoming call, a lock is held
in both the MmTelFeature and MmTelFeatureConnection. This can cause
a deadlock if the MmTelFeatureConnection is also processing an
event, such as sending/acknowleging an SMS message.

Remove the lock around the listener methods to the framework, since
it is not needed.

Bug: 155083563
Fixes: 155819733
Test: atest CtsTelephonyTestCases:ImsServiceTest FrameworksTelephonyTests
Change-Id: I39f7192c6f79e215ef989797870f5f501197cd08
Merged-In: I39f7192c6f79e215ef989797870f5f501197cd08
2020-05-26 15:52:09 -07:00
Calvin Pan
99fb86a51a Merge "Update getSimCarrierId() document" am: 4e61079a4c
Change-Id: I486690f2cb60629cd864d7acc919df3342a2f6ac
2020-05-19 09:00:36 +00:00
Calvin Pan
4e61079a4c Merge "Update getSimCarrierId() document" 2020-05-19 08:40:12 +00:00
Amit Mahajan
67bec2d79b Merge "DUT fail to unlock SIM after selecting Home IMSI from STK When unlock SIM pin,SIM begin refresh, and the UiccCardApp was disposed." am: 62120dcc8c
Change-Id: I50ca70c0e9a3a20bc64604e9e05cec619111679f
2020-05-18 23:55:10 +00:00
Amit Mahajan
62120dcc8c Merge "DUT fail to unlock SIM after selecting Home IMSI from STK When unlock SIM pin,SIM begin refresh, and the UiccCardApp was disposed." 2020-05-18 23:38:22 +00:00
calvinpan
301df3d935 Update getSimCarrierId() document
Carrier_list.pb move to latest_carrierid/ folder, so update the
description.

Bug: 155254987
Test: Build pass
Change-Id: Iacf1bfe68fa86194e8b75cbfce9aa37c0abfbca3
Merged-In: Iacf1bfe68fa86194e8b75cbfce9aa37c0abfbca3
2020-05-13 10:53:12 +00:00
Shuo Qian
9e80bca139 Merge "Modify the default values to avoid 2 DB hysteresis DB limitation" am: a059affff3
Change-Id: I2b7a90343be8d2e3b69d78dae9890ba28f01939f
2020-05-11 22:38:07 +00:00
Shuo Qian
e2faa8fff8 Modify the default values to avoid 2 DB hysteresis DB limitation
Test: Treehugger
Bug: 155026280
Change-Id: Ic1af774b28629c7ab0e105f6ce198bfce8d160a8
Merged-In: Ic1af774b28629c7ab0e105f6ce198bfce8d160a8
(cherry picked from commit 66c51cda97)
2020-05-11 20:57:28 +00:00
Rambo Wang
50612d1d1c Merge "LTE+ indicator not shown when attached to CA network" am: 1926b83e85
Change-Id: I85ce9363482a09aea2ce58940cdec41ee618ee8b
2020-05-11 20:20:29 +00:00
Rambo Wang
35c8eb194a LTE+ indicator not shown when attached to CA network
NetworkTypeController (or DcTracker in aosp/master) will set lte
display type to LTE_CA when current ServiceState fulfills one of the
following conditions:
- getDataNetworkType return NETWORK_TYPE_LTE_CA
- isUsingCarrierAggregation return true

NetworkRegistrationInfo#getAccessNetworkTechnology() always returns LTE
when data rat is LTE CA. So the first condition will never get
fulfilled.

isUsingCarrierAggregation flag will only get updated when
ServiceStateTracker calls RatRatcheter.ratchet without location change.
This makes isUsingCarrierAggregation flag not always reliable to
determine if carrier aggregation is on.

The CL fix the issue by changing ServiceState#isUsingCarrierAggregation
to return true when ServiceState#getCellBandwidths return more than one.
The same condition is already used by RatRatcheter when set
isUsingCarrierAggregation flag in RatRatcheter#ratchet.

Bug: 154060784
Test: atest com.android.internal.telephony.ServiceStateTest
Test: atest android.telephony.cts.ServiceStateTest
Merged-In: Ie6c07cb58d2a40eeb10e8f0131c98212ba463517
Change-Id: Ie6c07cb58d2a40eeb10e8f0131c98212ba463517
(cherry picked from commit 8a41bbf466)
2020-05-11 09:44:49 -07:00
Daniel Bright
780f5638c2 Merge "Add CarrierConfig key to customize apn priority" am: 04e78abfd4
Change-Id: Iae3414f321136590690e80c43b6b2e2d217be145
2020-05-07 19:47:00 +00:00
Daniel Bright
04e78abfd4 Merge "Add CarrierConfig key to customize apn priority" 2020-05-07 19:31:07 +00:00
Sarah Chin
5e00b85f76 Merge "Add legacy state to 5g timer configs" am: 5699f000cb
Change-Id: I3efd65adf9b578c75011f8b61dd832243c76c6f5
2020-05-07 01:03:01 +00:00
Sarah Chin
8d5f3ad3bb Merge changes from topics "displayinfocontroller", "remove_displayinfo" am: 94c22b7194
Change-Id: I67628d868754ca3e2ab74e0b2bcb49a468ec5b2e
2020-05-06 23:49:33 +00:00
Sarah Chin
4c18cacdd6 Add carrier configs for 5G timer requirements am: c4ef473307
Change-Id: I4d4396a4bcb36495c9c492ebed5d676585433df5
2020-05-06 23:49:24 +00:00
Sarah Chin
a193f84a9d Add legacy state to 5g timer configs
Test: manual testing
Bug: 154186364
Change-Id: Iaf89f4ef9dfcea244033237f74818ab67e104b92
Merged-In: Iaf89f4ef9dfcea244033237f74818ab67e104b92
2020-05-06 16:45:24 -07:00
Sarah Chin
94c22b7194 Merge changes from topics "displayinfocontroller", "remove_displayinfo"
* changes:
  Remove constants for DisplayInfo logic from DcTracker
  Add carrier configs for 5G timer requirements
2020-05-06 23:26:42 +00:00
Sarah Chin
04511a9f28 Merge "Debug message fix" am: 15418261cc
Change-Id: Ief60bab235ed796541675acc46428b07dfd6c7b2
2020-05-06 21:41:58 +00:00
Jack Yu
c4e911d1d5 Debug message fix
Fixed the toString and made overrideNetworkTypeToString
public for debugging purposes.

Fix: 154229268
Test: Manual
Change-Id: I5c886de22543188032df172810b987cff964577b
Merged-In: I5c886de22543188032df172810b987cff964577b
2020-05-06 13:09:15 -07:00
Andrew Sapperstein
df8396f2c3 Fix last broken @see links in aosp.
Seems that the doc-comment-check-docs wasn't in presubmit.

Bug: 6963924
Bug: 155825675
Test: make doc-comment-check-docs
Change-Id: I018a50cd76b0fd5f8c3642efa1374e53f1b746a6
Merged-In: Ib2e4360493275b79c72487ee1cb173bb5e0fd35f
2020-05-05 22:16:10 -07:00
Andrew Sapperstein
50dd1eaaeb Fix last broken @see links in aosp.
Seems that the doc-comment-check-docs wasn't in presubmit.

Bug: 6963924
Bug: 155825675
Test: make doc-comment-check-docs
Change-Id: I018a50cd76b0fd5f8c3642efa1374e53f1b746a6
Merged-In: Ib2e4360493275b79c72487ee1cb173bb5e0fd35f
2020-05-06 01:55:04 +00:00