Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate CellLocation#requestLocationUpdate

Browse Source 
Remove this method, which is undesirable, has unfortunate
side effects, and which is a worse way of getting the current
location than other methods such as TelephonyManager#getAllCellInfo()
(since KK) and TelephonyManager#requestCellInfoUpdate() (since QT/11).

Bug: 152648516
Test: make update-api && make (docstring-only change)
Change-Id: I3c7d345abcdd8c35cf539d33166ddf76ba987b1c
This commit is contained in:
Nathan Harold
2020-07-06 13:53:07 -07:00
parent 0459eb7cdc
commit bf3fff073f
3 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/current.txt
View File

@@ -45143,7 +45143,7 @@ package android.telephony {
public abstract class CellLocation {
ctor public CellLocation();
method public static android.telephony.CellLocation getEmpty();
method public static void requestLocationUpdate();
method @Deprecated public static void requestLocationUpdate();
}
public abstract class CellSignalStrength {

2
non-updatable-api/current.txt
View File

@@ -44999,7 +44999,7 @@ package android.telephony {
public abstract class CellLocation {
ctor public CellLocation();
method public static android.telephony.CellLocation getEmpty();
method public static void requestLocationUpdate();
method @Deprecated public static void requestLocationUpdate();
}
public abstract class CellSignalStrength {

7
telephony/java/android/telephony/CellLocation.java
View File

@@ -47,7 +47,14 @@ public abstract class CellLocation {
*
* Callers wishing to request a single location update should use
* {@link TelephonyManager#requestCellInfoUpdate}.
*
* @deprecated this method has undesirable side-effects, and it calls into the OS without
* access to a {@link android.content.Context Context}, meaning that certain safety checks and
* attribution are error-prone. Given that this method has numerous downsides, and given that
* there are long-available superior alternatives, callers are strongly discouraged from using
* this method.
*/
@Deprecated
public static void requestLocationUpdate() {
// Since this object doesn't have a context, this is the best we can do.
final Context appContext = ActivityThread.currentApplication();