Commit Graph

1214 Commits

Author SHA1 Message Date
Salvador Martinez
926f071688 Only query for estimate on battery level change
SysUI is querying for an estimate too much, this change gates
it on being the first estimate or the battery level having
changed so that we don't waste system resources.

Test: atest PowerUITest
Bug: 110259498
Change-Id: I6fb5c08d6388e463d6216de41b3fd49bbc489b81
2018-07-10 16:35:18 -07:00
Lucas Dupin
f8463ee043 Fade to black without showing system wallpaper
When on the lock screen, and going to AOD animated, user would
temporarily see the system wallpaper. That's not what we want,
we want to fade from semi-transparent black to black, on top
of the backdrop - lock screen wallpaper or media art.

Test: press power on the lock screen when playing media
Test: press power on the lock screen after dismissing media
Test: unlock from AOD
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Fixes: 80575770
Change-Id: I6796e844add889ff86be0cd2052db7c5d5073039
2018-06-18 09:24:38 -07:00
Lucas Dupin
b784e6f7bc Merge "Config to enable/disable AOD via overlay" into pi-dev 2018-06-14 01:16:44 +00:00
Lucas Dupin
1e02f340e0 Config to enable/disable AOD via overlay
Bug: 109894567
Test: mp droid; fastboot -w
Change-Id: I3fda0bf486ae0c4b795ce34ba6823d8dc36a3796
2018-06-13 15:36:04 -07:00
Lucas Dupin
f1381bbe13 Avoid showing bouncer when in a launch transition
The panel will collapse but the bouncer should not become visible,
otherwise the IME might be requested.

Test: go/sysui-bouncer-tests
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManagerTest.java
Change-Id: I0405cf1b956aa239b0684ac357a38cf4b2357cb2
Fixes: 109879604
2018-06-12 21:58:23 +00:00
TreeHugger Robot
cc4efe08de Merge "Update scrims when keyguard gets occluded" into pi-dev 2018-06-07 16:50:34 +00:00
Lucas Dupin
63d72170da Update scrims when keyguard gets occluded
We were assuming that a show_when_locked window would always be on
the lock screen when the device sleeps, but its possible that,
when charging, a window may come visible after the device enters
doze.

Ideally this should be handled in window manager but not feasible
in P.

Change-Id: I8a1b5e638a8e84bbea3a91fc4ac94feb6195390e
Fixes: 80647623
Test: manual with app from play store
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
2018-06-06 11:42:55 -07:00
Dieter Hsu
36e1ebca09 Update notifications on density or font size change for current user
For created notifications, entry manager is not going to update entries
after changing the font scale and/or display density when shade is
disabled or other reasons.
To reinflate notifications for current user even filtered.

Fixes: 77728867
Test: manually restore backup with lots of apps and change font scale and/or display density
Test: atest SystemUITests:NotificationDataTest
Change-Id: I37fa38e73af1ebb672abd06282d10d7d928cc3a9
2018-06-06 17:57:38 +00:00
TreeHugger Robot
842ec5085b Merge "Blank screen when coming from pulse" into pi-dev 2018-06-04 19:45:18 +00:00
Lucas Dupin
eb840eacf6 Blank screen when coming from pulse
We need to fade from black to the app to achieve a nice transition.

Test: visual
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Change-Id: I13edd9c5f7a1bf9378851ac50c513d36ab821c43
Fixes: 87939048
2018-06-01 18:32:48 +00:00
Lucas Dupin
71dd484427 Do not request focus during wake and unlock
Focus was being required because the expansion of the panel
would trigger onFullyShown. Bouncer shouldn't need any
translation during WAKE_AND_UNLOCK.

Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManagerTest.java
Test: go/sysui-bouncer-tests
Change-Id: I6d5c17ba89e14384859cf7fc91ca5cc2815dbfd9
Fixes: 80345339
2018-05-29 15:41:03 -07:00
Lucas Dupin
3116918bf0 Merge "Only animate when the slice is actually animating" into pi-dev 2018-05-23 20:15:19 +00:00
TreeHugger Robot
4524e93577 Merge "On orientation change, update rounded corners" into pi-dev 2018-05-23 14:35:29 +00:00
Beverly
e91f0d05da On orientation change, update rounded corners
When rotating landscape/seascape/upsidedown, the 'top' and 'bottom'
corners are in the correct place

Change-Id: I19858ca42939d81911c5f45bd80d163d0c22eee9
Fixes: 79163187
Test: manual, ScreenDecorationsTest
2018-05-23 09:37:09 -04:00
Sanry Huang
89d55288d9 Merge "Fix User unable to view the keyboard input" into pi-dev 2018-05-23 07:39:27 +00:00
sanryhuang
63787860c2 Fix User unable to view the keyboard input
revert extracted mode solution and using commandQueue to implement
setRemoteInputActive

Test: manual test
Test: atest
Change-Id: I82c63843dd38c19c1f88af15abcc137be4f72c83
Fixes:73275201
2018-05-23 07:37:58 +00:00
Lucas Dupin
3978e6e6ee Only animate when the slice is actually animating
It's not correct to always animate if there is a layout transition.
The transition might not be triggered when the view is invisible
for example. It's necessary to check if we have pending/running
animations.

Change-Id: I75dbc9f8a152a162a3c77c9b316f653e665b8842
Fixes: 79773596
Test: manual
Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardSliceViewTest.java
2018-05-22 19:13:51 -07:00
TreeHugger Robot
fe1b1f19fe Merge "[Notif] Don't show bouncer on dismiss" into pi-dev 2018-05-22 20:36:51 +00:00
Rohan Shah
593e8f18cd [Notif] Don't show bouncer on dismiss
For blocking helper, when user dismisses by interacting with elements
outside the current notification, we should not show the bouncer.

Changed the logic to only show bouncer/use the checksaverunnable when
the user hits 'stop notifications'

Test: Added test cases, ran via atest, verified manually too
Bug: 80132806
Change-Id: Ic204e1794360684cd6359ff93e77e184e39ad57e
2018-05-22 10:37:11 -07:00
TreeHugger Robot
553fc8b8e0 Merge "Bouncer shouldn't be translated when occluded" into pi-dev 2018-05-22 00:59:29 +00:00
Lucas Dupin
aece5028fc Bouncer shouldn't be translated when occluded
Only checking if the bouncer should be scrimmed isn't enough
since it might have been initialized for performance reasons,
but is hidden at the bottom of the keyguard.

Change-Id: If92083e2c385d51febe0ec3a5e5d3484476caf81
Fixes: 80101176
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManagerTest.java
Test: manual
2018-05-21 16:44:28 -07:00
Lucas Dupin
30c7547149 Pulse state should always show ambient wallpaper
Otherwise wallpaper wouldn't be set to AOD when the device pulses
and always on is off.

Bug: 78606979
Test: manual
Test: atest packages/SystemUI/tests/src/com/android/systemui/doze/DozeWallpaperStateTest.java
Change-Id: Ic40c18252cd6cb06ff6fd0d79ec3f1de16a1add5
2018-05-21 14:14:42 -07:00
Lucas Dupin
402e2a2b6f Merge "Keep scrim black when "always on" is off" into pi-dev 2018-05-21 18:23:59 +00:00
Lucas Dupin
69bda6014f Keep scrim black when "always on" is off
The first frame when waking up is expensive and we
need a black scrim hiding what was left behind.

Bug: 78022321
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Change-Id: I99e2b7960daf2cbe51bec6aee4b15c74d532078c
2018-05-21 10:14:23 -07:00
Chris Wren
2e89e8d893 clone the visibility objects for the handler thread
The main thread was recycling the objects before the hander could
pack up the binder call.

Change-Id: I4289bdcc5b940a0a8209fdd5d3df47972de0fa4b
Fixes: 72953296
Test: atest com.android.notification.functional.NotificationInteractionTests#testNotificationShadeMetrics
2018-05-18 15:32:21 -04:00
Selim Cinek
f75019b810 Merge "Keep notification when sending smart reply." into pi-dev 2018-05-18 16:20:40 +00:00
TreeHugger Robot
0a72c6b08d Merge "Do not allow bouncer translation when scrimmed" into pi-dev 2018-05-18 00:55:35 +00:00
Lucas Dupin
f9ca35eb09 Do not allow bouncer translation when scrimmed
We had special cases when the bouncer shouldn't be translated but that
doesn't really scale. It's much simpler to just check if it's being
scrimmed - because otherwse it mus be translated.

Change-Id: Ide0af6718f1792ef1a1e16fa39512a2b3a0ba8be
Bug: 78222122
Fixes: 78205990
Fixes: 78140990
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardBouncerTest.java
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManagerTest.java
Test: go/sysui-bouncer-tests
2018-05-17 16:40:50 -07:00
Selim Cinek
866b4de28f Merge "Fix that the empty shade view would be visible sometimes" into pi-dev 2018-05-17 21:02:01 +00:00
Selim Cinek
d60ef9ec87 Fix that the empty shade view would be visible sometimes
Refactored the state to be more clear and make sure the end runnable is always called.

Fixes: 78861878
Test: have no notification, hide view by scrolling up, get notification, observe
Change-Id: I51b00696f4b2dba565a0213c24a5a67a3c4099e0
2018-05-17 12:52:09 -07:00
Kenny Guy
8cc15d2ebf Keep notification when sending smart reply.
If an app cancels a notification while we are
sending a smart reply then don't dismiss the
notification.

Bug: 79120026
Test: atest NotificationEntryManagerTest
Test: atest SmartReplyControllerTest
Test: atest statusbar.NotificationListenerTest
Test: atest NotificationRemoteInputManagerTest

Change-Id: Ibbc0014ae0aeb12b58be13c041d720903251490f
2018-05-17 20:16:25 +01:00
TreeHugger Robot
5be1956952 Merge "Reduce usages of main looper in sysui tests" into pi-dev 2018-05-17 15:28:30 +00:00
Jason Monk
6dceace0ed Reduce usages of main looper in sysui tests
Push over to a standard testable looper, and a testable looper +
setAsMain when needed.

Also make tests more synchronous and single threaded as possible.
This will make them more deterministic and speeds them up noticeably.

Test: runtest systemui
Bug: 79550837
Change-Id: Iab0eb794329d7b1de95aef904ec08ecae7dadc98
2018-05-17 10:32:31 -04:00
TreeHugger Robot
ceeba4f6d6 Merge "Change status bar icons upon capability changes in the default network." into pi-dev 2018-05-17 06:46:39 +00:00
Anarghya Mitra
678722f9d0 Change status bar icons upon capability changes in the default network.
SysUI status bar updates currently happen upon receiving either the
CONNECTIVITY_ACTION broadcast (which is deprecated) and
INET_CONDITION_ACTION broadcast (which is sent upon validation state
change of networks only).

This leads to status bar showing stale connectivity state. The correct
fix for this is to listen to changes in network state by registering
NetworkCallbacks (see more details in http://b/79286300#comment9).

In the P timeframe, not listening to the broadcasts completely is out of
scope. So this CL just listens for changing network capabilities of the
default data network, which should fix all the cases where the
broadcasts are not getting sent.

Later, when we stop relying on the broadcasts, we will also have to
override onAvailable and onLost (and perhaps the other callbacks too).

Test: runtest --path frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/
Bug: 71904788
Change-Id: I2e58b9cfceb9937a0b54874dee116ead5339b37b
2018-05-16 22:23:56 -07:00
Lucas Dupin
7ff82b0a92 Fix KeyguardUpdateMonitor test
KeyguardUpdateMonitor's Handler runs on the main looper by design,
we need to ensure that whenever we're processing messages, that
they will also be received on the main looper.

Also unregistered a broadcast listener to avoid a possible race
condition

Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardUpdateMonitorTest.java
Bug: 79550837
Change-Id: I14a319da5c6bc46fd32675ae205e14a6228efaa4
2018-05-16 12:40:30 -07:00
TreeHugger Robot
cb20eb3a07 Merge "Pass Uri in SliceBroadcastRelay" into pi-dev 2018-05-11 22:05:36 +00:00
Lucas Dupin
29e796d26a Do not hide keyguard message when fp
Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardPinBasedInputViewTest.java
Change-Id: I5d76b688b0eb7c1df6a36c1cb910f2b0ec98bc46
Fixes: 78235570
2018-05-11 09:22:39 -07:00
TreeHugger Robot
895ed11d03 Merge "Fix issue with compressed smart replies." into pi-dev 2018-05-11 14:19:40 +00:00
TreeHugger Robot
d87ad2d97c Merge "Cannot add null callbacks to ZenController" into pi-dev 2018-05-11 02:03:55 +00:00
Beverly
80313ca38f Cannot add null callbacks to ZenController
- In StatusBar: remove callback on destroy

Bug: 79418729
Test: atest ZenModeControllerImplTest
Change-Id: I92729b0c0414d0ed8f844371cbf357b613ced0b5
2018-05-10 17:13:42 -04:00
TreeHugger Robot
aba96e5556 Merge "Fix notificationinfo test breakage" into pi-dev 2018-05-10 21:04:41 +00:00
Rohan Shah
c6b0d54ba9 Fix notificationinfo test breakage
Bind no longer logs unnecessarily - log was moved over to the manager
already.

Test: Ran test
Fixes: 79533793
Change-Id: I1d893935fa93ff7dbb91e922ae2444c4ac42b046
2018-05-10 20:07:58 +00:00
Rohan Shah
8b74f55c41 Merge "Move BH test to flaky and change it slightly" into pi-dev 2018-05-10 16:20:18 +00:00
Kenny Guy
48ee6d6cc0 Fix issue with compressed smart replies.
Width overflows if we both remeasure due
to failing to squeeze and due to padding
changes.

Bug: 79225896
Test: atest SmartReplyViewTest
Test: manual - recieve notification from Inbox check reply buttons.
Change-Id: I8ef306bbb7e3732b433830f856257fbfedeb89c0
2018-05-10 12:45:39 +01:00
Rohan Shah
dd588c76e3 Allow keep showing to bypass bouncer
User experience improvement that alleviates the current bouncer bug with
the blocking helper (where users can't swipe after interacting with the
blocking helper).

Bug: 78222122
Test: Added test case, verified on device with lock screen pin + helper
Change-Id: I54806df8b960ea305b120aef6217a6b90f30590b
2018-05-09 20:43:33 -07:00
Rohan Shah
ae5fdf0993 Move BH test to flaky and change it slightly
Marked the test as flaky. Additionally, changed how mocks are created.
This may or may not affect the test's passing rate. Also updated the
double spy horribleness.

Bug: 79444334
Test: Ran atest, no functional changes
Change-Id: Ieb901a1702ab15bdf98f37cb4b37d5068882162d
2018-05-09 18:59:44 -07:00
android-build-team Robot
6d4917b673 Merge "Remove the clock view when DISABLE_CLOCK is set" into pi-dev 2018-05-07 22:05:40 +00:00
Lucas Dupin
9fedb89f66 Update date during time tick event
Remove extra broadcast action and use existing doze_time_tick alarm to
update slice.

Change-Id: If167c8d81e5f5a67050d7904ce2497c1bdb70e9a
Fixes: 77988364
Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardSliceViewTest.java
Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardStatusViewTest.java
Test: atest packages/SystemUI/tests/src/com/android/systemui/keyguard/KeyguardSliceProviderTest.java
2018-05-07 11:33:50 -07:00
Evan Laird
74435e6486 Remove the clock view when DISABLE_CLOCK is set
Gets rid of Floating Notification Syndrome™

The easiest way to see this is launching SUW or pinned-task mode with
debug.layout set to true, and see that there is no box containing the
clock in these modes

Test: visual;
Change-Id: I518bc04d2dca2fb56f13e0cebc475929edaf2c48
Fixes: 77630482
2018-05-07 14:21:15 -04:00