Commit Graph

421113 Commits

Author SHA1 Message Date
TreeHugger Robot
9bb2607703 Merge "Skip IME initialization when received the token that already registered" into qt-dev 2019-05-30 17:33:17 +00:00
Winson Chung
c1da971644 Merge "Exclude the status bar and HUN from gestures" into qt-dev 2019-05-30 17:30:11 +00:00
Patrick Baumann
34ff7e76bb Merge "Handles pre-process failure without crashing system" into qt-dev
am: b8735359aa

Change-Id: I8b6724a77658bf1cca8b50e4d4c3cfad639d8361
2019-05-30 10:13:52 -07:00
TreeHugger Robot
b8735359aa Merge "Handles pre-process failure without crashing system" into qt-dev 2019-05-30 17:02:17 +00:00
Neil Fuller
9c50fd8c05 [automerger skipped] Merge "Switch to HexEncoding from ByteStringUtils" am: a326166eba
am: 364ed0b152 -s ours
am skip reason: change_id I2cb09da5ec5296799e03bab812b7fb29452a623e with SHA1 c3dfd08914 is in history

Change-Id: Ide371473356f522523e49cb7997449eb7f10222d
2019-05-30 10:00:03 -07:00
Steve Elliott
89c2b004bd Merge "Constrain global actions panel to available space" into qt-dev
am: e4de9d2c56

Change-Id: I4bdacc5fd40754ab9391681efb81beec18411f4f
2019-05-30 09:55:49 -07:00
Neil Fuller
364ed0b152 Merge "Switch to HexEncoding from ByteStringUtils"
am: a326166eba

Change-Id: Iba8a6d1c19b4daf24905c71f72fdcb280b942ea3
2019-05-30 09:50:53 -07:00
Priyank Singh
682c10b4bf Merge "Make the Handle bar grabbable." into qt-dev
am: 08703d61b1

Change-Id: I2fe9b8858688e751bcd8042d3d9894595ef1a482
2019-05-30 09:44:51 -07:00
TreeHugger Robot
e4de9d2c56 Merge "Constrain global actions panel to available space" into qt-dev 2019-05-30 16:44:43 +00:00
TreeHugger Robot
08703d61b1 Merge "Make the Handle bar grabbable." into qt-dev 2019-05-30 16:38:03 +00:00
Neil Fuller
a326166eba Merge "Switch to HexEncoding from ByteStringUtils" 2019-05-30 16:31:09 +00:00
Neil Fuller
ae6fef3de7 Switch to HexEncoding from ByteStringUtils
Migration in preparation for deletion of ByteStringUtils.

DexLogger contains import ordering fixes to enable upload.

Bug: 124232146
Test: build only
Exempt-From-Owner-Approval: Already approved internally
Merged-In: I2cb09da5ec5296799e03bab812b7fb29452a623e
Change-Id: I2cb09da5ec5296799e03bab812b7fb29452a623e
2019-05-30 16:30:53 +00:00
Android Build Merger (Role)
bd51fabf51 Merge "Merge "Add user-switching observer to AttentionDetector" into qt-dev am: 5828019131" into qt-dev-plus-aosp 2019-05-30 16:30:25 +00:00
Yi Jiang
d3b5e0b42d Merge "Add user-switching observer to AttentionDetector" into qt-dev
am: 5828019131

Change-Id: If6dae24b4cacef851184350529953db416bc34c6
2019-05-30 09:29:51 -07:00
Chalard Jean
886ba083e7 Merge "Fix a comment" am: ad0be320e2
am: c67f43f80c

Change-Id: I6e386d13610c182b2bddee8da16915ed27a3efe6
2019-05-30 09:29:36 -07:00
Zimuzo
c1a694dddd Merge "Add network health check watchdog triggered rollback tests" into qt-dev
am: 80b53bd68b

Change-Id: I760b8f0d948702a51b96c3aaffa6ccb268b891fe
2019-05-30 09:27:48 -07:00
Remi NGUYEN VAN
cc3bf6417a Merge changes I2cb4200b,If1fa00be into qt-dev
am: 6b2681521e

Change-Id: Ib279a80a19bcdaf53678921108c4932d04988474
2019-05-30 09:26:09 -07:00
arangelov
6fd8108679 Merge "Remove @VisibleForTesting from DevicePolicyEventLogger getters." into qt-dev
am: 26a28f64c5

Change-Id: Idbdde0976e2df6253a22e950837c414d51d92237
2019-05-30 09:24:43 -07:00
Matt Casey
558100d727 Hide assist handles during generic assist gesture invocation.
Currently we hide handles during an NGA session, this change also hides
them during non-NGA invocation gesture.

Bug: 133522787
Test: Manual testing
Change-Id: I3317b309cd07c032826e6bfccbf20433de0559c6
2019-05-30 12:22:06 -04:00
Luke Huang
eba8c859a3 Merge "Fix issue for DnsResolver#query" into qt-dev
am: 23d7a55d18

Change-Id: Ia1ce7b84f4ae4984e1b940760f02901c88fade48
2019-05-30 09:18:02 -07:00
Chalard Jean
c67f43f80c Merge "Fix a comment"
am: ad0be320e2

Change-Id: I14842efdaa0747297a550cc7ff53f169b7cf14fc
2019-05-30 09:17:23 -07:00
Chiachang Wang
99d1e84d9b [automerger skipped] Merge "Replace limited connectivity notification after detecting it" into qt-dev
am: 37efc112e2 -s ours
am skip reason: change_id I004e78a33689e2208918d4316bcf9a8f50a0bac3 with SHA1 a5c68348d8 is in history

Change-Id: I11daaf075229a2891eb2d8b3df54a91a285d52fb
2019-05-30 09:16:54 -07:00
Julia Reynolds
902b4d78e9 Merge "Fix some issues in notification bucketing" into qt-dev
am: 634c095610

Change-Id: Id58d5e55da409020533882a2c5df4027d96eaff1
2019-05-30 09:16:05 -07:00
Chalard Jean
b0307ddd38 [automerger skipped] Merge "Always give VPN the INTERNET capability." into qt-dev
am: bc16cf3d72 -s ours
am skip reason: change_id I262ca41fe0225660551c9a421562405366b6acac with SHA1 06d81d2c62 is in history

Change-Id: I367d5afaa5ee254064d61f7f807af838b37583fe
2019-05-30 09:15:23 -07:00
Yi Jiang
5828019131 Merge "Add user-switching observer to AttentionDetector" into qt-dev 2019-05-30 16:12:48 +00:00
Lorenzo Colitti
4e4efe42a1 Add one more test for VPN usage stats.
(cherry picked from commit 1419b0b20e)

Covers the case where the majority of traffic through the VPN is
caused by the VPN app itself, and ensures that that traffic is
correctly attributed to the VPN app as opposed to spread between
the other apps that use the VPN.

Bug: 120145746
Test: atest NetworkStatsServiceTest
Change-Id: Ibd7646dc088fa4180abd696e89c3148ff34ce190
Merged-In: Iffd3f95fc2e11d311691a797b010edb38d2ef3c6
2019-05-30 15:59:28 +00:00
Varun Anand
e4bfdccb57 Addressing comments for http://ag/7700679.
(cherry picked from commit a229333986)

Note, that its in a separate CL so we could cherry-pick this CL to aosp.
http://ag/7700679 is already in aosp (http://aosp/865073).

Bug: 113122541
Bug: 120145746
Test: atest FrameworksNetTests

Change-Id: Ic1767bc8bf1460e4223f86465fc72344428e6055
Merged-In: I7cfda226b4ed11b67002b83b38fba0f5caf96718
2019-05-30 15:59:07 +00:00
Joshua Tsuji
f49ee14a7e Fix issues with animations when the stack is expanded.
- Don't show the flyout if the stack has become expanded.
- Add onChildReordered so that the controllers don't receive onChildAdded calls when views are reordered. This was causing animation issues with expanded bubbles.
- Clear the dragging out bubble onGestureFinished, so that it's not ignored by animations.
- Update the expand/collapse animations when a new child is added during animation, so that it'll also animate to the proper spot.

Fixes: 129370170
Bug: 123542488
Test: atest SystemUITests
Change-Id: I1360deb09db82bd3ba72cb91fc9abe05b6dc1a9c
2019-05-30 11:58:55 -04:00
Linus Tufvesson
93c3855a38 Notify all running users of DeviceConfig changes
Test: adb shell pm create-user dude
      adb shell am switch-user 10
      atest CtsDeviceConfigTestCases

Bug: 133793612
Change-Id: If614c4a6fea92d858994b113fcdf0f537a94a054
2019-05-30 15:46:47 +00:00
Steve Elliott
300b48ff11 Constrain global actions panel to available space
Formerly, the global actions panel was given the entire screen, and
was rendered above the global actions menu. Now, we limit it to the
space unused by the menu.

Bug: 133511683
Test: manual
Change-Id: I74f4db0b9a2a4e030ec1fd53ddd65e7c372d229c
2019-05-30 11:23:44 -04:00
TreeHugger Robot
80b53bd68b Merge "Add network health check watchdog triggered rollback tests" into qt-dev 2019-05-30 15:22:26 +00:00
Remi NGUYEN VAN
6b2681521e Merge changes I2cb4200b,If1fa00be into qt-dev
* changes:
  PackageWatchdog listens for NetworkStack failures
  Proper handling of NetworkStack crash
2019-05-30 15:11:11 +00:00
TreeHugger Robot
26a28f64c5 Merge "Remove @VisibleForTesting from DevicePolicyEventLogger getters." into qt-dev 2019-05-30 15:05:26 +00:00
Patrick Baumann
2ef05dca3f Handles pre-process failure without crashing system
This change ensures that if we encounter any issues copying the APK to
be installed, we also fail the other sessions to prevent them being
cleaned up incorrectly on post-install.

Test: manual; use debugger to force InstallArgs.copyApk() to fail
Bug: 133380744
Change-Id: I19e84a4683a36ac152d435fab3d0b191db6cc2df
2019-05-30 15:03:13 +00:00
Chalard Jean
9a1f478681 Prevent a 4-way binder interlock leading to a leak.
System server             |        NetworkStack
                              |
NetworkMonitorCallbacks  ←----|--- NetworkMonitorCallbacks$Stub$Proxy
         ↓                    |           ↑
  NetworkAgentInfo            |      NetworkMonitor
         ↓                    |           ↑
NetworkMonitor$Stub$Proxy ----|---→ NetworkMonitorImpl

Bug: b/133174607
Test: Manual. The simplest artifact is observed by watching the output of
adb shell dumpsys meminfo -d com.android.networkstack | grep 'Proxy Binders'
while connecting and disconnecting multiple times to any network.
This will display the number of binder proxies. Before this, the binder
proxy count increases by 1 with each connection and never goes down (there
is some noise, as proxy objects are sometimes created for other reasons,
and get GC'd eventually). After this, the binder proxy count is always
eventually stable at 27 + connected network count.

See the bug for the complete analysis.

Merged-In: Ide2428dab3fcd6d7cd00aa2a9fd99d6c99b815a4
Change-Id: I6b74cf12bdbc72c0593d2a4d6f39c895d1ef3534
(cherry picked from commit eb43884fee)
2019-05-30 14:46:45 +00:00
Chalard Jean
ad0be320e2 Merge "Fix a comment" 2019-05-30 14:39:48 +00:00
Julia Reynolds
fe7525a340 Fix a11y readout of notification guts buttons
Test: manual with TB
Bug: 134047401
Change-Id: I28e00afc110d95e130fe54d301be406fa17f6f18
2019-05-30 10:30:21 -04:00
Remi NGUYEN VAN
383151a7e0 Add tests for NetworkStack failure notifications
The test adds a dependency on mockito extended to be able to mock the
Context, PackageManager etc.

Test: atest PackageWatchdogTest#testNetworkStackFailure (+rest of class)
Bug: 133725814
Change-Id: Iba8a47f5e94b5dba49d6d395085e77285305ee7c
2019-05-30 23:27:39 +09:00
arangelov
3b37af4c3c Remove @VisibleForTesting from DevicePolicyEventLogger getters.
Also make it extendable for mocking and update atoms.proto comments.

Bug: 131833599
Test: compiled
Change-Id: I6a0e8a6175e7e9e46572ea4aa50ce7669a02588b
2019-05-30 14:40:12 +01:00
Leon Scroggins III
63eb6e495a Allow non-convex paths in Outline#setConvexPath
Bug: 131759669
Test: I5eca77e1a60e484e4e118b7e464a88363c539ca9
Test: Manual - assert no longer fires and app looks normal

The limitation to only support convex paths was due to a limitation
in the old renderer. Today, it is fine to use a concave path. Further,
Skia has changed how it computes complexity - it is more conservative,
so paths which were previously thought to be convex are no longer. We
cannot guarantee that a path will be considered convex (especially
after e.g. rotating it, as in the library in question), so drop the
requirement.

Change-Id: Ice88d0995750e066320cb175a87f8ae70ce3aeed
2019-05-30 09:38:04 -04:00
TreeHugger Robot
23d7a55d18 Merge "Fix issue for DnsResolver#query" into qt-dev 2019-05-30 13:37:38 +00:00
Remi NGUYEN VAN
6a135107ff PackageWatchdog listens for NetworkStack failures
In addition to the NetworkStack app monitoring, have PackageWatchdog
register an observer to NetworkStackClient to receive severe failure
notifications, and attempt a rollback if available.

The callback is registered in onPackagesReady(), which is called in the
boot sequence just before starting the NetworkStack.

Test: installed new networkstack, killed it twice, observe rollback
Test: unit test in change on top
Bug: 133725814
Change-Id: I2cb4200b78c2482cacc4bfe2ace1581b869be512
2019-05-30 21:52:51 +09:00
Remi NGUYEN VAN
5855ce28cf Proper handling of NetworkStack crash
Instead of always crashing on userdebug builds, do the following on all
builds:
 - If the device did not observe a NetworkStack crash in the last 6h
   crash the system server. This is to handle spurious crashes of the
   NetworkStack, so that the system can recover instead of staying
   without connectivity.
 - Otherwise, the device has had a recent crash. Notify the listeners
   (watchdog listener to be added) that something is seriously wrong,
   but do not crash to avoid bootlooping the device. This allows the
   watchdog to do its job, and avoids bricking the device in
   situations where the user could need to make emergency calls.

Bug: 133725814
Test: Killed the network stack, observe reboot of framework.
Test: Kill network stack again, observe nothing.
Test: Wipe data, install new network stack, kill it twice: rollback.
      (with patch on top applied)
Change-Id: If1fa00bed769eb60ca4832609006bdf15ceddb80
2019-05-30 21:52:40 +09:00
TreeHugger Robot
37efc112e2 Merge "Replace limited connectivity notification after detecting it" into qt-dev 2019-05-30 12:52:33 +00:00
Julia Reynolds
634c095610 Merge "Fix some issues in notification bucketing" into qt-dev 2019-05-30 12:30:30 +00:00
Zimuzo
e77a3e1de2 Add network health check watchdog triggered rollback tests
This cl improves code coverage for the PackageWatchdog explicit health
checks.

Updating the NetworkStack triggers an explicit health check with
a time deadline. At the deadline, if network is unavailable on the device,
the update is rolled back, if network is available, nothing happens.

Bug: 132640467
Test: atest StagedRollbackTest

Change-Id: I16a40244de9345930a1c981188aa33546fe872fc
2019-05-30 13:30:26 +01:00
TreeHugger Robot
bc16cf3d72 Merge "Always give VPN the INTERNET capability." into qt-dev 2019-05-30 12:10:22 +00:00
Santos Cordon
71e482f972 Adding some brightness logging.
Logs each time there's a change to the rules that control brightness.
Example: screen_off -> automatic -> manual -> manual [dimmed]

Adds a few lines to the log on startup and during major transitions (screen
off/doze/on), but stays pretty quiet out of transitions.

This should help debugging some temporary brightness bugs that we get on
occasion.

Test: manual
Bug: 131412806
Change-Id: I4db53547b2edb25863cebc6d5f44f4dacc80a1a0
2019-05-30 13:00:15 +01:00
Luke Huang
459a5becd9 Fix issue for DnsResolver#query
1. Previously, getDnsNetId doesn't handle all the cases.
Fix it with cosidering bypass private DNS flag.
2. Make getDnsNetId return Network instead of netId,
and change name from getDnsNetId to getDnsNetwork

Bug: 129530368
Test: atest DnsResolverTest DnsUtilsTest

Merged-In: Ibb5080acd3c296650d56532fc7da525e9fa95e8f
(cherry picked from commit 3854966dc9)

Change-Id: I37353642088bcc17da0cf17f78a5ed9efc9aefc3
2019-05-30 11:58:25 +00:00
Chiachang Wang
318a4884b9 Replace limited connectivity notification after detecting it
No internet notification may be prompted before partial
connectivity being detected. Partial connectivity status will
be set into NAI and prompted in the Setting. Behavior is not
aligned between Setting and notification. Thus, update
notification again if partial connectivity is detected.
Also, sliently show the updated notification if no internet
notification has already been shown to user to prevent alerting
user in short time.

Bug: 130683832
Test: Verified with simulated partial connectivity
Test: atest FrameworksNetTests
Change-Id: Ie16a8ce6e0fa437048e8c1eea240314ca30e9520
Merged-In: I004e78a33689e2208918d4316bcf9a8f50a0bac3
Merged-In: I14385a39d99a45c4a6a50a665f456f589c2f4da3
(cherry picked from commit a5c68348d8)
2019-05-30 11:46:21 +00:00