Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Handles pre-process failure without crashing system

Browse Source 
This change ensures that if we encounter any issues copying the APK to
be installed, we also fail the other sessions to prevent them being
cleaned up incorrectly on post-install.

Test: manual; use debugger to force InstallArgs.copyApk() to fail
Bug: 133380744
Change-Id: I19e84a4683a36ac152d435fab3d0b191db6cc2df
This commit is contained in:
Patrick Baumann
2019-05-29 14:06:02 -07:00
parent 23d7a55d18
commit 2ef05dca3f
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
services/core/java/com/android/server/pm/PackageManagerService.java
View File

@@ -15032,24 +15032,26 @@ public class PackageManagerService extends IPackageManager.Stub
void tryProcessInstallRequest(InstallArgs args, int currentStatus) {
mCurrentState.put(args, currentStatus);
boolean success = true;
if (mCurrentState.size() != mChildParams.size()) {
return;
}
int completeStatus = PackageManager.INSTALL_SUCCEEDED;
for (Integer status : mCurrentState.values()) {
if (status == PackageManager.INSTALL_UNKNOWN) {
return;
} else if (status != PackageManager.INSTALL_SUCCEEDED) {
success = false;
completeStatus = status;
break;
}
}
final List<InstallRequest> installRequests = new ArrayList<>(mCurrentState.size());
for (Map.Entry<InstallArgs, Integer> entry : mCurrentState.entrySet()) {
installRequests.add(new InstallRequest(entry.getKey(),
createPackageInstalledInfo(entry.getValue())));
createPackageInstalledInfo(completeStatus)));
}
processInstallRequestsAsync(success, installRequests);
processInstallRequestsAsync(
completeStatus == PackageManager.INSTALL_SUCCEEDED,
installRequests);
}
}