Chalard Jean
b03aaa836d
Merge "Unify behavior of various cases of "no underlying networks"" into pi-dev am: 468fdc3dd2
...
am: d829e18d9a
2018-05-22 05:27:35 -07:00
Chalard Jean
d829e18d9a
Merge "Unify behavior of various cases of "no underlying networks"" into pi-dev
...
am: 468fdc3dd2
2018-05-22 05:19:52 -07:00
TreeHugger Robot
468fdc3dd2
Merge "Unify behavior of various cases of "no underlying networks"" into pi-dev
2018-05-22 12:07:53 +00:00
Mihai Popa
2c9ec43bd7
[automerger skipped] Merge "Fix crash after smart selection animation" into pi-dev am: 6df95fa087
...
am: 3fa9bdb193
2018-05-22 04:34:48 -07:00
Mihai Popa
3fa9bdb193
Merge "Fix crash after smart selection animation" into pi-dev
...
am: 6df95fa087
2018-05-22 04:26:56 -07:00
Richard Uhler
2076732af1
Merge "Reduce LoadedApkAssets LRU cache size." into pi-dev am: 31ec39297c
...
am: ce72108f43
2018-05-22 04:26:45 -07:00
Mihai Popa
6df95fa087
Merge "Fix crash after smart selection animation" into pi-dev
2018-05-22 11:19:24 +00:00
Richard Uhler
ce72108f43
Merge "Reduce LoadedApkAssets LRU cache size." into pi-dev
...
am: 31ec39297c
2018-05-22 04:18:05 -07:00
Chalard Jean
688e384218
Merge changes Ic8231b18,I30009f88 into pi-dev am: 200cad09c7
...
am: 53fa1d8542
2018-05-22 04:14:02 -07:00
TreeHugger Robot
31ec39297c
Merge "Reduce LoadedApkAssets LRU cache size." into pi-dev
2018-05-22 11:09:18 +00:00
Chalard Jean
53fa1d8542
Merge changes Ic8231b18,I30009f88 into pi-dev
...
am: 200cad09c7
2018-05-22 04:06:35 -07:00
TreeHugger Robot
200cad09c7
Merge changes Ic8231b18,I30009f88 into pi-dev
...
* changes:
Fix: VPNs update caps upon underlying network disconnect.
Add tests for setUnderlyingNetworks.
2018-05-22 10:57:27 +00:00
Annie Meng
0e4f3bf243
Merge "Check settings validators for NPE" into pi-dev am: 3a95d0bb94
...
am: 0b653bc5e4
2018-05-22 03:10:33 -07:00
Annie Meng
0b653bc5e4
Merge "Check settings validators for NPE" into pi-dev
...
am: 3a95d0bb94
2018-05-22 03:03:21 -07:00
David Brazdil
749c287463
Merge "Add more hidden API usages into greylist" into pi-dev am: 9b2938d253
...
am: e3614bdd76
2018-05-22 02:59:36 -07:00
Annie Meng
3a95d0bb94
Merge "Check settings validators for NPE" into pi-dev
2018-05-22 09:55:48 +00:00
Richard Uhler
7bd7a369e4
Reduce LoadedApkAssets LRU cache size.
...
The cached apk assets can take up multiple megabytes of .apk mmap and
native memory for associated data structures. Reduce the cache size
for potential multi-megabyte memory savings with hopefully no
noticeable performance impacts.
In particular, rough estimates of the memory and performance impacts
of this change were evaluated by starting the launcher app,
sampling system server PSS with dumpsys meminfo and cache stats using
dumpsys activity for a few different cache sizes:
LRU Size 1: cached apks: total= 1 created=0 evicted=33 hit= 0 miss=34 max=1 TOTAL PSS=187542
LRU Size 3: cached apks: total= 3 created=0 evicted=12 hit=19 miss=15 max=3 TOTAL PSS=190606
LRU Size 15: cached apks: total=15 created=0 evicted= 0 hit=19 miss=15 max=15 TOTAL PSS=199350
LRU Size 100: cached apks: total=15 created=0 evicted= 0 hit=19 miss=15 max=100 TOTAL PSS=201416
Comparing cache stats after launching the settings app:
LRU Size 3: cached apks: total=3 created=0 evicted=5 hit=14 miss=8 max=3
LRU Size 15: cached apks: total=6 created=0 evicted=0 hit=18 miss=6 max=15
Running performance tests locally to ensure no clear regression in app
startup:
app-startup/benchmark-app-hermetic/cold-dropcache-test:
LRU 15 3 3
activityStart: 40.47 38.53 39.27
bindApplication: 24.40 24.53 24.93
draw: 4.27 4.33 4.07
layout: 0.73 1.07 0.73
onCreate: 9.40 9.00 8.53
totalLaunchTime: 183.13 183.27 187.07
app-startup/hermetic-apps/cold-dropcache-test:
LRU 15 15 3 3
Calculator_avg: 333.9 333.1 343.3 334.6
Calculator_max: 345.0 360.0 370.0 363.0
Calculator_median: 333.5 331.5 343.5 333.5
Calculator_min: 320.0 317.0 320.0 311.0
Calculator_std_dev: 6.62 13.26 18.22 16.51
Clock_avg: 510.0 511.2 509.2 512.6
Clock_max: 529.0 528.0 530.0 529.0
Clock_median: 510.5 509.0 503.5 512.0
Clock_min: 498.0 495.0 487.0 492.0
Clock_std_dev: 7.70 11.71 15.25 11.07
Contacts_avg: 457.7 527.3 507.3 543.9
Contacts_max: 602.0 622.0 591.0 588.0
Contacts_median: 410.5 568.5 568.0 580.0
Contacts_min: 390.0 374.0 366.0 394.0
Contacts_std_dev: 85.64 96.80 88.80 72.97
Phone_avg: 6073.1 6109.7 6110.8 6115.8
Phone_max: 6196.0 6208.0 6180.0 6222.0
Phone_median: 6070.0 6117.5 6100.0 6133.5
Phone_min: 5982.0 5990.0 6061.0 5994.0
Phone_std_dev: 61.49 67.35 34.55 60.17
Settings_avg: 457.9 446.6 451.6 428.7
Settings_max: 487.0 468.0 494.0 449.0
Settings_median: 460.0 450.0 444.5 424.0
Settings_min: 423.0 421.0 431.0 420.0
Settings_std_dev: 21.21 12.02 20.46 9.71
Bug: 79115008
Test: Device boots.
Test: dumpsys activity all shows ResourcesManager max cache size of 3.
Change-Id: I7225b6978fac6197c27bec23d2b477fb1f5aee43
2018-05-22 10:52:40 +01:00
David Brazdil
e3614bdd76
Merge "Add more hidden API usages into greylist" into pi-dev
...
am: 9b2938d253
2018-05-22 02:50:58 -07:00
Chalard Jean
b3ab0d1e63
Unify behavior of various cases of "no underlying networks"
...
Before this change, VPNs having no underlying networks would be
marked as metered as the safe option, but VPNs having only
disconnected underlying networks would be marked as unmetered.
Fix this discrepancy.
Bug: 79748782
Test: runtest frameworks-net
Change-Id: I51c3badde29f43f692f383553bd98327d2da8dd1
2018-05-22 18:50:00 +09:00
Chalard Jean
6b65ec7756
Fix: VPNs update caps upon underlying network disconnect.
...
Bug: 79748782
Test: ConnectivityServiceTests still pass
Change-Id: Ic8231b18a17e6feb5ebafe8d5688fb59f9d4d58e
2018-05-22 18:49:58 +09:00
Mihai Popa
6748ff37db
Fix crash after smart selection animation
...
At the end of the smart selection animation, we run a callback that sets
the selection on the TextView (subsequently starting the action mode
toolbar and showing the handles). However, when the text changes before
the animation finishes, the selection might not be valid, and might get
out of the text bounds, which was producing a crash. This was observed
in a monkey crash. This CL fixes this bug by refusing to set the
selection when it goes outside the text bounds, corresponding to the
case when text has changed between the time the animation has started
and the time it ended.
Bug: 69919777
Test: manual testing before and after the fix
Change-Id: Iea043f320004d45ad16dd7e9e5b47e5256e6d9fa
(cherry picked from commit cce6e82d35
2018-05-22 10:42:16 +01:00
David Brazdil
9b2938d253
Merge "Add more hidden API usages into greylist" into pi-dev
2018-05-22 09:41:15 +00:00
Chalard Jean
f89e8dacf1
Add tests for setUnderlyingNetworks.
...
Fixes come later. This is complex enough as it is.
Bug: 79748782
Test: new test passes, old tests still pass
Change-Id: I30009f88e68a534c332ca88bae517cacc39a60bb
2018-05-22 18:25:33 +09:00
TreeHugger Robot
94433eb36d
Merge "Shared lib def for org.apache.http.legacy comes from java_sdk_library"
2018-05-22 09:20:17 +00:00
Remi NGUYEN VAN
b5c3b2be8a
Merge "Move CaptivePortalProbeResult to its own file" into pi-dev am: fd12af848a
...
am: adfb78afdc
2018-05-22 01:14:13 -07:00
Chalard Jean
c93ed402b0
Merge "Fix setCapabilities." into pi-dev am: d1d4cc94ba
...
am: c60a252b87
2018-05-22 01:09:11 -07:00
Remi NGUYEN VAN
adfb78afdc
Merge "Move CaptivePortalProbeResult to its own file" into pi-dev
...
am: fd12af848a
2018-05-22 01:09:08 -07:00
Chalard Jean
c60a252b87
Merge "Fix setCapabilities." into pi-dev
...
am: d1d4cc94ba
2018-05-22 01:01:39 -07:00
Remi NGUYEN VAN
fd12af848a
Merge "Move CaptivePortalProbeResult to its own file" into pi-dev
2018-05-22 08:00:56 +00:00
Chalard Jean
d1d4cc94ba
Merge "Fix setCapabilities." into pi-dev
2018-05-22 07:51:09 +00:00
Dianne Hackborn
1535914d30
[automerger skipped] Merge "Add new hidden-for-now AppOpsManager APIs to greylist." into pi-dev am: 7b8ac80db5
...
am: 7425f704ea
2018-05-22 00:46:07 -07:00
Dianne Hackborn
7425f704ea
Merge "Add new hidden-for-now AppOpsManager APIs to greylist." into pi-dev
...
am: 7b8ac80db5
2018-05-22 00:35:07 -07:00
TreeHugger Robot
7b8ac80db5
Merge "Add new hidden-for-now AppOpsManager APIs to greylist." into pi-dev
2018-05-22 07:18:27 +00:00
TreeHugger Robot
c95b820055
Merge "Add new hidden-for-now AppOpsManager APIs to greylist."
2018-05-22 07:14:03 +00:00
felkachang
597418d06d
Clock notification text was cut off am: e8a3536660
...
am: bc72e3a15e
2018-05-21 23:19:32 -07:00
felkachang
bc72e3a15e
Clock notification text was cut off
...
am: e8a3536660
2018-05-21 23:14:41 -07:00
felkachang
e8a3536660
Clock notification text was cut off
...
The root cause is that HeadsUpStatusBarView doesn't considerate the
Cut Out situation. The Cut Out situation can use
getRootWindowInsets().getDisplayCutout().getSafeInsetLeft() to get
the the value.
There are two parts need to handle Cut out.
The one part is to handle the padding. It needs to considerate both of
mLeftInset and mLeftCutOutInset because it use getLocationOnScreen to
count the location.
The other part is to handle the HeadsUpStatusBarView.translationX.
It only needs to considerate mLeftCutOutInset because landscape
degree 90 has the left side cut out and translationX by the distance
between screen left boundary and scroller's left boundary. The
distance include Cut Out so it need minus mCutOutInsetLeft in the
setPanelTranslation.
Cut Out has 4 mode: Disable, Corner, Double, and Tall. Disable and
Double are handled by the same way. Corner and Tall are handled
by the same way.
Bug: 78113562
Test: atest SystemUITests
Change-Id: Ic2a272c43f65eed8c4b3749787637f5fb848bb8a
Fix: 78113562
2018-05-22 06:05:14 +00:00
Lucas Dupin
03134abf8a
Merge "Add content description to zenmode" into pi-dev am: adc1534453
...
am: c320298e81
2018-05-21 23:01:15 -07:00
Lucas Dupin
c320298e81
Merge "Add content description to zenmode" into pi-dev
...
am: adc1534453
2018-05-21 22:53:27 -07:00
TreeHugger Robot
adc1534453
Merge "Add content description to zenmode" into pi-dev
2018-05-22 05:44:33 +00:00
Jian Jin
be79a70b6f
Merge "Bugfix: PIN keyguard is clipped in Car" into pi-dev am: 90101793e5
...
am: 14fe430904
2018-05-21 22:01:20 -07:00
Jian Jin
14fe430904
Merge "Bugfix: PIN keyguard is clipped in Car" into pi-dev
...
am: 90101793e5
2018-05-21 21:52:31 -07:00
Jian Jin
90101793e5
Merge "Bugfix: PIN keyguard is clipped in Car" into pi-dev
2018-05-22 04:43:21 +00:00
Tracy Zhou
a3d2101c39
Merge "Show swipe-up tip with exponential backoff" into pi-dev am: ef59d80730
...
am: cae4ba1fd1
2018-05-21 20:47:06 -07:00
Tracy Zhou
cae4ba1fd1
Merge "Show swipe-up tip with exponential backoff" into pi-dev
...
am: ef59d80730
2018-05-21 20:39:22 -07:00
TreeHugger Robot
ef59d80730
Merge "Show swipe-up tip with exponential backoff" into pi-dev
2018-05-22 03:28:13 +00:00
Tracy Zhou
9198f775f3
Show swipe-up tip with exponential backoff
...
Change-Id: Icd32c0bd98623173322e5e33bd5400e679a01a10
Fixes: 79985309
Test: Manual test
2018-05-21 19:28:20 -07:00
Jian Jin
d1b6398df8
Bugfix: PIN keyguard is clipped in Car
...
Car is a multi-user system. There's a cancel button on the Keyguard
that allows the user to cancel the Keyguard to go back to user
switcher. Because different user may have different security mode,
the container must be resized when the security mode changes. The fix
is to destroy the old bouncer view on cancel.
Screenshot of clipped view: https://screenshot.googleplex.com/0VWdDtrLkAr
Fix: 79202566
Test: In the head unit
Change-Id: Ife33c53785ed96778f08c8f5886885e2b9d29749
2018-05-21 18:34:49 -07:00
Lucas Dupin
7f3e2ab6b9
Merge "Bouncer shouldn't be translated when occluded" into pi-dev am: 553fc8b8e0
...
am: 76bb2c0b59
2018-05-21 18:22:04 -07:00
Lucas Dupin
76bb2c0b59
Merge "Bouncer shouldn't be translated when occluded" into pi-dev
...
am: 553fc8b8e0
2018-05-21 18:13:27 -07:00
