Commit Graph

2924 Commits

Author SHA1 Message Date
Kristian Monsen
98dedf7ccc Fix for bug 8607049: Improve javascript dialogs for classic
Make a common JsDialogHelper for classic and chromium webview
Improve on before unload dialog

Change-Id: Ib9711e4f95189ef8b2b31fc64aec7c0cb535d0e4
2013-04-15 10:22:34 -07:00
Alan Viverette
8586af3050 Don't recycle accessibility event after sending.
Bug: 8434656
Change-Id: Ic2ad41804280d58a3c58968a9cb7dd85b97fab86
2013-03-20 16:27:33 -07:00
John Reck
93f99846df am bd5ee4d3: am 733329a2: Merge "Fix NPE when pasting non-text from Clipboard"
* commit 'bd5ee4d39c8d7d1fc2c1f94980875f1900880880':
  Fix NPE when pasting non-text from Clipboard
2013-03-12 14:34:29 -07:00
Nils Holmström
df337f30e9 Fix NPE when pasting non-text from Clipboard
When copying a link from a bookmark and then pasting it into
a textfield a NullPointerException will occur.
A ClipData.Item is not guaranteed to always contain a text string
and therefore getText() can be set to null.

Using method coerceToText() instead of getText() makes sure that
a text string is always returned.

Change-Id: I81343c0371835a3a7a52045dcd1760e69e59a967
2013-03-12 20:49:14 +09:00
Selim Gurun
2905e18b03 Add a delimiter between scheme and host
Bug: 6923539
Change-Id: I49aac145e8e80a5af7475cfe93ef4a353d2d3fe6
2013-03-08 14:29:56 -08:00
Victoria Lease
913f3c8f17 am 263554ae: am 7d4e52ba: Merge "FIX Null Pointer Exception on dialog cancel"
* commit '263554ae5f51fe1181c0c80123ec7f489e124f1a':
  FIX Null Pointer Exception on dialog cancel
2013-03-05 23:53:48 +00:00
Victoria Lease
b2f91e7b23 am 8ef243cf: am f45efd27: Merge "Audio continue to played even if paused manually"
* commit '8ef243cf861044eec35ee3d8207561251e34c77c':
  Audio continue to played even if paused manually
2013-03-05 23:53:46 +00:00
Victoria Lease
7d4e52baee Merge "FIX Null Pointer Exception on dialog cancel" 2013-03-05 23:25:16 +00:00
Roger Chen
002ecd2122 Audio continue to played even if paused manually
Currently, audio will resume playing after a phone call
or notification even if the user had manually paused playback.

This patch addresses that by introducing a new player state
to distinguish the user pausing playback and the browser
losing audio focus for some other reason. Audio will only
 resume if the browser temporarily lost audio focus and
not when the user has manually paused playback.

Change-Id: I9e8beaedb0fcc5afe920068297ed9c387eab2ac8
Signed-off-by: Roger Chen <cxr514033970@gmail.com>
2013-03-05 13:05:34 +00:00
Brian Carlstrom
42ca4975dc am 6f2adcf9: am b0cbf860: Merge "Tracking libcore change to use longs instead of ints to store pointers in OpenSSL binding"
* commit '6f2adcf9ab4a3dbe0b82bcdc3dd47de3eb975ebd':
  Tracking libcore change to use longs instead of ints to store pointers in OpenSSL binding
2013-03-05 00:56:05 +00:00
Ben Murdoch
4c333e1772 Merge "Update WebView#loadDataWithBaseURL documentation. DO NOT MERGE" into jb-mr2-dev 2013-03-04 19:40:55 +00:00
Selim Gurun
7be6d4c421 Merge "Clarify the API documentation for WebSQL database." into jb-mr2-dev 2013-03-01 21:46:42 +00:00
Selim Gurun
2bca22b2a5 Clarify the API documentation for WebSQL database.
Bug: 8231270

WebSQL database is disabled by default. And setting change to
enable it must precede the first url navigation. This change
is to clarify this behavior.

Change-Id: Ic0aab764821daece83f3482b30df4bebc7ff1f37
2013-03-01 13:35:12 -08:00
Jonathan Dixon
1001012808 Merge "Remove obsolete target-densitydpi documentation" into jb-mr2-dev 2013-03-01 21:09:06 +00:00
Brian Carlstrom
6bae82a2ae Tracking libcore change to use longs instead of ints to store pointers in OpenSSL binding
Change-Id: Ieba5705f4faa7cea619cf509db3ef081fda570d5
2013-03-01 09:13:26 -08:00
Ben Murdoch
95afb3b11a Update WebView#loadDataWithBaseURL documentation. DO NOT MERGE
Trivial cherry pick from master, see
Id1182537e073a9dd7746e23eec20accacedd9fc8

historyURL must be a valid URL.

Bug: 7907196
Change-Id: I1f32a9bda4ae627f242b2533eca18aef3ba25411
2013-03-01 17:12:16 +00:00
Jonathan Dixon
6877006646 Merge "Fix javadoc build" into jb-mr2-dev 2013-02-28 23:37:23 +00:00
Jonathan Dixon
98fac170b1 Fix javadoc build
Change-Id: I99eb6713fb221e1a3a8e54d621038104913dc03a
2013-02-28 15:32:10 -08:00
Jonathan Dixon
0af1c59762 Merge "Deprecate various WebView related methods" into jb-mr2-dev 2013-02-28 22:11:36 +00:00
Jonathan Dixon
835b1fcc31 Deprecate various WebView related methods
WebSettings:
PluginState - plugins depreacted and will not be supported in future.
setRenderPriotity - b/6335436
setLightTouchEnabled - b/7683972 it's s no-op.
setAppCacheMaxSize - has a sensible default and will  be obsolete in
                     future with HTML Quota Management API. b/6236763

WebStorage.setQuotaForOrigin - same as setAppCacheMaxSize

WebView:
clearView, showFindDialog - buggy, can be achieved otherways
savePassword - not useful/usable in practice; see b/5012826
             - stock browser used hidden APIs to achieve this feature

WebIconDatabase:
Other than the open() method, this does nothing useful. b/7331507

Change-Id: I01793f7b34978046eb54033477fca2da96e69c2e
2013-02-28 13:01:48 -08:00
Jonathan Dixon
89f48e9ffc Remove obsolete target-densitydpi documentation
Bug: 7999930

In general WebView.java is not a good place for HTML/CSS reference
guide, and more specifically target-densitydpi is an obsolete CSS
feature that is being phased out in modern browsers.
http://petelepage.com/blog/2013/02/viewport-target-densitydpi-support-is-being-deprecated/

Change-Id: Idd5cf09bb44e9f5f13f57e5f1c4b5c8ae1fc069b
2013-02-27 16:48:28 -08:00
Ben Murdoch
52643e0ceb Update WebView#PictureListener for JBMR2.
Now JBMR2 constant is defined, update code and docs to use it.

Bug: 8241082
Change-Id: If221c6524b79cc259ffc71fc218b141ffe6ed790
2013-02-27 11:38:25 +00:00
Amit Kumar
fe6c30e44e FIX Null Pointer Exception on dialog cancel
Null Pointer Exception occurs because mWebViewCore instance
is made to null while calling destroyJava(). When 
1.webview hosting activity goest to background, without calling webview onPause().
2. If app is launched again (having launchmode:singletask ) and another activity (not  webview hosting) comes on top top.
3. It destorys the previous activity holding webview which internally tries to cancel the dialog, but webviewcore instance is null. 
Null pointer exception is raised.

Change-Id: Idbcd30d0b0d4a35819444bbaa5c73cced8bb35a3
Signed-off-by: Amit Kumar <amitkecian@gmail.com>
2013-02-24 09:20:26 +00:00
Ben Murdoch
1c8d7f0952 Update WebView.PictureListener.onNewPicture to pass null picture.
When targetting >= CUR_DEVELOPMENT, the WebView.PictureListener.onNewPicture API
should pass a null picture in the callback.

Bug: 8209022, 8244082
Change-Id: I280c7cc89f2a12b1273cd67bbe2c7a6f2ca5892f
2013-02-21 20:35:21 +00:00
Victoria Lease
efd8b105ca am 5782c16d: am c36303a6: Merge "Applying ChannelScrolling to remove calculateDragAngle"
* commit '5782c16d34d839282978f94b1421e91da1e70cde':
  Applying ChannelScrolling to remove calculateDragAngle
2013-02-19 10:13:54 -08:00
Victoria Lease
c36303a66d Merge "Applying ChannelScrolling to remove calculateDragAngle" 2013-02-19 17:40:09 +00:00
kiwon
72034953bf Applying ChannelScrolling to remove calculateDragAngle
To avoid angle calculation changed the logic to use virtual areas.
When try to drag or pan, check where the current touch point locates
and determine how to drag a page.

Change-Id: Id9bd08a69c4ac93ff385c8088e6c16bed5dc5f88
Signed-off-by: kiwon <kiwon98.lee@samsung.com>
2013-02-18 14:30:58 +09:00
Svetoslav Ganov
c163c606f6 Merge "Handle WebKit selection changes synchronously." 2013-02-05 21:47:22 +00:00
Martin Kosiba
5ee743eef7 Ensure the WebView provider is created onVisibilityChanged.
It is possible for onVisibilityChanged to be called during
WebView construciton.

BUG=7622923

Change-Id: Ie87dae537e1e6dd44d96e9e56982abbc134a31a0
2013-02-05 15:26:39 +00:00
Alan Viverette
f4d4595d9d Handle WebKit selection changes synchronously.
This ensures that performing an accessibility navigation action correctly
returns true or false based on the new selected element.

Bug: 8027669
Change-Id: Ib7b3e1ec92ef522b23b073d32878dc1dc05723e9
2013-02-01 16:14:33 -08:00
Selim Gurun
393fa83424 Fix public comments for SslErrorHandler.
Fix documentation.

Change-Id: I56a485d2ed3b338f9acb6fa8d7e42cba88ad6291
2013-01-28 16:57:37 -08:00
Kenny Root
572ec703d5 am a6472811: am 2e99d3c9: am ebb61ca2: Merge "Track libcore changes for OpenSSLKey"
# Via Android Git Automerger (2) and others
* commit 'a647281109584d96ba2265c0faa14432deeb9815':
  Track libcore changes for OpenSSLKey
2013-01-25 17:12:08 -08:00
Kenny Root
a647281109 am 2e99d3c9: am ebb61ca2: Merge "Track libcore changes for OpenSSLKey"
# Via Android Git Automerger (1) and others
* commit '2e99d3c9646861ca92faf6708c18e36c7530fd93':
  Track libcore changes for OpenSSLKey
2013-01-25 16:41:33 -08:00
Kenny Root
ebb61ca2ed Merge "Track libcore changes for OpenSSLKey" 2013-01-26 00:26:01 +00:00
Kenny Root
cc1fc6b6ad Track libcore changes for OpenSSLKey
Change-Id: I39f60c34daa9ccc633efb02988ea238a84e6bbf1
2013-01-22 15:22:56 -08:00
John Reck
f35a55769a am 58fb0002: am ecd3c76f: am 6458d9b1: Merge "Fix for truncated sentence in "Find on Page" field"
* commit '58fb00025daa78360a3d033b223d15364d49086f':
  Fix for truncated sentence in "Find on Page" field
2013-01-22 14:00:05 -08:00
John Reck
58fb00025d am ecd3c76f: am 6458d9b1: Merge "Fix for truncated sentence in "Find on Page" field"
* commit 'ecd3c76f6275d0ffb0b36100936cf284ab00bee2':
  Fix for truncated sentence in "Find on Page" field
2013-01-22 13:57:51 -08:00
Derek Sollenberger
0d7ddce178 Merge "Update version for serialized view (e.g. Saved Page)." 2013-01-22 20:21:13 +00:00
Ben Murdoch
52c9f7f950 Refactor FindActionModeCallback.
Refactor FindActionModeCallback to make it more suitable
for sharing between WebViewClassic and WebViewChromium.

Bug=5006564

Change-Id: Ic3156eb50f99033a17ba3f83d0b4f39ba992afa8
2013-01-18 23:18:09 +00:00
Derek Sollenberger
49eab2a8ef Update version for serialized view (e.g. Saved Page).
The update ensures that previous versions are deserialized and
played back using the appropriate version of Skia.

There are companion changes to this in...
  external/skia
  external/webkit

bug: 8019756
Change-Id: I8d6507a82fa9adee94c3cb6ab1eb52bc64e8fa72
2013-01-16 15:13:59 -05:00
Stefan Wysocki
1c15b8d896 Fix for truncated sentence in "Find on Page" field
When typing a text in find on page, then deleting it again the
default text in the field "Find on Page" is truncated by
an invisible view.

This commit fixes the problem by setting the visibility of
mMatches view changes to View.GONE instead of View.INVISIBLE.

Change-Id: I9889f22a254cdabb0cbaba72bff4b14158e5c9ff
2013-01-15 14:02:53 +01:00
Jonathan Dixon
c19b549752 Merge "Remove checkThread() in WebView.getFactory()" 2013-01-11 10:25:37 -08:00
Jonathan Dixon
a811c2f65c Remove checkThread() in WebView.getFactory()
Bug: 7617139

WebViewFactoryProvider.getProvider() is thread safe, and when
called from findAddress() this is giving a spurious strict mode
warning.
Also removing obsolete comment while here.

Change-Id: I0b36bc23c13c9c9bec26edaf32ee83ade88982c8
2013-01-11 10:23:01 -08:00
Scott Main
6f028480fa am 8a05d13e: am 5b56d432: am 9107fa5d: am 66adf0d0: am 70af3cdb: Merge "docs: resolve bugs from external tracker" into jb-mr1-dev
* commit '8a05d13ef656b0147d85e1826b70a55f6b32e1e3':
  docs: resolve bugs from external tracker
2013-01-10 14:51:43 -08:00
Scott Main
8a05d13ef6 am 5b56d432: am 9107fa5d: am 66adf0d0: am 70af3cdb: Merge "docs: resolve bugs from external tracker" into jb-mr1-dev
* commit '5b56d43237d959403bb8a32de25376deee2dab22':
  docs: resolve bugs from external tracker
2013-01-08 12:52:38 -08:00
Scott Main
6aad995042 docs: resolve bugs from external tracker
Change-Id: I680970ec63701197103f6c5ab55c25c736aa0519
2013-01-08 12:02:38 -08:00
Mikhail Naganov
cb000a68cb Update JavaDoc for WebSettings.{get|set}UseWideViewPort
Based on a black-box inspection of WebView behavior.

Change-Id: I8823dab9ef2302cf7d11abec87a64e854db9e116
2013-01-07 17:54:19 +00:00
Selim Gurun
5c11ef10db Remove doc references to private browsing.
Remove reference to private browsing since it is no longer supported.

Change-Id: I65bc8aecd949717f662454d4bd1759ca91ad553d
2013-01-04 14:58:36 -08:00
Kristian Monsen
d05e4d820d Merge "Update Geolocation.getInstance() comment." 2012-12-26 16:00:25 -08:00
Jean-Baptiste Queru
12174a1c62 am 48576911: Merge from AOSP staging branch
* commit '48576911a2de25c46ecfbecdf7dcb373b70be3a5':
  Return error upon attempt to use non-existent APN
  Memory leak due to bad destroy sequence
2012-12-18 15:52:45 -08:00