Commit Graph

8992 Commits

Author SHA1 Message Date
George Mount
02843213c0 Fling while overscrolled: ScrollView/HorizontalScrollView
Bug: 186430321

ScrollView and HorizontalScrollView was not allowing a fling
effect while overscrolling. This adds the ability to fling
while overscrolling.

Test: new test
Test: manual ApiDemos
Change-Id: Iebd402ff0f5b6f16518ecc5403e085cb58de5976
2021-04-29 20:37:56 +00:00
George Mount
a4b222f48d Merge "Allow intercept touch event while animating edge glow." into sc-dev 2021-04-29 15:21:51 +00:00
George Mount
109e474959 Allow intercept touch event while animating edge glow.
Bug: 185906621

During overscroll animation, there is no need to call
disallowInterceptTouchEvents(). This removed the
call so that parents can intercept touch events.

Test: Ia9ac6d81a5b60222f489ea87f31ecba0c1d48cea
Test: manual testing

Change-Id: Ie5d9428d95b86d7a976c2f3c519547151a45cec5
2021-04-28 21:47:12 +00:00
Yohei Yukawa
a35ebcf88e Fix stale EditorInfo upon EditText#setText()
This is a follow up to our previous CL [1], which added initial
surrounding text support into EditorInfo and let TextView support it.

What we overlooked was that calling TextView#setText() would trigger

  TextView#onCreateInputConnection()

before TextView#mText is updated to the new value.  As a result,
EditorInfo is initialized with a stale surrounding text information.

With this CL, EditorInfo will correctly be initialized with the new
text specified to TextView#setText().

One complicated thing in this CL is InputMethodManager also has some
issues about how to drop spurious

  InputMethodService#onUpdateSelection()

while InputConnection is being replaced with a new instance.  I ended
up having to introduce a hacky boolean

  Editor#mHasPendingRestartInputForSetText

to work around this in the TextView/EditText. This workaround is
expected to be removed/revisited as part of Bug 186582769.

 [1]: Ie04f2349b1157408aa8ed9044aea12ce99132cb4
      c486acc4d2

Fix: 161330778
Test: atest CtsInputMethodTestCases:EditTextImeSupportTest
Change-Id: Iee3b754eea319861b2eb955d6cc95ba13006b55e
2021-04-27 19:20:16 -07:00
TreeHugger Robot
1700fa9e5c Merge "Reduce animation completion epsilon to avoid early end." into sc-dev 2021-04-28 00:08:30 +00:00
Stevie Kideckel
cda49ca089 Merge "Fix some potential nullability issues in RemoteViews" into sc-dev 2021-04-27 20:10:27 +00:00
Stevie Kideckel
957a33fe0a Fix some potential nullability issues in RemoteViews
Test: Ran locally on device, all sample widgets still worked
Test: atest RemoteViewsTest
Bug: 185316709

Change-Id: I60c235ea196dd106325e79962e545c582a975168
2021-04-27 13:44:26 +00:00
Qi Wang
0ebb4d88a1 Merge "Validate spell checker suggestions before applying." into sc-dev 2021-04-27 06:26:43 +00:00
TreeHugger Robot
400dc92ebe Merge "Fix Magnifier position updates" into sc-dev 2021-04-26 22:27:40 +00:00
Vishnu Nair
f752c800d3 Fix Magnifier position updates
When the magnifier content moves relative to the parent surface,
it will call setPosition on the content surface control. This conflicts
with position updates called by the BlastBufferQueue adapter
causing a flicker on screen. Fix this by providing a wrapper surface
to BlastBufferQueue adapater to send buffer updates.

Fixes: 186072574
Test: Select text and see magnifier surface does not flicker or move
around

Change-Id: Idfcc06a5d90f400f69e5cbe91008a0cb59fd4646
2021-04-26 10:27:50 -07:00
Qi Wang
cfa318ee4d Validate spell checker suggestions before applying.
Fix: 185786752
Test: atest CtsInputMethodTestCases:SpellCheckerTest
Change-Id: Icf447fc3ab174bc17af0e823b830f5abef6071df
2021-04-26 10:06:37 +08:00
George Mount
e4f9d4f632 Reduce animation completion epsilon to avoid early end.
Fixes: 184892316

Changed the animation termination epsilons to make sure
that the animation doesn't end early and cause a jerky
end.

Test: visual inspection
Change-Id: I56e4ccb50cee95e713e92ffb659eff4dd026dd12
2021-04-22 16:20:25 +00:00
Chun-Yi Lee
6a213319a8 Merge "Move CtsAutoFillServiceTestCases to group presubmit-large" into sc-dev 2021-04-22 11:11:55 +00:00
Stevie Kideckel
32b16fa4fc Merge "Expose GridView/Layout APIs via @RemotableViewMethod" into sc-dev 2021-04-22 09:33:43 +00:00
easoncylee
e9f67379be Move CtsAutoFillServiceTestCases to group presubmit-large
The test config takes longer than 15mins to run. Move it to a dedicated
group for running slow presubmit Test Mapping test.

Some more context is in the referenced bug, e.g, b/174495337
The group will work exactly the same as presubmit for now.

Bug: 174654670
Bug: 174495337
Test: none
Change-Id: I946061e2c5a75b12ca370d172db32a8f7e8e8f68
2021-04-21 13:24:07 +00:00
Stevie Kideckel
9f8a7db5f9 Expose GridView/Layout APIs via @RemotableViewMethod
Bug: 185972660
Test: Built and ran locally, annotation change only

Change-Id: I85fc00ae62b124653e20fd53f9179493463933e0
2021-04-21 09:20:25 +00:00
Joanne Chung
be20ca46f6 Merge "API feedback: Translation View API refinement." into sc-dev 2021-04-21 00:29:24 +00:00
TreeHugger Robot
32e08f8b0d Merge "Revert^2 "Introduce SpellCheckerSessionParams."" into sc-dev 2021-04-20 16:45:50 +00:00
Kohsuke Yatoh
d4e3278b3e Revert^2 "Introduce SpellCheckerSessionParams."
Updated test added in commit 7000b5f89d8c43af5ccd116c1840ea89dd9f17dc

Bug: 179804789
Change-Id: I48c744815662cabcbef8e823916b1e6bba9c9b17
2021-04-20 14:28:56 +00:00
Jeff DeCew
5e7b103e14 Merge "Allow passing 0 to RemoteViews.setDimen() or setAttr()" into sc-dev 2021-04-20 13:44:38 +00:00
TreeHugger Robot
6ba89099f8 Merge "Ensure that the root view is an AppWidgetHostView in setRemoteAdapter" into sc-dev 2021-04-20 11:33:59 +00:00
Yi-yo Chiang
ea80476aa4 Merge "Revert "Introduce SpellCheckerSessionParams."" into sc-dev 2021-04-20 04:41:45 +00:00
Yi-yo Chiang
cef2817d90 Revert "Introduce SpellCheckerSessionParams."
Revert "Use SpellCheckerSessionParams in CTS."

Revert submission 14191185-ky-tsm

Reason for revert: breaks build test_suites_x86_64 b/185855437
Reverted Changes:
I724aaad15:Introduce SpellCheckerSessionParams.
I510a4cfec:Use SpellCheckerSessionParams in CTS.

Change-Id: I4173bd5bee62f02a248de69df77420c39326b9f0
2021-04-20 03:57:05 +00:00
Joanne Chung
f6a52811a1 API feedback: Translation View API refinement.
Bug: 178046780
Test: manual
Test: atest android.translation.cts.UiTranslationManagerTest
CTS-Coverage-Bug: 177960696

Change-Id: I557ca4b3b4e7324af12e81dd8b5ac8a04a17b6b8
2021-04-20 11:14:22 +08:00
Kohsuke Yatoh
93528b8f5b Merge "Introduce SpellCheckerSessionParams." into sc-dev 2021-04-20 03:06:40 +00:00
Kohsuke Yatoh
94635fcb89 Introduce SpellCheckerSessionParams.
SpellCheckerSessionParams encapsulates parameters for
TextServicesManager#newSpellCheckerSession().

Bug: 179804789
Test: atest CtsInputMethodTestCases:SpellCheckerTest
Change-Id: I724aaad15b0a4bd38f6a24585c4c45cfeee5b499
2021-04-17 22:49:25 +00:00
Ahaan Ugale
7110641881 AutoTranslate: Pad view text for compatibility reasons.
Some apps operate on the view text based on layout calculations made on
the transformed text. This can cause issues (even crashes) if the
transformed text is longer than the original, as is often the case with
Translate. A previous temporary fix,
I685ae4a9752c817db81f0d736f1d746b2e4a9839, ellipsized the translated
text. This change fixes it properly by instead padding the original
text.

A followup change will make this controllable by API instead of padding
every TextView.

The en space character, U+2002, is used for the padding here. It seems
to work well in practice for multiple languages. We don't make this
configurable through API as it could make debugging harder (issues
triggered by server-side changes).

Bug: 179693024
Test: atest CtsTranslationTestCases
Test: manual - toggling between original and translated, scrolling, new
 views appearing, multiple apps
Change-Id: I9d7db5d2bc200e4042baf3267796f00cfc298f19
2021-04-16 19:38:28 -07:00
Jeff DeCew
208b1b1b69 Allow passing 0 to RemoteViews.setDimen() or setAttr()
Bug: 185488522
Test: atest RemoteViewsTest
Change-Id: I535e44a431701e68edcfaf527e326fd0e769b16a
2021-04-16 13:08:40 -04:00
Stevie Kideckel
fb2df70041 Ensure that the root view is an AppWidgetHostView in setRemoteAdapter
Bug: 185367016
Test: atest RemoteViewsFixedCollectionAdapterTest

Change-Id: I77d866157e97c4507243dbc2cd5411384f885458
2021-04-16 10:03:06 +00:00
Michel Comin Escude
219106593d Merge "Fixed and decreased isAtEquilibrium thresholds" into sc-dev 2021-04-14 18:03:18 +00:00
Joanne Chung
bef7481684 Merge "Add debug log to help to debug translation problem." into sc-dev 2021-04-14 16:27:31 +00:00
Michel Comin Escude
0ca911f5f8 Added velocity scalar and updated spring values
Updated spring values to the latest ones agreed in design. In addition,
added a velocity multiplier that only affects after it absorbs an impact
at the scroll boundary. This will help to increase the spring behavior
when we fling the content, but keeping it controlled when we pull and
release.

Bug: 183768138
Test: ran EdgeEffectTest and visual
Change-Id: I4ed7b01dd42a9a5adda637917369c349a6ae2f76
2021-04-14 03:07:53 +00:00
Michel Comin Escude
0c81801f9e Fixed and decreased isAtEquilibrium thresholds
Distance and speed were multiplied by LINEAR_STRETCH_INTENSITY which is
not directly related to speed and and distance. Moreover the velocity
threshold was a little bit high (1/0.016, wich means 62 pixels/second)
and the distance as well (1 is ok if there's no scale but since there's
some stretching the difference was being magnified).

Bug: 184892316
Test: EdgeEffectTests and visual
Change-Id: Ibd7adb16d1d00df0ab6e96132bfe96a4fa4d45dc
2021-04-13 18:50:22 -07:00
Nader Jawad
e178f50356 Merge "Adjusted interpolation and stretch intensity" into sc-dev 2021-04-13 22:11:11 +00:00
Michel Comin Escude
9ed86141f2 Adjusted interpolation and stretch intensity
Updated stretch intensity to 0.016 and added a new uniform to control
the intensity of the interpoloation

Bug: 183768138
Test: ran EdgeEffectTest and visual
Change-Id: Iac10bee5980802fffe838ed83e02b7c41dee6f71
2021-04-13 12:30:51 -07:00
Pierre Barbier de Reuille
bc9e66e108 Merge "Add attribute setters for RemoteViews" into sc-dev 2021-04-13 17:10:24 +00:00
Pierre Barbier de Reuille
11d243e01c Add attribute setters for RemoteViews
This implements go/remoteviews-attribute-setters

Bug: 184931139
Test: atest CtsWidgetTestCases:RemoteViewsTest
Change-Id: I135ab857d3a3a52bbb02ee3226e2bf723d8c916a
2021-04-13 09:49:34 +01:00
Joanne Chung
8960d6667b Add debug log to help to debug translation problem.
There are some issues the resume/finish seems not work well. The
debug flag should be enabled manually, but in the most time the
user may forget to enable it before testing. Try to enable it in the
debug rom to help debugging, we use b/182433547 to trace the disable
this check before rom release.

Bug: 182433547
Test: manual
Change-Id: I2f85a0e17f8a2b8a4b93252044cf48d739b4eca2
2021-04-13 13:58:03 +08:00
Ahaan Ugale
44dccdbe1a Merge "Fix UiTranslation for ListView." into sc-dev 2021-04-13 02:11:07 +00:00
Nader Jawad
93ea53bbe2 Merge "Fixed issue with invalid stretch params" into sc-dev 2021-04-13 01:29:31 +00:00
Nader Jawad
0a458ab55a Fixed issue with invalid stretch params
Refactored error checking logic to ignore
all invalid parameters for vecX/vecY
regardless if NaN parameters were
computed through intermediate math
operations or provided as inputs

Fixes: 183781985
Test: Added CTS test
Change-Id: Ib9f3dd1becc0486dc15ce306660bd5d469b81256
2021-04-12 14:51:02 -07:00
TreeHugger Robot
c66db32d3b Merge "Fix consumption multiplier" into sc-dev 2021-04-12 18:08:52 +00:00
Rob Carr
88a1e89a3f Merge "Port magnifier widget to BLAST" into sc-dev 2021-04-09 21:55:11 +00:00
TreeHugger Robot
3e6905a8aa Merge "Fix magnifier appearing unexpectedly on scroll" into sc-dev 2021-04-09 21:39:56 +00:00
Mihai Popa
08093739f1 Fix magnifier appearing unexpectedly on scroll
Fixes: b/183057391
Test: manual testing
Change-Id: Iecd67be64084f52f26bf471c91bde3ba3f2b5c64
2021-04-09 16:11:51 +00:00
Robert Carr
fcdbf71fe6 Port magnifier widget to BLAST
It is one of the last users of deferTransactionUntil which we
are hoping to remove in the server (and gain some CPU usage wins
in the process).

Bug: 168505645
Test: Existing tests pass
Change-Id: I2ba66caf7b0eaf2ed7d4fe896d7dc58f57c6e37f
2021-04-08 20:12:26 -07:00
Stevie Kideckel
c134d8fac3 Apply tints when setting dial/hands to icons
Bug: 184731376
Test: local testing with sample app
Change-Id: Ib7c1aeaec6f805e93b9a731bc2d34e2182243ae1
2021-04-08 15:18:33 +00:00
Pierre Barbier de Reuille
2837eab16b Replace RemoteViews#setViewId with a constructor
This is a request of the API Council.

There was a hidden and, AFAICT, un-used constructor with the same
signature, which I have removed. Before replacing the constructor I
checked the whole OS builds and run with the constructor simply removed.

Fix: 182824754
Test: atest CtsWidgetTestCases:RemoteViewsRecyclingTest
Test: atest CtsWidgetTestCases:RemoteViewsTest
Change-Id: I0f12d2fa520cf4f0d54a7e3859337cc9a395ae66
2021-04-07 13:17:19 +01:00
Ahaan Ugale
d3ef775737 Fix UiTranslation for ListView.
There are 2 changes:
* When a view is scrapped, Autofill IDs in its subtree are reset. This
prevents flaky behavior like translating the wrong views when events are
ordered a certain way.
* Views that are being translated are marked as having transient state
since the system needs to attach the response to it later as well as
deliver UI Translation state changes to it.

Bug: 182491706
Test: atest CtsTranslationTestCases
Test: atest CtsContentCaptureServiceTestCases
Test: atest CtsAutoFillServiceTestCases
Test: manual - check in logs that autofill ids aren't reused on
 scrolling or new views appearing
Test: manual - translated views stay translated while on the screen
 when other views are scrolled off the screen
Test: manual - translated views stay translated when new views appear
Change-Id: I20a52415e3fd191768442d70614d536e11633dfa
2021-04-02 23:19:55 -07:00
TreeHugger Robot
c5f71969ab Merge "Fixed NaN exceptions in EdgeEffect" into sc-dev 2021-04-03 02:08:09 +00:00