Commit Graph

419983 Commits

Author SHA1 Message Date
Lucas Dupin
81cdfa4a82 Show bouncer when unlocking and not interactive
We cannot dismiss the bouncer when the device cannot be unlocked,
otherwise we'll be stuck looking since gatekeeper is not unlocked.

Test: face auth from AOD2 encrypted
Test: face auth from lock screen encrypted
Test: face auth from AOD2
Test: atest BiometricsUnlockControllerTest
Fixes: 138093575
Change-Id: I5c5b89ee9fa1a10cedceaf1ab227e26910beed2a
2019-07-25 22:16:26 -07:00
Kevin Chyn
dcb049c30e Merge "Ensure BiometricDialogView dismiss animation is run" into qt-r1-dev 2019-07-25 05:08:11 +00:00
TreeHugger Robot
bae4081329 Merge "Make sure scrims will fade from black" into qt-r1-dev 2019-07-25 04:37:41 +00:00
TreeHugger Robot
5faf43ad73 Merge "Fixed race condition with different profiles" into qt-r1-dev 2019-07-25 04:06:20 +00:00
Kevin Chyn
14d150e595 Merge "Log acquired vendorCode" into qt-r1-dev 2019-07-25 04:03:26 +00:00
Kevin Chyn
906bde5423 Ensure BiometricDialogView dismiss animation is run
postOnAnimation requests the animation be started on the next frame. The
behavior is undefined if an animation is already running. Currently
if this happens, the second animation is never initiated.

Fixes: 138199986

Test: Modify BiometricPromptDemo to cancel authentication immediately after
      requesting authentication. BiometricDialogView isn't stuck anymore

Change-Id: Ia62dccc2d484d1eaca5587bffa4d3def89730533
2019-07-24 18:57:21 -07:00
Ryan Mitchell
8052a9b958 Merge "Only update overlays for target" into qt-dev
am: ed4820f0d0

Change-Id: Ie64e68bf5b13d81a991a29f0483c1c6f75dd4c00
2019-07-24 18:39:46 -07:00
TreeHugger Robot
ed4820f0d0 Merge "Only update overlays for target" into qt-dev 2019-07-25 01:15:26 +00:00
joshmccloskey
a4772064df Fixed race condition with different profiles
Test: Verified that setting/getting features in one profile
does not change the other.
Fixes: 138127704
Change-Id: Id8627fc84f0d2f4ec642cfb3e9a4d9884209a91f
2019-07-25 01:14:08 +00:00
Dave Mankoff
ac20ec6310 Merge "Prevent the BrightLineFalsingManager from duping its session." into qt-dev
am: b340cce330

Change-Id: I2cc3960d5c85105244de1a23b606a01a9bf4cb81
2019-07-24 18:06:08 -07:00
Kevin Chyn
f24ae8da0e Log acquired vendorCode
Bug: 137688980

Test: adb shell cmd stats print-logs
      adb logcat | grep -i statsd

Change-Id: Icdbc4a4ba004b5f4b7407de6e8ee256bee8ef97a
2019-07-24 18:05:12 -07:00
Ned Burns
96463c8369 [automerger skipped] Merge "Fix issue with media notifs being misbucketed" into qt-dev
am: 16e2397de5 -s ours
am skip reason: change_id I19223720bac534ab92219a2962169097819e8efb with SHA1 8c1b763dcf is in history

Change-Id: I3985d7c5ea2a36d1eeed5239fe7309d582e1b9e4
2019-07-24 18:01:59 -07:00
TreeHugger Robot
b340cce330 Merge "Prevent the BrightLineFalsingManager from duping its session." into qt-dev 2019-07-25 00:47:21 +00:00
Ned Burns
16e2397de5 Merge "Fix issue with media notifs being misbucketed" into qt-dev 2019-07-25 00:34:18 +00:00
Lucas Dupin
a7eacf93fd Make sure scrims will fade from black
Scrims might be light if the wallpaper is light, but when
turning on the screen, we should always fade from black,
otherwise the display will bright up before dimming down.

Test: pulse with light wallpaper and AOD on/off
Test: press power with AOD on/off
Test: atest ScrimControllerTest
Fixes: 138097741
Change-Id: Icc1ce276c839bce248ab9362a5d8cf4905201e0e
2019-07-24 23:24:12 +00:00
Jorim Jaggi
cbacbea8fa Merge "DO NOT MERGE Do not call drawableChanged pre Q" into qt-dev
am: d007c7b90d

Change-Id: I19dc7196f9b7dfeff5e2f18e4ecaedc5c480db3b
2019-07-24 16:19:42 -07:00
Vadim Caen
605e74c930 DO NOT MERGE Do not call drawableChanged pre Q
am: 843f9dee8b

Change-Id: I813f41905386da06e6eaebd6b7f85c17a6051456
2019-07-24 16:19:39 -07:00
Jorim Jaggi
d007c7b90d Merge "DO NOT MERGE Do not call drawableChanged pre Q" into qt-dev 2019-07-24 22:49:21 +00:00
Dave Mankoff
0ae8f2e36a Prevent the BrightLineFalsingManager from duping its session.
The BrightLineFalsingManager should not be able to start a session
when it's already in a session. Primarily, this caused the
FalsingManager to hang onto extra registrations to the Proximity
Sensor, per the bug.

Bug: 138220274
Test: atest SystemUITests and manual.
Change-Id: Id10d2697a96524e98c87aaa87702209d1752fe68
2019-07-24 22:12:40 +00:00
Andrii Kulian
b95eefcc17 Merge "Revert "Add calling package verification for ATM binder calls"" into qt-r1-dev 2019-07-24 21:57:57 +00:00
Vadim Caen
843f9dee8b DO NOT MERGE Do not call drawableChanged pre Q
Some apps rely on not updating the window format when changing the
background of the DecorView. To keep the compatibilty with these app we
add only call DecoreView.drawableChanged() when the window background is
changed on app targetting Q and above.

Test: Manually test by lunching Instagram TV and pressing return twice.
The window should aninate with no flickering.
Bug: 136987724

Change-Id: I3593d30dc6f10519008151974e475f0dad86fc64
2019-07-24 21:29:12 +00:00
Chandan Nath
43f091072b Merge "DO NOT MERGE Add stop method to backup handler thread." into qt-r1-dev 2019-07-24 21:26:48 +00:00
Ned Burns
91e425d793 Fix issue with media notifs being misbucketed
Previous code assumed that "isHighPriority" == "is in top section",
which is not always true. Media notifs and some other notifs can appear
in the top section even if they're not high priority. Because we detect
section boundaries by iterating through the list until we find the first
notif where isHighPriority == false, we were sometimes drawing the
section boundary way too high. This change creates a new propery,
isInTopSection() that accurately tracks this state.

Setting this value in the proper location would require some seriously
destabilizing refactors, so instead we set it in the list comparator,
which is awful but here are.

Test: manual
Bug: 138320173
Change-Id: I19223720bac534ab92219a2962169097819e8efb
Merged-In: I19223720bac534ab92219a2962169097819e8efb
(cherry picked from commit 8c1b763dcf)
2019-07-24 21:23:59 +00:00
Curtis Belmonte
c2f168ec3f Merge "Use separate enroll timeout for fingerprint and face" into qt-r1-dev 2019-07-24 21:02:51 +00:00
Ryan Mitchell
8987e830e2 Only update overlays for target
When a target package would update, the OMS would update the stat of
overlays that target android as if the android overlays targeted the
target package. This would cause the overlay state to change to
STATE_MISSING_TARGET for android overlays.

This change will only update state for overlays that target the updated
package.

Bug: 137038000
Bug: 136549878
Test: manual debugging
Change-Id: I0430426d8e8588a0fb97096a1f2570a7930069b3
Merged-In: I0d545253179b3545307b88b3151d11fd9e6cbd5b
2019-07-24 20:16:19 +00:00
Dave Mankoff
2a26810aba [automerger skipped] Merge "Allow BrightLineFalsingManager settings to be experimented with via Phenotype." into qt-dev
am: 8d56bbf2e3 -s ours
am skip reason: change_id I9fa4d1344bb184dea00f92f8d265667f0be11466 with SHA1 1b80884e03 is in history

Change-Id: I2136fc988ec0704f4e2a4e643d2b309e41b56932
2019-07-24 12:28:39 -07:00
Dave Mankoff
8d56bbf2e3 Merge "Allow BrightLineFalsingManager settings to be experimented with via Phenotype." into qt-dev 2019-07-24 19:09:02 +00:00
Andrii Kulian
a8ccae4339 Revert "Add calling package verification for ATM binder calls"
This reverts commit fbc35b907a.

Reason for revert: Some call points pass 'null', which breaks
the verification. E.g. b/138224633

Bug: 137395936
Bug: 138224633
Change-Id: I990a2d0347ce23d7100ba71ceec10716281e9200
2019-07-24 18:51:06 +00:00
Dave Mankoff
e38da07841 Allow BrightLineFalsingManager settings to be experimented with via Phenotype.
This is a CP of http://ag/8687829

Bug: 138308096
Test: atest SystemUITests
Change-Id: I9e2b22b157c45da1606466acdfff3c5de7f182e1
Merged-In: I9fa4d1344bb184dea00f92f8d265667f0be11466
2019-07-24 18:37:11 +00:00
nathch
842369a82b DO NOT MERGE Add stop method to backup handler thread.
Currently we call .quit() on the underlying thread which will cause all
messages to stop being processed. This has the side effect that, because
the backup system is a state machine where the state transitions are
messages, the message to transition into a state where the WakeLock is
released may not occur when a user is torn down.

This change adds a stop method we can call instead of .quit() on the
thread which drops any remaining messages and then releases the
WakeLock.

We also wrap the wakelock acquire/release calls to prevent any acquire/release on
the underlying wakelock after a quit. For the acquire, this avoids a non-released
wakelock and for the release, this avoids a runtime exception which can happen
when we release a released wakelock

Test: atest CtsBackupTestCases CtsBackupHostTestCases
Test: m RunBackupFrameworksServicesRoboTests && atest RunBackupFrameworksServicesRoboTests
Test: blaze run -- //experimental/users/nathch/py/bug_repros:repro 136264323 -m acquire_quit  -log DEBUG
Test: blaze run -- //experimental/users/nathch/py/bug_repros:repro 136264323 -m quit_acquire  -log DEBUG
Test: blaze run -- //experimental/users/nathch/py/bug_repros:repro 136264323 -m acquire_quit_release  -log DEBUG
Bug: 136264323

Change-Id: I42dcf997fc44cde05695a563aa19c8e47f6f9f26
2019-07-24 17:46:09 +00:00
Ned Burns
dc860bdfa8 Merge "Fix issue with media notifs being misbucketed" into qt-r1-dev 2019-07-24 16:49:14 +00:00
Selim Cinek
628a0ae660 Merge "Collapsing the heads up when showing the bouncer" into qt-r1-dev 2019-07-24 16:49:12 +00:00
Selim Cinek
5c0932cf17 Merge "Disabled the media auto heads up experience" into qt-r1-dev 2019-07-24 16:48:19 +00:00
Selim Cinek
87592617ec Merge "Not asking for the password when dragging down and bypass" into qt-r1-dev 2019-07-24 16:47:47 +00:00
Selim Cinek
1a6596608a Merge "Allowing to drag down while the quick settings are expanded" into qt-r1-dev 2019-07-24 16:47:20 +00:00
Chandan Nath
66e6767675 Merge "Unsubscribe listeners when stopping UserBackupManagerService" into qt-r1-dev 2019-07-24 15:53:37 +00:00
nathch
240daf679b Unsubscribe listeners when stopping UserBackupManagerService
Unsubscribe listeners as otherwise they schedule work on a stopped handler thread
after the user backup manager service is stopped

This also ensures that any dangling wakelocks are released when they are
garbage collected

This was already done in master in ag/8036218

Test: atest CtsBackupTestCases CtsBackupHostTestCases
Test: m RunBackupFrameworksServicesRoboTests && atest RunBackupFrameworksServicesRoboTests

Test: blaze run -- //experimental/users/nathch/py/bug_repros:repro 136264323 -m w_codechange
followed by "adb shell kill -10 pid" (where pid = "adb shell pgrep system_server") to force GC
see in logs: PowerManager: WakeLock finalized while still held: *backup*-0

Test: blaze run -- //experimental/users/nathch/py/bug_repros:repro 136264323 -m backup_w_codechange
followed by same as above

Bug: 136264323
Bug: 135261178
Change-Id: I769d750a46faa3d28634d302e0f8e18cce41a744
2019-07-24 09:31:01 +01:00
Winson Chung
48e3cfc06a Merge "Modify deferred recents animation cancel to work without screenshot" into qt-r1-dev 2019-07-24 05:14:05 +00:00
Selim Cinek
dc40ca591f Merge "Fix breaking test" into qt-r1-dev 2019-07-24 04:15:53 +00:00
Selim Cinek
5584518d8c Allowing to drag down while the quick settings are expanded
Fixes: 137552697
Test: pull down after expanding quick settings
Change-Id: I8246820b727d134c5432e6411218f0806d3899cc
2019-07-23 19:26:38 -07:00
TreeHugger Robot
6d4d529fb1 Merge "Proxy search disabled flag to Launcher" into qt-r1-dev 2019-07-24 01:58:24 +00:00
Selim Cinek
a678b0ee1f Collapsing the heads up when showing the bouncer
Previously we were keep showing heads up and music
notifications when the shade was fully collapsed.
We're now collapsing them as soon as you start
collapsing the panel.

Fixes: 136882221
Change-Id: I85783e8504b27110e16a0f15d2289d743ef0c3ea
2019-07-23 18:57:26 -07:00
Selim Cinek
abcc201afb Not asking for the password when dragging down and bypass
Instead we'll just keep them in there looking like locked
notifications.

Fixes: 138225058
Test: add notifications, enable dynamic privacy, drag down
Change-Id: Ica49035ba3fe655c145f81be962817ddd294c48d
2019-07-23 18:44:07 -07:00
Lucas Dupin
5431a92fd5 Fix breaking test
Fixes: 138245190
Test: atest SystemUITests
Merged-In: Ic1a937d3d81f4386ae744109076935921da9591b
Change-Id: Ie6f1133cac2e0f4f73a3620c71bd0c44d3b9be0b
2019-07-24 01:42:06 +00:00
bsears
c7067c4d5d [automerger skipped] Merge "Don't animate clock when turning screen off." into qt-dev
am: 486503c74e -s ours
am skip reason: change_id If39777340b72bc623d6690bc4f784c7f5c26ea8d with SHA1 dc8fee7ea1 is in history

Change-Id: I8589586a14b38b70491641f545a31605467f34bd
2019-07-23 18:41:44 -07:00
Jorim Jaggi
25fde4b0ba Merge "Mark screen rotation as early (1/2)" into qt-dev
am: 7b4bbe003d

Change-Id: Ie053403cfe588ce0eee30bee8ec1d87c2bf6baeb
2019-07-23 18:33:52 -07:00
bsears
486503c74e Merge "Don't animate clock when turning screen off." into qt-dev 2019-07-24 01:22:21 +00:00
Selim Cinek
167a365824 Disabled the media auto heads up experience
Test: atest SystemUITests
Fixes: 	138253091
Change-Id: I611bfdac44bb91e55b5944f8880f369534dbf30c
2019-07-23 18:21:34 -07:00
Lucas Dupin
c2877e1197 Merge "Bouncer isn't in transit when fully visible/hidden" into qt-r1-dev 2019-07-24 01:18:38 +00:00
Lucas Dupin
428385c40e Merge "Isolate DPM and SIM PIN states from UX" into qt-r1-dev 2019-07-24 01:15:39 +00:00