After CL[1], the client might be waiting forever when
system server throw Exception. The expected behavior
after throwing an Exception from the system server
should let the caller crash.
To keep the previous behavior, support exception as a
valid result for ResultCallback.
CL[1]: If4b40244a2e0e3b11c38c1da9340ba8e5166ad64
Bug: 174263942
Bug: 163453493
Test: Throw an exception in system server and observe the
caller crash with ResultCallback flow.
Test: atest CtsInputMethodTestCases
Change-Id: If79e063641a01b325c63eb9f871f5b992d7c0b72
The ACTION_TOGGLE_RECENTS on launcher side may be not close enough
to the user feeling because it cannot know the actual window drawn
time on system. And it may be mixed with 3 button navigation mode
which doesn't start recents animation. So here creates a new latency
type to log the case of recents animation explicitly.
Bug: 169221287
Test: Use gesture navigation mode and swipe up from an app. The log
will show "LatencyTracker: action=8 latency=xx".
Change-Id: I660f472113684590b4eba40c0534da9dcf7773ce
Iteration based on areas of tree where detailed ownership was found
to be missing during routine code reviews.
Also add more detailed examples to OWNERS.md.
Bug: 174932174
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I46ccef33b34594181ae8dc62973d68020f827d6b
These functions were recently renamed, so this cl
updates a few comments referencing the old names.
Also removes an unused method.
Test: compiles (just comments and removing unused method)
Change-Id: Iaaf8fd4927c4ccf38fffb304c67ef139e626fdcf
When an attribute value is missing, we can immediately return the
default value instead of paying the cost of throwing an exception.
To bring this benefit to both human-readable and binary XML, this
is implemented by adding a new getAttributeIndex() lookup method
which is then used by default methods.
readExtraAttributes() also appears to be parsing a string list as
a boolean value (which seems very broken), so we add hand-rolled
parsing logic to avoid paying the cost of an exception. Someone
should follow up in the future to investigate if there's an actual
bug here.
Bug: 174544002
Test: manual
Change-Id: Id313d18000e345ca1acd3c66d2c0c0fc44769b71
This reverts commit 0ace970e19.
Bug: 174932174, 175111824
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I152186408ecf6da1cb7354d14737de7cce55a34b
Bug: 174932174
Test: I solemnly swear I tested this conflict resolution.
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I9262a08ffc1ccede8e519d0eed90ed2bfcf0232c
We're temporarily blocked on internal Gerrit tooling to support
relaxed OWNERS validation, so this change temporarily replaces all
"android.com" accounts with "google.com" equivalents.
Bug: 174932174,175111824
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I114f2a40cee1b65e21250da7372e11c18cd73e25
As general background, OWNERS files expedite code reviews by helping
code authors quickly find relevant reviewers, and they also ensure
that stakeholders are involved in code changes in their areas.
Some teams under frameworks/base/ have been using OWNERS files
successfully for many years, and we're ready to expand them to cover
more areas. Here's the historical coverage statistics for the last
two years of changes before these new OWNERS changes land:
-- 56% of changes are fully covered by OWNERS
-- 17% of changes are partially covered by OWNERS
-- 25% of changes have no OWNERS coverage
Working closely with team leads, we've now identified clear OWNERS on
a per-package basis, and we're using "include" directives whenever
possible to to simplify future maintenance. With this extensive
effort, we've now improved our coverage as follows:
-- 98% of changes are fully covered by OWNERS
-- 1% of changes are partially covered by OWNERS
-- 1% of changes have no OWNERS coverage
This specific change is automatically generated by a script that
identifies relevant "include" directives.
Bug: 174932174
Test: manual
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Merged-In: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
Change-Id: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
