Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Additional per-file OWNERS for shared directories." am: 8b102a5988 am: 7a9f3e10de

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1523618

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9df0f96893728df43b3ae402ac69ec3e02079f51
This commit is contained in:
Jeff Sharkey
2020-12-10 16:32:34 +00:00
committed by Automerger Merge Worker
parent f358ccece0 7a9f3e10de
commit 845bfdd0ba
11 changed files with 48 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OWNERS
View File

@@ -16,7 +16,7 @@ svetoslavganov@google.com
yamasani@google.com
# Support bulk translation updates
per-file */res*/values*/*.xml = byi@google.com
per-file */res*/values*/*.xml = byi@google.com, delphij@google.com
per-file Android.bp = file:platform/build/soong:/OWNERS
per-file Android.mk = file:platform/build/soong:/OWNERS

34
OWNERS.md
View File

@@ -1,3 +1,5 @@
# Background
As general background, `OWNERS` files expedite code reviews by helping code
authors quickly find relevant reviewers, and they also ensure that stakeholders
are involved in code changes in their areas.
@@ -27,8 +29,40 @@ main `services/core/` project:
* `media/`
* `wifi/`
# Design
Area maintainers are strongly encouraged to list people in a single
authoritative `OWNERS` file in **exactly one** location. Then, other paths
should reference that single authoritative `OWNERS` file using an include
directive. This approach ensures that updates are applied consistently across
the tree, reducing maintenance burden.
# Examples
The exact syntax of `OWNERS` files can be difficult to get correct, so here are
some common examples:
```
# Complete include of top-level owners from this repo
include /ZYGOTE_OWNERS
# Partial include of top-level owners from this repo
per-file ZygoteFile.java = file:/ZYGOTE_OWNERS
```
```
# Complete include of subdirectory owners from this repo
include /services/core/java/com/android/server/net/OWNERS
# Partial include of subdirectory owners from this repo
per-file NetworkFile.java = file:/services/core/java/com/android/server/net/OWNERS
```
```
# Complete include of top-level owners from another repo
include platform/libcore:/OWNERS
# Partial include of top-level owners from another repo
per-file LibcoreFile.java = file:platform/libcore:/OWNERS
```
```
# Complete include of subdirectory owners from another repo
include platform/frameworks/av:/camera/OWNERS
# Partial include of subdirectory owners from another repo
per-file CameraFile.java = file:platform/frameworks/av:/camera/OWNERS
```

3
core/java/android/app/OWNERS
View File

@@ -1 +1,4 @@
per-file *Alarm* = file:/apex/jobscheduler/OWNERS
per-file *AppOp* = file:/core/java/android/permission/OWNERS
per-file *Notification* = file:/packages/SystemUI/OWNERS
per-file *Zygote* = file:/ZYGOTE_OWNERS

3
core/java/android/os/OWNERS
View File

@@ -24,4 +24,7 @@ per-file PowerComponents.java = file:/BATTERY_STATS_OWNERS
per-file GraphicsEnvironment.java = chrisforbes@google.com, cnorthrop@google.com, lpy@google.com, timvp@google.com, zzyiwei@google.com
per-file *Network* = file:/services/core/java/com/android/server/net/OWNERS
per-file *Power* = file:/services/core/java/com/android/server/power/OWNERS
per-file *Telephony* = file:/telephony/OWNERS
per-file *Zygote* = file:/ZYGOTE_OWNERS

1
core/java/android/telephony/OWNERS Normal file
View File

@@ -0,0 +1 @@
include /telephony/OWNERS

1
core/java/com/android/internal/app/OWNERS Normal file
View File

@@ -0,0 +1 @@
per-file *AppOp* = file:/core/java/android/permission/OWNERS

1
core/java/com/android/internal/notification/OWNERS Normal file
View File

@@ -0,0 +1 @@
include /services/core/java/com/android/server/notification/OWNERS

1
core/java/com/android/internal/os/OWNERS
View File

@@ -1,3 +1,4 @@
per-file *Power* = file:/services/core/java/com/android/server/power/OWNERS
per-file *Zygote* = file:/ZYGOTE_OWNERS
# BatteryStats

1
core/java/com/android/internal/telephony/OWNERS Normal file
View File

@@ -0,0 +1 @@
include /telephony/OWNERS

2
services/core/java/com/android/server/OWNERS
View File

@@ -12,7 +12,7 @@ per-file ZramWriteback.java = minchan@google.com, rajekumar@google.com, srnvs@go
per-file UserspaceRebootLogger.java = ioffe@google.com, tomcherry@google.com
per-file *Alarm* = file:/apex/jobscheduler/OWNERS
per-file *AppOps* = file:/core/java/android/permission/OWNERS
per-file *AppOp* = file:/core/java/android/permission/OWNERS
per-file *Bluetooth* = file:/core/java/android/bluetooth/OWNERS
per-file *Gnss* = file:/services/core/java/com/android/server/location/OWNERS
per-file *Location* = file:/services/core/java/com/android/server/location/OWNERS

2
services/tests/servicestests/src/com/android/server/OWNERS
View File

@@ -1,5 +1,5 @@
per-file *Alarm* = file:/apex/jobscheduler/OWNERS
per-file *AppOps* = file:/core/java/android/permission/OWNERS
per-file *AppOp* = file:/core/java/android/permission/OWNERS
per-file *Bluetooth* = file:/core/java/android/bluetooth/OWNERS
per-file *Gnss* = file:/services/core/java/com/android/server/location/OWNERS
per-file *Network* = file:/services/core/java/com/android/server/net/OWNERS