In #clearValuesAndCheck, values are placed in the value map based on a
key that depends on the current user. When these values are checked
in #call, it uses default user 0 (unless CALL_METHOD_USER_KEY is
populated).
Considering we don't even use getStringForUser when checking the values,
it seems to make sense to check against the userId used to set the
values in #clearValuesAndCheck.
Bug: 143529292
Bug: 143480221
Test: atest VolumeDialogControllerImplTest before and after the patch
Merged-In: I0ee9313b1394515d9405344482dc1779d15c0819
Change-Id: I0ee9313b1394515d9405344482dc1779d15c0819
to be configurable.
Bug: 143372960
Test: manual - took before and after videos
Merged-In: Ia0b6a56859889d538e21f807a88bc5217d89e64a
Change-Id: Ia0b6a56859889d538e21f807a88bc5217d89e64a
GPS is normally disabled when the device is Dozing. This means that GPS
is turned off in Battery Saver when quick doze is enabled. This
interferes with navigation and possibly other use cases. This changes
the behavior so that GPS is only disabled during Dozing if the device is
stationary. This will not interfere with regular Doze since the device
has to be stationary before it will enter regular Doze, and also allows
GPS to continue to work when Quick Doze activates while the user is
still carrying the device around.
Bug: 140162457
Test: atest BatterySaverLocationTest
Test: atest com.android.server.DeviceIdleControllerTest
Test: [manual] Shorten motion timeout, step into idle, check gps
provider dump after short timeout to check mDisableGpsForPowerManager=true
Merged-In: I7bc68c8a5e6744aac3a160ac14fc3375f9374d82
Change-Id: I7bc68c8a5e6744aac3a160ac14fc3375f9374d82
(cherry picked from commit 810c77d5a0)
Also fixed shell cmd so it does not require name for pre-created users
Bug: 111451156
Bug: 132111956
Test: adb shell pm create-user --pre-create-only --guest # couple times
Change-Id: Ie256d55bdfe685f040d16223fcc70f2f2b7969da
(cherry picked from commit e35f5b01f8)
This change is to avoid issues in assigning signed integer
feature (WIFI_FEATURE_DPP) to long featureSet. The
assignement was resulting in large, signed integer.
Bug: 143363031
Test: atest com.android.wifi.server
Test: Wifi ON/OFF, Connect and data transfer
Test: Added logs and verified feature set saved in iface.
Change-Id: Ic3828e675e49a8c1628368a7e6cf7f01e420bd96
(cherry picked from commit 26ac48bcd7)
- createCar(context) will lead into crash when car service is crashed.
- Migrate all createCar to new style which can handle car service crash
while removing unnecessary delay for connect.
Bug: 142543455
Test: kill car service and check if systemui survives
Change-Id: I69298f763a2a2e63c0cf8deae13f747ea19bbf9d
Merged-In: I69298f763a2a2e63c0cf8deae13f747ea19bbf9d
(cherry picked from commit c83d7b93ae0620bac34af2a937d5855b05058213)
No change to logic, only docs.
This clarifies the docs for onShowCustomView. This @links to
FLAG_FULLSCREEN, reminds the developer they must override both
onShowCustomView and onHideCustomView, and provides guidance for
CustomViewCallback.
Bug: 143247282
Test: make -j4 docs
Change-Id: I64de3723674da5c138438921cc8232c4bf2a3d98
In cases where the source of the CellInfo fails
but does not generate a Throwable, the detail info
will not be provided and should be null. Inside the
user process, we need to check for null before
dereferencing the detail object. Oops. :-(
Bug: 142706765
Bug: 142421696
Test: manual
Merged-In: I1307d1d7aacef0bbd33bfc73700ee774e12e64c1
Change-Id: I1307d1d7aacef0bbd33bfc73700ee774e12e64c1
(cherry picked from commit fff052067c)
This reverts commit 9449cfc4a6.
This reverts commit 22fa97577f.
This reverts commit bde48202e7.
Bug: 141649119
Bug: 143195895 is also fixed on my taimen with the above.
Bug: 143185828
Test: atest SystemUITests
Change-Id: I225b10fef2f88d3436ef3a683c09717467b071ad
Inform developers that having onscreen zoom controls is deprecated and
that it's therefore not recommended to enable them in WebView, with
reference to ZoomButtonsController (which is what WebView uses to
implement them).
Bug: 141732094
Test: make ds-docs
Change-Id: I134551b87d3a93072e28aef56667507214b3e9c4
This reverts commit d7554f399f.
Reason for revert: May have caused phone_max regression
BUG:143316720
Change-Id: I592acd7f9f47ee2be06508236927a77b11185ace
And also pre-grant it to all apps that currently get any storage
permission pre-granted
Test: atest SplitPermissionTest
m -j gts && gts-tradefed run commandAndExit gts-dev -m GtsPermissionTestCases --test=com.google.android.permission.gts.DefaultPermissionGrantPolicyTest#testDefaultGrantsWithRemoteExceptions
Manual testing:
All combinations of
- App targetSdk = 28 and 29 (and 22 for extra credit)
- App having the <uses-permission> tag for
ACCESS_MEDIA_LOCATION or not
- Upgrade from P->Q-QPR and from vanilla Q->Q-QPR
Further upgrade of targetSdk from 28->29 while on Q-QPR
==> All permission behavior should make sense. Sometimes there
are weird, but expected behaviors. Hence we need to
collect the results and then look at the unexpected ones.
See SplitPermissionTest for some tests I added for the
location-background permission which was split from
the fine/coarse-location permissions
Fixes: 141048840,140961754
Change-Id: Ib9f50d25c002036f13cf2d42fc4d1b214f20920c
(cherry picked from commit ac7b10c135)
