Commit Graph

10295 Commits

Author SHA1 Message Date
Ryan Mitchell
a8f13667c2 Set idmap2 binary uid and gid after forking
The file permissions of the idmap2 binary are currently not set
correctly when the system forks and execs the idmap binary during
zygote. This chnages sets the uid and gid after forking to the same uid
and gid of the parent process.

Bug: 134897503
Test: device boots and generates idmap
Change-Id: Ic7fac49e5982f3c47713603b905c3a6be117a05b
2019-07-01 21:19:21 +00:00
John Reck
097e1d3330 Fix setPositionListener race condition
Fixes: 131625115
Test: atest android.view.cts.SystemGestureExclusionRectsTest android.view.cts.SurfaceViewSyncTest android.uirendering.cts.testclasses.SurfaceViewTests

Change-Id: Ia357ff6fa5d5fe1e152abc23bbd6d8051cfd7aa7
2019-06-12 15:41:50 -07:00
Nader Jawad
476d0d1605 Brought back compatibility check for falling back on dest_out
whenever clear is used as a blend mode to draw bitmaps

Modified SkiaRecordingCanvas to call filterBitmap instead of
filterPaint in order to conduct the necessary compatibility checks
to use dest_out instead of clear whenever a bitmap is drawn

Test: In progress..
Bug: 131689368
Change-Id: I56d015e773b312cac948d850ca2997d8df0cc66d
Merged-In: I56d015e773b312cac948d850ca2997d8df0cc66d
2019-05-30 15:51:37 -07:00
TreeHugger Robot
7ede526835 Merge "Log less" into qt-dev 2019-05-24 20:48:31 +00:00
John Reck
db72e7aa8a Log less
These aren't really actionable logs by whatever
is producing them, so move to verbose

Bug: 131773342
Test: build
Change-Id: Icd020d889d83deae5dfd4aac3352bc9b1e1159bc
2019-05-23 14:41:32 -07:00
TreeHugger Robot
9fdd35e9aa Merge "Fix fading edge effect from impacting neighboring pixels" into qt-dev 2019-05-22 21:32:59 +00:00
TreeHugger Robot
0117a744e9 Merge "Fix light center position for layers" into qt-dev 2019-05-22 21:22:42 +00:00
Stan Iliev
36b75f7961 Fix light center position for layers
SkiaLayer::inverseTransformInWindow should be the inverse
matrix of Layer transform. This CL fixes a bug, that matrix
value was not inverted.
This matrix is used in one place: to transform light
center coordinates from device to RenderNode/layer
coordinate space.

Bug: 132758858
Test: Ran test app attached to bug. Manually compared coordinates.
Change-Id: Id8e887276a5296091a8264d7a0b1bcc955620a6a
2019-05-22 14:43:44 -04:00
Joe Onorato
f581d1b92f Merge changes from topic "b_132890298" into qt-dev
* changes:
  Fix lookup of incident section by name to not crash.
  Add command line utilites to set the reason field in incident report header
  Add ProtoOutputStream.serializeToVector
2019-05-22 03:16:44 +00:00
Joe Onorato
dcd64522f4 Add ProtoOutputStream.serializeToVector
Bug: 132890298
Test: bit libprotoutil_test:*
Change-Id: I44bbeea9c487e0142bcd5f18562f5a092e8b6306
2019-05-21 13:29:23 -07:00
Eric Holk
4487398e0d Remove obtainStyledAttribute and AssetManager2::GetBag tracing
These traces are small and noisy, so they hurt performance more than they help.

This reverts commit c37457799b.

Test: m
Bug: 132721345
Change-Id: I9ef719f54f2bc8a54f23e88f46d74e35417a6519
(cherry picked from commit 3509b624fe)
2019-05-21 00:31:03 +00:00
Derek Sollenberger
9d25cc242f Fix fading edge effect from impacting neighboring pixels
Bug: 132354626
Bug: 129117085
Test: skia unit tests and test cases described in the bug
Change-Id: Ieaa7c831dd6298ac0565e6f1837b1c1dbd4545da
(cherry picked from commit ac33a48751)
2019-05-17 17:59:57 +00:00
Joe Onorato
05270525ee Fix EncodedBuffer_test to run after making EncodedBuffer inherit from RefBase
Test: bit libprotoutil_test:*
Bug: 129717537
Change-Id: I44cf2e631a5ac1bb8b4ee2c269cfc50438fb1782
2019-05-16 00:51:18 +00:00
Miguel de Dios
515e7a7464 Merge "Revert "hwui: ro.hwui.render_ahead=0 queue on high FPS"" into qt-dev 2019-05-15 21:06:07 +00:00
TreeHugger Robot
7ee86cdb65 Merge "Persist active metric status across system server" into qt-dev 2019-05-15 20:45:31 +00:00
Miguel de Dios
509627ba33 Revert "hwui: ro.hwui.render_ahead=0 queue on high FPS"
This reverts commit f802abe47f.

Reason for revert: We're seeing jank increase after this patch.

Change-Id: Ic8d77df3fbbeeedeed4b8f31737454d9c056f8b0
Bug: 132733305
2019-05-14 23:56:21 +00:00
Greg Daniel
13a31b2648 Merge "Remove workaround in VulkanSurface for missing vendor flag." into qt-dev 2019-05-14 21:32:29 +00:00
Greg Daniel
cdfc90231c Remove workaround in VulkanSurface for missing vendor flag.
Test: manual building and testing
Bug: b/128923272
Change-Id: I6be67fddbbf06d4eb7efe316f7e6fd12157e2852
2019-05-14 09:25:41 -04:00
Tej Singh
f53d445cef Persist active metric status across system server
Previously, all metrics/configs would deactivate on system server death.
Now, active status is restored.

Bug: 129717537
Test: bit statsd_test:*
Test: libprotoutil_test:ProtoOutputStream*
Change-Id: Idf372457f60a931a2d00176a5eab58c534a25e41
2019-05-13 15:37:19 -07:00
Kevin DuBois
1a4bce9917 Merge "hwui: ro.hwui.render_ahead=0 queue on high FPS" into qt-dev 2019-05-10 15:08:10 +00:00
Yao Chen
a8a18f6d32 Merge "Remove encryption from incidentd" into qt-dev 2019-05-08 21:31:04 +00:00
John Reck
4b5e5551ba Be quiet
Fixes: 131863240
Test: logcat
Change-Id: I0276082b949f9521a804a4c1ef8af2148b69621b
2019-05-02 17:10:46 -07:00
Yao Chen
a51f3fa6fe Remove encryption from incidentd
Test: build
Bug: 131371777

Change-Id: I412c73658025246004412f3bcdcf30f74d766326
2019-04-30 11:51:24 -07:00
Joe Onorato
7a406b47eb Don't include restricted images in incident reports unless they're specifically mentioned in the IncidentReportArgs
Test: adb shell incident -p EXPLICIT -s com.google.android.incident.gts/.ReportReadyReceiver 3025
Test: adb shell incident -p EXPLICIT -s com.google.android.incident.gts/.ReportReadyReceiver
Bug: 123543706
Change-Id: I2c55831b73338f68196838ee529e595f566e657f
2019-04-26 16:00:05 -07:00
TreeHugger Robot
862a21c977 Merge "Zygote: add a way to preload Vulkan driver" into qt-dev 2019-04-26 05:20:34 +00:00
John Reck
8538ceba82 Merge "Fix some force_dark prop behaviors" into qt-dev 2019-04-25 23:37:05 +00:00
Kevin DuBois
f802abe47f hwui: ro.hwui.render_ahead=0 queue on high FPS
ro.hwui.render_ahead was behaving the same as -1 when it was set
to zero. Correct it so that ro.hwui.render_ahead will queue frames
when set to zero on any display rate FPS.

Fixes: 131340980
Test: Test presence or not of timestamps with -1,0,1,2 settings
Change-Id: Ibd1974253e947130fb03a0b86f599e0e5f5eac38
2019-04-25 16:05:01 -07:00
Yiwei Zhang
4bf3d9eda4 Zygote: add a way to preload Vulkan driver
Since HWUI render pipeline has both GL and Vulkan backends now, we'd
like to preload either GL or Vulkan driver based upon HWUI's choice on
the render backend.

1) Keep using ro.zygote.disable_gl_preload property to disable Vulkan
driver preloading if HWUI's render pipeline uses Vulkan backend.
Properly rename the corresponding APIs for driver preloading.

2) Add a path to preload Vulkan driver based on HWUI's render backend.

Bug: 131249898
Test: build, flash and boot.
Test: verified with set USE_VULKAN=true
Test: verified with setprop debug.hwui.renderer skiagl/skiavk
Change-Id: Ie0bf5d18edcf907c75a25ac3249e2620ec21b63c
2019-04-25 14:29:34 -07:00
John Reck
8915167a88 Fix some force_dark prop behaviors
* Make it persist.hwui.force_dark so the dev option
  survices reboots.

* Remove the internal super-override behavior it applied
  using only the intended ViewRootImpl theme-aware behavior.

Fixes: 127350499
Fixes: 130354206
Test: set dev option, verified nothing went dark. Set dark
theme, verified non-dark apps were force-darked. Rebooted
and verified property still set.

Change-Id: I43adcbc25320669510fb03b162c98cbd14612f55
2019-04-25 10:59:23 -07:00
Greg Daniel
f58e51b4e3 Merge "Fix deletion of VkSemaphores in VulkanManager." into qt-dev 2019-04-24 23:30:35 +00:00
TreeHugger Robot
b0815b80e8 Merge "Add support for /oem/overlay" into qt-dev 2019-04-24 08:33:38 +00:00
TreeHugger Robot
30a25acb83 Merge "Disable flaky tests" into qt-dev 2019-04-24 06:58:00 +00:00
TreeHugger Robot
a35c2f1224 Merge "Add encryption in incidentd." into qt-dev 2019-04-24 01:01:25 +00:00
Yao Chen
43706b4470 Add encryption in incidentd.
+ Sections which require encryption will be encryted on disk.

+ When the sections are requested by clients (e.g., permission controller, report assignee),
  incidentd will decrypte the data.

+ For efficiency, encryption is done ONLY for sections that require encryption.

+ Use Keystore API for key management.

Bug: 131084614
Test: incidentd_test
Change-Id: I84d6b86807ba5bbde1051e847b2df6e79e6b5be5
2019-04-23 15:20:38 -07:00
Greg Daniel
d92a9b158e Fix deletion of VkSemaphores in VulkanManager.
We were deleting the VkSemaphore objects too quickly when
importing/exporting the semaphores. Even though the semaphore payload
gets reset on these operations the VkSemaphore still needs to be
finished its use in Vulkan before being deleted.

Test: manual build and testing of vulkan apps and vulakn ImageConsumer
Bug: b/130643604
Change-Id: I7f03087e477d812c0174ede3a10f12dc1df72ee1
2019-04-23 14:36:37 -04:00
Greg Daniel
68406a2dd5 Merge "Make sure to sync GPU after deleting memory in trimMemory." into qt-dev 2019-04-23 16:52:06 +00:00
John Reck
c24e8e6c5e Disable flaky tests
Fixes: 130587638
Fixes: 130158977
Test: this
Change-Id: I173a56b61205aff0903141beeb65e84b739d66e0
2019-04-23 09:23:52 -07:00
John Reck
eecc52d796 Merge "Dynamically adjust renderahead" into qt-dev 2019-04-22 19:18:53 +00:00
TreeHugger Robot
28dd5f8486 Merge "Fix a bug in ProtoFileReader." into qt-dev 2019-04-22 18:34:39 +00:00
Greg Daniel
1d857f03f7 Make sure to sync GPU after deleting memory in trimMemory.
On GL some devices may not delete gpu memory immediately after calling
delete and instead will just queue it up. We must call glFinish to
make sure the memory is deleted when we want it.

More importantly Vulkan memory will not be freed until the GPU is done
with all the work. Thus we require an additional flush to make sure the
previous gpu work we submitted has finished and we can delete the
memory.

Test: manual testing on device
Bug: b/130440975
Change-Id: I2a9202dd7d15d97b365120a8caf9e10b4100efc3
2019-04-22 13:43:06 +00:00
Yao Chen
9f433c8509 Fix a bug in ProtoFileReader.
Classic and consuming

Bug: 131037240
Test: unit test added in incidentd_test
Change-Id: I9200122ed35e874ef453eb12adc7fbf28c22003e
2019-04-21 20:10:27 -07:00
Derek Sollenberger
b9e296e18f Update the CPU text cache sizes to be the same as their GPU equivalents
Bug: 130684261
Test: uibench jank tests
Change-Id: Ieb837afd76d1990c796baa9794ba54a83b8cd46f
2019-04-19 15:29:48 -04:00
John Reck
cf185f5b0d Dynamically adjust renderahead
Tracks refresh rate changes and adjusts renderahead
based off of the active refresh rate.

Default is 60hz = 0 render ahead & > 70hz is render ahead 1

Bug: 127822449
Test: systraced stuff

Change-Id: I9849aa065262f21f7602d44cd1761373279dc28d
2019-04-18 14:20:56 -07:00
TreeHugger Robot
9c88c1e93e Merge "Add odm and oem policies" into qt-dev 2019-04-18 01:39:51 +00:00
Ryan Mitchell
939df096be Add odm and oem policies
This change adds parsing, encoding, and validating of odm and oem
overlayable policies to aapt2, libandroidfw, and idmap2.

Bug: 121033532
Test: aapt2_tests, idmap2_tests
Change-Id: Ifc0d4b6c9f9c37e06b2988abade69dbb277c50c2
2019-04-17 16:07:57 -07:00
Winson Chiu
facddb4508 Merge "Skip idmap1 generation if target defines overlayable" into qt-dev 2019-04-16 17:53:54 +00:00
Leon Scroggins
949305fe52 Merge "Do not cache AVDs that are off screen" into qt-dev 2019-04-16 12:15:16 +00:00
Winson
1201ca7054 Skip idmap1 generation if target defines overlayable
Since idmap1 can't enforce policy restrictions, we can't allow it
to generate an idmap that might get used.

Migrating to idmap2 is too difficult for now as it requires a lot
of PackageManager infrastructure to validate policies, and none of
that is available during manifest parsing, which is where idmap1
is currently used.

Bug: b/130260055

Test: manual test BT issue from b/130260055
Test: manual test app with test overlay toggling Activity enabled

Change-Id: I5e7e321d27aab9be360a5e8be77d804ad3f66336
2019-04-15 15:31:39 -07:00
TreeHugger Robot
8d8d704cf7 Merge "Fix set_buffers_damage in VulkanSurface" into qt-dev 2019-04-15 21:00:08 +00:00
John Reck
08ca2a2560 Merge "Support render-ahead in vulkan" into qt-dev 2019-04-15 18:20:28 +00:00