Commit Graph

367603 Commits

Author SHA1 Message Date
TreeHugger Robot
468fdc3dd2 Merge "Unify behavior of various cases of "no underlying networks"" into pi-dev 2018-05-22 12:07:53 +00:00
Mihai Popa
6df95fa087 Merge "Fix crash after smart selection animation" into pi-dev 2018-05-22 11:19:24 +00:00
TreeHugger Robot
31ec39297c Merge "Reduce LoadedApkAssets LRU cache size." into pi-dev 2018-05-22 11:09:18 +00:00
TreeHugger Robot
200cad09c7 Merge changes Ic8231b18,I30009f88 into pi-dev
* changes:
  Fix: VPNs update caps upon underlying network disconnect.
  Add tests for setUnderlyingNetworks.
2018-05-22 10:57:27 +00:00
Annie Meng
3a95d0bb94 Merge "Check settings validators for NPE" into pi-dev 2018-05-22 09:55:48 +00:00
Richard Uhler
7bd7a369e4 Reduce LoadedApkAssets LRU cache size.
The cached apk assets can take up multiple megabytes of .apk mmap and
native memory for associated data structures. Reduce the cache size
for potential multi-megabyte memory savings with hopefully no
noticeable performance impacts.

In particular, rough estimates of the memory and performance impacts
of this change were evaluated by starting the launcher app,
sampling system server PSS with dumpsys meminfo and cache stats using
dumpsys activity for a few different cache sizes:

LRU Size   1: cached apks: total= 1 created=0 evicted=33 hit= 0 miss=34 max=1    TOTAL PSS=187542
LRU Size   3: cached apks: total= 3 created=0 evicted=12 hit=19 miss=15 max=3    TOTAL PSS=190606
LRU Size  15: cached apks: total=15 created=0 evicted= 0 hit=19 miss=15 max=15   TOTAL PSS=199350
LRU Size 100: cached apks: total=15 created=0 evicted= 0 hit=19 miss=15 max=100  TOTAL PSS=201416

Comparing cache stats after launching the settings app:

LRU Size   3: cached apks: total=3 created=0 evicted=5 hit=14 miss=8 max=3
LRU Size  15: cached apks: total=6 created=0 evicted=0 hit=18 miss=6 max=15

Running performance tests locally to ensure no clear regression in app
startup:

app-startup/benchmark-app-hermetic/cold-dropcache-test:
LRU                15        3        3
activityStart:    40.47    38.53    39.27
bindApplication:  24.40    24.53    24.93
draw:              4.27     4.33     4.07
layout:            0.73     1.07     0.73
onCreate:          9.40     9.00     8.53
totalLaunchTime: 183.13   183.27   187.07

app-startup/hermetic-apps/cold-dropcache-test:

LRU                   15       15          3         3
Calculator_avg:      333.9    333.1      343.3      334.6
Calculator_max:      345.0    360.0      370.0      363.0
Calculator_median:   333.5    331.5      343.5      333.5
Calculator_min:      320.0    317.0      320.0      311.0
Calculator_std_dev:    6.62    13.26      18.22      16.51
Clock_avg:           510.0    511.2      509.2      512.6
Clock_max:           529.0    528.0      530.0      529.0
Clock_median:        510.5    509.0      503.5      512.0
Clock_min:           498.0    495.0      487.0      492.0
Clock_std_dev:         7.70    11.71      15.25      11.07
Contacts_avg:        457.7    527.3      507.3      543.9
Contacts_max:        602.0    622.0      591.0      588.0
Contacts_median:     410.5    568.5      568.0      580.0
Contacts_min:        390.0    374.0      366.0      394.0
Contacts_std_dev:     85.64    96.80      88.80      72.97
Phone_avg:          6073.1    6109.7    6110.8     6115.8
Phone_max:          6196.0    6208.0    6180.0     6222.0
Phone_median:       6070.0    6117.5    6100.0     6133.5
Phone_min:          5982.0    5990.0    6061.0     5994.0
Phone_std_dev:        61.49     67.35     34.55      60.17
Settings_avg:        457.9     446.6     451.6      428.7
Settings_max:        487.0     468.0     494.0      449.0
Settings_median:     460.0     450.0     444.5      424.0
Settings_min:        423.0     421.0     431.0      420.0
Settings_std_dev:     21.21     12.02     20.46       9.71

Bug: 79115008
Test: Device boots.
Test: dumpsys activity all shows ResourcesManager max cache size of 3.

Change-Id: I7225b6978fac6197c27bec23d2b477fb1f5aee43
2018-05-22 10:52:40 +01:00
Chalard Jean
b3ab0d1e63 Unify behavior of various cases of "no underlying networks"
Before this change, VPNs having no underlying networks would be
marked as metered as the safe option, but VPNs having only
disconnected underlying networks would be marked as unmetered.
Fix this discrepancy.

Bug: 79748782
Test: runtest frameworks-net
Change-Id: I51c3badde29f43f692f383553bd98327d2da8dd1
2018-05-22 18:50:00 +09:00
Chalard Jean
6b65ec7756 Fix: VPNs update caps upon underlying network disconnect.
Bug: 79748782
Test: ConnectivityServiceTests still pass
Change-Id: Ic8231b18a17e6feb5ebafe8d5688fb59f9d4d58e
2018-05-22 18:49:58 +09:00
Mihai Popa
6748ff37db Fix crash after smart selection animation
At the end of the smart selection animation, we run a callback that sets
the selection on the TextView (subsequently starting the action mode
toolbar and showing the handles). However, when the text changes before
the animation finishes, the selection might not be valid, and might get
out of the text bounds, which was producing a crash. This was observed
in a monkey crash. This CL fixes this bug by refusing to set the
selection when it goes outside the text bounds, corresponding to the
case when text has changed between the time the animation has started
and the time it ended.

Bug: 69919777
Test: manual testing before and after the fix
Change-Id: Iea043f320004d45ad16dd7e9e5b47e5256e6d9fa
(cherry picked from commit cce6e82d35)
Merged-in: Iea043f320004d45ad16dd7e9e5b47e5256e6d9fa
2018-05-22 10:42:16 +01:00
David Brazdil
9b2938d253 Merge "Add more hidden API usages into greylist" into pi-dev 2018-05-22 09:41:15 +00:00
Chalard Jean
f89e8dacf1 Add tests for setUnderlyingNetworks.
Fixes come later. This is complex enough as it is.

Bug: 79748782
Test: new test passes, old tests still pass
Change-Id: I30009f88e68a534c332ca88bae517cacc39a60bb
2018-05-22 18:25:33 +09:00
Remi NGUYEN VAN
fd12af848a Merge "Move CaptivePortalProbeResult to its own file" into pi-dev 2018-05-22 08:00:56 +00:00
Chalard Jean
d1d4cc94ba Merge "Fix setCapabilities." into pi-dev 2018-05-22 07:51:09 +00:00
TreeHugger Robot
7b8ac80db5 Merge "Add new hidden-for-now AppOpsManager APIs to greylist." into pi-dev 2018-05-22 07:18:27 +00:00
felkachang
e8a3536660 Clock notification text was cut off
The root cause is that HeadsUpStatusBarView doesn't considerate the
Cut Out situation. The Cut Out situation can use
getRootWindowInsets().getDisplayCutout().getSafeInsetLeft() to get
the the value.

There are two parts need to handle Cut out.
The one part is to handle the padding. It needs to considerate both of
mLeftInset and mLeftCutOutInset because it use getLocationOnScreen to
count the location.

The other part is to handle the HeadsUpStatusBarView.translationX.
It only needs to considerate mLeftCutOutInset because landscape
degree 90 has the left side cut out and translationX by the distance
between screen left boundary and scroller's left boundary. The
distance include Cut Out so it need minus mCutOutInsetLeft in the
setPanelTranslation.

Cut Out has 4 mode: Disable, Corner, Double, and Tall. Disable and
Double are handled by the same way. Corner and Tall are handled
by the same way.

Bug: 78113562
Test: atest SystemUITests
Change-Id: Ic2a272c43f65eed8c4b3749787637f5fb848bb8a
Fix: 78113562
2018-05-22 06:05:14 +00:00
TreeHugger Robot
adc1534453 Merge "Add content description to zenmode" into pi-dev 2018-05-22 05:44:33 +00:00
Jian Jin
90101793e5 Merge "Bugfix: PIN keyguard is clipped in Car" into pi-dev 2018-05-22 04:43:21 +00:00
TreeHugger Robot
ef59d80730 Merge "Show swipe-up tip with exponential backoff" into pi-dev 2018-05-22 03:28:13 +00:00
Tracy Zhou
9198f775f3 Show swipe-up tip with exponential backoff
Change-Id: Icd32c0bd98623173322e5e33bd5400e679a01a10
Fixes: 79985309
Test: Manual test
2018-05-21 19:28:20 -07:00
Jian Jin
d1b6398df8 Bugfix: PIN keyguard is clipped in Car
Car is a multi-user system.  There's a cancel button on the Keyguard
  that allows the user to cancel the Keyguard to go back to user
  switcher.  Because different user may have different security mode,
  the container must be resized when the security mode changes.  The fix
  is to destroy the old bouncer view on cancel.

  Screenshot of clipped view: https://screenshot.googleplex.com/0VWdDtrLkAr

Fix: 79202566
Test: In the head unit
Change-Id: Ife33c53785ed96778f08c8f5886885e2b9d29749
2018-05-21 18:34:49 -07:00
Remi NGUYEN VAN
d63c119101 Move CaptivePortalProbeResult to its own file
This is necessary to resolve visibility issues for the next change.

Bug: b/79499239
Test: runtest frameworks-net
Change-Id: I50bc96afe6ae88c8f58a693f0a4e821f1f9b3299
2018-05-22 10:00:28 +09:00
TreeHugger Robot
553fc8b8e0 Merge "Bouncer shouldn't be translated when occluded" into pi-dev 2018-05-22 00:59:29 +00:00
Lucas Dupin
1d5e91001d Add content description to zenmode
Test: manual
Change-Id: Ic478e8a6fcd2088d198b2cee2e70ab8376b4709d
Fixes: 79686343
2018-05-21 17:58:05 -07:00
Lucas Dupin
322d934e02 Merge "Measure text in 1 pass" into pi-dev 2018-05-22 00:16:36 +00:00
TreeHugger Robot
43688e8f2f Merge "Differentiate MediaController in a process for MediaSession" into pi-dev 2018-05-22 00:11:49 +00:00
Lucas Dupin
aece5028fc Bouncer shouldn't be translated when occluded
Only checking if the bouncer should be scrimmed isn't enough
since it might have been initialized for performance reasons,
but is hidden at the bottom of the keyguard.

Change-Id: If92083e2c385d51febe0ec3a5e5d3484476caf81
Fixes: 80101176
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManagerTest.java
Test: manual
2018-05-21 16:44:28 -07:00
TreeHugger Robot
758cfd63db Merge "Add utility methods to AmbientDisplayConfig" into pi-dev 2018-05-21 23:37:24 +00:00
TreeHugger Robot
52ecba88d1 Merge "Pulse state should always show ambient wallpaper" into pi-dev 2018-05-21 22:18:47 +00:00
TreeHugger Robot
908b548f3c Merge "FingerprintService: requires ro.product.first_api_level" into pi-dev 2018-05-21 22:18:42 +00:00
TreeHugger Robot
88bdf18545 Merge "Setup mAreChannelsBypassingDnd from notifPolicy" into pi-dev 2018-05-21 22:17:52 +00:00
Dianne Hackborn
7f122f6137 Add new hidden-for-now AppOpsManager APIs to greylist.
Bug: 78480444
Test: manual
Change-Id: I2a9c2040279df3d875b96edb4a686006f5114a76
Merged-In: I2a9c2040279df3d875b96edb4a686006f5114a76
2018-05-21 15:11:04 -07:00
Lucas Dupin
b9afc96b8f Measure text in 1 pass
Before we were setting the text again using setText, and this
would trigger a second measure/layout pass, which is unnecessary.

Now we're using the same mesure pass to calculate the view's
best line break.

Fixes: 79714443
Test: manual. set various meeting names animated or static
Change-Id: Ia911fae8f820b703ca385a10211073bae37f3258
2018-05-21 15:09:34 -07:00
Yifan Hong
456461238f FingerprintService: requires ro.product.first_api_level
Test: fingerprint registration works
Bug: 79950359
Change-Id: I1c75b9258a5c63b23fa2c546f002a596c9d55dc3
2018-05-21 21:31:28 +00:00
Lucas Dupin
30c7547149 Pulse state should always show ambient wallpaper
Otherwise wallpaper wouldn't be set to AOD when the device pulses
and always on is off.

Bug: 78606979
Test: manual
Test: atest packages/SystemUI/tests/src/com/android/systemui/doze/DozeWallpaperStateTest.java
Change-Id: Ic40c18252cd6cb06ff6fd0d79ec3f1de16a1add5
2018-05-21 14:14:42 -07:00
Beverly
c36640fd1f Setup mAreChannelsBypassingDnd from notifPolicy
Test: atest RankingHelperTest
Change-Id: I34d9c8dfb5924bab0e496e37d5b93715c48b78ad
Fixes: 80078295
2018-05-21 16:58:27 -04:00
Ying Zheng
ab38e73af6 Merge "DO NOT MERGE - Switch user picker/switcher to use CarUserManagerHelper." into pi-dev 2018-05-21 20:44:23 +00:00
TreeHugger Robot
aef6efeef5 Merge "Fix the Hearing Aids connected state in Settings App" into pi-dev 2018-05-21 20:20:31 +00:00
Matthew Fritze
3461bb46d0 Add utility methods to AmbientDisplayConfig
The added utility methods are to enable increased
granularity in determinining the availability of gesture
settings dependant on Always on Display.

Bug: 79779562
Test: robotests
Change-Id: Ib54a867ca554d44ee4190706805fa8545aec9fa0
2018-05-21 13:12:36 -07:00
Mike Digman
4b0351d53f Merge "Extend rotation button timeout duration" into pi-dev 2018-05-21 20:09:24 +00:00
TreeHugger Robot
c81ed627ab Merge "Allow UiAutomation being used off the main thread" into pi-dev 2018-05-21 20:03:10 +00:00
TreeHugger Robot
d0897f2b65 Merge "Remove MANAGE_USERS from setPackagesSuspended" into pi-dev 2018-05-21 20:01:36 +00:00
Svetoslav Ganov
a757fd7827 Merge "Make RemoteCallback test API" into pi-dev 2018-05-21 19:55:12 +00:00
TreeHugger Robot
6555a9fa16 Merge "Check for bpf support at NetworkStatsService start" into pi-dev 2018-05-21 19:19:59 +00:00
Lucas Dupin
402e2a2b6f Merge "Keep scrim black when "always on" is off" into pi-dev 2018-05-21 18:23:59 +00:00
Mike Digman
d13e43b2bd Extend rotation button timeout duration
Moving from 6s to 10s timeout when navbar is visible.

Change-Id: I3a7067c37f254698ae53fdb9208576f3e486c8ce
Fixes: 79981820
Test: manual
2018-05-21 11:23:56 -07:00
Ying Zheng
a6586cb21e DO NOT MERGE - Switch user picker/switcher to use CarUserManagerHelper.
Test: Build
Bug: 79417730
Change-Id: I52c9b0f5ba01b85e36242b112ef9bbcc54a08e48
2018-05-21 11:20:57 -07:00
TreeHugger Robot
711a8f7f28 Merge "Add a shell command for IMMS to test instant apps" into pi-dev 2018-05-21 18:15:43 +00:00
TreeHugger Robot
76cb7fe2f6 Merge "Add a field in config to disable/enable the string hashing in metric report." into pi-dev 2018-05-21 18:05:00 +00:00
TreeHugger Robot
fd37ec90b8 Merge "ResXMLTree: Clone DynamicRefTable on creation" into pi-dev 2018-05-21 17:59:35 +00:00
TreeHugger Robot
35426e5e69 Merge "Import translations. DO NOT MERGE" into pi-dev 2018-05-21 17:57:26 +00:00